[1.8] Renaming items

[nates1984]

So, as my first adventure into Minecraft modding I decided to create an anvil block that will allow me to specify custom repair mechanics. Everything works except for one aspect: renaming an item. The behavior I'm seeing is that the new name is reflected in the output slot, but when I try to pick the item up the game bugs out for a split second and then the gui resets to the state that existed just prior to me trying to pick up the renamed item. When I try to rename an item and do other things, i.e. repair using material or combine with a second item, the renaming aspect is ignored but the other changes occur.

 

I asked on the minecraftforge IRC channel and was given the lead that I'm doing something client side that I should be doing server side. My understanding is that client side and server side are relevant even for the combined client, i.e. that the combined client has both a client sandbox and a server sandbox. The server in the combined client is the world.

 

If this is the issue I'm seeing, I'm a bit confused. Why is it the case that I can spawn new items with my current code, but not spawn one with a new name? Is it the case that Forge is handling things under the hood that I'm not aware of, and renaming is an edge case that isn't handled?

 

Or perhaps I have a fundamental misunderstanding of what's going on here?

 

Regardless, not really sure where to go from here.

 

My code below if that helps, as a concrete example I can apply things to.

 

https://github.com/NatePillow/MinecraftMods/tree/master/Redstone%20Anvil/src/main/java/nates1984/redstoneanvil

 

A side question: I'd like to refactor and extend BlockAnvil and ContainerRepair... Any issue with doing this? It's how I was initially doing things, but backed off as a way to avoid any potential bugs this may cause.

 

Another side question: I've noticed that if I extend ItemMultiTexture, and create an overriden method for getUnlocalizaedName that just calls the super method, things don't work (this was the issue preventing different textures/names from metadata from working properly). Is that me misunderstanding Java, or misunderstanding Forge?

[larsgerrits]

Yes, you are doing something client side which you should do on the server side. Basically, server stores all the data, and client displays it. If you change it on the client, it only displays it, and isn't stored on the server. You'd have to use packets for setting the data on the server side.

[nates1984]

Wow, that was surprisingly easy with SimpleNetworkWrapper. Kind of feel like a noob for even asking.

 

Regardless, thanks for your comment.