Jump to content

Recommended Posts

Posted

In my FML event handler class, I subscribe to an event:

  @SubscribeEvent
  public void onMissing(FMLMissingMappingsEvent e)

 

In my mod's postInit, I try to register the event handler class with FML:

  public void postInit(FMLPostInitializationEvent e) {
    super.postInit (e);
    classEventBusSubs eb = new classEventBusSubs ();
    classCommonBusSubs cb = new classCommonBusSubs ();

    MinecraftForge.EVENT_BUS.register (eb);             // All of my "listeners" are in class...EventSubs,
    FMLCommonHandler.instance ().bus ().register (cb);  // So register it on every bus until events are triggered
  }

 

But FML rejects its own event as an event:

[18:44:45] [Client thread/ERROR] [FML]: The following problems were captured during this phase

[18:44:45] [Client thread/ERROR] [FML]: Caught exception from jrfmoonsensor

java.lang.IllegalArgumentException: Method public void jrfmoonsensor.classCommonBusSubs.onMissing(net.minecraftforge.fml.common.event.FMLMissingMappingsEvent) has @SubscribeEvent annotation, but takes a argument that is not an Event class net.minecraftforge.fml.common.event.FMLMissingMappingsEvent

at net.minecraftforge.fml.common.eventhandler.EventBus.register(EventBus.java:82) ~[forgeSrc-1.8-11.14.3.1450.jar:?]

at jrfmoonsensor.classSensorMod.postInit(classSensorMod.java:123) ~[bin/:?]

 

How can it not be an event class??? It's an extension of class FMLEvent! What part of "event" is not being communicated here?

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

Posted

There are two types of events in Forge:

  • Events that extend
    FMLEvent

    and are handled by a method with the

    @Mod.EventHandler

    annotation in your

    @Mod

    class (e.g.

    FMLPreInitializationEvent

    ,

    FMLMissingMappingsEvent

    )

  • Events that extend
    Event

    and are handled by a method with the

    @SubscribeEvent

    annotation in a class registered on the appropriate event bus (e.g.

    BlockEvent.HarvestDropsEvent

    ,

    PlayerEvent.ItemSmeltedEvent

    )

 

You're trying to handle an

FMLEvent

like it's an

Event

.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Posted

Aha... Coincidence (or confusion?) in naming. I guess I should move the handler to my main mod class (and change the annotation).

 

@statphantom: "onMissing" was just my own choice of method name (I had to call it something).

 

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • logs too big for one pastebin https://pastebin.com/ZjUGHu3u  https://pastebin.com/RqCUZf3X  https://pastebin.com/6ZPS99nD
    • You probably used jd-gui to open it, didn't you? Nothing wrong with that, I also made that mistake, except that Notch was a smart guy and he obfuscated the code. That's why you only see files called "a", "b", "c" and then a file that combines them all. As I said, use RetroMCP to deobfuscate the code so that you will 100% understand it and be able to navigate it.
    • Decompiling minecraft indev, infdev, alpha, beta or whichever legacy version is really easy. I'm not a plug, I just also got interested in modding legacy versions (Infdev to be specific). Use https://github.com/MCPHackers/RetroMCP-Java Once you install their client and the Zulu Architecture that they say they recommend (or use your own Java). I encountered some problems, so I run it with: "java -jar RetroMCP-Java-CLI.jar". You should run it in a seperate folder (not in downloads), otherwise the files and folders will go all over the place. How to use RetroMCP: Type setup (every time you want change version), copy-paste the version number from their list (they support indev), write "decompile" and done! The code will now be deobfuscated and filenames will be normal, instead of "a", "b" and "c"! Hope I helped you, but I don't expect you to reply, as this discussion is 9 years old! What a piece of history!  
    • I know that this may be a basic question, but I am very new to modding. I am trying to have it so that I can create modified Vanilla loot tables that use a custom enchantment as a condition (i.e. enchantment present = item). However, I am having trouble trying to implement this; the LootItemRandomChanceWithEnchantedBonusCondition constructor needs a Holder<Enchantment> and I am unable to use the getOrThrow() method on the custom enchantment declared in my mod's enchantments class. Here is what I have so far in the GLM:   protected void start(HolderLookup.Provider registries) { HolderLookup.RegistryLookup<Enchantment> registrylookup = registries.lookupOrThrow(Registries.ENCHANTMENT); LootItemRandomChanceWithEnchantedBonusCondition lootItemRandomChanceWithEnchantedBonusCondition = new LootItemRandomChanceWithEnchantedBonusCondition(0.0f, LevelBasedValue.perLevel(0.07f), registrylookup.getOrThrow(*enchantment here*)); this.add("nebu_from_deepslate", new AddItemModifier(new LootItemCondition[]{ LootItemBlockStatePropertyCondition.hasBlockStateProperties(Blocks.DEEPSLATE).build(), LootItemRandomChanceCondition.randomChance(0.25f).build(), lootItemRandomChanceWithEnchantedBonusCondition }, OrichalcumItems.NEBU.get())); }   Inserting Enchantments.[vanilla enchantment here] actually works but trying to declare an enchantment from my custom enchantments class as [mod enchantment class].[custom enchantment] does not work even though they are both a ResourceKey and are registered in Registries.ENCHANTMENT. Basically, how would I go about making it so that a custom enchantment declared as a ResourceKey<Enchantment> of value ResourceKey.create(Registries.ENCHANTMENT, ResourceLocation.fromNamespaceAndPath([modid], [name])), declared in a seperate enchantments class, can be used in the LootItemRandomChanceWithEnchantedBonusCondition constructor as a Holder? I can't use getOrThrow() because there is no level or block entity/entity in the start() method and it is running as datagen. It's driving me nuts.
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.