Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

[1.8] [Abandoned] ISmartItemModel isn't using the transforms from the JSON files

TrashCaster

By TrashCaster
in Modder Support

 Share

Recommended Posts

TrashCaster Creeper Killer

TrashCaster

Posted
Posted

[spoiler=voxelizer.json]

{
    "__comment": "Model generated using MrCrayfish's Model Creator (http://mrcrayfish.com/modelcreator/)",
    "textures": {
        "particle": "tsm:items/voxelizer",
        "layer0": "tsm:items/voxelizer"
    },
    "display": {
        "thirdperson": {
            "rotation": [ 90, -90, 90 ],
            "translation": [ 0.3, 4, -3 ],
            "scale": [ 0.55, 0.55, 0.55 ]
        },
        "firstperson": {
            "rotation": [ 20, -40, 10 ],
            "translation": [ 0, 4, 2 ],
            "scale": [ 1.7, 1.7, 1.7 ]
        },
        "gui": {
            "rotation": [ 10, -10, 10 ],
            "translation": [ -4, -3, 2 ],
            "scale": [ 1.2, 1.2, 1.2 ]
        }

    },
    "elements": [
        {
            "name": "barrel_b",
            "from": [ 7.0, 5.0, 0.0 ], 
            "to": [ 9.0, 6.0, 12.0 ], 
            "faces": {
                "north": { "texture": "layer0", "uv": [ 0.0, 2.0, 1.0, 4.0 ], "rotation": 90 },
                "east": { "texture": "layer0", "uv": [ 0.0, 2.0, 4.0, 3.0 ] },
                "south": { "texture": "layer0", "uv": [ 0.0, 2.0, 1.0, 4.0 ], "rotation": 90 },
                "west": { "texture": "layer0", "uv": [ 0.0, 2.0, 5.0, 3.0 ] },
                "up": { "texture": "layer0", "uv": [ 0.0, 2.0, 4.0, 3.0 ] },
                "down": { "texture": "layer0", "uv": [ 0.0, 3.0, 4.0, 4.0 ] }
            }
        },
        {
            "name": "barrel_t",
            "from": [ 7.0, 10.0, 0.0 ], 
            "to": [ 9.0, 11.0, 12.0 ], 
            "faces": {
                "north": { "texture": "layer0", "uv": [ 0.0, 2.0, 1.0, 4.0 ], "rotation": 90 },
                "east": { "texture": "layer0", "uv": [ 0.0, 2.0, 4.0, 3.0 ] },
                "south": { "texture": "layer0", "uv": [ 0.0, 2.0, 1.0, 4.0 ], "rotation": 90 },
                "west": { "texture": "layer0", "uv": [ 0.0, 2.0, 4.0, 3.0 ] },
                "up": { "texture": "layer0", "uv": [ 0.0, 2.0, 4.0, 4.0 ] },
                "down": { "texture": "layer0", "uv": [ 0.0, 2.0, 4.0, 4.0 ] }
            }
        },
        {
            "name": "barrel_w",
            "from": [ 5.0, 7.0, 0.0 ], 
            "to": [ 6.0, 9.0, 12.0 ], 
            "faces": {
                "north": { "texture": "layer0", "uv": [ 0.0, 2.0, 1.0, 4.0 ] },
                "east": { "texture": "layer0", "uv": [ 0.0, 2.0, 4.0, 4.0 ] },
                "south": { "texture": "layer0", "uv": [ 3.0, 2.0, 4.0, 4.0 ] },
                "west": { "texture": "layer0", "uv": [ 0.0, 2.0, 4.0, 4.0 ] },
                "up": { "texture": "layer0", "uv": [ 0.0, 2.0, 4.0, 3.0 ] },
                "down": { "texture": "layer0", "uv": [ 0.0, 3.0, 4.0, 4.0 ] }
            }
        },
        {
            "name": "barrel_e",
            "from": [ 10.0, 7.0, 0.0 ], 
            "to": [ 11.0, 9.0, 12.0 ], 
            "faces": {
                "north": { "texture": "layer0", "uv": [ 0.0, 2.0, 4.0, 4.0 ] },
                "east": { "texture": "layer0", "uv": [ 0.0, 2.0, 4.0, 4.0 ] },
                "south": { "texture": "layer0", "uv": [ 0.0, 2.0, 4.0, 4.0 ] },
                "west": { "texture": "layer0", "uv": [ 0.0, 2.0, 4.0, 4.0 ] },
                "up": { "texture": "layer0", "uv": [ 0.0, 3.0, 4.0, 4.0 ] },
                "down": { "texture": "layer0", "uv": [ 0.0, 2.0, 4.0, 3.0 ] }
            }
        },
        {
            "name": "barrel_tw",
            "from": [ 5.0, 6.0, 2.0 ], 
            "to": [ 6.0, 10.0, 13.0 ], 
            "rotation": { "origin": [ 8.0, 8.0, 8.0 ], "axis": "z", "angle": -45.0 },
            "faces": {
                "north": { "texture": "layer0", "uv": [ 0.0, 0.0, 1.0, 2.0 ] },
                "east": { "texture": "layer0", "uv": [ 0.0, 0.0, 4.0, 2.0 ] },
                "south": { "texture": "layer0", "uv": [ 3.0, 0.0, 4.0, 2.0 ] },
                "west": { "texture": "layer0", "uv": [ 0.0, 0.0, 4.0, 2.0 ] },
                "up": { "texture": "layer0", "uv": [ 0.0, 0.0, 4.0, 1.0 ] },
                "down": { "texture": "layer0", "uv": [ 0.0, 1.0, 4.0, 2.0 ] }
            }
        },
        {
            "name": "barrel_bw",
            "from": [ 5.0, 6.0, 2.0 ], 
            "to": [ 6.0, 10.0, 13.0 ], 
            "rotation": { "origin": [ 8.0, 8.0, 8.0 ], "axis": "z", "angle": 45.0 },
            "faces": {
                "north": { "texture": "layer0", "uv": [ 0.0, 0.0, 4.0, 2.0 ] },
                "east": { "texture": "layer0", "uv": [ 0.0, 0.0, 4.0, 2.0 ] },
                "south": { "texture": "layer0", "uv": [ 0.0, 0.0, 4.0, 2.0 ] },
                "west": { "texture": "layer0", "uv": [ 0.0, 0.0, 4.0, 2.0 ] },
                "up": { "texture": "layer0", "uv": [ 0.0, 0.0, 4.0, 2.0 ] },
                "down": { "texture": "layer0", "uv": [ 0.0, 0.0, 4.0, 2.0 ] }
            }
        },
        {
            "name": "barrel_te",
            "from": [ 10.0, 6.0, 2.0 ], 
            "to": [ 11.0, 10.0, 13.0 ], 
            "rotation": { "origin": [ 8.0, 8.0, 8.0 ], "axis": "z", "angle": 45.0 },
            "faces": {
                "north": { "texture": "layer0", "uv": [ 0.0, 0.0, 4.0, 2.0 ] },
                "east": { "texture": "layer0", "uv": [ 0.0, 0.0, 4.0, 2.0 ] },
                "south": { "texture": "layer0", "uv": [ 0.0, 0.0, 4.0, 2.0 ] },
                "west": { "texture": "layer0", "uv": [ 0.0, 0.0, 4.0, 2.0 ] },
                "up": { "texture": "layer0", "uv": [ 0.0, 0.0, 4.0, 2.0 ] },
                "down": { "texture": "layer0", "uv": [ 0.0, 0.0, 4.0, 2.0 ] }
            }
        },
        {
            "name": "barrel_be",
            "from": [ 10.0, 6.0, 2.0 ], 
            "to": [ 11.0, 10.0, 13.0 ], 
            "rotation": { "origin": [ 8.0, 8.0, 8.0 ], "axis": "z", "angle": -45.0 },
            "faces": {
                "north": { "texture": "layer0", "uv": [ 0.0, 0.0, 4.0, 2.0 ] },
                "east": { "texture": "layer0", "uv": [ 0.0, 0.0, 4.0, 2.0 ] },
                "south": { "texture": "layer0", "uv": [ 0.0, 0.0, 4.0, 2.0 ] },
                "west": { "texture": "layer0", "uv": [ 0.0, 0.0, 4.0, 2.0 ] },
                "up": { "texture": "layer0", "uv": [ 0.0, 0.0, 4.0, 2.0 ] },
                "down": { "texture": "layer0", "uv": [ 0.0, 0.0, 4.0, 2.0 ] }
            }
        },
        {
            "name": "core",
            "from": [ 7.0, 7.0, 3.0 ], 
            "to": [ 9.0, 9.0, 15.0 ], 
            "faces": {
                "north": { "texture": "layer0", "uv": [ 4.0, 1.0, 5.0, 2.0 ] },
                "east": { "texture": "layer0", "uv": [ 4.0, 1.0, 9.0, 2.0 ] },
                "south": { "texture": "layer0", "uv": [ 4.0, 1.0, 5.0, 2.0 ] },
                "west": { "texture": "layer0", "uv": [ 4.0, 1.0, 9.0, 2.0 ] },
                "up": { "texture": "layer0", "uv": [ 4.0, 1.0, 9.0, 2.0 ], "rotation": 90 },
                "down": { "texture": "layer0", "uv": [ 4.0, 1.0, 9.0, 2.0 ], "rotation": 90 }
            }
        },
        {
            "name": "handle",
            "from": [ 6.5, -4.0, 14.0 ], 
            "to": [ 9.5, 3.0, 17.0 ], 
            "rotation": { "origin": [ 8.0, 8.0, 8.0 ], "axis": "x", "angle": -22.5 },
            "faces": {
                "north": { "texture": "layer0", "uv": [ 8.0, 2.0, 12.0, 6.0 ] },
                "east": { "texture": "layer0", "uv": [ 8.0, 2.0, 12.0, 6.0 ] },
                "south": { "texture": "layer0", "uv": [ 8.0, 2.0, 12.0, 6.0 ] },
                "west": { "texture": "layer0", "uv": [ 8.0, 2.0, 12.0, 6.0 ] },
                "up": { "texture": "layer0", "uv": [ 8.0, 2.0, 12.0, 6.0 ] },
                "down": { "texture": "layer0", "uv": [ 8.0, 2.0, 12.0, 6.0 ] }
            }
        },
        {
            "name": "container_cap_1",
            "from": [ 5.0, 5.0, 15.0 ], 
            "to": [ 11.0, 11.0, 16.0 ], 
            "faces": {
                "north": { "texture": "layer0", "uv": [ 4.0, 2.0, 8.0, 6.0 ] },
                "east": { "texture": "layer0", "uv": [ 4.0, 2.0, 5.0, 6.0 ] },
                "south": { "texture": "layer0", "uv": [ 4.0, 2.0, 8.0, 6.0 ] },
                "west": { "texture": "layer0", "uv": [ 7.0, 2.0, 8.0, 6.0 ] },
                "up": { "texture": "layer0", "uv": [ 4.0, 2.0, 8.0, 3.0 ] },
                "down": { "texture": "layer0", "uv": [ 4.0, 5.0, 8.0, 6.0 ] }
            }
        },
        {
            "name": "grip",
            "from": [ 7.0, 0.0, 7.0 ], 
            "to": [ 9.0, 5.0, 9.0 ], 
            "faces": {
                "north": { "texture": "layer0", "uv": [ 0.0, 8.0, 4.0, 9.0 ] },
                "east": { "texture": "layer0", "uv": [ 0.0, 8.0, 4.0, 9.0 ] },
                "south": { "texture": "layer0", "uv": [ 0.0, 8.0, 4.0, 9.0 ] },
                "west": { "texture": "layer0", "uv": [ 0.0, 8.0, 4.0, 9.0 ] },
                "up": { "texture": "layer0", "uv": [ 0.0, 8.0, 2.0, 9.0 ] },
                "down": { "texture": "layer0", "uv": [ 2.0, 8.0, 4.0, 9.0 ] }
            }
        },
        {
            "name": "core_guard",
            "from": [ 7.0, 7.0, 7.0 ], 
            "to": [ 9.0, 9.0, 15.0 ], 
            "rotation": { "origin": [ 8.0, 8.0, 8.0 ], "axis": "z", "angle": -45.0 },
            "faces": {
                "north": { "texture": "layer0", "uv": [ 4.0, 0.0, 5.0, 1.0 ] },
                "east": { "texture": "layer0", "uv": [ 4.0, 0.0, 9.0, 1.0 ] },
                "south": { "texture": "layer0", "uv": [ 8.0, 0.0, 9.0, 1.0 ] },
                "west": { "texture": "layer0", "uv": [ 4.0, 0.0, 9.0, 1.0 ] },
                "up": { "texture": "layer0", "uv": [ 4.0, 0.0, 9.0, 1.0 ], "rotation": 90 },
                "down": { "texture": "layer0", "uv": [ 4.0, 0.0, 9.0, 1.0 ], "rotation": 90 }
            }
        },
        {
            "name": "trigger",
            "from": [ 7.5, 6.0, 15.5 ], 
            "to": [ 8.5, 8.0, 16.5 ], 
            "rotation": { "origin": [ 8.0, 8.0, 8.0 ], "axis": "x", "angle": 22.5 },
            "faces": {
                "north": { "texture": "layer0", "uv": [ 10.0, 0.0, 11.0, 1.0 ] },
                "east": { "texture": "layer0", "uv": [ 10.0, 0.0, 11.0, 1.0 ] },
                "south": { "texture": "layer0", "uv": [ 11.0, 0.0, 12.0, 1.0 ] },
                "west": { "texture": "layer0", "uv": [ 10.0, 0.0, 11.0, 1.0 ] },
                "up": { "texture": "layer0", "uv": [ 10.0, 0.0, 11.0, 1.0 ] },
                "down": { "texture": "layer0", "uv": [ 10.0, 0.0, 11.0, 1.0 ] }
            }
        },
        {
            "name": "trigger_guard",
            "from": [ 7.0, 2.0, 13.0 ], 
            "to": [ 9.0, 6.0, 17.0 ], 
            "faces": {
                "north": { "texture": "layer0", "uv": [ 0.0, 4.0, 1.0, 8.0 ] },
                "east": { "texture": "layer0", "uv": [ 0.0, 4.0, 4.0, 8.0 ] },
                "south": { "texture": "layer0", "uv": [ 3.0, 4.0, 4.0, 8.0 ] },
                "west": { "texture": "layer0", "uv": [ 0.0, 4.0, 4.0, 8.0 ] },
                "up": { "texture": "layer0", "uv": [ 0.0, 4.0, 4.0, 5.0 ] },
                "down": { "texture": "layer0", "uv": [ 0.0, 7.0, 4.0, 8.0 ] }
            }
        }
    ]
}

 

[spoiler=voxelizer_container.json]

{
    "__comment": "Model generated using MrCrayfish's Model Creator (http://mrcrayfish.com/modelcreator/)",
    "textures": {
        "particle": "tsm:items/voxelizer",
        "layer0": "tsm:items/voxelizer"
    },
    "display": {
        "thirdperson": {
            "rotation": [ 90, -90, 90 ],
            "translation": [ 0.3, 4, -3 ],
            "scale": [ 0.55, 0.55, 0.55 ]
        },
        "firstperson": {
            "rotation": [ 20, -40, 10 ],
            "translation": [ 0, 4, 2 ],
            "scale": [ 1.7, 1.7, 1.7 ]
        },
        "gui": {
            "rotation": [ 10, -10, 10 ],
            "translation": [ -4, -3, 2 ],
            "scale": [ 1.2, 1.2, 1.2 ]
        }

    },
    "elements": [
        {
            "name": "container_cap_2",
            "from": [ 5.0, 5.0, 23.0 ], 
            "to": [ 11.0, 11.0, 24.0 ], 
            "faces": {
                "north": { "texture": "layer0", "uv": [ 4.0, 2.0, 8.0, 6.0 ] },
                "east": { "texture": "layer0", "uv": [ 4.0, 2.0, 5.0, 6.0 ] },
                "south": { "texture": "layer0", "uv": [ 4.0, 2.0, 8.0, 6.0 ] },
                "west": { "texture": "layer0", "uv": [ 7.0, 2.0, 8.0, 6.0 ] },
                "up": { "texture": "layer0", "uv": [ 4.0, 2.0, 8.0, 3.0 ] },
                "down": { "texture": "layer0", "uv": [ 4.0, 5.0, 8.0, 6.0 ] }
            }
        },
        {
            "name": "container_guard",
            "from": [ 6.0, 6.0, 16.0 ], 
            "to": [ 10.0, 10.0, 23.0 ], 
            "faces": {
                "north": { "texture": "layer0", "uv": [ 12.0, 0.0, 13.0, 1.0 ] },
                "east": { "texture": "layer0", "uv": [ 12.0, 0.0, 16.0, 1.0 ] },
                "south": { "texture": "layer0", "uv": [ 15.0, 0.0, 16.0, 1.0 ] },
                "west": { "texture": "layer0", "uv": [ 12.0, 0.0, 16.0, 1.0 ] },
                "up": { "texture": "layer0", "uv": [ 12.0, 0.0, 16.0, 1.0 ] },
                "down": { "texture": "layer0", "uv": [ 12.0, 0.0, 16.0, 1.0 ] }
            }
        },
        {
            "name": "container_core",
            "from": [ 6.0, 6.0, 16.0 ], 
            "to": [ 10.0, 10.0, 23.0 ], 
            "rotation": { "origin": [ 8.0, 8.0, 8.0 ], "axis": "z", "angle": -45.0 },
            "faces": {
                "north": { "texture": "layer0", "uv": [ 12.0, 1.0, 13.0, 2.0 ] },
                "east": { "texture": "layer0", "uv": [ 12.0, 1.0, 16.0, 2.0 ] },
                "south": { "texture": "layer0", "uv": [ 15.0, 1.0, 16.0, 2.0 ] },
                "west": { "texture": "layer0", "uv": [ 12.0, 1.0, 16.0, 2.0 ] },
                "up": { "texture": "layer0", "uv": [ 12.0, 1.0, 16.0, 2.0 ] },
                "down": { "texture": "layer0", "uv": [ 12.0, 1.0, 16.0, 2.0 ] }
            }
        }
    ]
}

 

 

public class VoxelizerSmartItemModel implements ISmartItemModel, IPerspectiveAwareModel {
    public VoxelizerSmartItemModel(IBakedModel i_baseModel, IBakedModel i_containerModel) {
        baseModel = i_baseModel;
        containerModel = i_containerModel;
    }

    public static final ModelResourceLocation BASE = new ModelResourceLocation(
            TSM.MODID + ":" + TSM.voxelizer.getName(), "inventory");
    public static final ModelResourceLocation CONTAINER = new ModelResourceLocation(
            TSM.MODID + ":" + TSM.voxelizer.getName() + "_container", "inventory");

    @SuppressWarnings("deprecation")
    @Override
    public IBakedModel handleItemState(ItemStack stack) {
        hasContainer = false;
        if (stack != null && stack.getTagCompound() != null) {
            NBTTagCompound tag = stack.getTagCompound();
            if (tag.hasKey("Container", Constants.NBT.TAG_COMPOUND)) {
                hasContainer = true;
            }
        }
        return this;
    }

    @Override
    public TextureAtlasSprite getTexture() {
        return baseModel.getTexture();
    }

    @Override
    public List getFaceQuads(EnumFacing enumFacing) {
        return baseModel.getFaceQuads(enumFacing);
    }

    @Override
    public List getGeneralQuads() {
        List<BakedQuad> combinedQuadsList = new ArrayList(baseModel.getGeneralQuads());
        if (hasContainer) {
            combinedQuadsList.addAll(containerModel.getGeneralQuads());
        }
        return combinedQuadsList;
    }

    @Override
    public boolean isAmbientOcclusion() {
        return baseModel.isAmbientOcclusion();
    }

    @Override
    public boolean isGui3d() {
        return baseModel.isGui3d();
    }

    @Override
    public boolean isBuiltInRenderer() {
        return false;
    }

    @Override
    public ItemCameraTransforms getItemCameraTransforms() {
        return baseModel.getItemCameraTransforms();
    }

    @Override
    public Pair<IBakedModel, Matrix4f> handlePerspective(TransformType cameraTransformType) {
        switch (cameraTransformType) {
        case FIRST_PERSON:
            RenderItem.applyVanillaTransform(baseModel.getItemCameraTransforms().firstPerson);
            return Pair.of(baseModel, null);
        case GUI: // only this one returns the layered model
            RenderItem.applyVanillaTransform(baseModel.getItemCameraTransforms().gui);
            return Pair.of(baseModel, null);
        case HEAD:
            RenderItem.applyVanillaTransform(baseModel.getItemCameraTransforms().head);
            return Pair.of(baseModel, null);
        case THIRD_PERSON:
            RenderItem.applyVanillaTransform(baseModel.getItemCameraTransforms().thirdPerson);
            return Pair.of(baseModel, null);
        default:
            break;
        }
        return Pair.of(baseModel, null);
    }

    private boolean hasContainer = false;

    private IBakedModel baseModel;
    private IBakedModel containerModel;
}

 

Both models are rendering merged, as wanted. But they aren't using the transforms in the JSON files. The transforms work when I don't replace the model with the ISmartItemModel.

 

In my first test, I didn't implement IPerspectiveAwareModel, and in the second test, I did. They both had the same results.

Is there a fix?

EverythingGames Diamond Finder

EverythingGames

Posted
Posted

Return "this" in IPerspectiveAwareModel. Why not just "break" instead of returning the Pair for every transform type? Also, RenderItem.applyVanillaTransform will apply GL from the model you specify (watch for what you return there).

Development of Plugins [2012 - 2014] Development of Mods [2012 - Current]

coolAlias Reality Controller

coolAlias

Posted
Posted

In #handleItemState, you need to return 'this' instead of 'baseModel', otherwise nothing in your class is actually used ;)

 

It is returning "this" though.  :-\

Derp, so it is. For now, I'd just troubleshoot with the ISmartItemModel and get rid of IPerspectiveAwareModel. Try returning true from #isBuiltInRenderer and see if that changes anything.

TrashCaster Creeper Killer

TrashCaster

Posted
  • Author
Posted

In #handleItemState, you need to return 'this' instead of 'baseModel', otherwise nothing in your class is actually used ;)

 

It is returning "this" though.  :-\

Derp, so it is. For now, I'd just troubleshoot with the ISmartItemModel and get rid of IPerspectiveAwareModel. Try returning true from #isBuiltInRenderer and see if that changes anything.

 

Since my model only has two states, I decided to just use model variants and metadata.

 

Thanks though.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept