Search the Forums BEFORE making a new post.

[1.8] TagList in IExtendedEntityProperties

Posted November 30, 20159 yr

Can anyone give me some pointers as to what is wrong with loadNBTData() in the following code? I can tell that saveNBTData() is saving the proper data by opening the player.dat file with NBTExplorer, however, tagList.tagCount() is always 0 in loadNBTData(), and I can't figure out what is wrong with the code.

package net.woogie.extraDimensions;

import java.util.Set;

import net.minecraft.entity.Entity;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.EntityPlayerMP;
import net.minecraft.entity.player.InventoryPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.world.World;
import net.minecraftforge.common.IExtendedEntityProperties;
import net.minecraftforge.common.util.Constants;

public class ExtraDimensionsPlayerCreativeInventoryProperties implements IExtendedEntityProperties {

private final EntityPlayer player;
private static final String identifier = "ExtraDimensionsCreativeInventory";
private InventoryPlayer creativeInventory;

public ExtraDimensionsPlayerCreativeInventoryProperties(EntityPlayer player) {
	this.player = player;
	this.creativeInventory = new InventoryPlayer(player);

}

public static ExtraDimensionsPlayerCreativeInventoryProperties get(EntityPlayer player) {
	return (ExtraDimensionsPlayerCreativeInventoryProperties) player.getExtendedProperties(identifier);
}

public static void register(EntityPlayer player) {
	player.registerExtendedProperties(identifier, new ExtraDimensionsPlayerCreativeInventoryProperties(player));
}

public void setCreativeInventory(InventoryPlayer inventory) {
	this.creativeInventory.clear();
	for (int i = 0; i < inventory.getSizeInventory(); ++i) {
		ItemStack stack = inventory.getStackInSlot(i);
		this.creativeInventory.setInventorySlotContents(i, (stack == null ? null : stack.copy()));
	}
}

public InventoryPlayer getCreativeInventory() {
	return this.creativeInventory;
}

@Override
public void saveNBTData(NBTTagCompound compound) {

	int i;
	NBTTagCompound nbttagcompound;
	NBTTagList creativeInventoryNBT = new NBTTagList();

	for (i = 0; i < this.creativeInventory.mainInventory.length; ++i) {
		if (this.creativeInventory.mainInventory[i] != null) {
			nbttagcompound = new NBTTagCompound();
			nbttagcompound.setByte("Slot", (byte) i);
			this.creativeInventory.mainInventory[i].writeToNBT(nbttagcompound);
			creativeInventoryNBT.appendTag(nbttagcompound);
		}
	}

	for (i = 0; i < this.creativeInventory.armorInventory.length; ++i) {
		if (this.creativeInventory.armorInventory[i] != null) {
			nbttagcompound = new NBTTagCompound();
			nbttagcompound.setByte("Slot", (byte) (i + 100));
			this.creativeInventory.armorInventory[i].writeToNBT(nbttagcompound);
			creativeInventoryNBT.appendTag(nbttagcompound);
		}
	}

	compound.setTag(identifier, creativeInventoryNBT);
}

@Override
public void loadNBTData(NBTTagCompound compound) {
	this.creativeInventory.mainInventory = new ItemStack[36];
	this.creativeInventory.armorInventory = new ItemStack[4];

	NBTTagList tagList = compound.getTagList(identifier, Constants.NBT.TAG_COMPOUND);

	for (int i = 0; i < tagList.tagCount(); i++) {
		NBTTagCompound itemStackNBT = tagList.getCompoundTagAt(i);
		int slot = itemStackNBT.getByte("Slot") & 255;
		ItemStack itemstack = ItemStack.loadItemStackFromNBT(itemStackNBT);

		if (itemstack != null) {
			if (slot >= 0 && slot < this.creativeInventory.mainInventory.length) {
				this.creativeInventory.mainInventory[slot] = itemstack;
			}

			if (slot >= 100 && slot < this.creativeInventory.armorInventory.length + 100) {
				this.creativeInventory.armorInventory[slot - 100] = itemstack;
			}
		}
	}
}

@Override
public void init(Entity entity, World world) {

}

}

Thanks!

Quote

December 1, 20159 yr

Have you printed out the list of tags that's handed to you by the load function? May be some abnormalities there

I think its my java of the variables.

Quote

December 1, 20159 yr

Author

I've put back the debugging code, so it now looks like this:

package net.woogie.extraDimensions;

import java.util.Set;

import net.minecraft.entity.Entity;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.InventoryPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.nbt.NBTTagList;
import net.minecraft.world.World;
import net.minecraftforge.common.IExtendedEntityProperties;
import net.minecraftforge.common.util.Constants;

public class ExtraDimensionsPlayerCreativeInventoryProperties implements IExtendedEntityProperties {

private final EntityPlayer player;
private static final String identifier = "ExtraDimensionsCreativeInventory";
private InventoryPlayer creativeInventory;

public ExtraDimensionsPlayerCreativeInventoryProperties(EntityPlayer player) {
	this.player = player;
	this.creativeInventory = new InventoryPlayer(player);

}

public static ExtraDimensionsPlayerCreativeInventoryProperties get(EntityPlayer player) {
	return (ExtraDimensionsPlayerCreativeInventoryProperties) player.getExtendedProperties(identifier);
}

public static void register(EntityPlayer player) {
	player.registerExtendedProperties(identifier, new ExtraDimensionsPlayerCreativeInventoryProperties(player));
}

public void setCreativeInventory(InventoryPlayer inventory) {
	this.creativeInventory.clear();
	for (int i = 0; i < inventory.getSizeInventory(); ++i) {
		ItemStack stack = inventory.getStackInSlot(i);
		this.creativeInventory.setInventorySlotContents(i, (stack == null ? null : stack.copy()));
	}
}

public InventoryPlayer getCreativeInventory() {
	return this.creativeInventory;
}

@Override
public void saveNBTData(NBTTagCompound compound) {

	int i;
	NBTTagCompound nbttagcompound;
	NBTTagList creativeInventoryNBT = new NBTTagList();

	for (i = 0; i < this.creativeInventory.mainInventory.length; ++i) {
		if (this.creativeInventory.mainInventory[i] != null) {
			nbttagcompound = new NBTTagCompound();
			nbttagcompound.setByte("Slot", (byte) i);
			this.creativeInventory.mainInventory[i].writeToNBT(nbttagcompound);
			creativeInventoryNBT.appendTag(nbttagcompound);
		}
	}

	for (i = 0; i < this.creativeInventory.armorInventory.length; ++i) {
		if (this.creativeInventory.armorInventory[i] != null) {
			nbttagcompound = new NBTTagCompound();
			nbttagcompound.setByte("Slot", (byte) (i + 100));
			this.creativeInventory.armorInventory[i].writeToNBT(nbttagcompound);
			creativeInventoryNBT.appendTag(nbttagcompound);
		}
	}

	compound.setTag(identifier, creativeInventoryNBT);
}

@Override
public void loadNBTData(NBTTagCompound compound) {
	this.creativeInventory.mainInventory = new ItemStack[36];
	this.creativeInventory.armorInventory = new ItemStack[4];

	for (String key : (Set<String>) compound.getKeySet()) {
		System.out.println("Found tags: " + key + " tagtype: " + compound.getTagType(key));
	}

	if (compound.hasKey(identifier)) {
		System.out.println("Found key " + identifier);
	}

	if (compound.hasKey(identifier, Constants.NBT.TAG_LIST)) {
		System.out.println("Found key " + identifier + " with type " + Constants.NBT.TAG_LIST);
	}

	NBTTagList tagList = compound.getTagList(identifier, Constants.NBT.TAG_LIST);

	if (tagList == null) {
		System.out.println("tagList is null!!!");
	}

	System.out.println("tagList is type " + tagList.getTagType());
	System.out.println("tagList has " + tagList.tagCount() + " entries");


	for (int i = 0; i < tagList.tagCount(); i++) {
		NBTTagCompound itemStackNBT = tagList.getCompoundTagAt(i);
		int slot = itemStackNBT.getByte("Slot") & 255;
		ItemStack itemstack = ItemStack.loadItemStackFromNBT(itemStackNBT);

		if (itemstack != null) {
			if (slot >= 0 && slot < this.creativeInventory.mainInventory.length) {
				this.creativeInventory.mainInventory[slot] = itemstack;
			}

			if (slot >= 100 && slot < this.creativeInventory.armorInventory.length + 100) {
				this.creativeInventory.armorInventory[slot - 100] = itemstack;
			}
		}
	}
}

@Override
public void init(Entity entity, World world) {

}

}

Here is the output from the console:

[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: HurtByTimestamp tagtype: 3
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: Spawns tagtype: 9
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: SleepTimer tagtype: 2
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: Attributes tagtype: 9
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: Invulnerable tagtype: 1
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: PortalCooldown tagtype: 3
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: AbsorptionAmount tagtype: 5
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: abilities tagtype: 10
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: FallDistance tagtype: 5
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: DeathTime tagtype: 2
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: XpSeed tagtype: 3
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: ExtraDimensionsSurvivalInventory tagtype: 9
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: HealF tagtype: 5
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: XpTotal tagtype: 3
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: playerGameType tagtype: 3
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: SelectedItem tagtype: 10
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: Motion tagtype: 9
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: UUIDLeast tagtype: 4
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: Health tagtype: 2
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: foodSaturationLevel tagtype: 5
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: Air tagtype: 2
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: OnGround tagtype: 1
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: Dimension tagtype: 3
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: Rotation tagtype: 9
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: XpLevel tagtype: 3
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: Score tagtype: 3
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: UUIDMost tagtype: 4
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: Sleeping tagtype: 1
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: Pos tagtype: 9
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: Fire tagtype: 2
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: XpP tagtype: 5
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: EnderItems tagtype: 9
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: foodLevel tagtype: 3
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: foodExhaustionLevel tagtype: 5
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: HurtTime tagtype: 2
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: SelectedItemSlot tagtype: 3
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: ExtraDimensionsCreativeInventory tagtype: 9
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: Inventory tagtype: 9
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:81]: Found tags: foodTickTimer tagtype: 3
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:85]: Found key ExtraDimensionsCreativeInventory
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:89]: Found key ExtraDimensionsCreativeInventory with type 9
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:98]: tagList is type 0
[10:46:21] [server thread/INFO] [sTDOUT]: [net.woogie.extraDimensions.ExtraDimensionsPlayerCreativeInventoryProperties:loadNBTData:99]: tagList has 0 entries

Here is a screenshot of NBTExplorer taken just before starting Minecraft:

Quote

December 1, 20159 yr

Oh god... I am ashamed that I didn't notice this when I looked earlier today.

compound.getTagList(identifier, Constants.NBT.TAG_LIST);

Get List of NBTBase objects from "identifier" and "cast" them to "Constants.NBT.TAG_LIST".

So yeah - you don't want LIST of LISTS, but LIST of TAGS, which is actually "10", not "9" (Constants.NBT.TAG_LIST).

Note the fact: That way you can make e.g: List of strings or List or anything really. (just saying, something that i missed long ago in past).

1.7.10 is no longer supported by forge, you are on your own.

Quote

December 1, 20159 yr

Author

Thanks, Ernio! That did the trick!

Quote

December 2, 20159 yr

Thanks, Ernio! That did the trick!

I specifically checked for the tag list type, but your first post has the correct constant... why is it that the 2nd time you posted your code you use a different constant?

http://i.imgur.com/NdrFdld.png[/img]

Quote

December 2, 20159 yr

Author

I was trying some things and accidentally left it that way when I posted the code. Thanks again for your help.

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/35033-18-taglist-in-iextendedentityproperties/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

Help with file conversion

This is really helpful

By Brialeblanc · 2 hours ago2 hr
Cobblemon invalid player data

Hi everyone, I keep getting "invalid player data" when trying to log onto my friend's server. Log analysis says to remove Night Lights and ImmediatelyFast, but that doesn't work. Any insight is appreciated

Log: https://mclo.gs/uj6pMkd

By CobbleDN · Posted 8 hours ago8 hr
Bad pathfinding for big mobs (1.21.1)

I've struggled with this for way too long now, so I have decided to ask for some assistance here because there is almost no information about this online.

I made a hostile mob and I built it like this:
public static final Supplier<EntityType<Bunyip>> BUNYIP = ENTITY_TYPES.register("bunyip" , () -> EntityType.Builder. of(Bunyip::new, MobCategory.MONSTER).sized(3f, 2.5f).eyeHeight(1.75f).build("bunyip"));

However, I have discovered that a BoundingBox of 3 is too big for the vanilla pathfinding to work well. In fact, anything bigger than a block will not work well. This is especially noticeable when having it chase a player in a negative X and/or negative Z direction. The mob starts spinning, walking backwards, walking diagonally, etc.

I am using the Goal system:
protected void registerGoals() { super.registerGoals(); this.goalSelector.addGoal(1, new MeleeAttackGoal(this, 1.25, true)); this.targetSelector.addGoal(2, new NearestAttackableTargetGoal<>(this, Player.class, true, true)); }

This does not seem to be a me issue as the ravager, one of the biggest vanilla mobs, also struggles with proper pathfinding. I am a bit familiar with how Minecraft's pathfinding works, but not enough to make a pathfinding system from scratch (or at least not in a reasonable amount of time). Is there any way to fix this with some tweaks or will I have to make a custom pathfinding system?

By VictorEvers · Posted 16 hours ago16 hr
New Forum Design/Update: Issues and Suggestions

Unfortunately, it seems that Invision has decided that everything is locked down and no longer customizable.
Their attitude to anyone who wants to edit anything is 'Just accept it we know best and screw you for even insinuating that you want to customize your own site'
So there isn't much we can do about the layout of actual features.
Best bet for the editor is that psudo markdown works, so typing ` around words make code blocks.
Only options is to start writing bespoke modifications to the forum's php code itself, which I really don't want to do.
I would of stayed on v4 but the version of PHP that it supports is going EOL and Invision has stated they have no intentions of upgrading it.
They also removed the central community for finding plugins/community addons.
Overall it is my feeling that they are intentionally trying to kill off self-hosting communities by removing features and locking things down, in an effort to force everyone into using their paid hosting services.

My HOPE is that someone in the overall forum community will write an exporter for Invision to something like SMF. Which is what we were originally on before old team members decided enterprise software is better.

By LexManos · 20 hours ago20 hr
Orbital strike cannon fishing rod mod

Yes i will be uploading the mod to curse forge and modrinth you can already find a early build

https://www.curseforge.com/minecraft/mc-mods/wemmbus-style-orbital-strike-cannon
https://modrinth.com/mod/wemmbus-style-orbital-strike-cannon

hopefully 1.21.5 fabric will be out by the weekend also please note that there is a lot more features im adding like cubic metres orbital arrow cannon type shot (basically a stab shot but with insta kill arrows)

@JayKing014
@Astoxy
@Astoxy
@JayKing014

By FoxyWoxy · Yesterday at 03:38 AM1 day

TileEntity

Sign In

[1.8] TagList in IExtendedEntityProperties

Featured Replies

Join the conversation

Posts

Help with file conversion

Cobblemon invalid player data

Bad pathfinding for big mobs (1.21.1)

New Forum Design/Update: Issues and Suggestions

Orbital strike cannon fishing rod mod

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)