Search the Forums BEFORE making a new post.

[SOLVED] [1.8] Fluid not working :/

Posted December 4, 20159 yr

So i've tried looking at the ModelFluidDebug class here

https://github.com/MinecraftForge/MinecraftForge/blob/b45fd787f36626ef84f26e881848167fec5957b5/src/test/java/net/minecraftforge/debug/ModelFluidDebug.java

but is not working

I have done a new workspace with only that file (so basically a mod that adds only that fluid) but the texture is missing.

This is the main mod file (and also the only class in the mod)

package com.example.examplemod;

import net.minecraft.block.material.Material;
import net.minecraft.block.state.IBlockState;
import net.minecraft.client.renderer.ItemMeshDefinition;
import net.minecraft.client.renderer.block.statemap.StateMapperBase;
import net.minecraft.client.resources.model.ModelBakery;
import net.minecraft.client.resources.model.ModelResourceLocation;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.ResourceLocation;
import net.minecraftforge.client.model.ModelLoader;
import net.minecraftforge.fluids.BlockFluidClassic;
import net.minecraftforge.fluids.Fluid;
import net.minecraftforge.fluids.FluidRegistry;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.Mod.EventHandler;
import net.minecraftforge.fml.common.SidedProxy;
import net.minecraftforge.fml.common.event.FMLPreInitializationEvent;
import net.minecraftforge.fml.common.registry.GameRegistry;

@Mod(modid = ModelFluidDebug.MODID, version = ModelFluidDebug.VERSION)
public class ModelFluidDebug
{
    public static final String MODID = "ForgeDebugModelFluid";
    public static final String VERSION = "1.0";

    private static ModelResourceLocation fluidLocation = new ModelResourceLocation(MODID.toLowerCase() + ":" + TestFluidBlock.name, "fluid");
    private static ModelResourceLocation gasLocation = new ModelResourceLocation(MODID.toLowerCase() + ":" + TestFluidBlock.name, "gas");

    @EventHandler
    public void preInit(FMLPreInitializationEvent event) { FluidRegistry.registerFluid(TestFluid.instance);
    FluidRegistry.registerFluid(TestGas.instance);
    GameRegistry.registerBlock(TestFluidBlock.instance, TestFluidBlock.name);
    GameRegistry.registerBlock(TestGasBlock.instance, TestGasBlock.name); 
    Item fluid = Item.getItemFromBlock(TestFluidBlock.instance);
    Item gas = Item.getItemFromBlock(TestGasBlock.instance);
    ModelBakery.addVariantName(fluid);
    ModelBakery.addVariantName(gas);
    ModelLoader.setCustomMeshDefinition(fluid, new ItemMeshDefinition()
    {
        public ModelResourceLocation getModelLocation(ItemStack stack)
        {
            return fluidLocation;
        }
    });
    ModelLoader.setCustomMeshDefinition(gas, new ItemMeshDefinition()
    {
        public ModelResourceLocation getModelLocation(ItemStack stack)
        {
            return gasLocation;
        }
    });
    ModelLoader.setCustomStateMapper(TestFluidBlock.instance, new StateMapperBase()
    {
        protected ModelResourceLocation getModelResourceLocation(IBlockState state)
        {
            return fluidLocation;
        }
    });
    ModelLoader.setCustomStateMapper(TestGasBlock.instance, new StateMapperBase()
    {
        protected ModelResourceLocation getModelResourceLocation(IBlockState state)
        {
            return gasLocation;
        }
    });}

    public static final class TestFluid extends Fluid
    {
        public static final String name = "testfluid";
        public static final TestFluid instance = new TestFluid();

        private TestFluid()
        {
            super(name);
        }

        @Override
        public int getColor()
        {
            return 0xFF00FF00;
        }
    }

    public static final class TestGas extends Fluid
    {
        public static final String name = "testgas";
        public static final TestGas instance = new TestGas();

        private TestGas()
        {
            super(name);
            density = -1000;
            isGaseous = true;
        }

        @Override
        public int getColor()
        {
            return 0xFFFF0000;
        }
    }

    public static final class TestFluidBlock extends BlockFluidClassic
    {
        public static final TestFluidBlock instance = new TestFluidBlock();
        public static final String name = "TestFluidBlock";

        private TestFluidBlock()
        {
            super(TestFluid.instance, Material.water);
            setCreativeTab(CreativeTabs.tabBlock);
            setUnlocalizedName(MODID + ":" + name);
        }
    }

    public static final class TestGasBlock extends BlockFluidClassic
    {
        public static final TestGasBlock instance = new TestGasBlock();
        public static final String name = "TestGasBlock";

        private TestGasBlock()
        {
            super(TestGas.instance, Material.lava);
            setCreativeTab(CreativeTabs.tabBlock);
            setUnlocalizedName(MODID + ":" + name);
        }
    }
}

and that's the json file

{
    "forge_marker": 1,
    "variants": {
        "fluid": {
            "model": "forge:fluid",
            "custom": { "fluid": "testfluid" }
        },
        "gas": {
            "model": "forge:fluid",
            "custom": { "fluid": "testgas" }
        }
    }
}

any idea on why is not working?

Don't blame me if i always ask for your help. I just want to learn to be better

Quote

December 5, 20159 yr

Author

Anybody? I don't understand why the fluid when placed down is invisible

UPDATE: i've added this to the TestFluidBlock class

@Override
        public int getRenderType()
        {
        	return 3;
        }

and now it gives me this

So apparently is not spreading like the normal water does, it fills all the space with "blocks", is because it has no texture? How can i give it one?

Don't blame me if i always ask for your help. I just want to learn to be better

Quote

December 6, 20159 yr

Author

Still any idea?

Don't blame me if i always ask for your help. I just want to learn to be better

Quote

December 6, 20159 yr

I have got the same Problem too. Maybe this github code is wrong.

catch(Exception e)
{

}

Yay, Pokémon exception handling, gotta catch 'em all (and then do nothing with 'em).

Quote

December 8, 20159 yr

Author

bump

Don't blame me if i always ask for your help. I just want to learn to be better

Quote

December 8, 20159 yr

Dunno if this helps, but MODID must be lowercase..

I might be terribly wrong.. Like really, really wrong. But I'm just trying to help.

Quote

December 8, 20159 yr

Which version of Forge are you using? The fluid model was added in 1.8-11.14.3.1464.

The FML log should tell you what's going wrong. If you don't know what to make of it, upload it to Gist and link it here.

Fluid textures are set from the

Fluid(String, ResourceLocation, ResourceLocation)

constructor (added at the same time as the fluid model). Your code is using the

Fluid(String)

constructor.

The fluid code on Forge's GitHub repository works for me in 1.8-11.14.4.1571.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Quote

December 8, 20159 yr

Author

I do this in the ModelResourceLocation

MODID.toLowerCase()

so it's always lower case when passed as argument to ModelResourceLocation ctor

Don't blame me if i always ask for your help. I just want to learn to be better

Quote

December 8, 20159 yr

Author

Mmm... i'm using the 1.8-11.14.1.1375 version, i'll try it in that version

Don't blame me if i always ask for your help. I just want to learn to be better

Quote

December 8, 20159 yr

I do this in the ModelResourceLocation
MODID.toLowerCase()
so it's always lower case when passed as argument to ModelResourceLocation ctor

Well, that works.. But I'd really recommend making the MODID lowercase, as it will save you the time and tears when you forget to put it to lowercase. Give me one good reason for having an uppercase.

I might be terribly wrong.. Like really, really wrong. But I'm just trying to help.

Quote

December 8, 20159 yr

Author

ahahahah that was just a copy/paste from the github file, in fact in the mod where this will go it's lower case

Don't blame me if i always ask for your help. I just want to learn to be better

Quote

December 8, 20159 yr

wow...

Anyway, what's your current problem?

I might be terribly wrong.. Like really, really wrong. But I'm just trying to help.

Quote

December 8, 20159 yr

Author

Actually i had to test it in a newer version of Forge and see if it works As soon as i can i'll let you kow

Don't blame me if i always ask for your help. I just want to learn to be better

Quote

December 8, 20159 yr

Okay It will probably fix the issue

I might be terribly wrong.. Like really, really wrong. But I'm just trying to help.

Quote

December 9, 20159 yr

Author

Ok, so updating the Forge version to the latest or the MC1.8 fixed the error

For anyone who want an example, this is the actual code

package com.example.examplemod;

import net.minecraft.block.material.Material;
import net.minecraft.block.state.IBlockState;
import net.minecraft.client.renderer.ItemMeshDefinition;
import net.minecraft.client.renderer.block.statemap.StateMapperBase;
import net.minecraft.client.resources.model.ModelBakery;
import net.minecraft.client.resources.model.ModelResourceLocation;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.ResourceLocation;
import net.minecraftforge.client.model.ModelLoader;
import net.minecraftforge.fluids.BlockFluidClassic;
import net.minecraftforge.fluids.Fluid;
import net.minecraftforge.fluids.FluidRegistry;
import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.Mod.EventHandler;
import net.minecraftforge.fml.common.SidedProxy;
import net.minecraftforge.fml.common.event.FMLPreInitializationEvent;
import net.minecraftforge.fml.common.registry.GameRegistry;

@Mod(modid = ModelFluidDebug.MODID, version = ModelFluidDebug.VERSION)
public class ModelFluidDebug
{
    public static final String MODID = "ForgeDebugModelFluid";
    public static final String VERSION = "1.0";

    private static ModelResourceLocation fluidLocation = new ModelResourceLocation(MODID.toLowerCase() + ":" + TestFluidBlock.name, "fluid");
    private static ModelResourceLocation gasLocation = new ModelResourceLocation(MODID.toLowerCase() + ":" + TestFluidBlock.name, "gas");

    @EventHandler
    public void preInit(FMLPreInitializationEvent event) { 
    FluidRegistry.registerFluid(CustomFluid.instance);
    FluidRegistry.registerFluid(TestGas.instance);
    GameRegistry.registerBlock(TestFluidBlock.instance, TestFluidBlock.name);
    GameRegistry.registerBlock(TestGasBlock.instance, TestGasBlock.name); 
    Item fluid = Item.getItemFromBlock(TestFluidBlock.instance);
    Item gas = Item.getItemFromBlock(TestGasBlock.instance);
    ModelBakery.addVariantName(fluid);
    ModelBakery.addVariantName(gas);
    ModelLoader.setCustomMeshDefinition(fluid, new ItemMeshDefinition()
    {
        public ModelResourceLocation getModelLocation(ItemStack stack)
        {
            return fluidLocation;
        }
    });
    ModelLoader.setCustomMeshDefinition(gas, new ItemMeshDefinition()
    {
        public ModelResourceLocation getModelLocation(ItemStack stack)
        {
            return gasLocation;
        }
    });
    ModelLoader.setCustomStateMapper(TestFluidBlock.instance, new StateMapperBase()
    {
        protected ModelResourceLocation getModelResourceLocation(IBlockState state)
        {
            return fluidLocation;
        }
    });
    ModelLoader.setCustomStateMapper(TestGasBlock.instance, new StateMapperBase()
    {
        protected ModelResourceLocation getModelResourceLocation(IBlockState state)
        {
            return gasLocation;
        }
    });}

    public static final class CustomFluid extends Fluid
    {
        public static final String name = "myfluid";
        public static final CustomFluid instance = new CustomFluid();

        private CustomFluid()
        {
            super(name, new ResourceLocation(MODID.toLowerCase() + ":" + "blocks/testfluid"), new ResourceLocation(MODID.toLowerCase() + ":" + "blocks/testfluid"));
        }
    }

    public static final class TestGas extends Fluid
    {
        public static final String name = "testgas";
        public static final TestGas instance = new TestGas();

        private TestGas()
        {
            super(name, new ResourceLocation("blocks/lava_still"), new ResourceLocation("blocks/lava_flow"));
            density = -1000;
            isGaseous = true;
        }

    }

    public static final class TestFluidBlock extends BlockFluidClassic
    {
        public static final TestFluidBlock instance = new TestFluidBlock();
        public static final String name = "TestFluidBlock";

        private TestFluidBlock()
        {
            super(CustomFluid.instance, Material.water);
            setCreativeTab(CreativeTabs.tabBlock);
            setUnlocalizedName(MODID + ":" + name);
        }
        
        @Override
        public int getRenderType()
        {
        	return 3;
        }
        
        /**
         * The type of render function that is called for this block
         */
    }

    public static final class TestGasBlock extends BlockFluidClassic
    {
        public static final TestGasBlock instance = new TestGasBlock();
        public static final String name = "TestGasBlock";

        private TestGasBlock()
        {
            super(TestGas.instance, Material.lava);
            setCreativeTab(CreativeTabs.tabBlock);
            setUnlocalizedName(MODID + ":" + name);
        }
    }
}

and this is the Json file

{
    "forge_marker": 1,
    "variants": {
        "fluid": {
            "model": "forge:fluid",
            "custom": { "fluid": "myfluid" }
        },
        "gas": {
            "model": "forge:fluid",
            "custom": { "fluid": "testgas" }
        }
    }
}

Note that the name specified in "custom" in the json file is the same name as specified in the class, otherwise it will have the default water texture Thanks Choonster for the tip

Don't blame me if i always ask for your help. I just want to learn to be better

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/35078-solved-18-fluid-not-working/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

Cobblemon invalid player data

Hi everyone, I keep getting "invalid player data" when trying to log onto my friend's server. Log analysis says to remove Night Lights and ImmediatelyFast, but that doesn't work. Any insight is appreciated

Log: https://mclo.gs/uj6pMkd

By CobbleDN · Posted 4 hours ago4 hr
Bad pathfinding for big mobs (1.21.1)

I've struggled with this for way too long now, so I have decided to ask for some assistance here because there is almost no information about this online.

I made a hostile mob and I built it like this:
public static final Supplier<EntityType<Bunyip>> BUNYIP = ENTITY_TYPES.register("bunyip" , () -> EntityType.Builder. of(Bunyip::new, MobCategory.MONSTER).sized(3f, 2.5f).eyeHeight(1.75f).build("bunyip"));

However, I have discovered that a BoundingBox of 3 is too big for the vanilla pathfinding to work well. In fact, anything bigger than a block will not work well. This is especially noticeable when having it chase a player in a negative X and/or negative Z direction. The mob starts spinning, walking backwards, walking diagonally, etc.

I am using the Goal system:
protected void registerGoals() { super.registerGoals(); this.goalSelector.addGoal(1, new MeleeAttackGoal(this, 1.25, true)); this.targetSelector.addGoal(2, new NearestAttackableTargetGoal<>(this, Player.class, true, true)); }

This does not seem to be a me issue as the ravager, one of the biggest vanilla mobs, also struggles with proper pathfinding. I am a bit familiar with how Minecraft's pathfinding works, but not enough to make a pathfinding system from scratch (or at least not in a reasonable amount of time). Is there any way to fix this with some tweaks or will I have to make a custom pathfinding system?

By VictorEvers · Posted 11 hours ago11 hr
New Forum Design/Update: Issues and Suggestions

Unfortunately, it seems that Invision has decided that everything is locked down and no longer customizable.
Their attitude to anyone who wants to edit anything is 'Just accept it we know best and screw you for even insinuating that you want to customize your own site'
So there isn't much we can do about the layout of actual features.
Best bet for the editor is that psudo markdown works, so typing ` around words make code blocks.
Only options is to start writing bespoke modifications to the forum's php code itself, which I really don't want to do.
I would of stayed on v4 but the version of PHP that it supports is going EOL and Invision has stated they have no intentions of upgrading it.
They also removed the central community for finding plugins/community addons.
Overall it is my feeling that they are intentionally trying to kill off self-hosting communities by removing features and locking things down, in an effort to force everyone into using their paid hosting services.

My HOPE is that someone in the overall forum community will write an exporter for Invision to something like SMF. Which is what we were originally on before old team members decided enterprise software is better.

By LexManos · 15 hours ago15 hr
Orbital strike cannon fishing rod mod

Yes i will be uploading the mod to curse forge and modrinth you can already find a early build

https://www.curseforge.com/minecraft/mc-mods/wemmbus-style-orbital-strike-cannon
https://modrinth.com/mod/wemmbus-style-orbital-strike-cannon

hopefully 1.21.5 fabric will be out by the weekend also please note that there is a lot more features im adding like cubic metres orbital arrow cannon type shot (basically a stab shot but with insta kill arrows)

@JayKing014
@Astoxy
@Astoxy
@JayKing014

By FoxyWoxy · Yesterday at 03:38 AM1 day
Orbital strike cannon fishing rod mod

@FoxyWoxy do you potentially have an estimated time for fabric 1.21.5 and what will it be posted on (modrinth, etc.)

By JayKing014 · Yesterday at 12:36 AM1 day

Sign In

[SOLVED] [1.8] Fluid not working :/

Featured Replies

Join the conversation

Posts

Cobblemon invalid player data

Bad pathfinding for big mobs (1.21.1)

New Forum Design/Update: Issues and Suggestions

Orbital strike cannon fishing rod mod

Orbital strike cannon fishing rod mod

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)