Jump to content

Recommended Posts

Posted

Hello, I've been having a really difficult time correctly creating a custom entity i've aptly named "horror".

I'm new to entity creation so I'm certain i've made mistakes, my problem is that I dont know where the mistakes are and i cant figure out how to fix them.

 

My issue is that I havent been able to summon the monster in-game. Its not there and i dont know why not.

 

Any help would be greatly appreciated!

 

This is my Main class:

http://pastebin.com/jTbtKc9D

 

My EntityHorror class:

http://pastebin.com/uTZqBqYa

 

My EntityRegisterHorror Class:

http://pastebin.com/wS7snCkB

 

My ModelHorror Class:

http://pastebin.com/hzRfQ4Wf

 

My RenderHorror Class:

http://pastebin.com/F0C9ZikY

 

what my Eclipse looks like:

v2Ec9Cc.jpg

Posted

How do you know you did something wrong? Do you have a crash log? Is something not working? We need more details, so we know what to look for.

 

The monster isn't showing up in-game. I cant figure out why.  I edited the OP to clarify for future readers.

Posted

Do not use

EntityRegistry.registerGlobalEntityID

. It's completely unnecessary and will break things if you run out of global IDs (255 is the max and vanilla already uses a lot).

 

If you use the overload of

EntityRegistry.registerModEntity

with the two additional

int

parameters, it will call

EntityRegistry.registerEgg

for you (using the two

int

s as the background and foreground colours of the egg).

 

It looks like you're never actually calling the methods of

EntityRegisterHorror

from your main class. Side note: you don't need a separate registration class for each entity type.

 

Are you sure the entity isn't being summoned or is it just not being rendered? Put a breakpoint in the

EntityHorror

constructor and run Minecraft in debug mode.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Posted

I have a tutorial that covers a lot of the topics related to custom entities here: http://jabelarminecraft.blogspot.com/p/creating-custom-entities.html

 

There is a lot of things that actually have to come together to make a successful entity, so probably worthwhile to go through the points in my tutorial. Registering the entity, registering the renderers, animating the entity, creating a spawn egg, etc. is all described.

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Posted

You want that spawn egg so it's easy to spawn your own entity in early testing (rather than waiting for one to show up randomly). However, you should also be able to use a summon command. If the object is "successfully" summoned, but you still can't see it, then you probably have a rendering problem. Start setting break points or sprinkling your code with prints. Also, if you don't see clues in console, then check the log files, which contain more info than console out.

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

Posted

Do not use

EntityRegistry.registerGlobalEntityID

. It's completely unnecessary and will break things if you run out of global IDs (255 is the max and vanilla already uses a lot).

 

If you use the overload of

EntityRegistry.registerModEntity

with the two additional

int

parameters, it will call

EntityRegistry.registerEgg

for you (using the two

int

s as the background and foreground colours of the egg).

 

It looks like you're never actually calling the methods of

EntityRegisterHorror

from your main class. Side note: you don't need a separate registration class for each entity type.

 

Are you sure the entity isn't being summoned or is it just not being rendered? Put a breakpoint in the

EntityHorror

constructor and run Minecraft in debug mode.

 

Thank you, I was not calling those methods in the correct place. After fixing that I attempted to summon the monster in-game but still no such luck.

I know the monster isnt being summoned because the game text that appears after I enter the command "/summon entity.jm.horror.name"

is "unable to summon object".

 

 

I have a tutorial that covers a lot of the topics related to custom entities here: http://jabelarminecraft.blogspot.com/p/creating-custom-entities.html

 

There is a lot of things that actually have to come together to make a successful entity, so probably worthwhile to go through the points in my tutorial. Registering the entity, registering the renderers, animating the entity, creating a spawn egg, etc. is all described.

 

I actually used your tutorials to get this far Jabelar. Thank you so much for putting them up, they help a great deal. I don't know why I'm messing up so hard on this one.

 

I've edited the classes in the OP so that they accurately reflect what I have on my eclipse now:  I called the register and render methods in the initialization method of the main class.

 

 

Posted

You want that spawn egg so it's easy to spawn your own entity in early testing (rather than waiting for one to show up randomly). However, you should also be able to use a summon command. If the object is "successfully" summoned, but you still can't see it, then you probably have a rendering problem. Start setting break points or sprinkling your code with prints. Also, if you don't see clues in console, then check the log files, which contain more info than console out.

 

For rendering problems it is also really useful to use the F3+B key combo to enable entity bounding boxes to be highlighted. If you see your entity's bounding box, but not the entity, then you know it is a rendering problem. And to find the location of your entity (a lot of people accidentally spawn them at 0, 0, 0) like Choonster says you should use console statements to print out the position of the entity, then you know where to look. If you never get those print statements, then presumably the entity didn't even spawn.

Check out my tutorials here: http://jabelarminecraft.blogspot.com/

Posted

It looks like you're still calling

EntityRegistry.registerGlobalEntityID

, don't do this.

 

This method registers the entity class with the name you provide (i.e.

horror

), but if you only call

EntityRegistry.registerModEntity

instead it will prefix the name with your mod ID (i.e.

jm.horror

).

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Posted

SOLVED!

 

things I did after help from the people in this thread(original classes in the OP are all updated):

- changed the globalID entity registry to EntityRegistry.registerModEntity,

- moved RenderingRegistry.registerEntityRenderingHandler(EntityHorror.class, new RenderHorror(Minecraft.getMinecraft().getRenderManager(), new ModelHorror(), 1.0F)); from init() to preInit() in the main class.

- removed overridden entityInit() method from the EntityHorror class.

- removed this.getAttributeMap().registerAttribute(reinforcementChance).setBaseValue(this.rand.nextDouble() * net.minecraftforge.common.ForgeModContainer.zombieSummonBaseChance); from applyEntityAttributes method of the EntityHorror class.

 

Thank you all for your help.

 

Posted

You should be registering renderers in your client proxy, not your main class. If you call a client-only method or reference a client-only class in your main class, your mod will crash when run on a dedicated server.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • It is 1.12.2 - I have no idea if there is a 1.12 pack
    • Okay, but does the modpack works with 1.12 or just with 1.12.2, because I need the Forge client specifically for Minecraft 1.12, not 1.12.2
    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
  • Topics

  • Who's Online (See full list)

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.