Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

Sounds through Packets

Briggybros

By Briggybros
in Modder Support

 Share

Recommended Posts

Briggybros Creeper Killer

Briggybros

Posted
Posted

Hello, I am currently having problems sending a sound request through a packet system. I am constructing the packet as so;

    private void sendSoundPacket(int x, int y, int z, int sound)
    {
    	
    	ByteArrayOutputStream bos = new ByteArrayOutputStream(16);
    	DataOutputStream outputStream = new DataOutputStream(bos);
    	try
    	{
    		outputStream.writeInt(x);
    		outputStream.writeInt(y);
    		outputStream.writeInt(z);
    		outputStream.writeInt(sound);
    		outputStream.writeInt(mc.thePlayer.entityId);
    	}
    	catch (Exception ex)
    	{
    		ex.printStackTrace();
    	}

    	Packet250CustomPayload packet = new Packet250CustomPayload();
    	packet.channel = "SaberSound";
    	packet.data = bos.toByteArray();
    	packet.length = bos.size();
    	PacketDispatcher.sendPacketToServer(packet);
    }

 

Then handling it with;

	private void handleSoundPacket(Packet250CustomPayload packet, Player player)
{
	DataInputStream inputStream = new DataInputStream(new ByteArrayInputStream(packet.data));

    	int x;
    	int y;
    	int z;
    	int sound;
    	int playerID;
    	
	try
	{
		x = inputStream.readInt();
		y = inputStream.readInt();
		z = inputStream.readInt();
		sound = inputStream.readInt();
		playerID = inputStream.readInt();
	}
	catch (IOException e)
	{
		e.printStackTrace();
		return;
	}

	Side side = FMLCommonHandler.instance().getEffectiveSide();
	if (side == Side.SERVER)
	{
		sendSoundPacket(x, y, z, sound, (EntityPlayerMP)player);
	}
	else if (side == Side.CLIENT)
	{
		this.playSound(x, y, z , sound, ((EntityClientPlayerMP)mc.theWorld.getEntityByID(playerID)).worldObj); //PacketHandler.java:120
	}
}

 

The playSound method is;

    private void playSound(int x, int y, int z, int sound, World world)
    {
    	if(sound == 0)
    	{
    		world.playSoundEffect(x, y, z, "sabermod.saberoff", 1F, 1F);
    	}
    	
    	if(sound == 1)
    	{
    		world.playSoundEffect(x, y, z, "sabermod.saberon", 1F, 1F);
    	}
    	
    	if(sound == 2)
    	{
    		world.playSoundEffect(x, y, z, "sabermod.saberswing", 1F, 1F);
    	}
    }

 

and the server side sendSoundPacket is;

    private void sendSoundPacket(int x, int y, int z, int sound, EntityPlayerMP player)
    {
    	int playerID = player.entityId;
    	
    	ByteArrayOutputStream bos = new ByteArrayOutputStream(20);
    	DataOutputStream outputStream = new DataOutputStream(bos);
    	try
    	{
    		outputStream.writeInt(x);
    		outputStream.writeInt(y);
    		outputStream.writeInt(z);
    		outputStream.writeInt(sound);
    		outputStream.writeInt(playerID);
    	}
    	catch (Exception ex)
    	{
    		ex.printStackTrace();
    	}

    	Packet250CustomPayload packet = new Packet250CustomPayload();
    	packet.channel = "SaberSound";
    	packet.data = bos.toByteArray();
    	packet.length = bos.size();
    	PacketDispatcher.sendPacketToAllPlayers(packet);
    }

 

The sounds are registered with;

@ForgeSubscribe
    public void onSound(SoundLoadEvent event)
    {
        try 
        {
            event.manager.soundPoolSounds.addSound("sabermod/saberoff.ogg", SaberMod.class.getResource("/SaberMod/sound/saberoff.ogg"));
            event.manager.soundPoolSounds.addSound("sabermod/saberoff.ogg", SaberMod.class.getResource("/SaberMod/sound/saberoff.ogg"));
            event.manager.soundPoolSounds.addSound("sabermod/saberswing0.ogg", SaberMod.class.getResource("/SaberMod/sound/saberswing0.ogg"));
            event.manager.soundPoolSounds.addSound("sabermod/saberswing1.ogg", SaberMod.class.getResource("/SaberMod/sound/saberswing1.ogg"));
            event.manager.soundPoolSounds.addSound("sabermod/saberswing2.ogg", SaberMod.class.getResource("/SaberMod/sound/saberswing2.ogg"));
            event.manager.soundPoolSounds.addSound("sabermod/saberswing3.ogg", SaberMod.class.getResource("/SaberMod/sound/saberswing3.ogg"));
            event.manager.soundPoolSounds.addSound("sabermod/saberswing4.ogg", SaberMod.class.getResource("/SaberMod/sound/saberswing4.ogg"));
            event.manager.soundPoolSounds.addSound("sabermod/saberswing5.ogg", SaberMod.class.getResource("/SaberMod/sound/saberswing5.ogg"));
            event.manager.soundPoolSounds.addSound("sabermod/saberswing6.ogg", SaberMod.class.getResource("/SaberMod/sound/saberswing6.ogg"));
            event.manager.soundPoolSounds.addSound("sabermod/saberswing7.ogg", SaberMod.class.getResource("/SaberMod/sound/saberswing7.ogg"));
        } 
        catch (Exception e)
        {
            System.err.println("Failed to register one or more sounds.");
        }
    }

 

The error I get is;

2012-11-21 00:13:00 [iNFO] [sTDERR] net.minecraft.src.ReportedException: Exception in world tick
2012-11-21 00:13:00 [iNFO] [sTDERR] 	at net.minecraft.client.Minecraft.runTick(Minecraft.java:1892)
2012-11-21 00:13:00 [iNFO] [sTDERR] 	at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:858)
2012-11-21 00:13:00 [iNFO] [sTDERR] 	at net.minecraft.client.Minecraft.run(Minecraft.java:783)
2012-11-21 00:13:00 [iNFO] [sTDERR] 	at java.lang.Thread.run(Unknown Source)
2012-11-21 00:13:00 [iNFO] [sTDERR] Caused by: java.lang.NullPointerException
2012-11-21 00:13:00 [iNFO] [sTDERR] 	at uk.co.toomuchminecraft.sabermod.PacketHandler.handleSoundPacket(PacketHandler.java:120)
2012-11-21 00:13:00 [iNFO] [sTDERR] 	at uk.co.toomuchminecraft.sabermod.PacketHandler.onPacketData(PacketHandler.java:43)
2012-11-21 00:13:00 [iNFO] [sTDERR] 	at cpw.mods.fml.common.network.NetworkRegistry.handlePacket(NetworkRegistry.java:249)
2012-11-21 00:13:00 [iNFO] [sTDERR] 	at cpw.mods.fml.common.network.NetworkRegistry.handleCustomPacket(NetworkRegistry.java:239)
2012-11-21 00:13:00 [iNFO] [sTDERR] 	at cpw.mods.fml.common.network.FMLNetworkHandler.handlePacket250Packet(FMLNetworkHandler.java:78)
2012-11-21 00:13:00 [iNFO] [sTDERR] 	at net.minecraft.src.NetClientHandler.handleCustomPayload(NetClientHandler.java:1344)
2012-11-21 00:13:00 [iNFO] [sTDERR] 	at net.minecraft.src.Packet250CustomPayload.processPacket(Packet250CustomPayload.java:70)
2012-11-21 00:13:00 [iNFO] [sTDERR] 	at net.minecraft.src.MemoryConnection.processReadPackets(MemoryConnection.java:79)
2012-11-21 00:13:00 [iNFO] [sTDERR] 	at net.minecraft.src.NetClientHandler.processReadPackets(NetClientHandler.java:104)
2012-11-21 00:13:00 [iNFO] [sTDERR] 	at net.minecraft.src.WorldClient.tick(WorldClient.java:72)
2012-11-21 00:13:00 [iNFO] [sTDERR] 	at net.minecraft.client.Minecraft.runTick(Minecraft.java:1876)
2012-11-21 00:13:00 [iNFO] [sTDERR] 	... 3 more

 

I have marked the error location from the log in the src. What is going wrong with this? I think it's possibly the worlds, but I can't seem to be able to fix it whatever it is.

WildBamaBoy Tree Puncher

WildBamaBoy

Posted
Posted

I'd say for some reason it's failing to get an instance of the player from the client world.

 

Check the playerID when its sent and when its received. Make sure it's what it should be.

 

Also could you not just cast the player provided to EntityClientPlayerMP like you did server-side?

Briggybros Creeper Killer

Briggybros

Posted
  • Author
Posted

I was debating that, but surely, typecasting the player to EntityClientPlayerMP wouldn't return a player it would return CONSOLE as if it's being handled on the client it was sent from the server.

 

EDIT: Edited the PacketHandler;

package uk.co.toomuchminecraft.sabermod;

import java.io.ByteArrayInputStream;
import java.io.ByteArrayOutputStream;
import java.io.DataInputStream;
import java.io.DataOutputStream;
import java.io.IOException;
import net.minecraft.client.Minecraft;
import net.minecraft.src.Entity;
import net.minecraft.src.EntityClientPlayerMP;
import net.minecraft.src.EntityList;
import net.minecraft.src.EntityPlayer;
import net.minecraft.src.EntityPlayerMP;
import net.minecraft.src.EntityPlayerSP;
import net.minecraft.src.INetworkManager;
import net.minecraft.src.InventoryPlayer;
import net.minecraft.src.ItemStack;
import net.minecraft.src.Packet250CustomPayload;
import net.minecraft.src.World;
import net.minecraft.src.WorldClient;
import cpw.mods.fml.common.FMLCommonHandler;
import cpw.mods.fml.common.Side;
import cpw.mods.fml.common.asm.SideOnly;
import cpw.mods.fml.common.network.IPacketHandler;
import cpw.mods.fml.common.network.PacketDispatcher;
import cpw.mods.fml.common.network.Player;

public class PacketHandler implements IPacketHandler
{
@SideOnly(Side.CLIENT)
Minecraft mc;

@Override
public void onPacketData(INetworkManager manager, Packet250CustomPayload packet, Player player)
{
	if (packet.channel.equals("SaberExtend"))
	{
		handleExtendPacket(packet, player);
	}

	if (packet.channel.equals("SaberSound"))
	{
		handleSoundPacket(packet, player);
	}
}

private void handleExtendPacket(Packet250CustomPayload packet, Player player)
{
	DataInputStream inputStream = new DataInputStream(new ByteArrayInputStream(packet.data));

    	int itemID;
    	int itemDamage;
    	int slot;
    	int action;
    	int saberID;
    	
	try
	{
		itemID = inputStream.readInt();
		itemDamage = inputStream.readInt();
		slot = inputStream.readInt();
		action = inputStream.readInt();
		saberID = inputStream.readInt();
	}
	catch (IOException e)
	{
		e.printStackTrace();
		return;
	}

	Side side = FMLCommonHandler.instance().getEffectiveSide();
	if (side == Side.SERVER)
	{
		EntityPlayerMP executingPlayer = (EntityPlayerMP)player;
		extendSaber(saberID, action, executingPlayer);
		PacketDispatcher.sendPacketToAllPlayers(packet);
		closeInventoryChange(executingPlayer);
	}
	else if (side == Side.CLIENT)
	{
		EntityClientPlayerMP executingPlayer = (EntityClientPlayerMP)player;
		extendSaber(saberID, action, executingPlayer);
		closeInventoryChange(executingPlayer);
	}
}

private void handleSoundPacket(Packet250CustomPayload packet, Player player)
{
	DataInputStream inputStream = new DataInputStream(new ByteArrayInputStream(packet.data));

    	int x;
    	int y;
    	int z;
    	int sound;
    	
	try
	{
		x = inputStream.readInt();
		y = inputStream.readInt();
		z = inputStream.readInt();
		sound = inputStream.readInt();
	}
	catch (IOException e)
	{
		e.printStackTrace();
		return;
	}

	Side side = FMLCommonHandler.instance().getEffectiveSide();
	if (side == Side.SERVER)
	{
		PacketDispatcher.sendPacketToAllPlayers(packet);
		playSound(x, y, z, sound, (EntityPlayerMP)player);
	}
	else if (side == Side.CLIENT)
	{
		this.playSound(x, y, z , sound, (EntityClientPlayerMP)player);
	}
}

private void closeInventoryChange(EntityClientPlayerMP player)
{
	player.inventory.inventoryChanged = false;
}

private void closeInventoryChange(EntityPlayerMP player)
{
	player.inventory.inventoryChanged = false;
}
    
    private void playSound(int x, int y, int z, int sound, EntityClientPlayerMP player)
    {
    	if(sound == 0)
    	{
    		player.worldObj.playSoundEffect(x, y, z, "sabermod.saberoff", 1F, 1F);
    	}
    	
    	if(sound == 1)
    	{
    		player.worldObj.playSoundEffect(x, y, z, "sabermod.saberon", 1F, 1F);
    	}
    	
    	if(sound == 2)
    	{
    		player.worldObj.playSoundEffect(x, y, z, "sabermod.saberswing", 1F, 1F);
    	}
    }
    
    private void playSound(int x, int y, int z, int sound, EntityPlayerMP player)
    {
    	if(sound == 0)
    	{
    		System.out.println("SaberMod: " + player.username + " playing lightsaber retract sound");
    	}
    	
    	if(sound == 1)
    	{
    		System.out.println("SaberMod: " + player.username + " playing lightsaber extend sound");
    	}
    	
    	if(sound == 2)
    	{
    		System.out.println("SaberMod: " + player.username + " playing lightsaber swing sound");
    	}
    }
    
    private void extendSaber(int saberID, int action, EntityPlayerMP player)
    {
    	if(saberID == 0)
    	{
    		if(action == 0)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberPurpleOff.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    			System.out.println("SaberMod: " + player.username + " retracting lightsaber");
    		}
    		if(action == 1)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberPurpleOn.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    			System.out.println("SaberMod: " + player.username + " extending lightsaber");
    		}
    	}
    	if(saberID == 1)
    	{
    		if(action == 0)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberRedOff.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    			System.out.println("SaberMod: " + player.username + " retracting lightsaber");
    		}
    		if(action == 1)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberRedOn.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    			System.out.println("SaberMod: " + player.username + " extending lightsaber");
    		}
    	}
    	if(saberID == 2)
    	{
    		if(action == 0)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberYellowOff.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    			System.out.println("SaberMod: " + player.username + " retracting lightsaber");
    		}
    		if(action == 1)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberYellowOn.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    			System.out.println("SaberMod: " + player.username + " extending lightsaber");
    		}
    	}
    	if(saberID == 3)
    	{
    		if(action == 0)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberGreenOff.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    			System.out.println("SaberMod: " + player.username + " retracting lightsaber");
    		}
    		if(action == 1)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberGreenOn.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    			System.out.println("SaberMod: " + player.username + " extending lightsaber");
    		}
    	}
    	if(saberID == 4)
    	{
    		if(action == 0)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberBlackOff.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    			System.out.println("SaberMod: " + player.username + " retracting lightsaber");
    		}
    		if(action == 1)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberBlackOn.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    			System.out.println("SaberMod: " + player.username + " extending lightsaber");
    		}
    	}
    	if(saberID == 5)
    	{
    		if(action == 0)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberIndigoOff.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    			System.out.println("SaberMod: " + player.username + " retracting lightsaber");
    		}
    		if(action == 1)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberIndigoOn.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    			System.out.println("SaberMod: " + player.username + " extending lightsaber");
    		}
    	}
    	if(saberID == 6)
    	{
    		if(action == 0)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberDarkBlueOff.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    			System.out.println("SaberMod: " + player.username + " retracting lightsaber");
    		}
    		if(action == 1)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberDarkBlueOn.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    			System.out.println("SaberMod: " + player.username + " extending lightsaber");
    		}
    	}
    	if(saberID == 7)
    	{
    		if(action == 0)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberGoldOff.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    			System.out.println("SaberMod: " + player.username + " retracting lightsaber");
    		}
    		if(action == 1)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberGoldOn.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    			System.out.println("SaberMod: " + player.username + " extending lightsaber");
    		}
    	}
    	if(saberID == 
    	{
    		if(action == 0)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberLightBlueOff.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    			System.out.println("SaberMod: " + player.username + " retracting lightsaber");
    		}
    		if(action == 1)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberLightBlueOn.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    			System.out.println("SaberMod: " + player.username + " extending lightsaber");
    		}
    	}
    }
    
    private void extendSaber(int saberID, int action, EntityClientPlayerMP player)
    {
    	if(saberID == 0)
    	{
    		if(action == 0)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberPurpleOff.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    		}
    		if(action == 1)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberPurpleOn.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    		}
    	}
    	if(saberID == 1)
    	{
    		if(action == 0)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberRedOff.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    		}
    		if(action == 1)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberRedOn.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    		}
    	}
    	if(saberID == 2)
    	{
    		if(action == 0)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberYellowOff.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    		}
    		if(action == 1)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberYellowOn.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    		}
    	}
    	if(saberID == 3)
    	{
    		if(action == 0)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberGreenOff.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    		}
    		if(action == 1)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberGreenOn.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    		}
    	}
    	if(saberID == 4)
    	{
    		if(action == 0)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberBlackOff.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    		}
    		if(action == 1)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberBlackOn.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    		}
    	}
    	if(saberID == 5)
    	{
    		if(action == 0)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberIndigoOff.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    		}
    		if(action == 1)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberIndigoOn.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    		}
    	}
    	if(saberID == 6)
    	{
    		if(action == 0)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberDarkBlueOff.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    		}
    		if(action == 1)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberDarkBlueOn.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    		}
    	}
    	if(saberID == 7)
    	{
    		if(action == 0)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberGoldOff.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    		}
    		if(action == 1)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberGoldOn.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    		}
    	}
    	if(saberID == 
    	{
    		if(action == 0)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberLightBlueOff.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    		}
    		if(action == 1)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberLightBlueOn.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    		}
    	}
    }
}

 

EDIT: The system outputs the system messages for the extend sabers methods twice - not a problem, just can get cluttered. Also, the system output for the sound playing is working without error, however the sound itself isn't actually playing. I register the sounds with this clientside and play them as you can see in the PacketHandler.

package uk.co.toomuchminecraft.sabermod.client;

import uk.co.toomuchminecraft.sabermod.SaberMod;
import net.minecraft.client.Minecraft;
import net.minecraft.src.World;
import net.minecraftforge.client.event.sound.SoundLoadEvent;
import net.minecraftforge.event.ForgeSubscribe;

public class SaberSounds
{
    @ForgeSubscribe
    public void onSound(SoundLoadEvent event)
    {
        try 
        {
            event.manager.soundPoolSounds.addSound("sabermod/saberoff.ogg", SaberMod.class.getResource("/SaberMod/sound/saberoff.ogg"));
            event.manager.soundPoolSounds.addSound("sabermod/saberoff.ogg", SaberMod.class.getResource("/SaberMod/sound/saberoff.ogg"));
            event.manager.soundPoolSounds.addSound("sabermod/saberswing0.ogg", SaberMod.class.getResource("/SaberMod/sound/saberswing0.ogg"));
            event.manager.soundPoolSounds.addSound("sabermod/saberswing1.ogg", SaberMod.class.getResource("/SaberMod/sound/saberswing1.ogg"));
            event.manager.soundPoolSounds.addSound("sabermod/saberswing2.ogg", SaberMod.class.getResource("/SaberMod/sound/saberswing2.ogg"));
            event.manager.soundPoolSounds.addSound("sabermod/saberswing3.ogg", SaberMod.class.getResource("/SaberMod/sound/saberswing3.ogg"));
            event.manager.soundPoolSounds.addSound("sabermod/saberswing4.ogg", SaberMod.class.getResource("/SaberMod/sound/saberswing4.ogg"));
            event.manager.soundPoolSounds.addSound("sabermod/saberswing5.ogg", SaberMod.class.getResource("/SaberMod/sound/saberswing5.ogg"));
            event.manager.soundPoolSounds.addSound("sabermod/saberswing6.ogg", SaberMod.class.getResource("/SaberMod/sound/saberswing6.ogg"));
            event.manager.soundPoolSounds.addSound("sabermod/saberswing7.ogg", SaberMod.class.getResource("/SaberMod/sound/saberswing7.ogg"));
        } 
        catch (Exception e)
        {
            System.err.println("Failed to register one or more sounds.");
        }
    }
}

rich1051414 Creeper Killer

rich1051414

Posted
Posted

That's a bit nuts... although client to server packets get you kicked without your own packet handler, it usually is not necessary. If the method runs client and server side, just do this:

 

if(!world.isRemote()){

world.playerSoundAtEntity(player, ...etc);

}

 

If you need to play a sound but you are in a client side environment, just send the dimension and the entity ID that the sound originates and do a:

WorldServer world = FMLCommonHandler.getInstance().getServerInstance().getWorldServerByDimensionID(dimSentToSever);

Entity entity = world.getEntityByID(idSentToServer);

world.playSoundAtEntity(entity, ...);

 

 

I just typed that out by memory, so don't copy and paste it, it is just to give you an idea of how its normally done.

Briggybros Creeper Killer

Briggybros

Posted
  • Author
Posted

I've split my packet methods into the common and client proxy, thinking that if it were serverside then it would only run the CommonProxy and clientside, it would be overridden by the ClientProxy. So my PacketHandler now looks like this;

package uk.co.toomuchminecraft.sabermod;

import java.io.ByteArrayInputStream;
import java.io.ByteArrayOutputStream;
import java.io.DataInputStream;
import java.io.DataOutputStream;
import java.io.IOException;
import net.minecraft.client.Minecraft;
import net.minecraft.src.Entity;
import net.minecraft.src.EntityPlayerMP;
import net.minecraft.src.INetworkManager;
import net.minecraft.src.InventoryPlayer;
import net.minecraft.src.ItemStack;
import net.minecraft.src.Packet250CustomPayload;
import net.minecraft.src.World;
import net.minecraft.src.WorldClient;
import cpw.mods.fml.common.FMLCommonHandler;
import cpw.mods.fml.common.Side;
import cpw.mods.fml.common.asm.SideOnly;
import cpw.mods.fml.common.network.IPacketHandler;
import cpw.mods.fml.common.network.PacketDispatcher;
import cpw.mods.fml.common.network.Player;

public class PacketHandler implements IPacketHandler
{
@SideOnly(Side.CLIENT)
Minecraft mc;

@Override
public void onPacketData(INetworkManager manager, Packet250CustomPayload packet, Player player)
{
	if (packet.channel.equals("SaberExtend"))
	{
		handleExtendPacket(packet, player);
	}

	if (packet.channel.equals("SaberSound"))
	{
		handleSoundPacket(packet, player);
	}
}

private void handleExtendPacket(Packet250CustomPayload packet, Player player)
{
	DataInputStream inputStream = new DataInputStream(new ByteArrayInputStream(packet.data));

    	int itemID;
    	int itemDamage;
    	int slot;
    	int action;
    	int saberID;
    	
	try
	{
		itemID = inputStream.readInt();
		itemDamage = inputStream.readInt();
		slot = inputStream.readInt();
		action = inputStream.readInt();
		saberID = inputStream.readInt();
	}
	catch (IOException e)
	{
		e.printStackTrace();
		return;
	}

	Side side = FMLCommonHandler.instance().getEffectiveSide();
	if (side == Side.SERVER)
	{
		SaberMod.proxy.extendSaber(saberID, action, player);
		PacketDispatcher.sendPacketToAllPlayers(packet);
		SaberMod.proxy.closeInventoryChange(player);
	}
	else if (side == Side.CLIENT)
	{
		SaberMod.proxy.extendSaber(saberID, action, player);
		SaberMod.proxy.closeInventoryChange(player);
	}
}

private void handleSoundPacket(Packet250CustomPayload packet, Player player)
{
	DataInputStream inputStream = new DataInputStream(new ByteArrayInputStream(packet.data));

    	int sound;
    	
	try
	{
		sound = inputStream.readInt();
	}
	catch (IOException e)
	{
		e.printStackTrace();
		return;
	}

	Side side = FMLCommonHandler.instance().getEffectiveSide();
	if (side == Side.SERVER)
	{
		PacketDispatcher.sendPacketToAllPlayers(packet);
		SaberMod.proxy.playSound(sound, player);
	}
	else if (side == Side.CLIENT)
	{
		SaberMod.proxy.playSound(sound, player);
	}
}
}

 

The CommonProxy methods are;

    public void playSound(int sound, Player p)
    {
    	EntityClientPlayerMP player = (EntityClientPlayerMP)p;
    	if(sound == 0)
    	{
    		System.out.println("SaberMod: " + player.username + " playing lightsaber retract sound");
    	}
    	
    	if(sound == 1)
    	{
    		System.out.println("SaberMod: " + player.username + " playing lightsaber extend sound");
    	}
    	
    	if(sound == 2)
    	{
    		System.out.println("SaberMod: " + player.username + " playing lightsaber swing sound");
    	}
    }
    
public void closeInventoryChange(Player p)
{
	EntityPlayerMP player = (EntityPlayerMP)p;
	player.inventory.inventoryChanged = false;
}
    
    public void extendSaber(int saberID, int action, Player p)
    {
    	EntityPlayerMP player = (EntityPlayerMP)p;
    	if(saberID == 0)
    	{
    		if(action == 0)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberPurpleOff.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    			System.out.println("SaberMod: " + player.username + " retracting lightsaber");
    		}
    		if(action == 1)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberPurpleOn.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    			System.out.println("SaberMod: " + player.username + " extending lightsaber");
    		}
    	}
    	if(saberID == 1)
    	{
    		if(action == 0)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberRedOff.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    			System.out.println("SaberMod: " + player.username + " retracting lightsaber");
    		}
    		if(action == 1)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberRedOn.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    			System.out.println("SaberMod: " + player.username + " extending lightsaber");
    		}
    	}
    	if(saberID == 2)
    	{
    		if(action == 0)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberYellowOff.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    			System.out.println("SaberMod: " + player.username + " retracting lightsaber");
    		}
    		if(action == 1)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberYellowOn.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    			System.out.println("SaberMod: " + player.username + " extending lightsaber");
    		}
    	}
    	if(saberID == 3)
    	{
    		if(action == 0)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberGreenOff.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    			System.out.println("SaberMod: " + player.username + " retracting lightsaber");
    		}
    		if(action == 1)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberGreenOn.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    			System.out.println("SaberMod: " + player.username + " extending lightsaber");
    		}
    	}
    	if(saberID == 4)
    	{
    		if(action == 0)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberBlackOff.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    			System.out.println("SaberMod: " + player.username + " retracting lightsaber");
    		}
    		if(action == 1)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberBlackOn.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    			System.out.println("SaberMod: " + player.username + " extending lightsaber");
    		}
    	}
    	if(saberID == 5)
    	{
    		if(action == 0)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberIndigoOff.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    			System.out.println("SaberMod: " + player.username + " retracting lightsaber");
    		}
    		if(action == 1)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberIndigoOn.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    			System.out.println("SaberMod: " + player.username + " extending lightsaber");
    		}
    	}
    	if(saberID == 6)
    	{
    		if(action == 0)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberDarkBlueOff.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    			System.out.println("SaberMod: " + player.username + " retracting lightsaber");
    		}
    		if(action == 1)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberDarkBlueOn.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    			System.out.println("SaberMod: " + player.username + " extending lightsaber");
    		}
    	}
    	if(saberID == 7)
    	{
    		if(action == 0)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberGoldOff.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    			System.out.println("SaberMod: " + player.username + " retracting lightsaber");
    		}
    		if(action == 1)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberGoldOn.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    			System.out.println("SaberMod: " + player.username + " extending lightsaber");
    		}
    	}
    	if(saberID == 
    	{
    		if(action == 0)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberLightBlueOff.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    			System.out.println("SaberMod: " + player.username + " retracting lightsaber");
    		}
    		if(action == 1)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberLightBlueOn.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    			System.out.println("SaberMod: " + player.username + " extending lightsaber");
    		}
    	}
    }

 

and my ClientProxy methods are;

@Override
    public void playSound(int sound, Player p)
    {
    	EntityPlayerMP player = (EntityPlayerMP)p;
    	if(sound == 0)
    	{
    		player.worldObj.playSoundAtEntity((Entity)player, "sabermod.saberoff", 1F, 1F);
    	}
    	
    	if(sound == 1)
    	{
    		player.worldObj.playSoundAtEntity((Entity)player, "sabermod.saberon", 1F, 1F);
    	}
    	
    	if(sound == 2)
    	{
    		player.worldObj.playSoundAtEntity((Entity)player, "sabermod.saberswing", 1F, 1F);
    	}
    }

@Override
public void closeInventoryChange(Player p)
{
	EntityPlayerMP player = (EntityPlayerMP)p;
	player.inventory.inventoryChanged = false;
}

@Override
    public void extendSaber(int saberID, int action, Player p)
    {
	EntityPlayerMP player = (EntityPlayerMP)p; // ClientProxy(303)
	if(saberID == 0)
    	{
    		if(action == 0)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberPurpleOff.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    		}
    		if(action == 1)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberPurpleOn.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    		}
    	}
    	if(saberID == 1)
    	{
    		if(action == 0)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberRedOff.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    		}
    		if(action == 1)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberRedOn.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    		}
    	}
    	if(saberID == 2)
    	{
    		if(action == 0)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberYellowOff.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    		}
    		if(action == 1)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberYellowOn.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    		}
    	}
    	if(saberID == 3)
    	{
    		if(action == 0)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberGreenOff.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    		}
    		if(action == 1)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberGreenOn.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    		}
    	}
    	if(saberID == 4)
    	{
    		if(action == 0)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberBlackOff.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    		}
    		if(action == 1)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberBlackOn.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    		}
    	}
    	if(saberID == 5)
    	{
    		if(action == 0)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberIndigoOff.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    		}
    		if(action == 1)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberIndigoOn.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    		}
    	}
    	if(saberID == 6)
    	{
    		if(action == 0)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberDarkBlueOff.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    		}
    		if(action == 1)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberDarkBlueOn.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    		}
    	}
    	if(saberID == 7)
    	{
    		if(action == 0)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberGoldOff.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    		}
    		if(action == 1)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberGoldOn.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    		}
    	}
    	if(saberID == 
    	{
    		if(action == 0)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberLightBlueOff.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    		}
    		if(action == 1)
    		{
    			InventoryPlayer inventoryplayer = player.inventory;
    			inventoryplayer.setInventorySlotContents(inventoryplayer.currentItem, new ItemStack(SaberMod.saberLightBlueOn.shiftedIndex, 1, inventoryplayer.getCurrentItem().getItemDamage()));
    			player.inventory.inventoryChanged = true;
    		}
    	}
    }

 

However, when I run the game the when calling one of these methods the client throws this error;

2012-11-23 18:26:10 [iNFO] [sTDERR] net.minecraft.src.ReportedException: Exception in world tick
2012-11-23 18:26:10 [iNFO] [sTDERR] 	at net.minecraft.client.Minecraft.runTick(Minecraft.java:1892)
2012-11-23 18:26:10 [iNFO] [sTDERR] 	at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:858)
2012-11-23 18:26:10 [iNFO] [sTDERR] 	at net.minecraft.client.Minecraft.run(Minecraft.java:783)
2012-11-23 18:26:10 [iNFO] [sTDERR] 	at java.lang.Thread.run(Unknown Source)
2012-11-23 18:26:10 [iNFO] [sTDERR] Caused by: java.lang.ClassCastException: net.minecraft.src.EntityClientPlayerMP cannot be cast to net.minecraft.src.EntityPlayerMP
2012-11-23 18:26:10 [iNFO] [sTDERR] 	at uk.co.toomuchminecraft.sabermod.client.ClientProxy.extendSaber(ClientProxy.java:303)
2012-11-23 18:26:10 [iNFO] [sTDERR] 	at uk.co.toomuchminecraft.sabermod.PacketHandler.handleExtendPacket(PacketHandler.java:76)
2012-11-23 18:26:10 [iNFO] [sTDERR] 	at uk.co.toomuchminecraft.sabermod.PacketHandler.onPacketData(PacketHandler.java:34)
2012-11-23 18:26:10 [iNFO] [sTDERR] 	at cpw.mods.fml.common.network.NetworkRegistry.handlePacket(NetworkRegistry.java:249)
2012-11-23 18:26:10 [iNFO] [sTDERR] 	at cpw.mods.fml.common.network.NetworkRegistry.handleCustomPacket(NetworkRegistry.java:239)
2012-11-23 18:26:10 [iNFO] [sTDERR] 	at cpw.mods.fml.common.network.FMLNetworkHandler.handlePacket250Packet(FMLNetworkHandler.java:78)
2012-11-23 18:26:10 [iNFO] [sTDERR] 	at net.minecraft.src.NetClientHandler.handleCustomPayload(NetClientHandler.java:1344)
2012-11-23 18:26:10 [iNFO] [sTDERR] 	at net.minecraft.src.Packet250CustomPayload.processPacket(Packet250CustomPayload.java:70)
2012-11-23 18:26:10 [iNFO] [sTDERR] 	at net.minecraft.src.MemoryConnection.processReadPackets(MemoryConnection.java:79)
2012-11-23 18:26:10 [iNFO] [sTDERR] 	at net.minecraft.src.NetClientHandler.processReadPackets(NetClientHandler.java:104)
2012-11-23 18:26:10 [iNFO] [sTDERR] 	at net.minecraft.src.WorldClient.tick(WorldClient.java:72)
2012-11-23 18:26:10 [iNFO] [sTDERR] 	at net.minecraft.client.Minecraft.runTick(Minecraft.java:1876)
2012-11-23 18:26:10 [iNFO] [sTDERR] 	... 3 more

Again I have marked the line in the code. I'm really stumped with this, can someone help?

rich1051414 Creeper Killer

rich1051414

Posted
Posted

Use EntityPlayer references, not EntityPlayerMP(server only) or EntityClientPlayerMP(ClientSide), they BOTH inherit Entity Player, so that declaration is safe.

 

If you make sure it is serverside when you play sound at entity, the built in event bus will send the necessary packets to the clients to play sounds.

 

A client cannot tell the server to play a sound without a custom packet handler, and unless the server knows to play the sound too, you may not hear it at all, and definitely other players will not.

 

Most of the time, your methods can be accessed both by server and client, and you need to make sure which side you are on to prevent undesired packet duplication.(Servers CAN send packets to themselves.)

 

But as I said, all this is unnecessary 99% of the time, as most of your code can be accessed by the server and client.

 

You need to be careful setting up a packet handler to play sounds, because a clever coder could abuse it, spamming everyone with sounds. It is ideal to do the sound playing within the method, and avoid a packet handler when possible.

 

As I said, if the server side gets told to play a sound, it will automatically register the event and will deliver it with the built in packet handler.

nado Tree Puncher

nado

Posted
Posted

Sorry for slight necro. I'm doing some sounds using packets because I wasn't aware of what rich1051414 is saying.

 

Does that apply for simple world.playsound(...) calls, rich105? I had tried that originally with no luck, so I did the packet sending myself.

rich1051414 Creeper Killer

rich1051414

Posted
Posted

Sorry for slight necro. I'm doing some sounds using packets because I wasn't aware of what rich1051414 is saying.

 

Does that apply for simple world.playsound(...) calls, rich105? I had tried that originally with no luck, so I did the packet sending myself.

 

Depends on the method, some methods execute client side only, i dont play sounds at all in these, but in one situation, I did need to play a sound via a packet. In onItemUseFirst overrides, if you return false to prevent a menu from opening, it will not run server side. I made a packet to handle this request, but as it also consumed items, I felt it was a low risk of abuse.

 

And yes, all my sounds are played in a "if (FMLCommonHandler.instance().getEffectiveSide().isServer()) {}" block, and they all work great, and as an added bonus, it is inherently multiplayer compatible, other players will hear it too.

 

When I had problems playing sounds, it was when I did not put world.playSoundAtEntity calls within a server check block. This is probably your issue.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • Randream
      java.lang.NoSuchFieldError: TESSELATION_SHADERS

      By Randream · Posted

      When i start my game with a shader active the game crashes with this Error: java.lang.NoSuchFieldError: TESSELATION_SHADERS Minecraft java 1.20.1 in forge 47.4.0 crash report in pastebin: https://pastebin.com/6xiwHqZW thanks in advance
    • TileEntity
      invalid Java Runtime configuration

      By TileEntity · Posted

      If you are using AMD/ATI, update your drivers - get the drivers from their website - do not update via system
    • TicketZ
      Server was fine, then I restarted it and it wont turn back on. It uses fabric mods

      By TicketZ · Posted

      Not sure why this is happening, but I would love some help. The reason I restarted the server was because I was getting an error while trying to join regarding this "Internal Exception: io.netty.handler.codec.DecoderException: io.netty.handler.codec.EncoderException: java.io.IOException: Root tag must be a named compound tag" Im using ServerMiner if thats any help
    • TicketZ
      Server was fine, then I restarted it and it wont turn back on. It uses fabric mods

      By TicketZ · Posted

      [13-05-2025 02:20:01]    |-- fabric-renderer-registries-v1 3.2.25+df3654b390 [13-05-2025 02:20:01]    |-- fabric-rendering-data-attachment-v1 0.3.19+6e0787e690 [13-05-2025 02:20:01]    |-- fabric-rendering-fluids-v1 3.0.11+4d0d570390 [13-05-2025 02:20:01]    |-- fabric-rendering-v0 1.1.28+df3654b390 [13-05-2025 02:20:01]    |-- fabric-rendering-v1 1.13.0+526f2c6790 [13-05-2025 02:20:01]    |-- fabric-resource-conditions-api-v1 2.1.2+aae9039d90 [13-05-2025 02:20:01]    |-- fabric-resource-loader-v0 0.8.4+edbdcddb90 [13-05-2025 02:20:01]    |-- fabric-screen-api-v1 1.0.32+4d0d570390 [13-05-2025 02:20:01]    |-- fabric-screen-handler-api-v1 1.3.8+1cc24b1b90 [13-05-2025 02:20:01]    |-- fabric-sound-api-v1 1.0.2+c4f28df590 [13-05-2025 02:20:01]    |-- fabric-textures-v0 1.0.24+aeb40ebe90 [13-05-2025 02:20:01]    |-- fabric-transfer-api-v1 2.1.6+413cbbc790 [13-05-2025 02:20:01]    \-- fabric-transitive-access-wideners-v1 1.3.3+08b73de490 [13-05-2025 02:20:01] - fabricloader 0.16.14 [13-05-2025 02:20:01]    \-- mixinextras 0.4.1 [13-05-2025 02:20:01] - geckolib3 3.1.40 [13-05-2025 02:20:01]    \-- com_eliotlash_mclib_mclib 20 [13-05-2025 02:20:01] - genesis 1.19.2-1.0.2 [13-05-2025 02:20:01] - grounded_origins 1.2.3 [13-05-2025 02:20:01]    \-- apugli 1.9.3+1.19-fabric [13-05-2025 02:20:01] - icarus 1.14.1 [13-05-2025 02:20:01] - identity 2.6.1-1.19.1 [13-05-2025 02:20:01]    \-- omega-config 1.2.3-1.18.1 [13-05-2025 02:20:01] - impaled 1.1.4 [13-05-2025 02:20:01] - itemfig 1.19.2-0.2.7-fabric [13-05-2025 02:20:01] - java 17 [13-05-2025 02:20:01] - journeymap 5.9.8 [13-05-2025 02:20:01]    \-- journeymap-api-fabric 1.19.1-1.9-fabric-SNAPSHOT [13-05-2025 02:20:01] - landchidori 1.0.3 [13-05-2025 02:20:01] - latoorigins 1.19.2-1.1.0 [13-05-2025 02:20:01] - lithium 0.11.1 [13-05-2025 02:20:01] - magic_origins v0.3.5 [13-05-2025 02:20:01] - medievalorigins 5.1.9.2+1.19.2 [13-05-2025 02:20:01]    |-- additionalentityattributes 1.4.0+1.19.2 [13-05-2025 02:20:01]    |-- common-protection-api 1.0.0 [13-05-2025 02:20:01]    \-- reach-entity-attributes 2.3.0 [13-05-2025 02:20:01] - midnightlib 1.0.0 [13-05-2025 02:20:01] - minecraft 1.19.2 [13-05-2025 02:20:01] - moborigins 1.10.0 [13-05-2025 02:20:01] - mrplaguewarper 1.0.8 [13-05-2025 02:20:01] - mythic 1.0.2 [13-05-2025 02:20:01] - mythorigins 1.19-0.2.0 [13-05-2025 02:20:01] - omnitrix_origins 1.0.0 [13-05-2025 02:20:01] - oneporigins 1.0 [13-05-2025 02:20:01] - origins 1.7.1 [13-05-2025 02:20:01]    |-- apoli 2.6.1 [13-05-2025 02:20:01]    |    |-- calio 1.7.0 [13-05-2025 02:20:01]    |    |-- cardinal-components-base 5.0.1 [13-05-2025 02:20:01]    |    |-- cardinal-components-entity 5.0.1 [13-05-2025 02:20:01]    |    |-- cloth-config 8.0.75 [13-05-2025 02:20:01]    |    |    \-- cloth-basic-math 0.6.1 [13-05-2025 02:20:01]    |    \-- playerabilitylib 1.6.0 [13-05-2025 02:20:01]    \-- reach-entity-attributes 2.3.0 [13-05-2025 02:20:01] - origins-plus-plus 2.3.1 [13-05-2025 02:20:01] - origins_4d_being 1.0.0 [13-05-2025 02:20:01] - origins_vampire_mr 1-v2.1.0 [13-05-2025 02:20:01] - originsumbrellas 1.5.4 [13-05-2025 02:20:01] - pehkui 3.8.3+1.14.4-1.21 [13-05-2025 02:20:01]    \-- kanos_config 0.4.1+1.14.4-1.19.4 [13-05-2025 02:20:01] - promans_origins 1.0.0 [13-05-2025 02:20:01] - rpg_origins 1.4.3 [13-05-2025 02:20:01] - sculkling 1.0.0 [13-05-2025 02:20:01] - seleni 0.2.5+1.19.2 [13-05-2025 02:20:01] - slimeorigin 2.0.2-1.19.2 [13-05-2025 02:20:01] - spilaioorigins 1.19-0.3.0 [13-05-2025 02:20:01] - thiccpackets 1.17-1.19+ [13-05-2025 02:20:01] - thorigins 4.2.0 [13-05-2025 02:20:01] - trinkets 3.4.2 [13-05-2025 02:20:01] - voidwalker 1.0.0 [13-05-2025 02:20:01] - yee 3.0.3 [13-05-2025 02:20:01] Found 1 non-fabric mod: [13-05-2025 02:20:01] - better_weapons-1.jar [13-05-2025 02:20:01] SpongePowered MIXIN Subsystem Version=0.8.7 Source=file:/home/smpicnic/server/data/libraries/net/fabricmc/sponge-mixin/0.15.5+mixin.0.8.7/sponge-mixin-0.15.5+mixin.0.8.7.jar Service=Knot/Fabric Env=SERVER [13-05-2025 02:20:01] Compatibility level set to JAVA_17 [13-05-2025 02:20:02] Loaded configuration file for Lithium: 114 options available, 0 override(s) found [13-05-2025 02:20:02] Error loading class: net/minecraft/class_998 (java.lang.ClassNotFoundException: net/minecraft/class_998) [13-05-2025 02:20:02] @Mixin target net.minecraft.class_998 was not found impaled.mixins.json:TridentRiptideFeatureRendererMixin from mod impaled [13-05-2025 02:20:02] Initializing MixinExtras via com.llamalad7.mixinextras.service.MixinExtrasServiceImpl(version=0.4.1). [13-05-2025 02:20:03] Method overwrite conflict for revertScale in slimeorigin.mixins.json:MixinLivingEntity from mod slimeorigin, previously written by latokike.mythorigins.mixin.LivingEntityMixin. Skipping method. [13-05-2025 02:20:03] Added Config bclib.generator to auto sync (file hash) [13-05-2025 02:20:03] Added Config bclib.main to auto sync (content diff) [13-05-2025 02:20:03] Added Config bclib.recipes to auto sync (file hash) [13-05-2025 02:20:03] Added Config bclib.biomes to auto sync (file hash) [13-05-2025 02:20:04] Method overwrite conflict for damage in spilaioorigins.mixins.json:ItemStackMixin from mod spilaioorigins, previously written by latokike.latoorigins.mixin.ItemStackMixin. Skipping method. [13-05-2025 02:20:05] Building unoptimized datafixer [13-05-2025 02:20:05] Method overwrite conflict for method_6091 in moborigins.mixins.json:RavagerEntityMixin from mod moborigins, previously written by draylar.identity.mixin.RavagerEntityMixin. Skipping method. [13-05-2025 02:20:05] Minecraft has crashed! [13-05-2025 02:20:05] net.fabricmc.loader.impl.FormattedException: java.lang.NoSuchFieldError: ATTACK_DAMAGE_MODIFIER [13-05-2025 02:20:05] at net.fabricmc.loader.impl.FormattedException.ofLocalized(FormattedException.java:63) ~[fabric-loader-0.16.14.jar:?] [13-05-2025 02:20:05] at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:482) ~[fabric-loader-0.16.14.jar:?] [13-05-2025 02:20:05] at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74) [fabric-loader-0.16.14.jar:?] [13-05-2025 02:20:05] at net.fabricmc.loader.impl.launch.knot.KnotServer.main(KnotServer.java:23) [fabric-loader-0.16.14.jar:?] [13-05-2025 02:20:05] at net.fabricmc.loader.impl.launch.server.FabricServerLauncher.main(FabricServerLauncher.java:69) [fabric-loader-0.16.14.jar:?] [13-05-2025 02:20:05] Caused by: java.lang.NoSuchFieldError: ATTACK_DAMAGE_MODIFIER [13-05-2025 02:20:05] at net.minecraft.class_1799.<clinit>(class_1799.java:126) ~[server-intermediary.jar:?] [13-05-2025 02:20:05] at net.minecraft.class_1761.<init>(class_1761.java:114) ~[server-intermediary.jar:?] [13-05-2025 02:20:05] at net.minecraft.class_1761$1.<init>(class_1761.java:15) ~[server-intermediary.jar:?] [13-05-2025 02:20:05] at net.minecraft.class_1761.<clinit>(class_1761.java:15) ~[server-intermediary.jar:?] [13-05-2025 02:20:05] at net.minecraft.class_1802.<clinit>(class_1802.java:22) ~[server-intermediary.jar:?] [13-05-2025 02:20:05] at net.minecraft.class_1308$Anonymous$dedb2ce0fc304852b6ae6ea54fec0e73.<init>(DropSkullsMixins.java:23) ~[?:?] [13-05-2025 02:20:05] at net.minecraft.class_1308.<clinit>(class_1308.java:87) ~[server-intermediary.jar:?] [13-05-2025 02:20:05] at net.minecraft.class_1299.<clinit>(class_1299.java:260) ~[server-intermediary.jar:?] [13-05-2025 02:20:05] at net.minecraft.class_3103.<clinit>(class_3103.java:28) ~[server-intermediary.jar:?] [13-05-2025 02:20:05] at net.minecraft.class_3031.<clinit>(class_3031.java:84) ~[server-intermediary.jar:?] [13-05-2025 02:20:05] at net.minecraft.class_6800.<clinit>(class_6800.java:20) ~[server-intermediary.jar:?] [13-05-2025 02:20:05] at net.minecraft.class_6803.method_39702(class_6803.java:24) ~[server-intermediary.jar:?] [13-05-2025 02:20:05] at net.minecraft.class_5458.method_44104(class_5458.java:98) ~[server-intermediary.jar:?] [13-05-2025 02:20:05] at net.minecraft.class_5458.method_30566(class_5458.java:105) ~[server-intermediary.jar:?] [13-05-2025 02:20:05] at java.util.LinkedHashMap.forEach(LinkedHashMap.java:721) ~[?:?] [13-05-2025 02:20:05] at net.minecraft.class_5458.<clinit>(class_5458.java:104) ~[server-intermediary.jar:?] [13-05-2025 02:20:05] at net.minecraft.class_2378.<clinit>(class_2378.java:326) ~[server-intermediary.jar:?] [13-05-2025 02:20:05] at net.minecraft.class_2966.method_12851(class_2966.java:50) ~[server-intermediary.jar:?] [13-05-2025 02:20:05] at net.minecraft.server.Main.main(Main.java:98) ~[server-intermediary.jar:?] [13-05-2025 02:20:05] at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:480) ~[fabric-loader-0.16.14.jar:?] [13-05-2025 02:20:05] ... 3 more
    • Sylus
      invalid Java Runtime configuration

      By Sylus · Posted

      Every time I try to run a modpack I am using, I get a crash error saying that it was caused by an invalid Java Runtime configuration. I have tried everything I can think of to try and debug it but nothing has worked. https://pastebin.com/ddxQTLh4

  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept