[1.8] How to stop the player from sprinting?

[HappyKiller1O1]

Alright, so I need to stop the player from accessing the sprint option while certain things are true. I can modify the players walk speed quite fine. But, when attempting to stop the player from sprinting, it works for double tapping the forward key, and pressing the sprint key. But, holding the sprint key down allows them to sprint. Any way to prevent this?

 

Here's where I do the changing of movement speed:

@SubscribeEvent
public void onLivingUpdate(LivingUpdateEvent event) {
	if(event.entity instanceof EntityPlayer) {
		EntityPlayer player = (EntityPlayer)event.entity;

		ExtendedPlayer props = ExtendedPlayer.get(player);

		if(props.get(player) != null) {
			if(props.isOverEncumbered()) {
				System.out.println("Player is Overencumbered! Changing walk speed...");

				player.capabilities.setPlayerWalkSpeed(0.05F);

				player.setSprinting(false);
			}else {
				if(player.capabilities.getWalkSpeed() != 0.1F) {
					player.capabilities.setPlayerWalkSpeed(0.1F);
				}
			}
		}
	}
}

[coolAlias]

You should consider adding AttributeModifiers to the player's speed instead of trying to manage it directly - it will play much better with vanilla / other mods and is also pretty easy. Take a look at the vanilla Sprinting modifier (in one of the Entity classes, maybe EntityLivingBase) and change the bonus to a penalty.

[HappyKiller1O1]

I'll get to that, but what is so different between setting the player walk speed in PlayerCapabilities, and setting it in AttributeModifier?

[coolAlias]

I'll get to that, but what is so different between setting the player walk speed in PlayerCapabilities, and setting it in AttributeModifier?

Because you wouldn't be setting it, you would be adding a modifier.

[HappyKiller1O1]

Ah yes, I read through some older threads while waiting for your reply. So, you can simply use any randomly generated UUID to store your AttributeModifier?

[HappyKiller1O1]

I got that to work pretty flawlessly. But, I hate how the FOV changes when I lower the speed. I know there is an FOVUpdateEvent, but how will it know when not to change the FOV?

[coolAlias]

It won't, but you can recalculate it manually based on the same formula as in EntityPlayerSP but removing your custom modifier from the equation, i.e. by subtracting it from the retrieved speed attribute total.

[HappyKiller1O1]

So, I should get the player's current speed, and subtract my modified speed from it to reset the FOV?

[HappyKiller1O1]

Hm, so I figured that if I check my ExtendedPlayer for the method "isOverEncumbered", I can basically tell the event when I am changing the speed. Should I just make the new FOV, the FOV setting the player may have set? (Just in case they changed their default FOV)

[coolAlias]

Sorry, looks like 1.8 moved the #getFovModifier to AbstractClientPlayer class. Take a look at it and all should become clear. See how they get the entire speed attribute value (including ALL modifiers)? Do the same, but then subtract your custom modifier value (if present) from it before doing the rest of the FOV calculation.

[HappyKiller1O1]

Hm, I decided, considering I will not be changing how slow you are when you're overencumbered; I would just use the double that is set for the speed after the modifier. Here is what I have:

 

@SubscribeEvent
public void onFOVChanged(FOVUpdateEvent event) {
	if(event.entity != null) {
		EntityPlayer player = event.entity;

		ExtendedPlayer props = ExtendedPlayer.get(player);

		if(props.isOverEncumbered() && player.getActivePotionEffects().isEmpty()) {
			IAttributeInstance iai = player.getEntityAttribute(SharedMonsterAttributes.movementSpeed);

			double speed = iai.getAttributeValue();

			//System.out.println("Speed: " + speed);
			//System.out.println("Compared Speed: " + 0.06000000089406967);

			if(speed == 0.06000000089406967) {
				System.out.println("SPEED IS KEY");

				event.newfov = 1.0F;
			}
		}
	}
}

 

Although, this does help A LOT with my code and such. This does not help me stop the player from sprinting entirely.

[coolAlias]

You should most definitely NOT compare floating point values like that using equality... not to mention that there could be other attribute modifiers affecting the players speed besides yours.

 

If you really want to stop the player from sprinting, the only reliable way to do so is to setSprinting(false) every tick and on the client side unset the sprint key:

KeyBinding.setKeyBindState(mc.gameSettings.keyBindSprint.getKeyCode(), false);

[HappyKiller1O1]

Hm, I might honestly just keep the FOV change as it is not too much of a bother. And, should I do that in my LivingUpdateEvent, or in a client side tick handler?

[coolAlias]

And, should I do that in my LivingUpdateEvent, or in a client side tick handler?

Well, keyboard input is all handled client-side only, so which do you think would be the better choice?

[HappyKiller1O1]

Gotcha. Although, couldn't I just disable the key once, and re-enable it when the player is not over-encumbered? Or does it need to be disabled every tick?

[coolAlias]

It's not disabling the key, it is unsetting the key state so that, as far as the game is concerned, it is not pressed, even when it is. Obviously you would only unset the key state when the player is encumbered, otherwise you would prevent the player from sprinting ever, and that's not the goal.

[HappyKiller1O1]

Hm, I will be using the tick handler, but would there be any way of disabling the key input for a time? I feel like if you could, it might save some processing power from constantly setting the state of the key. I may be wrong though, so thanks.

[61352151511]

You both seem to forget the sprint keybind is not the only way to sprint. I still use the the old method of double tapping forward. So the tick handler is the definitely the way to go, I wouldn't be overly concerned about disabling the sprint key considering you could still start sprinting via double tapping forward.

[HappyKiller1O1]

You disable sprint by doing:

 

 player.setSprinting(false) 

 

within a tick handler. I have to set the state of the KeyBind, in order to stop the player for pressing or holding down CTRL (or whatever they have set it to) to sprint.

 

@coolAlias So, I wasn't able to set the key state via ClientTickEvent (ExtendedPlayer couldn't get the props right). So I just check if it is a client world in #onLivingUpdate, and if so, set the KeyBind as false when OverEncumbered.