[1.8]Crafting echnachted books

[Kaneka]

HI everybody,

 

I wanted to add some recipes(shapeless) with enchated books, but only one at a time... all i get is that you can craft with all enchanted books, not only the one i type.

 

Thanks for your answers,

 

 

Kaneka

[HappyKiller1O1]

Please take a look at the ItemEnchantedBook class (net.minecraft.item.ItemEnchantedBook). With this, you will see that enchantments are saved via NBT to the ItemStack. When creating the book in crafting, you need to set the correct NBT.

[Kaneka]

hi, i read the ItemEnchantedBook, and see that the addEnchantment - method adds the NBT, but this wount work :

ItemStack eff1 = new ItemStack(Items.enchanted_book);
eff1.addEnchantment(Enchantment.efficiency, 1);

GameRegistry.addShapelessRecipe(new ItemStack(Modblocks.eff1), eff1);

[HappyKiller1O1]

Could you show where you're registering it? This should work just fine.

[Kaneka]

In the init part of my Common proxy

[HappyKiller1O1]

Try just adding the recipe in the init of your main mod class. Or, make sure your CommonProxy is registered correctly.

[Kaneka]

It is set up correctly, my mod works fine...check planttech if you dont think so ....see here(I deletet all unimportant parts and wrote there a ...):

Main.class:

public class Main
{
   ...
    @SidedProxy(clientSide="net.kaneka.planttech.ClientProxy", serverSide="net.kaneka.planttech.ServerProxy")
    public static CommonProxy proxy;
    
    @EventHandler
    public void preinit(FMLPreInitializationEvent e)
    {
    	 
    		...
    	
	this.proxy.preInit(e);

    }
    
    @EventHandler
    public void init(FMLInitializationEvent e)
    {
    	
    	this.proxy.init(e);
    	

    }
    
    @EventHandler
    public void postinit(FMLPostInitializationEvent e)
    {
	this.proxy.postInit(e);
    }
}

 

Commonproxy.class:

public class CommonProxy {


    public void preInit(FMLPreInitializationEvent e) 
    {
    	...
    	
    }

    public void init(FMLInitializationEvent e) 
    {
    	Craftingrecipes.addRecipe();
    	
    	...
    	
    }

    public void postInit(FMLPostInitializationEvent e) 
    {

    }
}

 

and least but not last:

Craftingrecipes:

public class Craftingrecipes {

public static void addRecipe()
{
              ....
ItemStack eff1 = new ItemStack(Items.enchanted_book);
	eff1.addEnchantment(Enchantment.efficiency, 1);


	GameRegistry.addShapelessRecipe(new ItemStack(Modblocks.eff1), eff1);

}
}

[HappyKiller1O1]

Call "CraftingRecipes.addRecipe" in your main mod init, not your proxy. Also, try doing "ItemStack(ModItem.eff1, 1, 0)". The 1 is the amount required, the 0 is the metadata.

[Kaneka]

Did all you said, nothing works...

[HappyKiller1O1]

Well, if the recipe isn't working, it must not be registering. If the enchanting isn't working, you'll have to set the NBT manually.

[Kaneka]

This do no work....addenchantment return void, but the addRecipe method needs only ItemStack as input, but i think i found the major problem:

My code in CraftingRecipes:

..
GameRegistry.addShapelessRecipe(new ItemStack(Modblocks.eff1,1,0), Items.enchanted_book.getEnchantedItemStack(new EnchantmentData(Enchantment.efficiency, 1)));
...

 

GameRegistry.class:

...
public static void addShapelessRecipe(ItemStack output, Object... params)
    {
        CraftingManager.getInstance().addShapelessRecipe(output, params);
    }
...

 

CrafttingManager.class:

...
public void addShapelessRecipe(ItemStack stack, Object ... recipeComponents)
    {
        ArrayList arraylist = Lists.newArrayList();
        Object[] aobject = recipeComponents;
        int i = recipeComponents.length;

        for (int j = 0; j < i; ++j)
        {
            Object object1 = aobject[j];

            if (object1 instanceof ItemStack)
            {
                arraylist.add(((ItemStack)object1).copy());
            }
            else if (object1 instanceof Item)
            {
                arraylist.add(new ItemStack((Item)object1));
            }
            else
            {
                if (!(object1 instanceof Block))
                {
                    throw new IllegalArgumentException("Invalid shapeless recipe: unknown type " + object1.getClass().getName() + "!");
                }

                arraylist.add(new ItemStack((Block)object1));
            }
        }

       [u] this.recipes.add(new ShapelessRecipes(stack, arraylist));[/u]
    }

...

 

recipes.class:

...
public void addShapelessRecipe(ItemStack stack, Object ... recipeComponents)
    {
        ArrayList arraylist = Lists.newArrayList();
        Object[] aobject = recipeComponents;
        int i = recipeComponents.length;

        for (int j = 0; j < i; ++j)
        {
            Object object1 = aobject[j];

            if (object1 instanceof ItemStack)
            {
                arraylist.add(((ItemStack)object1).copy());
            }
            else if (object1 instanceof Item)
            {
                arraylist.add(new ItemStack((Item)object1));
            }
            else
            {
                if (!(object1 instanceof Block))
                {
                    throw new IllegalArgumentException("Invalid shapeless recipe: unknown type " + object1.getClass().getName() + "!");
                }

                arraylist.add(new ItemStack((Block)object1));
            }
        }

        [u]this.recipes.add(new ShapelessRecipes(stack, arraylist));[/u]
    }
...

 

ShapelessRecipes.class

...
public boolean matches(InventoryCrafting p_77569_1_, World worldIn)
    {
        ArrayList arraylist = Lists.newArrayList(this.recipeItems);

        for (int i = 0; i < p_77569_1_.getHeight(); ++i)
        {
            for (int j = 0; j < p_77569_1_.getWidth(); ++j)
            {
                ItemStack itemstack = p_77569_1_.getStackInRowAndColumn(j, i);

                if (itemstack != null)
                {
                    boolean flag = false;
                    Iterator iterator = arraylist.iterator();

                    while (iterator.hasNext())
                    {
                        ItemStack itemstack1 = (ItemStack)iterator.next();

                        if (itemstack.getItem() == itemstack1.getItem() && (itemstack1.getMetadata() == 32767 || itemstack.getMetadata() == itemstack1.getMetadata()))
                        {
                            flag = true;
                            arraylist.remove(itemstack1);
                            break;
                        }
                    }

                    if (!flag)
                    {
                        return false;
                    }
                }
            }
        }

        return arraylist.isEmpty();
    }
...

 

I see that with the .getItem in the last Code it erases the enchantment....

[Kaneka]

oh ok, thanks for the answers...

[jeffryfisher]

1) Your sided proxy annotation mentions "ClientProxy" and "ServerProxy", but you showed us only CommonProxy. There are potential problems here if they're not tied together properly, and we can't see them.

 

2) If you're going to put something vital into a common proxy method, then make sure that your client proxy method (and server proxy method) calls super.

 

3) When you say "won't work", please be more specific. Did it report an error? did the line even execute? Have you stepped through in the debugger and seen some wrong data or found data missing?

 

4) If you haven't stepped through the errant code in a debugger, please do so. Many puzzling errors become head-slappers in the debugger. Even if not, there's SO much more you can tell us after examining what's actually happening in the order it happens.

 

5) I'm looking at "new ItemStack(Modblocks.eff1...)" and trying to see Modblocks to check its declaration and instantiation of this other eff1. Where is it? What is it? Is it a block that becomes an specific enchanted book in a crafting table? The recipe "won't work" if this input object is out of order.

   

the .getItem in the last Code it erases the enchantment...

6) Which enchantment, input or output? When and where was "matches" called? Was it operating on recipe inputs or output? If you were hoping for an input item to confer an enchantment upon an output, then you need an anvil, not a crafting table. Crafting tables do indeed drop enchantments (which is why you should never repair magic items in ordinary crafting spaces unless you want to scrub them -- making a palimpsest ready for new enchantments).

 

7) Tell us what you are trying to do.

[Elix_x]

If you were hoping for an input item to confer an enchantment upon an output, then you need an anvil, not a crafting table. Crafting tables do indeed drop enchantments (which is why you should never repair magic items in ordinary crafting spaces unless you want to scrub them -- making a palimpsest ready for new enchantments).

Although it is still possible to use custom

IRecipe

to depend on enchantements.