Jump to content

[SOLVED][1.8.x] Dynamic block textures without TESR


Recommended Posts

Posted

I'm trying to port my multi block fluid tank from 1.7.10. I got connected textures to work using the new model system and blockstates but I can't figure out how to go about rendering the fluid. The problem is the texture. I can't predefine any textures in the .jsons because I don't know what fluids other mods will add. So I looked at ISmartBlockModel in hope of finding a way to change the fluid texture programmatically but I can't figure out how to do it (I also read TheGreyGhosts examples for ISmartBlockModel but they deal only with swapping out entire models or composing them together, no texture changes). I'm aware that in this case going with TESR would probably much easier but I want to avoid the performance hit if at all possible.

 

If someone can point me in the right direction or even give a short example I would be grateful.

Posted

You can render this with ISmartBlockModel, though of course you'll still need a tile entity to know what fluid is stored in the tank.

 

You'll need to construct a SmartBlockModel that returns a different model from handleBlockState (or from getQuads) depending on MinecraftForgeClient.getRenderLayer().  Presumably you would use SOLID or ALPHA for your inner fluid model and CUTOUT or ALPHA for the external tank.

 

I suppose you could render both the tank and fluid with alpha, but you'd have to merge the baked quads from both models and return them via getFaceQuads or getGeneralQuads.

 

I'm not exactly sure how you'll get the fluid texture because I haven't done that myself, but look at the new forge bucket - they had to do it somehow.

 

One you have the fluid texture, call retexture on your fluid model before baking it.  You could also dynamically bake a model or quads for each handleBlockState but there really aren't going to be so many fluids that you can't just pre-bake them and cache them all up front. You could cache them right in the SmartBlockModel and return the appropriate baked fluid model in handleBlockState.

 

Posted

Thanks ! (Sorry for the late reply.)

 

I almost got everything to work. Once I ironed out the kinks I'll probably make a post explaining what I ended up doing so others can learn from it or at least have a good laugh ;).

Posted

So as promised an (attempted) explanation for what I did.

 

I ended up making two separate models, one for the tank frame and one for the fluid. The tank model has a blockstate json that defines all the connected textures variants. The fluid model has none.

 

In onModelBakeEvent the fluid model is loaded using the ModelLoader and cast to IRetexturableModel. Then .retexture() is called on it for every fluid in the forge fluid registry. The resulting models get baked and cached. Finally all tank variant models in the ModelRegistry get replaced with an ISmartBlockModel that stores the tank variant model.

 

In ISmartBlockModel.handleBlockState() an IBakedModel is returned that gets the variant model from the ISmartBlockModel and the fluid name from the IExtendedBlockState. In getFaceQuads() and getGeneralQuads() the IBakedModel returns the quads of the tank variant model plus the quads of the previously cached fluid model determined by the stored fluid name.

 

There's some additional stuff happening and there is actually more than one fluid model for the different fill levels of the tank, but explaining that would make everything too complicated.

 

For those that prefer looking at code:

https://github.com/Zarathul/simplefluidtanks/blob/1.8/src/main/java/net/zarathul/simplefluidtanks/ClientEventHub.java

https://github.com/Zarathul/simplefluidtanks/blob/1.8/src/main/java/net/zarathul/simplefluidtanks/rendering/TankModelFactory.java

https://github.com/Zarathul/simplefluidtanks/blob/1.8/src/main/java/net/zarathul/simplefluidtanks/rendering/BakedTankModel.java

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • i managed to fix it by reinstalling the modpack and re-add all the extra mods I've had previously.
    • Ah, it appears I spoke too soon, I still need a little help here. I now have the forceloading working reliably.  However, I've realized it's not always the first tick that loads the entity.  I've seen it take anywhere from 2-20ish to actually go through, in which time my debugging has revealed that the chunk is loaded, but during which time calling  serverLevelIn.getEntity(uuidIn) returns a null result.  I suspect this has to do with queuing and how entities are loaded into the game.  While not optimal, it's acceptable, and I don't think there's a whole ton I can do to avoid it. However, my concern is that occasionally teleporting an entity in this manner causes a lag spike.  It's not every time and gives the appearance of being correlated with when other chunks are loading in.  It's also not typically a long spike, but can last a second or two, which is less than ideal.  The gist of how I'm summoning is here (although I've omitted some parts that weren't relevant.  The lag occurs before the actual summon so I'm pretty confident it's the loading, and not the actual summon call). ChunkPos chunkPos = new ChunkPos(entityPosIn); if (serverLevelIn.areEntitiesLoaded(chunkPos.toLong())) { boolean isSummoned = // The method I'm using for actual summoning is called here. Apart from a few checks, the bulk of it is shown later on. if (isSummoned) { // Code that runs here just notifies the player of the summon, clears it from the queue, and removes the forceload } } else { // I continue forcing the chunk until the summon succeeds, to make sure it isn't inadvertently cleared ForgeChunkManager.forceChunk(serverLevelIn, MODID, summonPosIn, chunkPos.x, chunkPos.z, true, true); } The summon code itself uses serverLevelIn.getEntity(uuidIn) to retrieve the entity, and moves it as such.  It is then moved thusly: if (entity.isAlive()) { entity.moveTo(posIn.getX(), posIn.getY(), posIn.getZ()); serverLevelIn.playSound(null, entity, SoundEvents.ENDERMAN_TELEPORT, SoundSource.NEUTRAL, 1.0F, 1.0F); return true; } I originally was calling .getEntity() more frequently and didn't have the check for whether or not entities were loaded in place to prevent unnecessary code calls, but even with those safety measures in place, the lag still persists.  Could this just be an issue with 1.18's lack of optimization in certain areas?  Is there anything I can do to mitigate it?  Is there a performance boosting mod I could recommend alongside my own to reduce the chunk loading lag? At the end of the day, it does work, and I'm putting measures in place to prevent players from abusing the system to cause lag (i.e. each player can only have one queued summon at a time-- trying to summon another replaces the first call).  It's also not an unacceptable level of lag, IMO, given the infrequency of such calls, and the fact that I'm providing the option to toggle off the feature if server admins don't want it used.  However, no amount of lag is ideal, so if possible I'd love to find a more elegant solution-- or at least a mod recommendation to help improve it. Thanks!
    • When i start my forge server its on but when i try to join its come a error Internal Exception: java.lang.OutOfMemoryError: Requested array size exceeds VM limit Server infos: Linux Minecraft version 1.20.1 -Xmx11G -Xms8G
    • Also add the latest.log from your logs-folder
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.