Jump to content

Recommended Posts

Posted

Good nigts

i been working in an elevator for mi mod i actualy have more of the elevator is working plus the door,

but i missing a control gui to set where i wanna go

 

like is a block after all  i been using a tileEntity to store the data soo im trying to make a GUI whith the tileentity Data

but get stuck whith the little issue, how i send the data from the presed button in the client side to the tileEntity in the server side to make the elevator works

 

i alredy have package system and has alredy made code to send packages from gui in the local side to especific entity in the server side, but never to

tileEntity

 

thanks fro reading

 

 

 

Posted

Are you using the SimpleNetworkWrapper to deal with your packets? If not, I recommend it. There's a thread somewhere about it.

 

When you open the interface, you should store the tile entity position as a variable. Then when you click your button, send it back to the server through the packet.

Try to do as indicated, and post back with your results. Posting your errors, and attempted code if needed.

Posted

well i have of that  most of that

 

 

 

the question is what would go here 

if i wanna send the package to the tileEntity in

BlockPos{x=-46, y=72, z=328}

 

protected void actionPerformed(GuiButton guibutton) {
	// id is the id you give your button

	int dx;
	int dy;
	int sx;

	switch (guibutton.id) {
	case 0:

		break;

	case 1:

		break;

	case 2:


		break;


	}
	// Packet code here
	// PacketDispatcher.sendPacketToServer(packet); //send packet
}

 

 

in the gui for the merchant of mi mod i send the packages this way

 

protected void actionPerformed(GuiButton guibutton) {
	// id is the id you give your button

	int dx;
	int dy;
	int sx;

	switch (guibutton.id) {
	case 1:
		Mercenary.network.sendToServer(new mensajeMercenarioalServidor("UPapp_"+te.getEntity().getEntityId() ));
		break;

	case 2:
		Mercenary.network.sendToServer(new mensajeMercenarioalServidor("BUY_00"+te.getEntity().getEntityId() ));
		break;

	case 3:
		Mercenary.network.sendToServer(new mensajeMercenarioalServidor("BUY_01"+te.getEntity().getEntityId() ));
		break;

	case 4:
		Mercenary.network.sendToServer(new mensajeMercenarioalServidor("BUY_02"+te.getEntity().getEntityId() ));
		break;			

	case 5:
		Mercenary.network.sendToServer(new mensajeMercenarioalServidor("BUY_03"+te.getEntity().getEntityId() ));
		break;

	case 6:
		Mercenary.network.sendToServer(new mensajeMercenarioalServidor("BUY_04"+te.getEntity().getEntityId() ));
		break;

	case 7:
		Mercenary.network.sendToServer(new mensajeMercenarioalServidor("DWapp_"+te.getEntity().getEntityId() ));
		break;

	case 8:
		Mercenary.network.sendToServer(new mensajeMercenarioalServidor("BOT_00"+te.getEntity().getEntityId() ));
		break;

	case 9:
		Mercenary.network.sendToServer(new mensajeMercenarioalServidor("BOT_01"+te.getEntity().getEntityId() ));
		break;

	case 10:
		Mercenary.network.sendToServer(new mensajeMercenarioalServidor("BOT_02"+te.getEntity().getEntityId() ));
		break;
	}
	// Packet code here
	// PacketDispatcher.sendPacketToServer(packet); //send packet
}

 

 

thanks for reading

Posted

Well, you have your buttons. You simply send packet to server when button is pressed.

Packet will contain x/y/z and data you want to send.

On server you know who is sending packet (from MessageContext), then you get world of player and get TileEntity is x/y/z.

Update your data in server's TileEntity (1st always check if it is "legal", e.g if player is actually near TE and stuff).

After server's data is updated - send update packets back to all clients that need it (again with x/y/z system).

 

Note: That is if you are using TE + Gui (client).

 

Addition:

If your TileEntity uses Container (has slots), the server knows when player has Container opened (you know, server's one corresponds with client's one).

If your container is bound to TileEntity (has reference when opened) you don't need to send x/y/z in packet.

That is just another way to get TE on server (not really popular), but 1st one (x/y/z) is better.

1.7.10 is no longer supported by forge, you are on your own.

Posted

Take a look at GuiEditSign. They store the TileEntity as a variable, and send the position in the packet.

 

That's a pretty common way to do it. If you want to know how everything is working, just navigate through the various functions and objects. (Ctrl + click a bit of code to view where it's from and all that)

Posted

well solved but not as clean as i wanted

 

well  idont wana make an

 

Mercenary.network.sendToServer(new mensajeMercenarioalServidor("TE"+posX+","+posY+","+posZ));

 

and dont get how worklks the thing whith GuiEditSign sooo

 

i use the package to triger a metod to check where the player is looking and if it its the block of the especific kind do stuff

for the way mi elevator works there is little risk to chech a wrong block but

 

there is another little issue

 

i wanna make the gui to close before the elevator begins to move

but i dont see something like

 

this.close();  gui.close(); // or kill

there is way to close the gui from inside code ??

 

 

 

 

 

 

Posted

As BusyBeever said, it's a bad idea (not buggy, just bad practice) to send a compounded string as your packet.

Send 3 integers in your packet. It's less payload, I believe, than to send a string.

 

As far as closing the interface, that is also in the GuiEditSign class

this.mc.displayGuiScreen((GuiScreen)null);

Posted

i wass thinking in made another message class but this one sending binary data rather than string, ihave  the one you get whith the tutorials

bu t not go too deep whith it

 

the trick of make the this.mc.displayGuiScreen((GuiScreen)null); works nice afthe the actionPerformed(GuiButton guibutton) to close the gui

so thanks

 

whith this i set the threath a solved

 

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • Do you use features of inventory profiles next (ipnext) or is there a change without it?
    • Remove rubidium - you are already using embeddium, which is a fork of rubidium
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.