[1.8.9]ITickable not ticking

[captaincleric]

Pretty much as the topic describes, I've got an ITickable object that isn't ticking, and I'm not sure why. (It used to work)

 

Here's the class:

package com.nosrick.masterofmagic.trackers;

import java.io.File;
import java.io.FileNotFoundException;
import java.io.FileReader;
import java.io.FileWriter;
import java.io.FilenameFilter;
import java.io.IOException;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.UUID;

import com.nosrick.masterofmagic.MoMMod;
import com.nosrick.masterofmagic.items.wands.ItemBaseWand;
import com.nosrick.masterofmagic.packets.PlayerManaChangePacket;
import com.nosrick.masterofmagic.utils.PlayerUtils;

import net.minecraft.client.Minecraft;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.entity.player.EntityPlayerMP;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.util.ITickable;
import net.minecraft.world.World;
import net.minecraft.world.WorldSavedData;
import net.minecraft.world.storage.MapStorage;

public final class PlayerManaTracker extends WorldSavedData implements ITickable
{
protected static final String s_Key = "MoMCraftManaTracker";

protected Map m_ManaTracker;
protected Map m_ManaTickers;

protected static final int STARTING_MANA = 100;
protected static final int MAX_MANA_TICKER = 600;

protected NBTTagCompound m_NBT;

public PlayerManaTracker() 
{
	super(s_Key);
	m_ManaTracker = new HashMap();
	m_ManaTickers = new HashMap();
}

public PlayerManaTracker(String mapName) 
{
	super(mapName);
	m_ManaTracker = new HashMap();
	m_ManaTickers = new HashMap();
}   

public void ModMana(EntityPlayer player, int value)
{
	if(m_ManaTracker == null)
	{
		m_ManaTracker = new HashMap();
	}

	if(m_ManaTickers == null)
	{
		m_ManaTickers = new HashMap();
	}

	if(m_ManaTracker.containsKey(player.getUniqueID()))
	{
		int mana = (Integer)m_ManaTracker.get(player.getUniqueID());

		ItemStack itemStack = PlayerUtils.FindWand(player);
		if(itemStack == null)
			return;

		ItemBaseWand wand = (ItemBaseWand)itemStack.getItem();
		mana = Math.min(wand.GetMaxMana(), mana + value);

		m_ManaTracker.put(player.getUniqueID(), mana);
	}
	else
	{
		m_ManaTracker.put(player.getUniqueID(), STARTING_MANA + value);
	}
	MoMMod.s_NetworkChannel.sendTo(new PlayerManaChangePacket(m_ManaTracker.get(player.getUniqueID()).toString()), (EntityPlayerMP) player);
	markDirty();
}

public void SetMana(EntityPlayer player, int value)
{
	if(m_ManaTracker.containsKey(player.getUniqueID()))
	{
		m_ManaTracker.put(player.getUniqueID(), value);
	}
	else
	{
		m_ManaTracker.put(player.getUniqueID(), STARTING_MANA);
	}
	MoMMod.s_NetworkChannel.sendTo(new PlayerManaChangePacket(Integer.toString(value)), (EntityPlayerMP) player);
	markDirty();
}

public int GetMana(UUID uuid)
{
	if(m_ManaTracker.containsKey(uuid))
	{
		return (Integer)m_ManaTracker.get(uuid);
	}
	else
	{
		m_ManaTracker.put(uuid, STARTING_MANA);
		return STARTING_MANA;
	}
}

@Override
public void update() 
{
	List<EntityPlayer> players = Minecraft.getMinecraft().theWorld.playerEntities;

	for(int i = 0; i < players.size(); i++)
	{
		EntityPlayer player = players.get(i);
		UUID uuid = player.getUniqueID();

		if(m_ManaTickers.containsKey(uuid))
		{
			int ticker = (Integer)m_ManaTickers.get(uuid);
			ticker -= 1;

			if(ticker <= 0)
			{
				ItemStack wandStack = PlayerUtils.FindWand(player);
				if(wandStack == null)
					return;

				ItemBaseWand wand = (ItemBaseWand)wandStack.getItem();

				if(!m_ManaTracker.containsKey(uuid))
				{
					m_ManaTracker.put(uuid, STARTING_MANA);
				}

				int mana = (Integer)m_ManaTracker.get(uuid);
				if(mana < wand.GetMaxMana())
				{
					m_ManaTickers.put(uuid, MAX_MANA_TICKER);
					ModMana(player, 1);
				}
			}
			else
			{
				m_ManaTickers.put(uuid, ticker);
			}
		}
		else
		{
			m_ManaTickers.put(uuid, MAX_MANA_TICKER);
		}
	}
}

@Override
public void readFromNBT(NBTTagCompound nbt)
{
	String allPlayersMana = nbt.getString("manaTracker");
	String[] playersAndMana = allPlayersMana.split(",");
	for(int i = 0; i < playersAndMana.length; i++)
	{
		String[] split = playersAndMana[i].split(":");

		UUID playerID;
		int mana;
		playerID = UUID.fromString(split[0].trim());
		mana = Integer.parseInt(split[1].trim());
		m_ManaTracker.put(playerID, mana);			
	}
}

@Override
public void writeToNBT(NBTTagCompound nbt) 
{
	String allPlayersMana = "";
	Object[] players;
	Object[] mana;

	players = m_ManaTracker.keySet().toArray();
	mana = m_ManaTracker.values().toArray();
	for(int i = 0; i < m_ManaTracker.size(); i++)
	{
		allPlayersMana += players[i].toString();
		allPlayersMana += ":" + mana[i].toString() + ",";
	}
	allPlayersMana = (String)allPlayersMana.subSequence(0, allPlayersMana.length() - 1);

	nbt.setString("manaTracker", allPlayersMana);
}

public static PlayerManaTracker Get(World world) 
{
	PlayerManaTracker data = (PlayerManaTracker)world.loadItemData(PlayerManaTracker.class, s_Key);
	if (data == null) 
	{
		data = new PlayerManaTracker();
		world.setItemData(s_Key, data);
	}
	return data;
}
}

 

Unfortunately, for some reason, update isn't being called at all.

[BusyBeever]

ITickable doesnt work for WorldSavedData. I think it only works for TileEntities

[BusyBeever]

From reading your code it looks like you are triing to give your player mana. You should do that using the new capability system, not worldsaved data https://mcforge.readthedocs.org/en/latest/datastorage/capabilities/

(btw how to make clickable links?)

[Choonster]

ITickable

s have to be registered for Minecraft to tick them. This is done automatically for

TileEntities

, but you can register other tickables using

MinecraftServer#registerTickable

.

 

(btw how to make clickable links?)

 

[nobbc]Like this[/nobbc]

[captaincleric]

ITickable

s have to be registered for Minecraft to tick them. This is done automatically for

TileEntities

, but you can register other tickables using

MinecraftServer#registerTickable

.

I tried this, but it doesn't seem to be working. No errors or anything, just doesn't bother calling the update() function.

 

From reading your code it looks like you are triing to give your player mana. You should do that using the new capability system, not worldsaved data https://mcforge.readthedocs.org/en/latest/datastorage/capabilities/

(btw how to make clickable links?)

Thanks for pointing this out; I've never heard of it before, so I'll give it a shot. Will report back with progress.

[Choonster]

ITickable

s have to be registered for Minecraft to tick them. This is done automatically for

TileEntities

, but you can register other tickables using

MinecraftServer#registerTickable

.

I tried this, but it doesn't seem to be working. No errors or anything, just doesn't bother calling the update() function.

 

If you set a breakpoint, is

MinecraftServer#registerTickable

definitely being called? Are you sure your

update

method isn't being called?

[captaincleric]

If you set a breakpoint, is

MinecraftServer#registerTickable

definitely being called? Are you sure your

update

method isn't being called?

It's not, but then I'm not sure I'm trying to call it in the right place. My ServerProxy.Init() method is trying calling it, but that method never gets called, either. Is that correct?

And I put a breakpoint on the update() method; it never, ever gets hit.

[captaincleric]

(Sorry for the double post, but I've been messing around a bit.)

So I've got it calling, but now it tells me there's NoSuchMethod.

Here's the offending line: (Called in an event hook's OnWorldLoad() function)

MinecraftServer.getServer().registerTickable(PlayerManaTracker.Get(event.world));

 

Now, doing MinecraftServer.registerTickable() tells me I can't use a non-static function from a static instance.

[Choonster]

I'm not sure if it's a widely-used convention, but I use

ClassName.memberName

to denote a static method/field and

ClassName#memberName

to denote an instance method/field.

 

In this case,

registerTickable

is an instance method so it needs to be called on an instance of

MinecraftServer

(returned from the

MinecraftServer.getServer

method). You already seem to be doing this, though.

 

Could you be more specific about which method the

NoSuchMethodError

is being thrown for?

[captaincleric]

Could you be more specific about which method the

NoSuchMethodError

is being thrown for?

Ah, sorry, it's the registerTickable() method that's throwing it. I tried rebuilding all my forge and gradle stuff, as well as a brand new install, but it still throws that error. I'm using Forge 1764, I believe.

 

EDIT: I tried it with a fresh install of 1722, as well. No dice. Still get the same error.

[Choonster]

Could you be more specific about which method the

NoSuchMethodError

is being thrown for?

Ah, sorry, it's the registerTickable() method that's throwing it. I tried rebuilding all my forge and gradle stuff, as well as a brand new install, but it still throws that error. I'm using Forge 1764, I believe.

 

EDIT: I tried it with a fresh install of 1722, as well. No dice. Still get the same error.

 

The method certainly exists in my installs of 1764 and 1763. Can you see it in the

MinecraftServer

class in your IDE?

 

Are you running your mod in your IDE or building it and running it in a normal client?

 

Upload the FML log (logs/fml-client-latest.log) to Gist and link it here.

[captaincleric]

Yup, I can see it in the IDE. Also, I've tried running it in both IDE and regular Minecraft. Same thing happens in both.

 

Here's the Gist:

 

https://gist.github.com/anonymous/a57d258ae129a993f593

 

[UberAffe]

net.minecraft.server.MinecraftServer.registerTickable(Lnet/minecraft/util/ITickable;)

 

that sounds like it is actually your playermana.get is the one having problems.

[captaincleric]

net.minecraft.server.MinecraftServer.registerTickable(Lnet/minecraft/util/ITickable;)

 

that sounds like it is actually your playermana.get is the one having problems.

Just tried it with a blank ITickable implementation: same error.

[UberAffe]

Can you post your CommonProxy imports and init()

[captaincleric]

Here we go:

 

package com.nosrick.masterofmagic;

import com.nosrick.masterofmagic.blocks.BlockHandler;
import com.nosrick.masterofmagic.enchantments.EnchantmentHandler;
import com.nosrick.masterofmagic.entities.EntityGuardianSpirit;
import com.nosrick.masterofmagic.items.ItemHandler;
import com.nosrick.masterofmagic.tileentities.TileEntityHandler;
import com.nosrick.masterofmagic.trackers.PlayerManaTracker;

import net.minecraft.init.Blocks;
import net.minecraft.server.MinecraftServer;
import net.minecraftforge.fml.common.Mod.EventHandler;
import net.minecraftforge.fml.common.event.FMLInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPostInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPreInitializationEvent;
import net.minecraftforge.fml.common.registry.EntityRegistry;

public class CommonProxy 
{    
@EventHandler
    public void preInit(FMLPreInitializationEvent event)
    {
	ItemHandler.Initialise();
	EnchantmentHandler.PreInitialise();
	BlockHandler.PreInitialise();
	TileEntityHandler.Initialise();
    }
    
    @EventHandler
    public void init(FMLInitializationEvent event)
    {
    	EnchantmentHandler.Initialise();
    	EntityRegistry.registerModEntity(EntityGuardianSpirit.class, "guardian_spirit", EntityRegistry.findGlobalUniqueEntityId(), 
    			MoMMod.instance, 16, 2, true);
    	//MinecraftServer.getServer().registerTickable(new PlayerManaTracker()); FOR TESTING PURPOSES, USUALLY USE PlayerManaTracker.Get()
    }
    
    @EventHandler
    public void postInit(FMLPostInitializationEvent event)
    {
    }
}

 

[GotoLink]

Are you trying to call it on client side ?

You shouldn't.

Also fix this:

@Override
public void update()
{
List<EntityPlayer> players = Minecraft.getMinecraft().theWorld.playerEntities;

[captaincleric]

Are you trying to call it on client side ?

You shouldn't.

Also fix this:

@Override
public void update()
{
List<EntityPlayer> players = Minecraft.getMinecraft().theWorld.playerEntities;

 

Oh dear. That's embarrassing. That was from my first day of Minecraft modding and I haven't updated it since. Sorry about that!

And no, I'm not calling it client side, but I am trying to fetch players the client side way, stupidly. I won't make that mistake again.

[GotoLink]

Simply make sure you are only MinecraftServer#registerTickables on server side.

 

Besides, you have @EventHandler annotations in your proxy class. They should be restricted to your @Mod class.

And please don't use

EntityRegistry.findGlobalUniqueEntityId()

You do not need a global entity id.

 

 

[captaincleric]

Simply make sure you are only MinecraftServer#registerTickables on server side.

 

Besides, you have @EventHandler annotations in your proxy class. They should be restricted to your @Mod class.

And please don't use

EntityRegistry.findGlobalUniqueEntityId()

You do not need a global entity id.

 

I've done all of these, now. Thanks for the tips!

[captaincleric]

Guys, guys, what the hell are you doing?

 

WorldSavedData is not the right tool for this. Stop using it!

Use Capabilities, like BusyBeever already pointed out, or IEEP (deprecated in favor of capabilities).

How would I go about ticking the player's mana so that it slowly restores using capabilities?

[captaincleric]

Subscribe to PlayerTickEvent (make sure to check event.phase), get the capability and call some method on it.

I'll give it a shot, thank you. Will report back with progress tomorrow.