[1.8] Custom drop from vanilla block not working

[Daeruin]

I just started a new mod, and I'm trying to get my new item to drop from a vanilla block. It's nothing original (straw dropping from tall grass). It was just supposed to be something easy. But I can't for the life of me get it to work. I don't get any errors, but the item never drops.

 

public class ModDrops {

@SubscribeEvent
public void onDrop(BlockEvent.HarvestDropsEvent event) {
	if (event.state.getBlock() == Blocks.tallgrass) {
		event.drops.clear();
		event.dropChance = 1.0f;
		event.drops.add(new ItemStack(ModItems.ItemStraw, 1));
	}
}

}

 

public class CommonProxy {

public void preInit(FMLPreInitializationEvent e) {
	ModItems.createItems();
}

public void init(FMLInitializationEvent e) {
}

public void postInit(FMLPostInitializationEvent e) {
	MinecraftForge.EVENT_BUS.register(new ModDrops());
}

}

[Choonster]

Put breakpoints in

ModDrops#onDrop

and

CommonProxy#postInit

and run Minecraft in debug mode. Are the breakpoints ever hit?

[Daeruin]

The breakpoint on CommonProxy#postInit is hit, but the one on ModDrops#onDrop is not. I had already added System.out.println in a few places with the same results--postInit occurs but ModDrops never seems to.

[Ernio]

Move registration to preInit.

[Daeruin]

Move registration to preInit.

I tried moving it to init and preInit. No change.

[Daeruin]

Here you go.

 

Main:

 

@Mod(modid = Main.MODID, name = Main.MODNAME, version = Main.VERSION)

public class Main {

public static final String MODID = "primalcraft";
public static final String MODNAME = "PrimalCraft";
public static final String VERSION = "v0.1-mc1.8.9";

@Instance("primalcraft")
public static Main instance = new Main();

@SidedProxy(clientSide="com.daeruin.primalcraft.ClientProxy", serverSide="com.daeruin.primalcraft.ServerProxy")
public static CommonProxy proxy;

@EventHandler
public void preInit(FMLPreInitializationEvent e) {
	proxy.preInit(e);
}

@EventHandler
public void init(FMLInitializationEvent e) {
	proxy.init(e);
}

@EventHandler
public void postInit(FMLPostInitializationEvent e) {
	proxy.postInit(e);
}

}

 

 

CommonProxy:

 

public class CommonProxy {

public void preInit(FMLPreInitializationEvent e) {
	ModItems.createItems();
}

public void init(FMLInitializationEvent e) {
}

public void postInit(FMLPostInitializationEvent e) {
	MinecraftForge.EVENT_BUS.register(new ModDrops());
}

}

 

 

ClientProxy:

 

public class ClientProxy extends CommonProxy {

@Override
public void preInit(FMLPreInitializationEvent e) {
	super.preInit(e);
}

@Override
public void init(FMLInitializationEvent e) {
	super.init(e);		
	ItemRenderRegister.registerItemRenderer();
}

@Override
public void postInit(FMLPostInitializationEvent e) {
	super.postInit(e);
}

}

 

 

ServerProxy:

 

public class ServerProxy extends CommonProxy {

@Override
public void preInit(FMLPreInitializationEvent e) {
	super.preInit(e);
}

@Override
public void init(FMLInitializationEvent e) {
	super.init(e);
}

@Override
public void postInit(FMLPostInitializationEvent e) {
	super.postInit(e);
}

}

 

[Ernio]

1. Don't do this (initialize). Forge does it for you.

public static Main instance = new Main();

 

2. Everything else seems fine. You say that your ModDrops is initialized? And event inside never called? One explanation could be that your IDE is not recognising changes in .java and event method is simply not there in .class file. Idk really, but I know that it's possilbe. Rebuild WS and maybe even reinstall.

[Daeruin]

It's working now! Thanks so much for your feedback.