Jump to content

[1.8] Custom drop from vanilla block not working


Daeruin

Recommended Posts

I just started a new mod, and I'm trying to get my new item to drop from a vanilla block. It's nothing original (straw dropping from tall grass). It was just supposed to be something easy. But I can't for the life of me get it to work. I don't get any errors, but the item never drops.

 

public class ModDrops {

@SubscribeEvent
public void onDrop(BlockEvent.HarvestDropsEvent event) {
	if (event.state.getBlock() == Blocks.tallgrass) {
		event.drops.clear();
		event.dropChance = 1.0f;
		event.drops.add(new ItemStack(ModItems.ItemStraw, 1));
	}
}

}

 

public class CommonProxy {

public void preInit(FMLPreInitializationEvent e) {
	ModItems.createItems();
}

public void init(FMLInitializationEvent e) {
}

public void postInit(FMLPostInitializationEvent e) {
	MinecraftForge.EVENT_BUS.register(new ModDrops());
}

}

Link to comment
Share on other sites

Put breakpoints in

ModDrops#onDrop

and

CommonProxy#postInit

and run Minecraft in debug mode. Are the breakpoints ever hit?

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Link to comment
Share on other sites

Here you go.

 

Main:

 

@Mod(modid = Main.MODID, name = Main.MODNAME, version = Main.VERSION)

public class Main {

public static final String MODID = "primalcraft";
public static final String MODNAME = "PrimalCraft";
public static final String VERSION = "v0.1-mc1.8.9";

@Instance("primalcraft")
public static Main instance = new Main();

@SidedProxy(clientSide="com.daeruin.primalcraft.ClientProxy", serverSide="com.daeruin.primalcraft.ServerProxy")
public static CommonProxy proxy;

@EventHandler
public void preInit(FMLPreInitializationEvent e) {
	proxy.preInit(e);
}

@EventHandler
public void init(FMLInitializationEvent e) {
	proxy.init(e);
}

@EventHandler
public void postInit(FMLPostInitializationEvent e) {
	proxy.postInit(e);
}

}

 

 

CommonProxy:

 

public class CommonProxy {

public void preInit(FMLPreInitializationEvent e) {
	ModItems.createItems();
}

public void init(FMLInitializationEvent e) {
}

public void postInit(FMLPostInitializationEvent e) {
	MinecraftForge.EVENT_BUS.register(new ModDrops());
}

}

 

 

ClientProxy:

 

public class ClientProxy extends CommonProxy {

@Override
public void preInit(FMLPreInitializationEvent e) {
	super.preInit(e);
}

@Override
public void init(FMLInitializationEvent e) {
	super.init(e);		
	ItemRenderRegister.registerItemRenderer();
}

@Override
public void postInit(FMLPostInitializationEvent e) {
	super.postInit(e);
}

}

 

 

ServerProxy:

 

public class ServerProxy extends CommonProxy {

@Override
public void preInit(FMLPreInitializationEvent e) {
	super.preInit(e);
}

@Override
public void init(FMLInitializationEvent e) {
	super.init(e);
}

@Override
public void postInit(FMLPostInitializationEvent e) {
	super.postInit(e);
}

}

 

Link to comment
Share on other sites

1. Don't do this (initialize). Forge does it for you.

public static Main instance = new Main();

 

2. Everything else seems fine. You say that your ModDrops is initialized? And event inside never called? One explanation could be that your IDE is not recognising changes in .java and event method is simply not there in .class file. Idk really, but I know that it's possilbe. Rebuild WS and maybe even reinstall.

1.7.10 is no longer supported by forge, you are on your own.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.