[1.7.10] Toggle fly function with Keybinding

[itsPauV]

Hey guys,

I wanted to make a forge mod, so when you press a key, you can start flying. Start flying works great, but i can't disable flying . Here's my code:

 

<code>

import cpw.mods.fml.common.eventhandler.SubscribeEvent;

import cpw.mods.fml.common.gameevent.InputEvent.KeyInputEvent;

import me.extendedcrafting.com.ExtendedCrafting;

import net.minecraft.client.Minecraft;

import net.minecraft.entity.player.EntityPlayer;

import net.minecraft.potion.Potion;

import net.minecraft.potion.PotionEffect;

import net.minecraft.util.ChatComponentText;

 

public class KeyHandler {

public static boolean onToggle = true;

 

public static boolean notToggled = false;

 

@SubscribeEvent

 

public void onKeyPressed(KeyInputEvent event){

 

EntityPlayer player = Minecraft.getMinecraft().thePlayer;

 

if(ExtendedCrafting.keybinding.isPressed()  && onToggle == true && notToggled == false){

notToggled = true;

onToggle = false;

player.addChatComponentMessage(new ChatComponentText("Fly enabled"));

player.capabilities.allowFlying = true;

player.capabilities.setFlySpeed(0.1F);

//player.addPotionEffect(new PotionEffect(Potion.resistance.getId(), 1900, 10));

}else if (ExtendedCrafting.keybinding.isPressed() && notToggled == true && onToggle == false){

onToggle = true;

player.addChatComponentMessage(new ChatComponentText("Fly disabled"));

player.capabilities.allowFlying = false;

 

}

}

}

 

</code>

 

Thank you for helping.

[captaincleric]

Does it ever print out the "Fly disabled" message?

[itsPauV]

No just the 'fly enabled' message. And when I press the key again, nothing happens and I still can fly

[captaincleric]

Try putting a breakpoint on the else if statement, and seeing what the values are when it gets there. Something has to be set wrongly.

I'm guessing it might be that isPressed() function, because the other two conditions look like they're set just fine in the if statement.

[coolAlias]

Are you sure your flight is not getting disabled? Try also setting player.capabalitites.isFlying to false - that will drop you out of the sky if you are currently flying.

 

Also, KeyInputEvent fires for every key that is pressed OR released; Keyboard#getEventKey() will give you the key code of the key that triggered the event, and Keyboard#getEventKeyState() will tell you if the key was pressed (true) or released (false). So:

if (!Keyboard#getEventKeyState()) {
  return; // don't care about key being released (you might, but it seems like you won't need to)
}
if (Keyboard#getEventKey() == ExtendedCrafting.keybinding.getKeyCode()) {
  // your key binding was pressed

 

In this case, you're probably better off using one of the player tick events to check, rather than KeyInputEvent, and you probably want to send a packet to the server and let it decide if the player can fly or not. If you do go with a tick event, you generally want to use #getKeyIsPressed() (or #isKeyDown(), whatever it's called now), not #isPressed().

 

Java tip: boolean values do not need an ' == true' or ' == false' comparison, as they are already either only true or false:

if (onToggle && !notToggled) {

// is the same as but syntactically better than:
if (onToggle == true && notToggled == false) {

[itsPauV]

I did it like CoolAlias said, now it works, but when I press the key, it enables flying but instantly disables flying. I tried to let the code sleep, but then obviously the complete game freezes, so how do I make the code wait for a short amount of time?

 

Now that's my code:

 

public class KeyHandler2 {

 

public static boolean onToggle = true;

 

public static boolean notToggled = false;

 

@SubscribeEvent

 

public void onKeyPressed(KeyInputEvent event){

EntityPlayer player = Minecraft.getMinecraft().thePlayer;

 

if(Keyboard.getEventKey() == ExtendedCrafting.keybindingfly.getKeyCode() && onToggle && !notToggled){

notToggled = true;

onToggle = false;

player.addChatComponentMessage(new ChatComponentText("Fly enabled"));

player.capabilities.allowFlying = true;

player.capabilities.setFlySpeed(0.1F);

 

}else if (Keyboard.getEventKey() == ExtendedCrafting.keybindingfly.getKeyCode() && !onToggle && notToggled){

notToggled = false;

onToggle = true;

player.addChatComponentMessage(new ChatComponentText("Fly disabled"));

player.capabilities.allowFlying = false;

 

}

}

}

[itsPauV]

Same problem with your code, after enabling the code, it instantly disables flying. But your solution looks so cleaner than my one

[itsPauV]

Hmm... before, when I pressed the button it showed in the Chat:"Flying Enabled" and instantly after that "Flying Disabled", but now it doesn't do anything, here's my code:

My KeyHandler:

 

public class KeyHandler3 {

 

boolean active = false;

 

public void onTick(){

EntityPlayer player = Minecraft.getMinecraft().thePlayer;

 

if(ExtendedCrafting.keybindingfly.isPressed()){

if(active){

active = false;

player.addChatComponentMessage(new ChatComponentText("Fly disabled"));

player.capabilities.allowFlying = false;

player.capabilities.setFlySpeed(0.1F);

 

}else {

active = true;

player.addChatComponentMessage(new ChatComponentText("Fly enabled"));

player.capabilities.allowFlying = true;

}

}

}

}

 

And my keybind registration:

public class ExtendedCrafting {

 

@Instance

public static ExtendedCrafting instance;

 

//Keybindings

public static KeyBinding keybindingfly = new KeyBinding("keyBinding.Fly", Keyboard.KEY_F, "OwnMod");

 

@EventHandler

public void preInit(FMLPreInitializationEvent event){

}

 

@EventHandler

public void Init(FMLInitializationEvent event){

ClientRegistry.registerKeyBinding(keybindingfly);

FMLCommonHandler.instance().bus().register(new KeyHandler3());

}

 

 

 

[coolAlias]

He gave you pseudo-code, not copy/paste ready code. By 'onTick' he meant that you should create an event handler for ClientTickEvent, which is the one I was trying to tell you about earlier but I was thinking it was tied to the PlayerEvents, which it's not (sucks not having an IDE handy...).

 

So:

@SubscribeEvent
public void onTick(ClientTickEvent event) {
  // rest of code here
}

[itsPauV]

Perfect!! Thank you all for your help It works now.