Search the Forums BEFORE making a new post.

[1.8.9 -> 1.9] Changes in event order?

Posted April 1, 20169 yr

We are talking about:

* PlayerEvent.StartTracking

* EntityJoinWorldEvent

Some part of my mod are pretty old (but well written), and they are working for months now.

About month (I think) ago I upped to 1.8.9 and everything also seemed (I wasn't coding much, maybe I missed bug there) fine.

Anyway, I soon decided to go to 1.9. Currently I am on latest (while ago 1812 -> 1816 now) build and I am getting unexpected errors (as in - they are concerning my very old code).

Okay, so problem:

Till now system worked like this:

1. Construction attaches props.

2. Maps are constructed and filled with "holders" for attributes.

3. EntityJoinWorldEvent calls props.maps.load() - this is done because entity can be constructed, but not be in world, so I decided to load attributes to map after they join. Also - world (and coords/weather/etc) affects loaded attributes so that is pretty much design requirement.

4. PlayerEvent.StartTracking catches every entity player starts tracking, iterates over all holders in entity's props.maps and send them to client.

Till now - this all happened smooth. As of (I think) 1.9 update it seems that expected order of events is not longer kept.

BIG NOTE! While tracking is called on server only - joinWorld is called on both. I just need to say - this and anything with threads is not my problem, we are right now talking about server only side.

In past when player logged in, all entities near his pos were:

constructed -> loaded -> tracked

Note: server (even without players) sometimes constructs entities without making them join world.

As of now: As expected those things happen in this order but only after 10-20 entities load.

[05:01:37] common.entity.player.ExtendedPlayer:deserializeNBT:183]: LOADING: {C:[]}
[05:01:37] server.event.ServerForgeEvents:onEntityJoinWorld:116]: EntityPlayerMP['Ernio'/236, l='world', x=-84,50, y=71,00, z=241,50] JOIN
[05:01:37] server.event.ServerForgeEvents:onPlayerStartTracking:71]: EntitySheep['Sheep'/35, l='world', x=-146,50, y=69,00, z=259,50] TRACK
[05:01:37] common.entity.EntityStats:synchronizeStatsTo:77]: EntitySheep['Sheep'/35, l='world', x=-146,50, y=69,00, z=259,50]  null
[05:01:37] server.event.ServerForgeEvents:onPlayerStartTracking:71]: EntitySheep['Sheep'/37, l='world', x=-158,49, y=67,00, z=272,70] TRACK
[05:01:37] common.entity.EntityStats:synchronizeStatsTo:77]: EntitySheep['Sheep'/37, l='world', x=-158,49, y=67,00, z=272,70]  null
[05:01:37] server.event.ServerForgeEvents:onPlayerStartTracking:71]: EntitySheep['Sheep'/42, l='world', x=-133,76, y=73,00, z=245,57] TRACK
[05:01:37] common.entity.EntityStats:synchronizeStatsTo:77]: EntitySheep['Sheep'/42, l='world', x=-133,76, y=73,00, z=245,57]  null
[05:01:37] server.event.ServerForgeEvents:onPlayerStartTracking:71]: EntitySheep['Sheep'/36, l='world', x=-143,80, y=74,00, z=264,45] TRACK
[05:01:37] common.entity.EntityStats:synchronizeStatsTo:77]: EntitySheep['Sheep'/36, l='world', x=-143,80, y=74,00, z=264,45]  null
[05:01:37] server.event.ServerForgeEvents:onPlayerStartTracking:71]: EntityCow['Cow'/44, l='world', x=-113,48, y=84,00, z=182,78] TRACK
[05:01:37] common.entity.EntityStats:synchronizeStatsTo:77]: EntityCow['Cow'/44, l='world', x=-113,48, y=84,00, z=182,78]  null
[05:01:37] server.event.ServerForgeEvents:onPlayerStartTracking:71]: EntityCow['Cow'/45, l='world', x=-115,46, y=76,00, z=205,75] TRACK
[05:01:37] common.entity.EntityStats:synchronizeStatsTo:77]: EntityCow['Cow'/45, l='world', x=-115,46, y=76,00, z=205,75]  null
[05:01:37] server.event.ServerForgeEvents:onPlayerStartTracking:71]: EntityCow['Cow'/46, l='world', x=-120,18, y=85,00, z=194,48] TRACK
[05:01:37] common.entity.EntityStats:synchronizeStatsTo:77]: EntityCow['Cow'/46, l='world', x=-120,18, y=85,00, z=194,48]  null
[05:01:37] server.event.ServerForgeEvents:onPlayerStartTracking:71]: EntitySheep['Sheep'/65, l='world', x=-64,80, y=70,00, z=246,40] TRACK
[05:01:37] common.entity.EntityStats:synchronizeStatsTo:77]: EntitySheep['Sheep'/65, l='world', x=-64,80, y=70,00, z=246,40]  null
[05:01:37] server.event.ServerForgeEvents:onPlayerStartTracking:71]: EntitySheep['Sheep'/66, l='world', x=-65,81, y=70,00, z=249,17] TRACK
[05:01:37] common.entity.EntityStats:synchronizeStatsTo:77]: EntitySheep['Sheep'/66, l='world', x=-65,81, y=70,00, z=249,17]  null
[05:01:37] server.event.ServerForgeEvents:onPlayerStartTracking:71]: EntitySheep['Sheep'/67, l='world', x=-69,50, y=70,00, z=240,50] TRACK
[05:01:37] common.entity.EntityStats:synchronizeStatsTo:77]: EntitySheep['Sheep'/67, l='world', x=-69,50, y=70,00, z=240,50]  null
[05:01:37] server.event.ServerForgeEvents:onPlayerStartTracking:71]: EntitySheep['Sheep'/68, l='world', x=-64,27, y=70,00, z=264,49] TRACK
[05:01:37] common.entity.EntityStats:synchronizeStatsTo:77]: EntitySheep['Sheep'/68, l='world', x=-64,27, y=70,00, z=264,49]  null
[05:01:37] server.event.ServerForgeEvents:onPlayerStartTracking:71]: EntitySheep['Sheep'/75, l='world', x=-63,76, y=70,00, z=232,81] TRACK
[05:01:37] common.entity.EntityStats:synchronizeStatsTo:77]: EntitySheep['Sheep'/75, l='world', x=-63,76, y=70,00, z=232,81]  null
[05:01:37] server.event.ServerForgeEvents:onPlayerStartTracking:71]: EntitySheep['Sheep'/76, l='world', x=-52,50, y=68,00, z=270,50] TRACK
[05:01:37] common.entity.EntityStats:synchronizeStatsTo:77]: EntitySheep['Sheep'/76, l='world', x=-52,50, y=68,00, z=270,50]  null
[05:01:37] server.event.ServerForgeEvents:onPlayerStartTracking:71]: EntitySheep['Sheep'/77, l='world', x=-55,50, y=70,00, z=266,50] TRACK
[05:01:37] common.entity.EntityStats:synchronizeStatsTo:77]: EntitySheep['Sheep'/77, l='world', x=-55,50, y=70,00, z=266,50]  null
[05:01:37] server.event.ServerForgeEvents:onPlayerStartTracking:71]: EntityItem['item.tile.mushroom'/74, l='world', x=-48,75, y=32,00, z=222,82] TRACK // item are not synced, only living ents are
[05:01:37] server.event.ServerForgeEvents:onPlayerStartTracking:71]: EntitySheep['Sheep'/84, l='world', x=-41,95, y=69,00, z=265,52] TRACK
[05:01:37] common.entity.EntityStats:synchronizeStatsTo:77]: EntitySheep['Sheep'/84, l='world', x=-41,95, y=69,00, z=265,52]  null
[05:01:37] server.event.ServerForgeEvents:onPlayerStartTracking:71]: EntityItem['item.tile.mushroom'/83, l='world', x=-44,97, y=34,00, z=223,78] TRACK
[05:01:37] server.event.ServerForgeEvents:onPlayerStartTracking:71]: EntityCow['Cow'/97, l='world', x=-32,55, y=66,75, z=218,51] TRACK
[05:01:37] common.entity.EntityStats:synchronizeStatsTo:77]: EntityCow['Cow'/97, l='world', x=-32,55, y=66,75, z=218,51]  null
[05:01:37] server.event.ServerForgeEvents:onPlayerStartTracking:71]: EntityCow['Cow'/64, l='world', x=-67,04, y=66,00, z=180,35] TRACK
[05:01:37] common.entity.EntityStats:synchronizeStatsTo:77]: EntityCow['Cow'/64, l='world', x=-67,04, y=66,00, z=180,35]  null
[05:01:37] server.event.ServerForgeEvents:onPlayerStartTracking:71]: EntityCow['Cow'/57, l='world', x=-110,55, y=81,00, z=182,58] TRACK
[05:01:37] common.entity.EntityStats:synchronizeStatsTo:77]: EntityCow['Cow'/57, l='world', x=-110,55, y=81,00, z=182,58]  null
[05:01:37] server.event.ServerForgeEvents:onPlayerStartTracking:71]: EntityCow['Cow'/72, l='world', x=-50,54, y=66,00, z=185,72] TRACK
[05:01:37] common.entity.EntityStats:synchronizeStatsTo:77]: EntityCow['Cow'/72, l='world', x=-50,54, y=66,00, z=185,72]  null
[05:01:37] server.event.ServerForgeEvents:onPlayerStartTracking:71]: EntityCow['Cow'/73, l='world', x=-54,51, y=64,00, z=176,23] TRACK
[05:01:37] common.entity.EntityStats:synchronizeStatsTo:77]: EntityCow['Cow'/73, l='world', x=-54,51, y=64,00, z=176,23]  null
[05:01:37] server.event.ServerForgeEvents:onPlayerStartTracking:71]: EntityCow['Cow'/98, l='world', x=-18,22, y=64,00, z=221,49] TRACK
[05:01:37] common.entity.EntityStats:synchronizeStatsTo:77]: EntityCow['Cow'/98, l='world', x=-18,22, y=64,00, z=221,49]  null
[05:01:37] server.event.ServerForgeEvents:onPlayerStartTracking:71]: EntityCow['Cow'/99, l='world', x=-19,60, y=64,00, z=215,53] TRACK
[05:01:37] common.entity.EntityStats:synchronizeStatsTo:77]: EntityCow['Cow'/99, l='world', x=-19,60, y=64,00, z=215,53]  null
[05:01:37] server.event.ServerForgeEvents:onPlayerStartTracking:71]: EntityCow['Cow'/96, l='world', x=-19,59, y=64,00, z=207,81] TRACK
[05:01:37] common.entity.EntityStats:synchronizeStatsTo:77]: EntityCow['Cow'/96, l='world', x=-19,59, y=64,00, z=207,81]  null
[05:01:37] server.event.ServerForgeEvents:onPlayerStartTracking:71]: EntityCow['Cow'/56, l='world', x=-110,50, y=80,00, z=164,20] TRACK
[05:01:37] common.entity.EntityStats:synchronizeStatsTo:77]: EntityCow['Cow'/56, l='world', x=-110,50, y=80,00, z=164,20]  null
[05:01:37] server.event.ServerForgeEvents:onPlayerStartTracking:71]: EntityCow['Cow'/71, l='world', x=-54,95, y=63,00, z=173,29] TRACK
[05:01:37] common.entity.EntityStats:synchronizeStatsTo:77]: EntityCow['Cow'/71, l='world', x=-54,95, y=63,00, z=173,29]  null
[05:01:37] server.event.ServerForgeEvents:onEntityJoinWorld:116]: EntityBat['Bat'/276, l='world', x=-39,50, y=54,00, z=241,50] JOIN // FINALLY 1st JOIN
[05:01:37] common.entity.BaseStats:load:195]: EntityBat['Bat'/276, l='world', x=-39,50, y=54,00, z=241,50] LOAD // and his LOAD (called from JOIN)
[05:01:37] server.event.ServerForgeEvents:onPlayerStartTracking:71]: EntityBat['Bat'/276, l='world', x=-39,50, y=54,00, z=241,50] TRACK // and his corresponding TRACK
[05:01:37] common.entity.EntityStats:synchronizeStatsTo:77]: EntityBat['Bat'/276, l='world', x=-39,50, y=54,00, z=241,50]  B10.0 // and STATS are detected
[05:01:37] server.event.ServerForgeEvents:onEntityJoinWorld:116]: EntitySkeleton['Skeleton'/286, l='world', x=-70,50, y=29,00, z=224,50] JOIN
[05:01:37] common.entity.BaseStats:load:195]: EntitySkeleton['Skeleton'/286, l='world', x=-70,50, y=29,00, z=224,50] LOAD
[05:01:37] server.event.ServerForgeEvents:onPlayerStartTracking:71]: EntitySkeleton['Skeleton'/286, l='world', x=-70,50, y=29,00, z=224,50] TRACK
[05:01:37] common.entity.EntityStats:synchronizeStatsTo:77]: EntitySkeleton['Skeleton'/286, l='world', x=-70,50, y=29,00, z=224,50]  B10.0
[05:01:37] server.event.ServerForgeEvents:onEntityJoinWorld:116]: EntityBat['Bat'/302, l='world', x=-74,50, y=33,00, z=273,50] JOIN
[05:01:37] common.entity.BaseStats:load:195]: EntityBat['Bat'/302, l='world', x=-74,50, y=33,00, z=273,50] LOAD
[05:01:37] server.event.ServerForgeEvents:onPlayerStartTracking:71]: EntityBat['Bat'/302, l='world', x=-74,50, y=33,00, z=273,50] TRACK
[05:01:37] common.entity.EntityStats:synchronizeStatsTo:77]: EntityBat['Bat'/302, l='world', x=-74,50, y=33,00, z=273,50]  B10.0
// AND SO ON

As you can se - we get:

TRACK -> null at 1st, but then everything is back to normal:

JOIN (LOAD) -> TRACK -> stats sent (this B10.0 thing).

Question: Could someone help me find what exacly changed in callbacks? Something must have!

Addition: Yeah I can make null check but that would mean that those 20 entities would not get synced on player join - that would be very bad for client display (in my case).

1.7.10 is no longer supported by forge, you are on your own.

Quote

April 1, 20169 yr

Author

Noone? :C I am lost here guys.

What amazes me is actually how entity can be started to be tracked if it never joined world.

Its either that:

* JoinWorld is not called for few entities (wtf?) and they are spawned without calling event.

* They are NOT actually spawned (and thats why JoinWorld is not called), but mistakenly put into EntityTracker's Player mapping where they are not supposed to be (since they are not in world).

I am starting to think someone messed up and this might be a bug.

When I get back in few h I will make cleaner test mod (tho my current tests are quite clean since I am just printing stuff from event call).

1.7.10 is no longer supported by forge, you are on your own.

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/37654-189-gt-19-changes-in-event-order/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

How to add my mob to another mod's biome in 1.20.1.

I'm on 1.20.1 and was wondering if there was a way to add a mob I am going to make to a other mod's biome (Regions Unexplored in this case). I am trying to figure this out before I start coding the mod. Could someone point me to a good guide on this? I saw some things about biome modifier's but all the resources are either to short, unhelpful or for a different version. Thanks in advance. (i am a beginner but i have java and modding knowledge so this isn't like a "i am new and don't know anything about coding" problem btw)

By ilov3gam3z · Posted 5 hours ago5 hr
incompatible fml modded server and tearing my hair out. Forge 1.16.5 - 36.2.9

Dealing with modded server issues can be a real headache been there! At least you can keep your look stress-free with a fresh low taper fade.

By AriaDawn · 5 hours ago5 hr
Help with file conversion

This is really helpful

By Brialeblanc · 10 hours ago10 hr
Cobblemon invalid player data

Hi everyone, I keep getting "invalid player data" when trying to log onto my friend's server. Log analysis says to remove Night Lights and ImmediatelyFast, but that doesn't work. Any insight is appreciated

Log: https://mclo.gs/uj6pMkd

By CobbleDN · Posted 17 hours ago17 hr
Bad pathfinding for big mobs (1.21.1)

I've struggled with this for way too long now, so I have decided to ask for some assistance here because there is almost no information about this online.

I made a hostile mob and I built it like this:
public static final Supplier<EntityType<Bunyip>> BUNYIP = ENTITY_TYPES.register("bunyip" , () -> EntityType.Builder. of(Bunyip::new, MobCategory.MONSTER).sized(3f, 2.5f).eyeHeight(1.75f).build("bunyip"));

However, I have discovered that a BoundingBox of 3 is too big for the vanilla pathfinding to work well. In fact, anything bigger than a block will not work well. This is especially noticeable when having it chase a player in a negative X and/or negative Z direction. The mob starts spinning, walking backwards, walking diagonally, etc.

I am using the Goal system:
protected void registerGoals() { super.registerGoals(); this.goalSelector.addGoal(1, new MeleeAttackGoal(this, 1.25, true)); this.targetSelector.addGoal(2, new NearestAttackableTargetGoal<>(this, Player.class, true, true)); }

This does not seem to be a me issue as the ravager, one of the biggest vanilla mobs, also struggles with proper pathfinding. I am a bit familiar with how Minecraft's pathfinding works, but not enough to make a pathfinding system from scratch (or at least not in a reasonable amount of time). Is there any way to fix this with some tweaks or will I have to make a custom pathfinding system?

By VictorEvers · Posted Yesterday at 08:42 PM1 day

VictorEvers

Sign In

[1.8.9 -> 1.9] Changes in event order?

Featured Replies

Join the conversation

Posts

How to add my mob to another mod's biome in 1.20.1.

incompatible fml modded server and tearing my hair out. Forge 1.16.5 - 36.2.9

Help with file conversion

Cobblemon invalid player data

Bad pathfinding for big mobs (1.21.1)

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)