Jump to content
Search the Forums BEFORE making a new post.
Currently supported: All versions

Setting light level doesn't work properly

MikeMacho

By MikeMacho
in Modder Support

 Share

Recommended Posts

MikeMacho Tree Puncher

MikeMacho

Posted
Posted

Hello everybody!

 

I have a problem setting the light level of a block. I'm trying to create a custom lamp. When I turn it on or off the lighting is changing, but not as it's supposed to. There seem to be 2 different types of lighting. One of those is directly affected by calling 

setLightLevel(float value)

(which currently is the only thing I do to change the lighting). The other one changes when I restart the game and sometimes in game, but I can't figure out what it's triggered by. For better understanding of what I'm talking about I have some screenshots:

How it's supposed to look when it's turned off:

twa8t7sd.png

 

And this is how it is not supposed to look when turned off but sometimes does:

 

5v8pwtl7.png

 

How it's supposed to look when turned on:

 

jo2us36m.png

 

And finally how it's not supposed to look when turned on but sometimes does:

 

hkk4nq53.png

 

Sorry for the long post but I think the screenshots help to make my point.

 

Thanks in advance for any help you can give me!

MikeMacho Tree Puncher

MikeMacho

Posted
  • Author
Posted

Thanks for your help.

I couldn't find a setState-Method (or any method to change the state) in the Block-class.

How would I trigger a state change if had set it up like you proposed?

Choonster Reality Controller

Choonster

Posted
Posted 
World#setBlockState

sets the block state at the specified position in the world.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

MikeMacho Tree Puncher

MikeMacho

Posted
  • Author
Posted

This works but it leads me to another problem. To call setBlockState I need the BlockPos-object for the block. I tried to save it into an attribute in the onBlockPlaced-Method of the Block-class but then the BlockPos-attribute is null after restarting the game.

So my question is: Is there some kind of livecycle-method in the Block-class that is called when the game starts and has the BlockPos as a parameter or is there another way to get the BlockPos-object of my block from inside the Block-class?

Choonster Reality Controller

Choonster

Posted
Posted 

Block

is a singleton, there is a single instance per block type shared between all blocks of that type. This means that you can't store per-position data in fields of your 

Block

(or the position itself).

 

Most methods of 

Block

include the 

BlockPos

of the block that's currently being affected/queried (or whatever it is that the particular method does).

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

jeffryfisher World Shaper

jeffryfisher

Posted
Posted

Would onBlockActivated suit your needs?

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

脳   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

脳   Your link has been automatically embedded.   Display as a link instead

脳   Your previous content has been restored.   Clear editor

脳   You cannot paste images directly. Upload or insert images from URL.

脳
 Share
Go to topic listing

Announcements



  • Recently Browsing

    • No registered users viewing this page.

  • Posts

    • collinj153
      Can't get custom sounds to play. MC 1.19.2.

      By collinj153 路 Posted

      Well, as usual, it was user error. Naming mismatch in sounds.json.  Please delete this post if you find it necessary. 
    • collinj153
      Can't get custom sounds to play. MC 1.19.2.

      By collinj153 路 Posted

      Hello Forge community.  I'm running into an issue with a mod I'm working on.  To preface, I can call /playsound modId:name music @a and I can hear the sound I registered being played in game. Great!  However, I cannot get it to trigger via my mod code.    Registration: public static final RegistryObject<SoundEvent> A_WORLD_OF_MADNESS = SOUND_EVENTS.register("a_world_of_madness", () -> new SoundEvent(new ResourceLocation("tetheredsouls", "a_world_of_madness")));   Playback: Minecraft mc = Minecraft.getInstance(); if (!(mc.player instanceof LocalPlayer) || mc.level == null) return; LocalPlayer player = (LocalPlayer) mc.player; BlockPos pos = player.blockPosition(); SoundEvent track = ModSounds.A_WORLD_OF_MADNESS.get(); System.out.println(track); System.out.println(pos); System.out.println(player); // play exactly like the tutorial: client-only, at the player's position try { mc.level.playLocalSound( player.getX(), player.getY(), player.getZ(), track, SoundSource.MUSIC, // Or MASTER if needed 1f, 1f, false ); System.out.println("[DEBUG] playSound success: " + track.getLocation()); } catch (Exception e) { System.err.println("[ERROR] Failed to play sound: " + track.getLocation()); e.printStackTrace(); } Sounds.json:   { "theme_of_laura": { "category": "music", "sounds": [ { "name": "tetheredsouls:a_world_of_madness", "stream": true } ] } } Things I have tried: - multiple .ogg files. Short .ogg files (5 seconds, <100KB).  - default minecraft sounds imported from import net.minecraft.sounds.SoundEvents; These work given my code. No idea why these are different.  - playSound() method, as well as several others in past iterations that did not work   I would be forever grateful if somebody could point me in the right direction. I've looked at several mod github repositories and found extremely similar code to what I'm doing. I've also found several threads in this forum that did not solve my issue. I just cannot figure out what I'm doing differently, and why I'm able to queue sounds manually with playsound but the code won't play it (despite confirming the code is being run with the debug statements.)
    • mochi957640
      ROPL

      By mochi957640 路 Posted

      馃榾
    • TileEntity
      exception in server time loop

      By TileEntity 路 Posted

      Delete the tensura-reincarnated/common.toml file (config folder)
    • pouuhh
      mndcrft32

      By pouuhh 路 Posted

      Jesus Christ is God's Son, Jesus died for our sins and rose from the dead to Give us eternal life. Ask Him to also heal your body.

  • Topics

脳
脳
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.

  I accept