Jump to content

[1.9] New Registry System Help


Demonly

Recommended Posts

Hey Everyone,

 

Got some help last week, was great help, was able to do 90% of the things the guy told me to do, besides the new Registry System, and I am entirely not sure what I am doing wrong.

I read through some other threads, and even have my custom Biome working perfectly fine with the new Registry System, however it seems I can't get this simple block to register

correctly, I've tried multiple rendering techniques, all failing with a NPE on the "RENDER" part.

 

If anyone can give me a slight push, I am not entirely sure what I am not getting.

 

package com.demonly.netherexpansion.blocks;

import com.demonly.netherexpansion.blocks.Molten_Obsidian.Molten_Obsidian;
import com.demonly.netherexpansion.blocks.Skull_Block.Skull_block;
import com.demonly.netherexpansion.util.Reference;

import net.minecraft.block.Block;
import net.minecraft.client.Minecraft;
import net.minecraft.client.renderer.block.model.ModelResourceLocation;
import net.minecraft.item.Item;
import net.minecraftforge.client.model.ModelLoader;
import net.minecraftforge.client.model.b3d.B3DLoader;
import net.minecraftforge.fml.common.registry.GameRegistry;

public class BlocksRegistry {
public static Skull_block testBlock;
public static Molten_Obsidian MoltenObsidian;

public static void preInitCommon() {

	//Registering Test_block - Old Method
	//testBlock = (Skull_block) (new Skull_block().setUnlocalizedName("test_block"));
	//GameRegistry.registerBlock(testBlock, "test_block").getUnlocalizedName().substring(5);

	//Registering MoltenObsidian - Old Method
	//MoltenObsidian = (Molten_Obsidian) (new Molten_Obsidian().setUnlocalizedName("Molten_Obsidian"));
	//GameRegistry.registerBlock(MoltenObsidian, "Molten_Obsidian").getUnlocalizedName().substring(5);

	//Testing new Method
	MoltenObsidian = new Molten_Obsidian();
	MoltenObsidian.setUnlocalizedName("Molten_Obsidian");
	MoltenObsidian.setRegistryName(MoltenObsidian.getUnlocalizedName());
	GameRegistry.register(MoltenObsidian);

}

public static void initCommon() {
}

public static void postInitCommon() {
}

public static void registerRenders() {

	//Registering the Render of the Item of testBlock
	registerBlockRender(MoltenObsidian);
	//registerBlockRender(testBlock);

}

public static void registerBlockRender(Block block) {

	MoltenObsidian = new Molten_Obsidian();

	Item render = Item.getItemFromBlock(block);

	//New Model Loader
	ModelLoader.setCustomModelResourceLocation(render, 0, (ModelResourceLocation) render.getRegistryName());

	//Old Model Loader
	//Minecraft.getMinecraft().getRenderItem().getItemModelMesher()
	//.register(render, 0, new ModelResourceLocation(Reference.MOD_ID 
    //+ ":" + render.getUnlocalizedName().substring(5), "inventory"));

}

}

Link to comment
Share on other sites

- Don't use the unlocalized name as the registry name. If anything do it the other way around.

- You never registered an ItemBlock for your Block, hence it cannot exist in the inventory or any other ItemStack based form.

 

Thank you,

 

Got it working. Much appreciation, can't believe I was missing the ItemBlock. xD

Link to comment
Share on other sites

Guest
This topic is now closed to further replies.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Try deliting feur builder  It caused this issue in my modpack
    • I am not using hardcoded recipes, I'm using Vanilla's already existing code for leather armor dying. (via extending and implementing DyeableArmorItem / DyeableLeatherItem respectively) I have actually figured out that it's something to do with registering item colors to the ItemColors instance, but I'm trying to figure out where exactly in my mod's code I would be placing a call to the required event handler. Unfortunately the tutorial is criminally undescriptive. The most I've found is that it has to be done during client initialization. I'm currently trying to do the necessary setup via hijacking the item registry since trying to modify the item classes directly (via using SubscribeEvent in the item's constructor didn't work. Class so far: // mrrp mrow - mcmod item painter v1.0 - catzrule ch package catzadvitems.init; import net.minecraft.client.color.item.ItemColors; import net.minecraft.world.item.Item; import net.minecraftforge.registries.ObjectHolder; import net.minecraftforge.fml.event.lifecycle.FMLClientSetupEvent; import net.minecraftforge.fml.common.Mod; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.client.event.ColorHandlerEvent; import catzadvitems.item.DyeableWoolArmorItem; @Mod.EventBusSubscriber(bus = Mod.EventBusSubscriber.Bus.MOD) public class Painter { @ObjectHolder("cai:dyeable_wool_chestplate") public static final Item W_CHEST = null; @ObjectHolder("cai:dyeable_wool_leggings") public static final Item W_LEGS = null; @ObjectHolder("cai:dyeable_wool_boots") public static final Item W_SOCKS = null; public Painter() { // left blank, idk if forge throws a fit if constructors are missing, not taking the chance of it happening. } @SubscribeEvent public static void init(FMLClientSetupEvent event) { new Painter(); } @Mod.EventBusSubscriber private static class ForgeBusEvents { @SubscribeEvent public static void registerItemColors(ColorHandlerEvent.Item event) { ItemColors col = event.getItemColors(); col.register(DyeableUnderArmorItem::getItemDyedColor, W_CHEST, W_LEGS, W_SOCKS); //placeholder for other dye-able items here later.. } } } (for those wondering, i couldn't think of a creative wool helmet name)
    • nvm found out it was because i had create h and not f
    • Maybe there's something happening in the 'leather armor + dye' recipe itself that would be updating the held item texture?
    • @SubscribeEvent public static void onRenderPlayer(RenderPlayerEvent.Pre e) { e.setCanceled(true); model.renderToBuffer(e.getPoseStack(), pBuffer, e.getPackedLight(), 0f, 0f, 0f, 0f, 0f); //ToaPlayerRenderer.render(); } Since getting the render method from a separate class is proving to be bit of a brick wall for me (but seems to be the solution in older versions of minecraft/forge) I've decided to try and pursue using the renderToBuffer method directly from the model itself. I've tried this route before but can't figure out what variables to feed it for the vertexConsumer and still can't seem to figure it out; if this is even a path to pursue.  The vanilla model files do not include any form of render methods, and seem to be fully constructed from their layer definitions? Their renderer files seem to take their layers which are used by the render method in the vanilla MobRenderer class. But for modded entities we @Override this function and don't have to feed the method variables because of that? I assume that the render method in the extended renderer takes the layer definitions from the renderer classes which take those from the model files. Or maybe instead of trying to use a render method I should be calling the super from the renderer like   new ToaPlayerRenderer(context, false); Except I'm not sure what I would provide for context? There's a context method in the vanilla EntityRendererProvider class which doesn't look especially helpful. I've been trying something like <e.getEntity(), model<e.getEntity()>> since that generally seems to be what is provided to the renderers for context, but I don't know if it's THE context I'm looking for? Especially since the method being called doesn't want to take this or variations of this.   In short; I feel like I'm super super close but I have to be missing something obvious? Maybe this insane inane ramble post will provide some insight into this puzzle?
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.