Jump to content
View in the app

A better way to browse. Learn more.
Forge Forums

A full-screen app on your home screen with push notifications, badges and more.

To install this app on iOS and iPadOS
  1. Tap the Share icon in Safari
  2. Scroll the menu and tap Add to Home Screen.
  3. Tap Add in the top-right corner.
To install this app on Android
  1. Tap the 3-dot menu (⋮) in the top-right corner of the browser.
  2. Tap Add to Home screen or Install app.
  3. Confirm by tapping Install.
Search the Forums BEFORE making a new post.
Currently supported: All versions

[1.8.9] WorldSavedData not executing readFromNBT [SOLVED]

Atijaf
in Modder Support

Featured Replies

Posted

What would cause #readFromNBT to not be called?

 

I have a class that extends WorldSavedData and that class overrides both writeToNBT and readFromNBT.

 

get method

public static WorldData get(World world)
{
	WorldData data = (WorldData) world.loadItemData(WorldData.class, IDENTITY);
	if(data == null)
	{
		data = new WorldData();
		world.setItemData(IDENTITY, data);
	}
	return data;
}

 

I use the get method and call #markDirty().  It then runs through #writeToNBT and I store data within the nbt.  I am fairly certain it is writing data correctly, but for some unknown reason, #readFromNBT is never called.

 

Am I suppose to register my class somewhere or...

 

Thanks!

  • Quote

    How do you know it is not being called vs. simply failing?

     

    For example, you use NBT.TAG_LIST, but you are not storing a list of lists, you are storing a list of NBTTagCompounds, so you should be using that constant instead (the constant is the type of tag stored in the list, not the list itself).

  • Quote
    • Author

    While debugging, I have a breakpoint at where #readFromNBT starts.  Nothing ever happens for me there.  I run it in debug mode.

     

    //Instead of this
NBTTagList list = nbt.getTagList(IDENTITY, NBT.TAG_LIST);

//I should do this?
NBTTagList list = nbt.getTagList(IDENTITY, NBT.TAG_COMPOUND);
//Because the integer passed is the type of NBT's the list is holding?

     

    Thanks for clarifying that bit up, was a little bit confused as to how that worked:)

  • Quote

    Yep, in your case (which is the typical case), you should use NBT.TAG_COMPOUND when retrieving your list.

     

    If your #readFromNBT is never getting called, is your static #get method ever called? How about #writeToNBT?

     

    Also, I'm a little dubious about your use of long as a storage method for potentially an entire chunk's worth of data... while it may work most of the time if you generally need to store only a few positions per chunk, it seems extremely fragile to me for very little benefit. Of course, I don't know the whole story, so maybe you will only ever have 1 or 2 positions per chunk and that's fine, but something to consider.

  • Quote
    • Author

    I do call the #get method.  After marking it dirty and it saves, #writeToNBT is called.

     

    I have a hierarchy of lists within lists...  This is saved within nbt in a long.

     

    The chunk requires about 48 bits, (22 bits x coord, 22 bits z coord, 4 bits dimension) in order to cover the Minecraft world of chunks and in which dimension they belong.  Then, within the chunk, I store the x, y, and z coords (4 bits, 8 bits, 4 bits), taking up a total of 64 bits. (During ram usage)

    So, in other words, A chunk needs 48 bits, and each block within needs 16.

     

    I do see your point on storing a long within the nbt...  I'll work on that after getting the #readFromNBT to work.  Perhaps I just need to update my forge version.

     

    I'll mess around with the code a little bit.

     

    Thanks for the help thus far.

  • Quote
    • Author

    Am I suppose to call the get method in order for it to run #readFromNBT?  I do call it, but is there a certain place that I'm suppose to do that?

     

    Also, I get this error

     

     

     

    [03:54:14] [server thread/INFO] [FML]: Loading dimension 0 (New World) (net.minecraft.server.integrated.IntegratedServer@359173ac)
[03:54:14] [server thread/INFO] [FML]: Loading dimension 1 (New World) (net.minecraft.server.integrated.IntegratedServer@359173ac)
[03:54:14] [server thread/INFO] [sTDERR]: [net.minecraft.world.storage.MapStorage:loadData:70]: java.lang.RuntimeException: Failed to instantiate class MCO.World.WorldData
[03:54:14] [server thread/INFO] [sTDERR]: [net.minecraft.world.storage.MapStorage:loadData:70]: 	at net.minecraft.world.storage.MapStorage.loadData(MapStorage.java:59)
[03:54:14] [server thread/INFO] [sTDERR]: [net.minecraft.world.storage.MapStorage:loadData:70]: 	at MCO.World.WorldData.get(WorldData.java:26)
[03:54:14] [server thread/INFO] [sTDERR]: [net.minecraft.world.storage.MapStorage:loadData:70]: 	at MCO.Events.PlayerEvents.worldEvent(PlayerEvents.java:433)
[03:54:14] [server thread/INFO] [sTDERR]: [net.minecraft.world.storage.MapStorage:loadData:70]: 	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_6_PlayerEvents_worldEvent_Load.invoke(.dynamic)
[03:54:14] [server thread/INFO] [sTDERR]: [net.minecraft.world.storage.MapStorage:loadData:70]: 	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:49)
[03:54:14] [server thread/INFO] [sTDERR]: [net.minecraft.world.storage.MapStorage:loadData:70]: 	at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:140)
[03:54:14] [server thread/INFO] [sTDERR]: [net.minecraft.world.storage.MapStorage:loadData:70]: 	at net.minecraft.server.integrated.IntegratedServer.loadAllWorlds(IntegratedServer.java:100)
[03:54:14] [server thread/INFO] [sTDERR]: [net.minecraft.world.storage.MapStorage:loadData:70]: 	at net.minecraft.server.integrated.IntegratedServer.startServer(IntegratedServer.java:127)
[03:54:14] [server thread/INFO] [sTDERR]: [net.minecraft.world.storage.MapStorage:loadData:70]: 	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:508)
[03:54:14] [server thread/INFO] [sTDERR]: [net.minecraft.world.storage.MapStorage:loadData:70]: 	at java.lang.Thread.run(Unknown Source)
[03:54:14] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:-1]: Caused by: java.lang.NoSuchMethodException: MCO.World.WorldData.<init>(java.lang.String)
[03:54:14] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:-1]: 	at java.lang.Class.getConstructor0(Unknown Source)
[03:54:14] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:-1]: 	at java.lang.Class.getConstructor(Unknown Source)
[03:54:14] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:-1]: 	at net.minecraft.world.storage.MapStorage.loadData(MapStorage.java:55)
[03:54:14] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:-1]: 	... 9 more
[03:54:14] [server thread/INFO] [FML]: Loading dimension -1 (New World) (net.minecraft.server.integrated.IntegratedServer@359173ac)
[03:54:14] [server thread/INFO] [sTDERR]: [net.minecraft.world.storage.MapStorage:loadData:70]: java.lang.RuntimeException: Failed to instantiate class MCO.World.WorldData
[03:54:14] [server thread/INFO] [sTDERR]: [net.minecraft.world.storage.MapStorage:loadData:70]: 	at net.minecraft.world.storage.MapStorage.loadData(MapStorage.java:59)
[03:54:14] [server thread/INFO] [sTDERR]: [net.minecraft.world.storage.MapStorage:loadData:70]: 	at MCO.World.WorldData.get(WorldData.java:26)
[03:54:14] [server thread/INFO] [sTDERR]: [net.minecraft.world.storage.MapStorage:loadData:70]: 	at MCO.Events.PlayerEvents.worldEvent(PlayerEvents.java:433)
[03:54:14] [server thread/INFO] [sTDERR]: [net.minecraft.world.storage.MapStorage:loadData:70]: 	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_6_PlayerEvents_worldEvent_Load.invoke(.dynamic)
[03:54:14] [server thread/INFO] [sTDERR]: [net.minecraft.world.storage.MapStorage:loadData:70]: 	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:49)
[03:54:14] [server thread/INFO] [sTDERR]: [net.minecraft.world.storage.MapStorage:loadData:70]: 	at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:140)
[03:54:14] [server thread/INFO] [sTDERR]: [net.minecraft.world.storage.MapStorage:loadData:70]: 	at net.minecraft.server.integrated.IntegratedServer.loadAllWorlds(IntegratedServer.java:100)
[03:54:14] [server thread/INFO] [sTDERR]: [net.minecraft.world.storage.MapStorage:loadData:70]: 	at net.minecraft.server.integrated.IntegratedServer.startServer(IntegratedServer.java:127)
[03:54:14] [server thread/INFO] [sTDERR]: [net.minecraft.world.storage.MapStorage:loadData:70]: 	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:508)
[03:54:14] [server thread/INFO] [sTDERR]: [net.minecraft.world.storage.MapStorage:loadData:70]: 	at java.lang.Thread.run(Unknown Source)
[03:54:14] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:-1]: Caused by: java.lang.NoSuchMethodException: MCO.World.WorldData.<init>(java.lang.String)
[03:54:14] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:-1]: 	at java.lang.Class.getConstructor0(Unknown Source)
[03:54:14] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:-1]: 	at java.lang.Class.getConstructor(Unknown Source)
[03:54:14] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:-1]: 	at net.minecraft.world.storage.MapStorage.loadData(MapStorage.java:55)
[03:54:14] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:-1]: 	... 9 more
[03:54:14] [server thread/INFO] [sTDERR]: [net.minecraft.world.storage.MapStorage:loadData:70]: java.lang.RuntimeException: Failed to instantiate class MCO.World.WorldData
[03:54:14] [server thread/INFO] [sTDERR]: [net.minecraft.world.storage.MapStorage:loadData:70]: 	at net.minecraft.world.storage.MapStorage.loadData(MapStorage.java:59)
[03:54:14] [server thread/INFO] [sTDERR]: [net.minecraft.world.storage.MapStorage:loadData:70]: 	at MCO.World.WorldData.get(WorldData.java:26)
[03:54:14] [server thread/INFO] [sTDERR]: [net.minecraft.world.storage.MapStorage:loadData:70]: 	at MCO.Events.PlayerEvents.worldEvent(PlayerEvents.java:433)
[03:54:14] [server thread/INFO] [sTDERR]: [net.minecraft.world.storage.MapStorage:loadData:70]: 	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_6_PlayerEvents_worldEvent_Load.invoke(.dynamic)
[03:54:14] [server thread/INFO] [sTDERR]: [net.minecraft.world.storage.MapStorage:loadData:70]: 	at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:49)
[03:54:14] [server thread/INFO] [sTDERR]: [net.minecraft.world.storage.MapStorage:loadData:70]: 	at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:140)
[03:54:14] [server thread/INFO] [sTDERR]: [net.minecraft.world.storage.MapStorage:loadData:70]: 	at net.minecraft.server.integrated.IntegratedServer.loadAllWorlds(IntegratedServer.java:100)
[03:54:14] [server thread/INFO] [sTDERR]: [net.minecraft.world.storage.MapStorage:loadData:70]: 	at net.minecraft.server.integrated.IntegratedServer.startServer(IntegratedServer.java:127)
[03:54:14] [server thread/INFO] [sTDERR]: [net.minecraft.world.storage.MapStorage:loadData:70]: 	at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:508)
[03:54:14] [server thread/INFO] [sTDERR]: [net.minecraft.world.storage.MapStorage:loadData:70]: 	at java.lang.Thread.run(Unknown Source)
[03:54:14] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:-1]: Caused by: java.lang.NoSuchMethodException: MCO.World.WorldData.<init>(java.lang.String)
[03:54:14] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:-1]: 	at java.lang.Class.getConstructor0(Unknown Source)
[03:54:14] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:-1]: 	at java.lang.Class.getConstructor(Unknown Source)
[03:54:14] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:-1]: 	at net.minecraft.world.storage.MapStorage.loadData(MapStorage.java:55)
[03:54:14] [server thread/INFO] [sTDERR]: [java.lang.Throwable:printStackTrace:-1]: 	... 9 more

     

     

  • Quote
    • Author

    Thank you!  I was missing the constructor you mentioned.  That fixed the problem.

  • Quote

    • Join the conversation

    You can post now and register later. If you have an account, sign in now to post with your account.
    Note: Your post will require moderator approval before it will be visible.

    Guest
    Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
    Reply to this topic...
    Go to topic listing

    Important Information

    By using this site, you agree to our Terms of Use.

    I accept

    Configure browser push notifications
    Chrome (Android)
    1. Tap the lock icon next to the address bar.
    2. Tap Permissions → Notifications.
    3. Adjust your preference.
    Chrome (Desktop)
    1. Click the padlock icon in the address bar.
    2. Select Site settings.
    3. Find Notifications and adjust your preference.