Search the Forums BEFORE making a new post.

[SOLVED][1.9] Glass slab glitch

Posted May 21, 20169 yr

I'm using this class to make some slabs. However one of this is a glass slab, and so it needs to be transparent. The texture it is, but when placed down it glitches the block below, but only the double or the bottom slab, doing this

I've already tried adding the BlockGlass methods (isOpaque/isFullCube) but the glitch reamin

This is the class i use

package com.mwvanilla.blocks;

import java.util.List;
import java.util.Random;

import com.mineworld.blocks.ores.BlockOreSlab;
import com.mwvanilla.core.MWVanillaSlabs;
import com.mwvanilla.core.MWVanillaTabs;

import net.minecraft.block.Block;
import net.minecraft.block.BlockSlab;
import net.minecraft.block.BlockSlab.EnumBlockHalf;
import net.minecraft.block.material.Material;
import net.minecraft.block.properties.IProperty;
import net.minecraft.block.properties.PropertyEnum;
import net.minecraft.block.state.BlockStateContainer;
import net.minecraft.block.state.IBlockState;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.init.Blocks;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.BlockRenderLayer;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.IStringSerializable;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public abstract class BlockVanillaSlab extends BlockSlab
{
    public static final PropertyEnum<BlockVanillaSlab.Variant> VARIANT = PropertyEnum.<BlockVanillaSlab.Variant>create("variant", BlockVanillaSlab.Variant.class);
    private Block block;
    public BlockVanillaSlab(Block block)
    {
        super(block.getDefaultState().getMaterial());
        this.block = block;
        IBlockState iblockstate = this.blockState.getBaseState();

        if (!this.isDouble())
        {
            iblockstate = iblockstate.withProperty(HALF, BlockSlab.EnumBlockHalf.BOTTOM);
            this.setCreativeTab(MWVanillaTabs.tabVanillaSlabs);
        }

        this.setDefaultState(iblockstate.withProperty(VARIANT, BlockVanillaSlab.Variant.DEFAULT));
        this.setHardness(block.getBlockHardness(block.getDefaultState(), null, null));
        this.setResistance(block.getExplosionResistance(null));
        this.setStepSound(this.block.getStepSound());
        if(this.block.equals(Blocks.glowstone))
        	this.setLightLevel(0.75F);
        if(this.block.equals(Blocks.sea_lantern))
        	this.setLightLevel(1.0F);
	this.useNeighborBrightness = !this.isDouble();
    }
    
    @SideOnly(Side.CLIENT)
    public BlockRenderLayer getBlockLayer()
    {
        return this.block.getDefaultState().getMaterial().equals(Material.glass) ? BlockRenderLayer.CUTOUT : BlockRenderLayer.SOLID;
    }
            
    protected boolean canSilkHarvest()
    {
        return this.block.getDefaultState().getMaterial().equals(Material.glass);
    }
    
    @Override
public boolean canProvidePower(IBlockState state) {
	return this.block.equals(Blocks.redstone_block);
}

@Override
public int getWeakPower(IBlockState blockState, IBlockAccess blockAccess, BlockPos pos, EnumFacing side) {
	return  this.block.equals(Blocks.redstone_block) ? 15 : 0;
}

    /**
     * Get the Item that this Block should drop when harvested.
     */
    public Item getItemDropped(IBlockState state, Random rand, int fortune)
    {
        return this.block.getDefaultState().getMaterial().equals(Material.glass) ? null : Item.getItemFromBlock(this);
    }

    public ItemStack getItem(World worldIn, BlockPos pos, IBlockState state)
    {
        return new ItemStack(Item.getItemFromBlock(this));
    }

    /**
     * Convert the given metadata into a BlockState for this Block
     */
    public IBlockState getStateFromMeta(int meta)
    {
        IBlockState iblockstate = this.getDefaultState().withProperty(VARIANT, BlockVanillaSlab.Variant.DEFAULT);

        if (!this.isDouble())
        {
            iblockstate = iblockstate.withProperty(HALF, (meta &  == 0 ? BlockSlab.EnumBlockHalf.BOTTOM : BlockSlab.EnumBlockHalf.TOP);
        }

        return iblockstate;
    }

    /**
     * Convert the BlockState into the correct metadata value
     */
    public int getMetaFromState(IBlockState state)
    {
        int i = 0;

        if (!this.isDouble() && state.getValue(HALF) == BlockSlab.EnumBlockHalf.TOP)
        {
            i |= 8;
        }

        return i;
    }

    protected BlockStateContainer createBlockState()
    {
        return this.isDouble() ? new BlockStateContainer(this, new IProperty[] {VARIANT}): new BlockStateContainer(this, new IProperty[] {HALF, VARIANT});
    }

    /**
     * Returns the slab block name with the type associated with it
     */
    public String getUnlocalizedName(int meta)
    {
        return super.getUnlocalizedName();
    }

    public IProperty<?> getVariantProperty()
    {
        return VARIANT;
    }

    public Comparable<?> getTypeForItem(ItemStack stack)
    {
        return BlockVanillaSlab.Variant.DEFAULT;
    }

    public static enum Variant implements IStringSerializable
    {
        DEFAULT;

        public String getName()
        {
            return "default";
        }
    }
}

Don't blame me if i always ask for your help. I just want to learn to be better

Quote

May 21, 20169 yr

Author

I've already looked at that classes. Already added in the slab class the getBlockLayer function and the canSilkHarvest function. The only functions not added are the isFullCube, the isOpaque and the shouldSideBeRendered. Adding the isFullCube didn't change, overriding the shouldSideBeRendered to call the supermethod if the material isn't glass or running the same code of the BlockBreakable class if it is also didn't change. So i've added the last function, isOpaque, returning always false, but then the game crashes as i place a double slab (also the glitch persist). The class is now looking like this

package com.mwvanilla.blocks;

import java.util.List;
import java.util.Random;

import com.mineworld.blocks.ores.BlockOreSlab;
import com.mwvanilla.core.MWVanillaSlabs;
import com.mwvanilla.core.MWVanillaTabs;

import net.minecraft.block.Block;
import net.minecraft.block.BlockSlab;
import net.minecraft.block.BlockSlab.EnumBlockHalf;
import net.minecraft.block.material.Material;
import net.minecraft.block.properties.IProperty;
import net.minecraft.block.properties.PropertyEnum;
import net.minecraft.block.state.BlockStateContainer;
import net.minecraft.block.state.IBlockState;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.init.Blocks;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.BlockRenderLayer;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.IStringSerializable;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public abstract class BlockVanillaSlab extends BlockSlab
{
    public static final PropertyEnum<BlockVanillaSlab.Variant> VARIANT = PropertyEnum.<BlockVanillaSlab.Variant>create("variant", BlockVanillaSlab.Variant.class);
    private Block block;
    public BlockVanillaSlab(Block block)
    {
        super(block.getDefaultState().getMaterial());
        this.block = block;
        IBlockState iblockstate = this.blockState.getBaseState();

        if (!this.isDouble())
        {
            iblockstate = iblockstate.withProperty(HALF, BlockSlab.EnumBlockHalf.BOTTOM);
            this.setCreativeTab(MWVanillaTabs.tabVanillaSlabs);
        }

        this.setDefaultState(iblockstate.withProperty(VARIANT, BlockVanillaSlab.Variant.DEFAULT));
        this.setHardness(block.getBlockHardness(block.getDefaultState(), null, null));
        this.setResistance(block.getExplosionResistance(null));
        this.setStepSound(this.block.getStepSound());
        if(this.block.equals(Blocks.glowstone))
        	this.setLightLevel(0.75F);
        if(this.block.equals(Blocks.sea_lantern))
        	this.setLightLevel(1.0F);
	this.useNeighborBrightness = !this.isDouble();
    }
    
    public boolean isFullCube(IBlockState state)
    {
        return false;
    }
    
    public boolean isOpaqueCube(IBlockState state)
    {
        return false;
    }
    
    @Override
    public boolean shouldSideBeRendered(IBlockState blockState, IBlockAccess blockAccess, BlockPos pos,
    		EnumFacing side) {
    	if(this.block.getDefaultState().getMaterial().equals(Material.glass)) {
    		IBlockState iblockstate = blockAccess.getBlockState(pos.offset(side));
            Block block = iblockstate.getBlock();
            if (blockState != iblockstate)
            {
                return true;
            }

            if (block == this)
            {
                return false;
            }
            
            return block == this ? false : super.shouldSideBeRendered(blockState, blockAccess, pos, side);
    	}
    	return this.isDouble() ? true : super.shouldSideBeRendered(blockState, blockAccess, pos, side);
    }
    
    @SideOnly(Side.CLIENT)
    public BlockRenderLayer getBlockLayer()
    {
        return this.block.getDefaultState().getMaterial().equals(Material.glass) ? BlockRenderLayer.CUTOUT : BlockRenderLayer.SOLID;
    }
            
    protected boolean canSilkHarvest()
    {
        return !this.isDouble();
    }
    
    @Override
public boolean canProvidePower(IBlockState state) {
	return this.block.equals(Blocks.redstone_block);
}

@Override
public int getWeakPower(IBlockState blockState, IBlockAccess blockAccess, BlockPos pos, EnumFacing side) {
	return  this.block.equals(Blocks.redstone_block) ? 15 : 0;
}

    /**
     * Get the Item that this Block should drop when harvested.
     */
    public Item getItemDropped(IBlockState state, Random rand, int fortune)
    {
        return this.block.getDefaultState().getMaterial().equals(Material.glass) ? null : Item.getItemFromBlock(this);
    }

    public ItemStack getItem(World worldIn, BlockPos pos, IBlockState state)
    {
        return new ItemStack(Item.getItemFromBlock(this));
    }

    /**
     * Convert the given metadata into a BlockState for this Block
     */
    public IBlockState getStateFromMeta(int meta)
    {
        IBlockState iblockstate = this.getDefaultState().withProperty(VARIANT, BlockVanillaSlab.Variant.DEFAULT);

        if (!this.isDouble())
        {
            iblockstate = iblockstate.withProperty(HALF, (meta &  == 0 ? BlockSlab.EnumBlockHalf.BOTTOM : BlockSlab.EnumBlockHalf.TOP);
        }

        return iblockstate;
    }

    /**
     * Convert the BlockState into the correct metadata value
     */
    public int getMetaFromState(IBlockState state)
    {
        int i = 0;

        if (!this.isDouble() && state.getValue(HALF) == BlockSlab.EnumBlockHalf.TOP)
        {
            i |= 8;
        }

        return i;
    }

    protected BlockStateContainer createBlockState()
    {
        return this.isDouble() ? new BlockStateContainer(this, new IProperty[] {VARIANT}): new BlockStateContainer(this, new IProperty[] {HALF, VARIANT});
    }

    /**
     * Returns the slab block name with the type associated with it
     */
    public String getUnlocalizedName(int meta)
    {
        return super.getUnlocalizedName();
    }

    public IProperty<?> getVariantProperty()
    {
        return VARIANT;
    }

    public Comparable<?> getTypeForItem(ItemStack stack)
    {
        return BlockVanillaSlab.Variant.DEFAULT;
    }

    public static enum Variant implements IStringSerializable
    {
        DEFAULT;

        public String getName()
        {
            return "default";
        }
    }
}

And this is the crash i have

java.lang.IllegalArgumentException: Cannot get property PropertyEnum{name=half, clazz=class net.minecraft.block.BlockSlab$EnumBlockHalf, values=[top, bottom]} as it does not exist in BlockStateContainer{block=mw:glass_double_slab, properties=[variant]}
at net.minecraft.block.state.BlockStateContainer$StateImplementation.getValue(BlockStateContainer.java:192)
at net.minecraft.block.BlockSlab.doesSideBlockRendering(BlockSlab.java:67)
at net.minecraft.block.state.BlockStateContainer$StateImplementation.doesSideBlockRendering(BlockStateContainer.java:468)
at net.minecraft.block.Block.shouldSideBeRendered(Block.java:516)
at net.minecraft.block.state.BlockStateContainer$StateImplementation.shouldSideBeRendered(BlockStateContainer.java:408)
at net.minecraftforge.client.model.pipeline.ForgeBlockModelRenderer.render(ForgeBlockModelRenderer.java:113)
at net.minecraftforge.client.model.pipeline.ForgeBlockModelRenderer.renderModelSmooth(ForgeBlockModelRenderer.java:84)
at net.minecraft.client.renderer.BlockModelRenderer.renderModel(BlockModelRenderer.java:45)
at net.minecraft.client.renderer.BlockModelRenderer.renderModel(BlockModelRenderer.java:36)
at net.minecraft.client.renderer.BlockRendererDispatcher.renderBlock(BlockRendererDispatcher.java:81)
at net.minecraft.client.renderer.chunk.RenderChunk.rebuildChunk(RenderChunk.java:196)
at net.minecraft.client.renderer.chunk.ChunkRenderWorker.processTask(ChunkRenderWorker.java:124)
at net.minecraft.client.renderer.chunk.ChunkRenderDispatcher.updateChunkNow(ChunkRenderDispatcher.java:171)
at net.minecraft.client.renderer.RenderGlobal.setupTerrain(RenderGlobal.java:975)
at net.minecraft.client.renderer.EntityRenderer.renderWorldPass(EntityRenderer.java:1339)
at net.minecraft.client.renderer.EntityRenderer.renderWorld(EntityRenderer.java:1282)
at net.minecraft.client.renderer.EntityRenderer.updateCameraAndRender(EntityRenderer.java:1091)
at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:1135)
at net.minecraft.client.Minecraft.run(Minecraft.java:401)
at net.minecraft.client.main.Main.main(Main.java:118)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97)
at GradleStart.main(GradleStart.java:26)

It says that it cannot set the half property to a double slab as it doesn't exixts, wich is correct but looking at the supermethod the doubleslab case is handled well

Don't blame me if i always ask for your help. I just want to learn to be better

Quote

May 21, 20169 yr

Author

EDIT: the crash was cause by the doesSideBlockRendering, wich overriding properly as solved the problem. In case everyone want to look how this has been fixed, this is the complete class

package com.mwvanilla.blocks;

import java.util.List;
import java.util.Random;

import com.mineworld.blocks.ores.BlockOreSlab;
import com.mwvanilla.core.MWVanillaSlabs;
import com.mwvanilla.core.MWVanillaTabs;

import net.minecraft.block.Block;
import net.minecraft.block.BlockSlab;
import net.minecraft.block.BlockSlab.EnumBlockHalf;
import net.minecraft.block.material.Material;
import net.minecraft.block.properties.IProperty;
import net.minecraft.block.properties.PropertyEnum;
import net.minecraft.block.state.BlockStateContainer;
import net.minecraft.block.state.IBlockState;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.init.Blocks;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.util.BlockRenderLayer;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.IStringSerializable;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public abstract class BlockVanillaSlab extends BlockSlab
{
    public static final PropertyEnum<BlockVanillaSlab.Variant> VARIANT = PropertyEnum.<BlockVanillaSlab.Variant>create("variant", BlockVanillaSlab.Variant.class);
    private Block block;
    public BlockVanillaSlab(Block block)
    {
        super(block.getDefaultState().getMaterial());
        this.block = block;
        IBlockState iblockstate = this.blockState.getBaseState();

        if (!this.isDouble())
        {
            iblockstate = iblockstate.withProperty(HALF, BlockSlab.EnumBlockHalf.BOTTOM);
            this.setCreativeTab(MWVanillaTabs.tabVanillaSlabs);
        }

        this.setDefaultState(iblockstate.withProperty(VARIANT, BlockVanillaSlab.Variant.DEFAULT));
        this.setHardness(block.getBlockHardness(block.getDefaultState(), null, null));
        this.setResistance(block.getExplosionResistance(null));
        this.setStepSound(this.block.getStepSound());
        if(this.block.equals(Blocks.glowstone))
        	this.setLightLevel(0.75F);
        if(this.block.equals(Blocks.sea_lantern))
        	this.setLightLevel(1.0F);
	this.useNeighborBrightness = !this.isDouble();
    }
    
    @Override
    public boolean isOpaqueCube(IBlockState state) {
    	return false;
    }
    
    @Override
    public boolean doesSideBlockRendering(IBlockState state, IBlockAccess world, BlockPos pos, EnumFacing face)
    {
        if(this.block.getDefaultState().getMaterial().equals(Material.glass))
        	return Blocks.glass.doesSideBlockRendering(state, world, pos, face);
        else
        	return super.doesSideBlockRendering(state, world, pos, face);
    }
    
    @Override
    public boolean shouldSideBeRendered(IBlockState blockState, IBlockAccess blockAccess, BlockPos pos,
    		EnumFacing side) {
    	if(this.block.getDefaultState().getMaterial().equals(Material.glass)) {
    		IBlockState iblockstate = blockAccess.getBlockState(pos.offset(side));
            Block block = iblockstate.getBlock();
            if (blockState != iblockstate)
            {
                return true;
            }

            if (block == this)
            {
                return false;
            }
            
            return block == this ? false : super.shouldSideBeRendered(blockState, blockAccess, pos, side);
    	}
    	return super.shouldSideBeRendered(blockState, blockAccess, pos, side);
    }
    
    @SideOnly(Side.CLIENT)
    public BlockRenderLayer getBlockLayer()
    {
        return this.block.getDefaultState().getMaterial().equals(Material.glass) ? BlockRenderLayer.CUTOUT : BlockRenderLayer.SOLID;
    }
            
    protected boolean canSilkHarvest()
    {
        return !this.isDouble();
    }
    
    @Override
public boolean canProvidePower(IBlockState state) {
	return this.block.equals(Blocks.redstone_block);
}

@Override
public int getWeakPower(IBlockState blockState, IBlockAccess blockAccess, BlockPos pos, EnumFacing side) {
	return  this.block.equals(Blocks.redstone_block) ? 15 : 0;
}

    /**
     * Get the Item that this Block should drop when harvested.
     */
    public Item getItemDropped(IBlockState state, Random rand, int fortune)
    {
        return this.block.getDefaultState().getMaterial().equals(Material.glass) ? null : Item.getItemFromBlock(this);
    }

    public ItemStack getItem(World worldIn, BlockPos pos, IBlockState state)
    {
        return new ItemStack(Item.getItemFromBlock(this));
    }

    /**
     * Convert the given metadata into a BlockState for this Block
     */
    public IBlockState getStateFromMeta(int meta)
    {
        IBlockState iblockstate = this.getDefaultState().withProperty(VARIANT, BlockVanillaSlab.Variant.DEFAULT);

        if (!this.isDouble())
        {
            iblockstate = iblockstate.withProperty(HALF, (meta &  == 0 ? BlockSlab.EnumBlockHalf.BOTTOM : BlockSlab.EnumBlockHalf.TOP);
        }

        return iblockstate;
    }

    /**
     * Convert the BlockState into the correct metadata value
     */
    public int getMetaFromState(IBlockState state)
    {
        int i = 0;

        if (!this.isDouble() && state.getValue(HALF) == BlockSlab.EnumBlockHalf.TOP)
        {
            i |= 8;
        }

        return i;
    }

    protected BlockStateContainer createBlockState()
    {
        return this.isDouble() ? new BlockStateContainer(this, new IProperty[] {VARIANT}): new BlockStateContainer(this, new IProperty[] {HALF, VARIANT});
    }

    /**
     * Returns the slab block name with the type associated with it
     */
    public String getUnlocalizedName(int meta)
    {
        return super.getUnlocalizedName();
    }

    public IProperty<?> getVariantProperty()
    {
        return VARIANT;
    }

    public Comparable<?> getTypeForItem(ItemStack stack)
    {
        return BlockVanillaSlab.Variant.DEFAULT;
    }

    public static enum Variant implements IStringSerializable
    {
        DEFAULT;

        public String getName()
        {
            return "default";
        }
    }
}

Thank you diesieben for the help

Don't blame me if i always ask for your help. I just want to learn to be better

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/38891-solved19-glass-slab-glitch/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

Orbital strike cannon fishing rod mod

Yeah I saw, he just mentioned Fabric so I was wondering when it would be out.
@FoxyWoxy
When you are near (1-12ish blocks) the stab shot when it hits, the player gets launched around 50-100 blocks in the air

By JayKing014 · 36 minutes ago36 min
New Forum Design/Update: Issues and Suggestions

Thanks for your feedback and suggestions. The new forums run Invision Community 5 - some things are more customisable, other things a lot less. I'm happy to adjust the settings as desired but not sure where they'd be or if they're still available in the new version, so if you could let me know I'll give it a go.

By Paint_Ninja · 3 hours ago3 hr
Orbital strike cannon fishing rod mod

This is the Forge forums. Only Forge is supported here, not Fabric.

By Paint_Ninja · 3 hours ago3 hr
Need help with server (lilypad)

Remove the client-side-only mods from your server

Start with smartkeyprompts

By TileEntity · 8 hours ago8 hr
Orbital strike cannon fishing rod mod

When will it be done for fabric 1.21.5 and is it server side or client side?? @FoxyWoxy

By JayKing014 · 10 hours ago10 hr

Sign In

[SOLVED][1.9] Glass slab glitch

Featured Replies

Join the conversation

Posts

Orbital strike cannon fishing rod mod

New Forum Design/Update: Issues and Suggestions

Orbital strike cannon fishing rod mod

Need help with server (lilypad)

Orbital strike cannon fishing rod mod

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)