Search the Forums BEFORE making a new post.

[1.8.9] Fortune With Custom Ores?

Posted May 22, 20169 yr

So I have this code which makes it so that my ores drop an item rather than themselves (like Diamond Ore does) but I can't get it to drop more with fortune, how would I make it so that they multiply with fortune like diamond ore does?

package com.MonstrousApple.mod.gems;

import java.util.Random;

import com.MonstrousApple.mod.MAGlobal;
import com.MonstrousApple.mod.items.MAItems;
import com.MonstrousApple.mod.ores.MAOres;

import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.block.state.IBlockState;
import net.minecraft.init.Items;
import net.minecraft.item.Item;

public class MAGem extends Block {

public MAGem(String unlocalizedName, Material material, float hardness, float resistance) {
	super(material);

	this.setCreativeTab(MAGlobal.maCreativeTabOres);
	this.setUnlocalizedName(unlocalizedName);
	this.setHardness(hardness);
	this.setResistance(resistance);
	}

public Item getItemDropped(IBlockState state, Random rand, int fortune) {
	if (this == MAGems.SapphireOre) {
		return MAItems.Sapphire;
		}
		else if (this == MAGems.RubyOre) {
		return MAItems.Ruby;
		}
		else {
		return null;
		}
	}


public int quantityDropped(Random random) {
	if (this == MAGems.SapphireOre) {
		return 4 + random.nextInt(5);
		}
		else if (this == MAGems.RubyOre) {
		return 4 + random.nextInt(5);
		}
		else {
		return 0;
		}
	}
}

Quote

May 22, 20169 yr

Override

Block#quantityDropped(IBlockState, int, Random)

instead of

Block#quantityDropped(Random)

, this gives you the fortune level.

I would personally recommend having fields to store the dropped item and quantity rather than checking which instance

this

is, it makes your code more extendable.

Side note: Always annotate override methods with

@Override

so you get a compiler error if they don't override a super method.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Quote

May 22, 20169 yr

Author

So like this? Or is there more to add?

package com.MonstrousApple.mod.gems;

import java.util.Random;

import com.MonstrousApple.mod.MAGlobal;
import com.MonstrousApple.mod.items.MAItems;
import com.MonstrousApple.mod.ores.MAOres;

import net.minecraft.block.Block;
import net.minecraft.block.material.Material;
import net.minecraft.block.state.IBlockState;
import net.minecraft.init.Items;
import net.minecraft.item.Item;

public class MAGem extends Block {

public MAGem(String unlocalizedName, Material material, float hardness, float resistance) {
	super(material);

	this.setCreativeTab(MAGlobal.maCreativeTabOres);
	this.setUnlocalizedName(unlocalizedName);
	this.setHardness(hardness);
	this.setResistance(resistance);
	}

@Override
public Item getItemDropped(IBlockState state, Random random, int fortune) {
	if (this == MAGems.SapphireOre) {
		return MAItems.Sapphire;
		}
		else if (this == MAGems.RubyOre) {
		return MAItems.Ruby;
		}
		else if (this == MAGems.DiamondOre) {
		return Items.diamond;
		}
		else {
		return null;
		}
	}

public int quantityDropped(IBlockState state, int fortune, Random random) {
	if (this == MAGems.SapphireOre) {
		return 4 + random.nextInt(5);
		}
		else if (this == MAGems.RubyOre) {
		return 4 + random.nextInt(5);
		}
		else {
		return 0;
		}
	}
}

Quote

May 22, 20169 yr

Your new code is doing exactly the same thing as your old code, you need to add the fortune bonus yourself.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Quote

May 22, 20169 yr

Author

Okay but I need it the exact same effect as on diamond ore?

Quote

May 22, 20169 yr

Look at

BlockOre#quantityDroppedWithBonus

to see how vanilla ores add the fortune bonus.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Quote

May 22, 20169 yr

Author

Okay thanks

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/38916-189-fortune-with-custom-ores/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

How to change player renderer and transform model parts?

I have been trying for a while now to make a custom player renderer, and replace the vanilla player renderer with it. So far I've come up with a custom player renderer class that extends vanilla PlayerRenderer:
package com.FireDude123.BOTW.entity.renderer; import com.mojang.blaze3d.vertex.PoseStack; import net.minecraft.client.player.AbstractClientPlayer; import net.minecraft.client.renderer.MultiBufferSource; import net.minecraft.client.renderer.entity.player.PlayerRenderer; import net.minecraft.client.renderer.entity.EntityRendererProvider; import net.minecraftforge.client.event.RenderPlayerEvent; import net.minecraftforge.common.MinecraftForge; public class PoseablePlayerRenderer extends PlayerRenderer { public PoseablePlayerRenderer(EntityRendererProvider.Context ctx, boolean slim) { super(ctx, slim); System.out.println("here too"); } @Override public void render(AbstractClientPlayer p_117788_, float p_117789_, float p_117790_, PoseStack poseStack, MultiBufferSource p_117792_, int p_117793_) { System.out.println("didnt get here lol"); model.leftArm.xRot=(float)Math.toRadians(160); super.render(p_117788_, p_117789_, p_117790_, poseStack, p_117792_, p_117793_); } } As you can see, the intended purpose of this is to raise the player's left arm by 160 degrees. However, combined with this logic in ClientModEvents:
@Mod.EventBusSubscriber(modid = MODID, bus = Mod.EventBusSubscriber.Bus.MOD, value = Dist.CLIENT) public static class ClientModEvents { @SubscribeEvent public static void onClientSetup(FMLClientSetupEvent event) { EntityRenderers.register((EntityType<? extends AbstractClientPlayer>)(EntityType<?)EntityType.PLAYER, ctx -> new PoseablePlayerRenderer(ctx, true)); EntityRenderers.register(Entities.MAGNESIS_BLOCK.get(), com.FireDude123.BOTW.entity.renderer.BlockDisplayRenderer::new); EntityRenderers.register(Entities.REMOTE_BOMB.get(), ThrownItemRenderer::new); EntityRenderers.register(Entities.CRYONIS_ICE.get(), com.FireDude123.BOTW.entity.renderer.BlockDisplayRenderer::new); EntityRenderers.register(Entities.STASIS_BLOCK.get(), FallingBlockRenderer::new); } @SubscribeEvent public static void registerLayerDefinitions(EntityRenderersEvent.RegisterLayerDefinitions event) { event.registerLayerDefinition(new ModelLayerLocation(new ResourceLocation(BOTW.MODID, "paraglider"), "main"), ParagliderLayer::createBodyLayer); } }(I also have a paraglider layer here for something else, it's working perfectly fine, also I used the slim setting because the player is slim in 1.20.1 forge)
This logic isn't replacing the renderer, as far as I can tell. Can someone please advise as to why, and how to fix it?

By FireDude123 · Posted 15 hours ago15 hr
How to add my mob to another mod's biome in 1.20.1.

I'm on 1.20.1 and was wondering if there was a way to add a mob I am going to make to a other mod's biome (Regions Unexplored in this case). I am trying to figure this out before I start coding the mod. Could someone point me to a good guide on this? I saw some things about biome modifier's but all the resources are either to short, unhelpful or for a different version. Thanks in advance. (i am a beginner but i have java and modding knowledge so this isn't like a "i am new and don't know anything about coding" problem btw)

By ilov3gam3z · Posted 23 hours ago23 hr
Help with file conversion

Many Forge users seek help with file conversions. Similarly, managing your health can benefit from structured tools like the https://wellness-app.com/calculator/fasting-calculator/ and a free intermittent fasting calculator. These tools help you plan and personalize your fasting and eating windows based on your lifestyle and goals. By entering your preferred fasting duration and meal times, you receive a tailored schedule that makes intermittent fasting easier to follow. Just as mastering file conversions improves modding success, using a fasting calculator brings clarity and structure to your health routine, supporting better results over time.

By Brialeblanc · Yesterday at 10:34 AM1 day
Cobblemon invalid player data

Hi everyone, I keep getting "invalid player data" when trying to log onto my friend's server. Log analysis says to remove Night Lights and ImmediatelyFast, but that doesn't work. Any insight is appreciated

Log: https://mclo.gs/uj6pMkd

By CobbleDN · Posted Yesterday at 04:14 AM1 day
Bad pathfinding for big mobs (1.21.1)

I've struggled with this for way too long now, so I have decided to ask for some assistance here because there is almost no information about this online.

I made a hostile mob and I built it like this:
public static final Supplier<EntityType<Bunyip>> BUNYIP = ENTITY_TYPES.register("bunyip" , () -> EntityType.Builder. of(Bunyip::new, MobCategory.MONSTER).sized(3f, 2.5f).eyeHeight(1.75f).build("bunyip"));

However, I have discovered that a BoundingBox of 3 is too big for the vanilla pathfinding to work well. In fact, anything bigger than a block will not work well. This is especially noticeable when having it chase a player in a negative X and/or negative Z direction. The mob starts spinning, walking backwards, walking diagonally, etc.

I am using the Goal system:
protected void registerGoals() { super.registerGoals(); this.goalSelector.addGoal(1, new MeleeAttackGoal(this, 1.25, true)); this.targetSelector.addGoal(2, new NearestAttackableTargetGoal<>(this, Player.class, true, true)); }

This does not seem to be a me issue as the ravager, one of the biggest vanilla mobs, also struggles with proper pathfinding. I am a bit familiar with how Minecraft's pathfinding works, but not enough to make a pathfinding system from scratch (or at least not in a reasonable amount of time). Is there any way to fix this with some tweaks or will I have to make a custom pathfinding system?

By VictorEvers · Posted Tuesday at 08:42 PM1 day

Sign In

[1.8.9] Fortune With Custom Ores?

Featured Replies

Join the conversation

Posts

How to change player renderer and transform model parts?

How to add my mob to another mod's biome in 1.20.1.

Help with file conversion

Cobblemon invalid player data

Bad pathfinding for big mobs (1.21.1)

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)