Jump to content

[1.9] onItemRightClick getting called twice?


Recommended Posts

Hello everyone, I've just started modding minecraft today so I apologize if this question sounds a bit silly. I've finished the basic tutorials and started coding my own item. The idea is that when you kill mobs their souls get stored in the item and when you right click, you can respawn them back into the world. I managed to successfully get it to work except for two things. One, the function is getting called twice or at least I think it is. Two, one of the mobs spawned just freezes there not doing anything.

Wand Code:

public class ReAniWand extends Item{
public ReAniWand()
{
	setRegistryName("reAnimationWand");
	setUnlocalizedName("reAnimationWand");
	GameRegistry.register(this);
}

@SideOnly(Side.CLIENT)
public void initModel()
{
	ModelLoader.setCustomModelResourceLocation(this, 0, new ModelResourceLocation(getRegistryName(), "inventory"));
}

@Override
public void onCreated(ItemStack itemStack, World world,EntityPlayer player)
{
	itemStack.setTagCompound(new NBTTagCompound());	
	itemStack.getTagCompound().setInteger("MobCounter", 0);
	itemStack.getTagCompound().setString("Mob0", "h");
	itemStack.getTagCompound().setString("Mob1", "h");
	itemStack.getTagCompound().setString("Mob2", "h");
}

@Override
public ActionResult<ItemStack> onItemRightClick(ItemStack itemStackIn, World worldIn, EntityPlayer playerIn, EnumHand hand)
    {
	if(itemStackIn.getTagCompound().getInteger("MobCounter") > 0)
	{
		int mobCounter = itemStackIn.getTagCompound().getInteger("MobCounter");
		final int spawnRange = 4;
		--mobCounter;
		EntityLiving entity = null;
		entity = (EntityLiving)EntityList.createEntityByName(itemStackIn.getTagCompound().getString
                       ("Mob"+Integer.toString(mobCounter)), worldIn);
		entity.setLocationAndAngles((double)playerIn.getPosition().getX() + 
                      (worldIn.rand.nextDouble() - worldIn.rand.nextDouble()) * (double)spawnRange + 0.5D,
	      (double)(playerIn.getPosition().getY() + worldIn.rand.nextInt(3)), 
	      (double)playerIn.getPosition().getZ() + 
                      (worldIn.rand.nextDouble() - worldIn.rand.nextDouble()) * (double)spawnRange + 0.5D, 
	      MathHelper.wrapAngleTo180_float(worldIn.rand.nextFloat() * 360.0F), 0.0F);
	      entity.rotationYawHead = entity.rotationYaw;
              entity.renderYawOffset = entity.rotationYaw;
              worldIn.spawnEntityInWorld(entity);
              entity.playLivingSound();
              itemStackIn.getTagCompound().setInteger("MobCounter", mobCounter);
	}
        return new ActionResult(EnumActionResult.PASS, itemStackIn);
    }
}

Tracking Event Code:

public class EventTrackMob {

@SubscribeEvent
public void myEvent(LivingDeathEvent e)
{
	if(e.getEntity().isCreatureType(EnumCreatureType.MONSTER, false) 
                && e.getSource().getEntity() != null && e.getSource().getEntity() instanceof EntityPlayer)
	{
		EntityPlayer player = (EntityPlayer)e.getSource().getEntity();
		for(int i=0;i<9;i++)
			if(player.inventory.mainInventory[i] != null && 
                                player.inventory.mainInventory[i].getItem() instanceof ReAniWand)
			{
				if(player.inventory.mainInventory[i].getTagCompound().getInteger("MobCounter") < 3)
				{
					int mobCounter = player.inventory.mainInventory[i].getTagCompound().getInteger("MobCounter");
					String whichMob = "Mob"+Integer.toString(mobCounter++);
					player.inventory.mainInventory[i].getTagCompound().setString
                                                (whichMob, e.getEntity().getClass().getSimpleName().substring(6));
					player.inventory.mainInventory[i].getTagCompound().setInteger("MobCounter",mobCounter);
					break;
				}
			}
	}
}
}

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • They were already updated, and just to double check I even did a cleanup and fresh update from that same page. I'm quite sure drivers are not the problem here. 
    • i tried downloading the drivers but it says no AMD graphics hardware has been detected    
    • Update your AMD/ATI drivers - get the drivers from their website - do not update via system  
    • As the title says i keep on crashing on forge 1.20.1 even without any mods downloaded, i have the latest drivers (nvidia) and vanilla minecraft works perfectly fine for me logs: https://pastebin.com/5UR01yG9
    • Hello everyone, I'm making this post to seek help for my modded block, It's a special block called FrozenBlock supposed to take the place of an old block, then after a set amount of ticks, it's supposed to revert its Block State, Entity, data... to the old block like this :  The problem I have is that the system breaks when handling multi blocks (I tried some fix but none of them worked) :  The bug I have identified is that the function "setOldBlockFields" in the item's "setFrozenBlock" function gets called once for the 1st block of multiblock getting frozen (as it should), but gets called a second time BEFORE creating the first FrozenBlock with the data of the 1st block, hence giving the same data to the two FrozenBlock :   Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=head] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@73681674 BlockEntityData : id:"minecraft:bed",x:3,y:-60,z:-6} Old Block Fields set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=3, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} Frozen Block Entity set BlockState : Block{minecraft:black_bed}[facing=east,occupied=false,part=foot] BlockPos{x=2, y=-60, z=-6} BlockEntity : net.minecraft.world.level.block.entity.BedBlockEntity@6d1aa3da BlockEntityData : {id:"minecraft:bed",x:2,y:-60,z:-6} here is the code inside my custom "freeze" item :    @Override     public @NotNull InteractionResult useOn(@NotNull UseOnContext pContext) {         if (!pContext.getLevel().isClientSide() && pContext.getHand() == InteractionHand.MAIN_HAND) {             BlockPos blockPos = pContext.getClickedPos();             BlockPos secondBlockPos = getMultiblockPos(blockPos, pContext.getLevel().getBlockState(blockPos));             if (secondBlockPos != null) {                 createFrozenBlock(pContext, secondBlockPos);             }             createFrozenBlock(pContext, blockPos);             return InteractionResult.SUCCESS;         }         return super.useOn(pContext);     }     public static void createFrozenBlock(UseOnContext pContext, BlockPos blockPos) {         BlockState oldState = pContext.getLevel().getBlockState(blockPos);         BlockEntity oldBlockEntity = oldState.hasBlockEntity() ? pContext.getLevel().getBlockEntity(blockPos) : null;         CompoundTag oldBlockEntityData = oldState.hasBlockEntity() ? oldBlockEntity.serializeNBT() : null;         if (oldBlockEntity != null) {             pContext.getLevel().removeBlockEntity(blockPos);         }         BlockState FrozenBlock = setFrozenBlock(oldState, oldBlockEntity, oldBlockEntityData);         pContext.getLevel().setBlockAndUpdate(blockPos, FrozenBlock);     }     public static BlockState setFrozenBlock(BlockState blockState, @Nullable BlockEntity blockEntity, @Nullable CompoundTag blockEntityData) {         BlockState FrozenBlock = BlockRegister.FROZEN_BLOCK.get().defaultBlockState();         ((FrozenBlock) FrozenBlock.getBlock()).setOldBlockFields(blockState, blockEntity, blockEntityData);         return FrozenBlock;     }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.