Jump to content

Existing user? Sign In
Sign In

Remember me Not recommended on shared computers

Forgot your password?

Or sign in with one of these services
Sign Up

Modder Support

Search the Forums BEFORE making a new post.

Currently supported: All versions

How to count killings?

qxjl1010

By qxjl1010
June 3, 2016 in Modder Support

Share

https://forums.minecraftforge.net/topic/39223-how-to-count-killings/

Recommended Posts

qxjl1010

Tree Puncher

qxjl1010

Posted June 3, 2016

Posted June 3, 2016

Hey guys,

I've finished a class which be used to count killings.

package com.practise.request;


import net.minecraft.entity.passive.EntityChicken;
import net.minecraft.init.Items;
import net.minecraft.world.World;
import net.minecraftforge.common.MinecraftForge;
import net.minecraftforge.event.entity.living.LivingDeathEvent;
import net.minecraftforge.fml.common.FMLCommonHandler;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

public class KillingRequest {
public int KillingNumbers = 0;
public boolean ifFinished = false;

public KillingRequest() {
	FMLCommonHandler.instance().bus().register(this);
	MinecraftForge.EVENT_BUS.register(this);
}

@SubscribeEvent
public void KillingCount(LivingDeathEvent event){
	System.out.println("position.1,the killingNumbers is "+KillingNumbers);
	if((event.entity instanceof EntityChicken)){
		System.out.println("position.2,the killingNumbers is "+KillingNumbers);
		KillingNumbers += 1;
		System.out.println("position.3,the killingNumbers is "+KillingNumbers);
		if(KillingNumbers >= 5)
			ifFinished = true;

	}
}	
}

However, in the game, as soon as I kill a chicken, the console gives me this:

[16:03:41] [server thread/INFO]: Player483 joined the game

[16:03:51] [server thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:23]: position.1,the killingNumbers is 0

[16:03:51] [server thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:25]: position.2,the killingNumbers is 0

[16:03:51] [server thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:27]: position.3,the killingNumbers is 1

[16:03:51] [server thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:23]: position.1,the killingNumbers is 0

[16:03:51] [server thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:25]: position.2,the killingNumbers is 0

[16:03:51] [server thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:27]: position.3,the killingNumbers is 1

[16:03:51] [server thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:23]: position.1,the killingNumbers is 0

[16:03:51] [server thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:25]: position.2,the killingNumbers is 0

[16:03:51] [server thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:27]: position.3,the killingNumbers is 1

[16:03:51] [server thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:23]: position.1,the killingNumbers is 0

[16:03:51] [server thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:25]: position.2,the killingNumbers is 0

[16:03:51] [server thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:27]: position.3,the killingNumbers is 1

[16:03:51] [server thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:23]: position.1,the killingNumbers is 0

[16:03:51] [server thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:25]: position.2,the killingNumbers is 0

[16:03:51] [server thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:27]: position.3,the killingNumbers is 1

[16:03:51] [server thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:23]: position.1,the killingNumbers is 0

[16:03:51] [server thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:25]: position.2,the killingNumbers is 0

[16:03:51] [server thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:27]: position.3,the killingNumbers is 1

[16:03:51] [server thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:23]: position.1,the killingNumbers is 0

[16:03:51] [server thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:25]: position.2,the killingNumbers is 0

[16:03:51] [server thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:27]: position.3,the killingNumbers is 1

[16:03:51] [Client thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:23]: position.1,the killingNumbers is 1

[16:03:51] [Client thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:25]: position.2,the killingNumbers is 1

[16:03:51] [Client thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:27]: position.3,the killingNumbers is 2

[16:03:51] [Client thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:23]: position.1,the killingNumbers is 1

[16:03:51] [Client thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:25]: position.2,the killingNumbers is 1

[16:03:51] [Client thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:27]: position.3,the killingNumbers is 2

[16:03:51] [Client thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:23]: position.1,the killingNumbers is 1

[16:03:51] [Client thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:25]: position.2,the killingNumbers is 1

[16:03:51] [Client thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:27]: position.3,the killingNumbers is 2

[16:03:51] [Client thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:23]: position.1,the killingNumbers is 1

[16:03:51] [Client thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:25]: position.2,the killingNumbers is 1

[16:03:51] [Client thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:27]: position.3,the killingNumbers is 2

[16:03:51] [Client thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:23]: position.1,the killingNumbers is 1

[16:03:51] [Client thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:25]: position.2,the killingNumbers is 1

[16:03:51] [Client thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:27]: position.3,the killingNumbers is 2

[16:03:51] [Client thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:23]: position.1,the killingNumbers is 1

[16:03:51] [Client thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:25]: position.2,the killingNumbers is 1

[16:03:51] [Client thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:27]: position.3,the killingNumbers is 2

[16:03:51] [Client thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:23]: position.1,the killingNumbers is 1

[16:03:51] [Client thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:25]: position.2,the killingNumbers is 1

[16:03:51] [Client thread/INFO] [sTDOUT]: [com.practise.request.KillingRequest:KillingCount:27]: position.3,the killingNumbers is 2

[16:03:55] [server thread/INFO]: Saving and pausing game...

Does it mean I trigger this method several times when I kill only one chicken?

Quote

Reality Controller

Ernio

Posted June 3, 2016

Posted June 3, 2016

Death != Kill

Subscribing to events mean you listen to all such events. IN this case - you are listening to whenever EntityLivingBase dies (on client and on server).

What you need to do is to make it player specific.

1. Implement http://mcforge.readthedocs.io/en/latest/datastorage/capabilities/ in order to store killings and progress in player (and his NBT).

2. In event - check event.source.getEntity() - if it exist and is player, get that player's capability and increment kill.

3. Obviously, if you want more than one kill tracker you have to hold some lists.

4. This all is harder than you seem to be thinking (seeing your code, you don't really know much about internals).

Quote

1.7.10 is no longer supported by forge, you are on your own.

qxjl1010

Tree Puncher

qxjl1010

Posted June 4, 2016

Author

Posted June 4, 2016

I read the document and checked my reference library, cannot find a package called "capabilities".

My forge version is 1.8, can use something else instead?

Quote

shadowfacts

Dragon Slayer

shadowfacts

Posted June 4, 2016

Posted June 4, 2016

You could use

IEntityExtendedProperties

, but you should just update. 1.8 is EOL.

Quote

Don't make mods if you don't know Java.

Check out my website: http://shadowfacts.net

Developer of many mods

World Shaper

jeffryfisher

Posted June 4, 2016

Posted June 4, 2016

Don't vanilla stats already count all kills by each player?

Quote

The debugger is a powerful and necessary tool in any IDE, so learn how to use it. You'll be able to tell us more and get better help here if you investigate your runtime problems in the debugger before posting.

Reality Controller

Ernio

Posted June 4, 2016

Posted June 4, 2016

You could use
IEntityExtendedProperties
, but you should just update. 1.8 is EOL.

It's IExtendedEntityProperties.

Don't vanilla stats already count all kills by each player?

It does, but only globals and all-time. If one want to start from some point, it's kinda useless (well, you can use time-stamp-like "kill-stamps").

And yeah - you should update to 1.8.9+ (and use capabilities)

Quote

1.7.10 is no longer supported by forge, you are on your own.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

× Pasted as rich text. Restore formatting

Only 75 emoji are allowed.

× Your link has been automatically embedded. Display as a link instead

× Your previous content has been restored. Clear editor

× You cannot paste images directly. Upload or insert images from URL.

Insert image from URL

×

Share

https://forums.minecraftforge.net/topic/39223-how-to-count-killings/

Go to topic listing

Announcements

New Discord server

Recently Browsing
- No registered users viewing this page.
Posts
- Better Combat causing game crash upon loading into world Minecraft Forge 1.20.1
  
  By Veradigm · Posted 1 hour ago
  
  I recently built a mod pack ,RLMCC Insanity Unfolds, and Ive been playing it to make sure its stable and playable, these last few days the game has been running fine with the exception of a few player loading quirks here and there but nothing game breaking, fast forward to this morning attempting to load into my survival world results in the game crashing, I will reach 100% on world loading, the joining game prompt will appear, the loading terrain prompt will appear, I get a large lag spike, and then the game says Saving world and then crashes throwing an unknown error in the launcher when checking the logs I can see that right before the world gets shut down better combat throws a fatal error, I had assumed at first that maybe when the world got shutdown last that something got stuck in an invalid state so I removed the mod and played for a bit to hopefully un-stick whatever it was, no luck there. When I placed the mod back into the game the world continued to crash the game when loading in. I figured that maybe there was a bug introduced in the latest version so I downgraded a couple versions and worked my way back up. The original version of Better Combat the mod pack was using was better combat 1.8.6 - 1.20.1, I tried better combat 1.8.1 - 1.20.1 and worked my way up to version 1.8.5 - 1.20.1, still running into the problem. Removing Better combat solves the problem but removing the mod renders a major part of my mod pack broken as one of the major aspects of the pack was focused around better combat. As mentioned the mod pack was working and running stable prior to this morning with Better Combat 1.8.6 - 1.20.1, and there was no change in the mod list this morning I do not believe that this is a mod compatibility issue as I am still able to generate a new world perfectly fine and the mod pack was working fine these last few days. The loading issue seems to only occur with my original survival world that I made when I built the mod pack. Here is the last section from my latest.log file https://pastebin.com/6Q9e9ZLf
- 5855948346363
  
  By MrEmiradam · Posted 2 hours ago
  
  4747474785868478474734
- (((SOLVED))) Loading into certain worlds stuck on "Reading world data" then stops responding.
  
  By GreenChilis505 · Posted 4 hours ago
  
  It's called serverconfig file. You can find it by opening curseforge selecting your modpack, click the 3 dots next to play, select open folder then from there go to saves > your world that isn't working > serverconfig. Then highlight all the files within the serverconfig folder and delete them
- minecraft forge(40.2.24) 1.18.2 crash(org.spongepowered.asm.mixin.transformer.throwables.MixinTransformerError)
  
  By TileEntity · Posted 9 hours ago
  
  And without any mods? Just Forge?
- GAME CRASH Code -1 ERROR
  
  By TileEntity · Posted 9 hours ago
  
  Remove randompatches
Topics
- 0
  
  Better Combat causing game crash upon loading into world Minecraft Forge 1.20.1
  
  Veradigm · Started 1 hour ago
- 0
  
  5855948346363
  
  MrEmiradam · Started 2 hours ago
- 9
  
  (((SOLVED))) Loading into certain worlds stuck on "Reading world data" then stops responding.
  
  smokahs · Started November 15, 2021
- 10
  
  minecraft forge(40.2.24) 1.18.2 crash(org.spongepowered.asm.mixin.transformer.throwables.MixinTransformerError)
  
  dasonQAQ · Started Thursday at 02:12 PM
- 3
  
  GAME CRASH Code -1 ERROR
  
  Rickyfmr · Started 10 hours ago
Who's Online (See full list)
- Kermir
- Pomegranate

×

Browse
- Back
- Forums
- Staff
- Online Users
- Leaderboard
Activity
- Back
- All Activity
- Search

×

Create New...

Important Information

By using this site, you agree to our Terms of Use.

I accept

IPS spam blocked by CleanTalk.