Jump to content

[1.9.4] ItemStack rendering issue


CreativeMD

Recommended Posts

Hey there,

as i tried to port my InGameConfigManager to 1.9.4 i ran into a problem. Item rendering isn't working as it should.

U96wG8l.png

This isn't the first time i ran into that problem. So i tried to fix it. Unfortunately, without any success. I have tried various things to setup OpenGL properly in order to correct the lighting effect.

GlStateManager.enableRescaleNormal();
GlStateManager.enableBlend();
GlStateManager.tryBlendFuncSeparate(GlStateManager.SourceFactor.SRC_ALPHA, GlStateManager.DestFactor.ONE_MINUS_SRC_ALPHA, GlStateManager.SourceFactor.ONE, GlStateManager.DestFactor.ZERO);
RenderHelper.enableGUIStandardItemLighting();

 

After a lot of pain and headaches, i eventually found out, if i add this line

GlStateManager.loadIdentity();

it will make all itemstacks disappear, but once i remove it again it will fix the non lighting issue, although it's still not as it should be.

4sElK4b.png

 

Although i have been modding Minecraft for several years now, i have no idea what is causing this issue. It's seems like i'm missing something to setup OpenGL properly to rendering an itemstack in the correct way. So i would be very happy, if someone can help me out.

 

In Regards

CreativeMD

Link to comment
Share on other sites

Should  :D , but it doesn't  :(

 

Due to a gui-api the rendering is done by different controls and so on. I copied every necessary code and included the methods itself:

Style style = getStyle();
Vec3d centerOffset = getCenterOffset();

GlStateManager.pushMatrix();
GlStateManager.translate(posX+centerOffset.xCoord, posY+centerOffset.yCoord, 0);
GlStateManager.rotate(rotation, 0, 0, 1);
GlStateManager.translate(-centerOffset.xCoord, -centerOffset.yCoord, 0);

GlStateManager.scale(scale, scale, 0);

renderBackground(helper, style);

int spaceUsed = getContentOffset();

GlStateManager.translate(marginWidth, marginWidth, 0);

GL11.glEnable(GL11.GL_STENCIL_TEST);

GL11.glStencilOp(GL11.GL_KEEP, GL11.GL_KEEP, GL11.GL_KEEP);
GL11.glStencilFunc(GL11.GL_EQUAL, 0x1, 0x1);

renderContent(helper, style, width-spaceUsed*2, height-spaceUsed*2, relativeMaximumRect);{

float scale = getScaleFactor();
int xOffset = getOffsetX();
int yOffset = getOffsetY();

Rect newRect = relativeMaximumRect.mergeRects(getRect());

lastRenderedHeight = 0;

for (int i = controls.size()-1; i >= 0; i--) {
	GuiControl control = controls.get(i);

	if(control.visible && control.isVisibleInsideRect(-xOffset, -yOffset, width, height, scale))
	{
		GL11.glEnable(GL11.GL_STENCIL_TEST);

		prepareContentStencil(helper, relativeMaximumRect);

		GL11.glStencilOp(GL11.GL_KEEP, GL11.GL_KEEP, GL11.GL_KEEP);
		GL11.glStencilFunc(GL11.GL_EQUAL, 0x1, 0x1);

		GlStateManager.pushMatrix();
		GlStateManager.translate(xOffset, yOffset, 0);				
		control.renderControl(helper, scale, newRect.getOffsetRect(xOffset, yOffset));{

			Style style = getStyle();
			Vec3d centerOffset = getCenterOffset();

			GlStateManager.pushMatrix();
			GlStateManager.translate(posX+centerOffset.xCoord, posY+centerOffset.yCoord, 0);
			GlStateManager.rotate(rotation, 0, 0, 1);
			GlStateManager.translate(-centerOffset.xCoord, -centerOffset.yCoord, 0);

			//GlStateManager.translate(x, y, 0);
			GlStateManager.scale(scale, scale, 0);

			renderBackground(helper, style);

			int spaceUsed = getContentOffset();

			GlStateManager.translate(marginWidth, marginWidth, 0);

			GL11.glEnable(GL11.GL_STENCIL_TEST);

			GL11.glStencilOp(GL11.GL_KEEP, GL11.GL_KEEP, GL11.GL_KEEP);
			GL11.glStencilFunc(GL11.GL_EQUAL, 0x1, 0x1);

			renderContent(helper, style, width-spaceUsed*2, height-spaceUsed*2, relativeMaximumRect);{

				super.renderContent(helper, style, width, height);{
					if(shouldDrawTitle())
						helper.drawStringWithShadow(caption, 0, 0, width, height, getColor(), getAdditionalSize());
				}
				GlStateManager.pushMatrix();
				GlStateManager.translate(width/2-(helper.getStringWidth(caption)+getAdditionalSize())/2, height/2-avatarSize/2, 0);
				avatar.handleRendering(helper, avatarSize, avatarSize); //Rendering of the itemstack is done here
				{
				      GuiRenderHelper.instance.drawItemStack(stack, 0, 0, avatarSize, avatarSize);
				}
				GlStateManager.popMatrix();

			}

			GL11.glDisable(GL11.GL_STENCIL_TEST);

			GlStateManager.translate(-spaceUsed, -spaceUsed, 0);
			renderForeground(helper, style);

			GlStateManager.popMatrix();

			}

		GlStateManager.popMatrix();

		GL11.glDisable(GL11.GL_STENCIL_TEST);
	}

	lastRenderedHeight = (int) Math.max(lastRenderedHeight, (control.posY+control.height)*scale);

}
renderContent(helper, style, width, height);

}

GL11.glDisable(GL11.GL_STENCIL_TEST);

GlStateManager.translate(-spaceUsed, -spaceUsed, 0);
renderForeground(helper, style);

GlStateManager.popMatrix();

Outside of this code itemstack renderer rendering works without any issue. Example code:

GlStateManager.pushMatrix();
GL11.glEnable(GL11.GL_STENCIL_TEST);
GL11.glStencilOp(GL11.GL_KEEP, GL11.GL_KEEP, GL11.GL_KEEP);
GL11.glStencilFunc(GL11.GL_EQUAL, 0x1, 0x1);

GuiControl.defaultStyle.getBorder(layers.get(i)).renderStyle(GuiRenderHelper.instance, 100, 100);
GuiControl.defaultStyle.getBackground(layers.get(i)).renderStyle(10, 10, GuiRenderHelper.instance, 80, 80);
GuiRenderHelper.instance.font.drawStringWithShadow("Hey", 20, 20, ColorUtils.WHITE);
GuiRenderHelper.instance.drawItemStack(new ItemStack(Blocks.REDSTONE_TORCH), 8, 8, 16, 16);
GuiRenderHelper.instance.drawItemStack(new ItemStack(Blocks.FURNACE), 8, 48, 16, 16);
        
GL11.glDisable(GL11.GL_STENCIL_TEST);
GlStateManager.popMatrix();

To be honest, i have no idea would could cause an issue like that  :blank:

Link to comment
Share on other sites

F***, oh my ...

the mistake is sooo simple and easy.

 

Just take a closer look at this here:

GlStateManager.scale(scale, scale, 0);

 

and can you see the mistake? one little line can ruin everything :blank: :blank: :blank: :blank:

z scaling zero will result in a plane, which will of course mess up the lighting.

 

I changed it to

GlStateManager.scale(scale, scale, 1);

and everything works just fine.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Try deliting feur builder  It caused this issue in my modpack
    • I am not using hardcoded recipes, I'm using Vanilla's already existing code for leather armor dying. (via extending and implementing DyeableArmorItem / DyeableLeatherItem respectively) I have actually figured out that it's something to do with registering item colors to the ItemColors instance, but I'm trying to figure out where exactly in my mod's code I would be placing a call to the required event handler. Unfortunately the tutorial is criminally undescriptive. The most I've found is that it has to be done during client initialization. I'm currently trying to do the necessary setup via hijacking the item registry since trying to modify the item classes directly (via using SubscribeEvent in the item's constructor didn't work. Class so far: // mrrp mrow - mcmod item painter v1.0 - catzrule ch package catzadvitems.init; import net.minecraft.client.color.item.ItemColors; import net.minecraft.world.item.Item; import net.minecraftforge.registries.ObjectHolder; import net.minecraftforge.fml.event.lifecycle.FMLClientSetupEvent; import net.minecraftforge.fml.common.Mod; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.client.event.ColorHandlerEvent; import catzadvitems.item.DyeableWoolArmorItem; @Mod.EventBusSubscriber(bus = Mod.EventBusSubscriber.Bus.MOD) public class Painter { @ObjectHolder("cai:dyeable_wool_chestplate") public static final Item W_CHEST = null; @ObjectHolder("cai:dyeable_wool_leggings") public static final Item W_LEGS = null; @ObjectHolder("cai:dyeable_wool_boots") public static final Item W_SOCKS = null; public Painter() { // left blank, idk if forge throws a fit if constructors are missing, not taking the chance of it happening. } @SubscribeEvent public static void init(FMLClientSetupEvent event) { new Painter(); } @Mod.EventBusSubscriber private static class ForgeBusEvents { @SubscribeEvent public static void registerItemColors(ColorHandlerEvent.Item event) { ItemColors col = event.getItemColors(); col.register(DyeableUnderArmorItem::getItemDyedColor, W_CHEST, W_LEGS, W_SOCKS); //placeholder for other dye-able items here later.. } } } (for those wondering, i couldn't think of a creative wool helmet name)
    • nvm found out it was because i had create h and not f
    • Maybe there's something happening in the 'leather armor + dye' recipe itself that would be updating the held item texture?
    • @SubscribeEvent public static void onRenderPlayer(RenderPlayerEvent.Pre e) { e.setCanceled(true); model.renderToBuffer(e.getPoseStack(), pBuffer, e.getPackedLight(), 0f, 0f, 0f, 0f, 0f); //ToaPlayerRenderer.render(); } Since getting the render method from a separate class is proving to be bit of a brick wall for me (but seems to be the solution in older versions of minecraft/forge) I've decided to try and pursue using the renderToBuffer method directly from the model itself. I've tried this route before but can't figure out what variables to feed it for the vertexConsumer and still can't seem to figure it out; if this is even a path to pursue.  The vanilla model files do not include any form of render methods, and seem to be fully constructed from their layer definitions? Their renderer files seem to take their layers which are used by the render method in the vanilla MobRenderer class. But for modded entities we @Override this function and don't have to feed the method variables because of that? I assume that the render method in the extended renderer takes the layer definitions from the renderer classes which take those from the model files. Or maybe instead of trying to use a render method I should be calling the super from the renderer like   new ToaPlayerRenderer(context, false); Except I'm not sure what I would provide for context? There's a context method in the vanilla EntityRendererProvider class which doesn't look especially helpful. I've been trying something like <e.getEntity(), model<e.getEntity()>> since that generally seems to be what is provided to the renderers for context, but I don't know if it's THE context I'm looking for? Especially since the method being called doesn't want to take this or variations of this.   In short; I feel like I'm super super close but I have to be missing something obvious? Maybe this insane inane ramble post will provide some insight into this puzzle?
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.