Jump to content

[1.9.4] ItemStack rendering issue


CreativeMD

Recommended Posts

Hey there,

as i tried to port my InGameConfigManager to 1.9.4 i ran into a problem. Item rendering isn't working as it should.

U96wG8l.png

This isn't the first time i ran into that problem. So i tried to fix it. Unfortunately, without any success. I have tried various things to setup OpenGL properly in order to correct the lighting effect.

GlStateManager.enableRescaleNormal();
GlStateManager.enableBlend();
GlStateManager.tryBlendFuncSeparate(GlStateManager.SourceFactor.SRC_ALPHA, GlStateManager.DestFactor.ONE_MINUS_SRC_ALPHA, GlStateManager.SourceFactor.ONE, GlStateManager.DestFactor.ZERO);
RenderHelper.enableGUIStandardItemLighting();

 

After a lot of pain and headaches, i eventually found out, if i add this line

GlStateManager.loadIdentity();

it will make all itemstacks disappear, but once i remove it again it will fix the non lighting issue, although it's still not as it should be.

4sElK4b.png

 

Although i have been modding Minecraft for several years now, i have no idea what is causing this issue. It's seems like i'm missing something to setup OpenGL properly to rendering an itemstack in the correct way. So i would be very happy, if someone can help me out.

 

In Regards

CreativeMD

Link to comment
Share on other sites

Should  :D , but it doesn't  :(

 

Due to a gui-api the rendering is done by different controls and so on. I copied every necessary code and included the methods itself:

Style style = getStyle();
Vec3d centerOffset = getCenterOffset();

GlStateManager.pushMatrix();
GlStateManager.translate(posX+centerOffset.xCoord, posY+centerOffset.yCoord, 0);
GlStateManager.rotate(rotation, 0, 0, 1);
GlStateManager.translate(-centerOffset.xCoord, -centerOffset.yCoord, 0);

GlStateManager.scale(scale, scale, 0);

renderBackground(helper, style);

int spaceUsed = getContentOffset();

GlStateManager.translate(marginWidth, marginWidth, 0);

GL11.glEnable(GL11.GL_STENCIL_TEST);

GL11.glStencilOp(GL11.GL_KEEP, GL11.GL_KEEP, GL11.GL_KEEP);
GL11.glStencilFunc(GL11.GL_EQUAL, 0x1, 0x1);

renderContent(helper, style, width-spaceUsed*2, height-spaceUsed*2, relativeMaximumRect);{

float scale = getScaleFactor();
int xOffset = getOffsetX();
int yOffset = getOffsetY();

Rect newRect = relativeMaximumRect.mergeRects(getRect());

lastRenderedHeight = 0;

for (int i = controls.size()-1; i >= 0; i--) {
	GuiControl control = controls.get(i);

	if(control.visible && control.isVisibleInsideRect(-xOffset, -yOffset, width, height, scale))
	{
		GL11.glEnable(GL11.GL_STENCIL_TEST);

		prepareContentStencil(helper, relativeMaximumRect);

		GL11.glStencilOp(GL11.GL_KEEP, GL11.GL_KEEP, GL11.GL_KEEP);
		GL11.glStencilFunc(GL11.GL_EQUAL, 0x1, 0x1);

		GlStateManager.pushMatrix();
		GlStateManager.translate(xOffset, yOffset, 0);				
		control.renderControl(helper, scale, newRect.getOffsetRect(xOffset, yOffset));{

			Style style = getStyle();
			Vec3d centerOffset = getCenterOffset();

			GlStateManager.pushMatrix();
			GlStateManager.translate(posX+centerOffset.xCoord, posY+centerOffset.yCoord, 0);
			GlStateManager.rotate(rotation, 0, 0, 1);
			GlStateManager.translate(-centerOffset.xCoord, -centerOffset.yCoord, 0);

			//GlStateManager.translate(x, y, 0);
			GlStateManager.scale(scale, scale, 0);

			renderBackground(helper, style);

			int spaceUsed = getContentOffset();

			GlStateManager.translate(marginWidth, marginWidth, 0);

			GL11.glEnable(GL11.GL_STENCIL_TEST);

			GL11.glStencilOp(GL11.GL_KEEP, GL11.GL_KEEP, GL11.GL_KEEP);
			GL11.glStencilFunc(GL11.GL_EQUAL, 0x1, 0x1);

			renderContent(helper, style, width-spaceUsed*2, height-spaceUsed*2, relativeMaximumRect);{

				super.renderContent(helper, style, width, height);{
					if(shouldDrawTitle())
						helper.drawStringWithShadow(caption, 0, 0, width, height, getColor(), getAdditionalSize());
				}
				GlStateManager.pushMatrix();
				GlStateManager.translate(width/2-(helper.getStringWidth(caption)+getAdditionalSize())/2, height/2-avatarSize/2, 0);
				avatar.handleRendering(helper, avatarSize, avatarSize); //Rendering of the itemstack is done here
				{
				      GuiRenderHelper.instance.drawItemStack(stack, 0, 0, avatarSize, avatarSize);
				}
				GlStateManager.popMatrix();

			}

			GL11.glDisable(GL11.GL_STENCIL_TEST);

			GlStateManager.translate(-spaceUsed, -spaceUsed, 0);
			renderForeground(helper, style);

			GlStateManager.popMatrix();

			}

		GlStateManager.popMatrix();

		GL11.glDisable(GL11.GL_STENCIL_TEST);
	}

	lastRenderedHeight = (int) Math.max(lastRenderedHeight, (control.posY+control.height)*scale);

}
renderContent(helper, style, width, height);

}

GL11.glDisable(GL11.GL_STENCIL_TEST);

GlStateManager.translate(-spaceUsed, -spaceUsed, 0);
renderForeground(helper, style);

GlStateManager.popMatrix();

Outside of this code itemstack renderer rendering works without any issue. Example code:

GlStateManager.pushMatrix();
GL11.glEnable(GL11.GL_STENCIL_TEST);
GL11.glStencilOp(GL11.GL_KEEP, GL11.GL_KEEP, GL11.GL_KEEP);
GL11.glStencilFunc(GL11.GL_EQUAL, 0x1, 0x1);

GuiControl.defaultStyle.getBorder(layers.get(i)).renderStyle(GuiRenderHelper.instance, 100, 100);
GuiControl.defaultStyle.getBackground(layers.get(i)).renderStyle(10, 10, GuiRenderHelper.instance, 80, 80);
GuiRenderHelper.instance.font.drawStringWithShadow("Hey", 20, 20, ColorUtils.WHITE);
GuiRenderHelper.instance.drawItemStack(new ItemStack(Blocks.REDSTONE_TORCH), 8, 8, 16, 16);
GuiRenderHelper.instance.drawItemStack(new ItemStack(Blocks.FURNACE), 8, 48, 16, 16);
        
GL11.glDisable(GL11.GL_STENCIL_TEST);
GlStateManager.popMatrix();

To be honest, i have no idea would could cause an issue like that  :blank:

Link to comment
Share on other sites

F***, oh my ...

the mistake is sooo simple and easy.

 

Just take a closer look at this here:

GlStateManager.scale(scale, scale, 0);

 

and can you see the mistake? one little line can ruin everything :blank: :blank: :blank: :blank:

z scaling zero will result in a plane, which will of course mess up the lighting.

 

I changed it to

GlStateManager.scale(scale, scale, 1);

and everything works just fine.

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hello, Hi and I am making a forge 1.12.2 mod and also trying to get a custom model helmet item (I made a joker mask) and exported it to .json format and put it in the ~/namespace/models/item folder. Though, I'm struggling to get the item to render what I want it to be rendered like as I've positioned it in the 'head' window view in blockbench. How did you render out your model? I checked your code and it looks like no references to the actual model are being made. I'm new to this forge modding stuff (was a fabric modder) and I desperately need some help. Is there a way to standardly render out armor models made using blockbench? any methods that one can use? My model in JSON: ```json { "credit": "Made with Blockbench", "texture_size": [160, 160], "textures": { "0": "ydyrn:items/joker_mask_texture", "particle": "ydyrn:items/joker_mask_texture" }, "elements": [ { "from": [0, 0, 0], "to": [16, 16, 1], "faces": { "north": {"uv": [0, 1.7, 16, 14.2], "texture": "#0"}, "east": {"uv": [0, 4, 0.9, 5.6], "texture": "#0"}, "south": {"uv": [0, 5.8, 1.6, 7.4], "texture": "#0"}, "west": {"uv": [0, 1.9, 1.3, 3.5], "texture": "#0"}, "up": {"uv": [0, 3.4, 1.6, 4.2], "texture": "#0"}, "down": {"uv": [0, 9, 1.6, 9.7], "texture": "#0"} } }, { "from": [15.8, 11, 0.5], "to": [16.2, 13, 15], "faces": { "north": {"uv": [7.9, 7.9, 7.94, 8.1], "texture": "#0"}, "east": {"uv": [7.9, 7.9, 9.35, 8.1], "texture": "#0"}, "south": {"uv": [7.9, 7.9, 7.94, 8.1], "texture": "#0"}, "west": {"uv": [7.9, 7.9, 9.35, 8.1], "texture": "#0"}, "up": {"uv": [7.9, 7.9, 7.94, 9.35], "texture": "#0"}, "down": {"uv": [7.9, 7.9, 7.94, 9.35], "texture": "#0"} } }, { "from": [0.2, 11, 14.6], "to": [15.8, 13, 15], "faces": { "north": {"uv": [7.9, 7.9, 9.46, 8.1], "texture": "#0"}, "east": {"uv": [7.9, 7.9, 7.94, 8.1], "texture": "#0"}, "south": {"uv": [7.9, 7.9, 9.46, 8.1], "texture": "#0"}, "west": {"uv": [7.9, 7.9, 7.94, 8.1], "texture": "#0"}, "up": {"uv": [7.9, 7.9, 9.46, 7.94], "texture": "#0"}, "down": {"uv": [7.9, 7.9, 9.46, 7.94], "texture": "#0"} } }, { "from": [-0.2, 11, 0.5], "to": [0.2, 13, 15], "faces": { "north": {"uv": [7.9, 7.9, 7.94, 8.1], "texture": "#0"}, "east": {"uv": [7.9, 7.9, 9.35, 8.1], "texture": "#0"}, "south": {"uv": [7.9, 7.9, 7.94, 8.1], "texture": "#0"}, "west": {"uv": [7.9, 7.9, 9.35, 8.1], "texture": "#0"}, "up": {"uv": [7.9, 7.9, 7.94, 9.35], "texture": "#0"}, "down": {"uv": [7.9, 7.9, 7.94, 9.35], "texture": "#0"} } } ], "display": { "thirdperson_righthand": { "translation": [-0.25, -2.75, 0], "scale": [0.3, 0.3, 0.3] }, "thirdperson_lefthand": { "translation": [-0.25, -2.75, 0], "scale": [0.3, 0.3, 0.3] }, "firstperson_righthand": { "rotation": [-9, 115, 15], "translation": [0, 1.25, -1.75], "scale": [0.5, 0.5, 0.5] }, "firstperson_lefthand": { "rotation": [-9, 115, 15], "translation": [0, 1.25, -1.75], "scale": [0.5, 0.5, 0.5] }, "ground": { "rotation": [40, 0, 0], "translation": [0, -2.5, 0], "scale": [0.5, 0.5, 0.5] }, "gui": { "rotation": [0, 180, 0] }, "head": { "translation": [0, 0, 0.25], "scale": [0.82773, 0.73594, 0.9] }, "fixed": { "translation": [0, 0, 8.75] } }, "groups": [ 0, { "name": "straps", "origin": [0, 0, 0], "color": 0, "children": [1, 2, 3] } ] } ```
    • Add the crash-report or latest.log (logs-folder) with sites like https://paste.ee/ and paste the link to it here  
    • In your config folder, delete the sophisticatedcore-common.toml file and test it again
    • Add the crash-report or latest.log (logs-folder) with sites like https://paste.ee/ and paste the link to it here  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.