Jump to content

Recommended Posts

Posted

im making a client mod and i just need to get the string of the vanilla current title and the subtitle

 

 

EDIT:

 

hey guys i solved it with the help of diesieben07

 

diesieben again thank you so much for all the help!

 

for people from the future that want to know what i did, this for Title:

String title = (String) ReflectionHelper.findField(GuiIngame.class, "displayedTitle", "field_175201_x").get(Minecraft.getMinecraft().ingameGUI);

 

and this for subtitle:

String title = (String) ReflectionHelper.findField(GuiIngame.class, "displayedSubTitle", "field_175200_y").get(Minecraft.getMinecraft().ingameGUI);

 

 

 

 

 

 

 

also if anyone wants a super easy method to get them i just made this:

    public static String getCurrentTitle(){
        try {
            return (String) ReflectionHelper.findField(GuiIngame.class, "displayedTitle", "field_175201_x").get(Minecraft.getMinecraft().ingameGUI);
        } catch (IllegalAccessException e) {}
        return "";
    }
    public static String getCurrentSubTitle(){
        try {
            return (String) ReflectionHelper.findField(GuiIngame.class, "displayedSubTitle", "field_175200_y").get(Minecraft.getMinecraft().ingameGUI);
        } catch (IllegalAccessException e) {}
        return "";
    }

 

it should actually be safe to copypaste, i'v put it in my reference class and i can just call it whenever..

  • Like 1

Doing stuff n' things

Posted

Look at the

CommandTitle

class to see how it sends the title to the client, then look at how that packet's handler method sets the current title.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Posted

Look at the

CommandTitle

class to see how it sends the title to the client, then look at how that packet's handler method sets the current title.

that does not help me... i looked and i think im not qualafied to search stuff because i got nowhere :D

could someone give me the piece of code that get the title and another that gets the subtitle please?

Doing stuff n' things

Posted

someone? i really have no clue how to look up things inside existing code... i looked at the SPacketTitle and i looked at GuiIngame..

i dont seem to find a way to extract the 2 strings...

please someone help i cant do anything until i get this working...

Doing stuff n' things

Posted

What "didn't work"?

Show your attempt and any errors.

listen, i am an idiot... im starting to learn java now and im too stupid to understand the way i just look at code.... from what i understood, i cannot take protected arguments and plain ol' nonstatic arguments from the GuiIngame class....

 

so please for the love of god just explain to me how im supposed to take this out of there into a class of mine.

Doing stuff n' things

Posted

Well, see, now we have an actual question (at least somewhat).

 

You can use Reflection to access fields that were otherwise inaccessible to you. And yes, since the fields are not static you need an instance of

GuiIngame

to access them, this is

Minecraft#guiIngame

. How to get the

Minecraft

instance?

Minecraft.getMinecraft

.

 

And now, let me show you the process of how to find this information on your own so you can learn and do it yourself in the future:

now i understand what i need to get.. but again i have no idea about Reflection because i never used it and online really cant explain it...

i would really love to know how do i use it to extract these protected Strings:

/** The current title displayed */
protected String displayedTitle = "";
/** The current sub-title displayed */
protected String displayedSubTitle = "";

i understand that i am calling for "Minecraft.getMinecraft().ingameGui.[protected unaccessable]

but still i cant figure it out...

Doing stuff n' things

Posted

online really cant explain it...

Sure it can. What have you tried so far?

 

so i tried this on a chat event:

        the event also has throws Exception cuz i had to
        GuiIngame newgui = new GuiIngame(Minecraft.getMinecraft());
        Field field = Reference.getField(newgui.getClass(), "displayedTitle");
        Reference.makeAccessible(field);
        System.out.println(field.get(newgui));

and my reference class has:

    public static Field getField(Class clazz, String fieldName) throws NoSuchFieldException {
        try {
            return clazz.getDeclaredField(fieldName);
        } catch (NoSuchFieldException e) {
            Class superClass = clazz.getSuperclass();
            if (superClass == null) {
                throw e;
            } else {
                return getField(superClass, fieldName);
            }
        }
    }
    public static void makeAccessible(Field field) {
        if (!Modifier.isPublic(field.getModifiers()) ||
                !Modifier.isPublic(field.getDeclaringClass().getModifiers()))
        {
            field.setAccessible(true);
        }
    }

and it just outputs to log empty lines(well not empty, they have the [15:55:35] [Client thread/INFO]: [com.SHsuperCM.ElytraMCMod.MapInfo.MapChatHandler:getChatEvent:69]: )

 

Doing stuff n' things

Posted

Ok, that's way too much crap.

 

private static final titleField = ReflectionHelper.findField(GuiIngame.class, "displayedTitle", "field_175201_x");
private static final subtitleField = ReflectionHelper.findField(GuiIngame.class, "displayedSubTitle", "field_175200_y");

soooo sorry for bothering the modder support so much but how do i use it? i have no idea what is the field object..

Doing stuff n' things

Posted

The

Field

object is a representation of, well, the field in code. You can get it's name (

getName

) and other metadata or you can read it's current value using the

get

method.

what do i do in the get method? i tried that with Minecraft.getMinecraft() and i cant think of anything else that should be there?

Doing stuff n' things

Posted

Read the documentation for it, it is worded pretty clearly:

Returns the value of the field represented by this Field, on the specified object.

[...]The underlying field's value is obtained as follows:

If the underlying field is a static field, the obj argument is ignored; it may be null.

Otherwise, the underlying field is an instance field. If the specified obj argument is null, the method throws a NullPointerException. If the specified object is not an instance of the class or interface declaring the underlying field, the method throws an IllegalArgumentException.

[...]

 

so i ended up with this:

if(msg.contains("what's the title?")){
            Field titleField = ReflectionHelper.findField(GuiIngame.class, "displayedTitle", "field_175201_x");
            System.out.println(titleField.get(null));
        }

and it didnt work...

Doing stuff n' things

Posted

it dumps this in the console:

[22:01:07] [Client thread/FATAL]: Error executing task
java.util.concurrent.ExecutionException: java.lang.NullPointerException
at java.util.concurrent.FutureTask.report(FutureTask.java:122) ~[?:1.8.0_92]
at java.util.concurrent.FutureTask.get(FutureTask.java:192) ~[?:1.8.0_92]
at net.minecraft.util.Util.runTask(Util.java:26) [util.class:?]
at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:1107) [Minecraft.class:?]
at net.minecraft.client.Minecraft.run(Minecraft.java:404) [Minecraft.class:?]
at net.minecraft.client.main.Main.main(Main.java:118) [Main.class:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_92]
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_92]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_92]
at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_92]
at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) [launchwrapper-1.12.jar:?]
at net.minecraft.launchwrapper.Launch.main(Launch.java:28) [launchwrapper-1.12.jar:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_92]
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_92]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_92]
at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_92]
at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97) [start/:?]
at GradleStart.main(GradleStart.java:26) [start/:?]
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_92]
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_92]
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_92]
at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_92]
at com.intellij.rt.execution.application.AppMain.main(AppMain.java:134) [idea_rt.jar:?]
Caused by: java.lang.NullPointerException
at sun.reflect.UnsafeFieldAccessorImpl.ensureObj(UnsafeFieldAccessorImpl.java:57) ~[?:1.8.0_92]
at sun.reflect.UnsafeObjectFieldAccessorImpl.get(UnsafeObjectFieldAccessorImpl.java:36) ~[?:1.8.0_92]
at java.lang.reflect.Field.get(Field.java:393) ~[?:1.8.0_92]
at com.SHsuperCM.ElytraMCMod.MapInfo.MapChatHandler.getChatEvent(MapChatHandler.java:80) ~[MapChatHandler.class:?]
at net.minecraftforge.fml.common.eventhandler.ASMEventHandler_8_MapChatHandler_getChatEvent_ClientChatReceivedEvent.invoke(.dynamic) ~[?:?]
at net.minecraftforge.fml.common.eventhandler.ASMEventHandler.invoke(ASMEventHandler.java:49) ~[ASMEventHandler.class:?]
at net.minecraftforge.fml.common.eventhandler.EventBus.post(EventBus.java:140) ~[EventBus.class:?]
at net.minecraftforge.event.ForgeEventFactory.onClientChat(ForgeEventFactory.java:269) ~[ForgeEventFactory.class:?]
at net.minecraft.client.network.NetHandlerPlayClient.handleChat(NetHandlerPlayClient.java:887) ~[NetHandlerPlayClient.class:?]
at net.minecraft.network.play.server.SPacketChat.processPacket(SPacketChat.java:54) ~[sPacketChat.class:?]
at net.minecraft.network.play.server.SPacketChat.processPacket(SPacketChat.java:11) ~[sPacketChat.class:?]
at net.minecraft.network.PacketThreadUtil$1.run(PacketThreadUtil.java:15) ~[PacketThreadUtil$1.class:?]
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_92]
at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_92]
at net.minecraft.util.Util.runTask(Util.java:25) ~[util.class:?]
... 20 more

Doing stuff n' things

Posted

You disregarded everything I previously said in this thread AND you disregarded the documentation I quoted.

 

Good job.

it seems that whatever i try with

private static final titleField = ReflectionHelper.findField(GuiIngame.class, "displayedTitle", "field_175201_x");
private static final subtitleField = ReflectionHelper.findField(GuiIngame.class, "displayedSubTitle", "field_175200_y");

just doesnt work... first from my knowledge of java you cant just do public static final titlefield =

it says no identifier...

and if i fix it from what it returns to get it into an actuall object it just thows errors whatever i do with it..

im currently laughing on how i cant understand anything in lyfe but i really need this to work so i can keep on moddin'

Doing stuff n' things

Posted

first from my knowledge of java you cant just do public static final titlefield =
What. Of course you can. That's how you declare fields.

 

You call get() on these things with

Minecraft.getMinecraft().ingameGui

as the argument. Seriously, this is simple.

 

diesieben again thank you so much for all the help!

i finally figured it out!

 

 

for people from the future that want to know what i did, this for Title:

String title = (String) ReflectionHelper.findField(GuiIngame.class, "displayedTitle", "field_175201_x").get(Minecraft.getMinecraft().ingameGUI);

 

and this for subtitle:

String title = (String) ReflectionHelper.findField(GuiIngame.class, "displayedSubTitle", "field_175200_y").get(Minecraft.getMinecraft().ingameGUI);

Doing stuff n' things

Posted

Don't look up the field every single time... Store them! Like I already showed you.

its not letting me do that... but what does looking each time hurt it?

its working fine for what im doing...

Doing stuff n' things

Posted

its not letting me do that...
Show what you tried.
but what does looking each time hurt it?
Because looking up the field is slower than dial-up.

just putting what you said throws a bunch of errors identifier required... i dont need to work on this part currently because its not slowing down anything for me... if it becomes a giant issue than ill go again to it but now im working on other parts of my mod...

its working now and that's what matters.....

Doing stuff n' things

  • 6 years later...
Posted
On 7/4/2016 at 3:13 AM, SHsuperCM said:

it seems that whatever i try with

 

just doesnt work... first from my knowledge of java you cant just do public static final titlefield =

it says no identifier...

and if i fix it from what it returns to get it into an actuall object it just thows errors whatever i do with it..

im currently laughing on how i cant understand anything in lyfe but i really need this to work so i can keep on moddin'

judge the NullUnexpection plsss :)

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
    • Do you use features of inventory profiles next (ipnext) or is there a change without it?
    • Remove rubidium - you are already using embeddium, which is a fork of rubidium
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.