[1.8.9] Deal damage at looking entity

[JimiIT92]

What i'm trying to do is to deal damage to an entity or a player i'm looking at. If is a player the damage is based on his health. I already got working the "get the entity a player is looking at" part, so if i look, for instance a cow, the code knows that the player is looking a cow. What is not working is the damage part. At the moment i have this

if (Minecraft.getMinecraft().objectMouseOver != null
				&& Minecraft.getMinecraft().objectMouseOver.entityHit != null) {
			if (Minecraft.getMinecraft().objectMouseOver.entityHit instanceof EntityLiving) {
				Entity target = Minecraft.getMinecraft().objectMouseOver.entityHit;
				if (target instanceof EntityPlayer)
					target.attackEntityFrom(DamageSource.generic,
							1.0F + (10.0F - ((EntityPlayer) target).getHealth()));
				else
					target.attackEntityFrom(DamageSource.generic, 10.0F);
			}
		}

 

Wich will get the entity the player is looking and will damage it. But for some reason the attackEntityFrom method doesn't work Any idea of why this doesn't?

[JimiIT92]

So i've tried doing this, checking if the world is not remote

if (Minecraft.getMinecraft().objectMouseOver != null
				&& Minecraft.getMinecraft().objectMouseOver.entityHit != null) {
			if (Minecraft.getMinecraft().objectMouseOver.entityHit instanceof EntityLiving  && !player.worldObj.isRemote) {
				Entity target = Minecraft.getMinecraft().objectMouseOver.entityHit;
				if (target instanceof EntityPlayer)
					target.attackEntityFrom(DamageSource.generic,
							1.0F + (10.0F - ((EntityPlayer) target).getHealth()));
				else
					target.attackEntityFrom(DamageSource.generic, 10.0F);
			}
		}

But it still doesn't deal damage

[Ernio]

http://mcforge.readthedocs.org/en/latest/concepts/sides/

 

Checking if you are on server thread while being on client will do nothing...

You need to call code on server.

 

Aside from that - Minecraft is client-only class, you can't use #objectMouseOver like that. You need to recreate ray tracing on server side (lookup raytrace methods). If you'd update 1.9+ I think everything is taken care of (server-sided methods exist).