Jump to content

Mod works fine from IntelliJ/Eclipse, but not when exported as JAR


Recommended Posts

Posted

So, Ive made a simple mod that basically listens for a BlockEvent.BreakEvent event, then figures out which direction the player is facing, and scans the next 30 blocks ahead for diamonds or any other valuable ore, and outputs the results in text format. It works fine when running it from IntelliJ and in a simple test world thatI have created, but when I build a JAR and put the JAR in my mod folder for my regular minecraft install (with the correct forgemod version installed of course), it causes all sorts of problems. First, when breaking a block, the block disappears, but its still there, as u are not able to move into it. Its like its invisible. And the text doesnt appear either. And after a while, minecraft crashes....any tips?

 

Here is the code from my event handler

 

    private static final int RANGE = 30;
    private static Set<String> skipList = new HashSet<String>();

    static {
        skipList.add("tile.stone");
        skipList.add("tile.dirt");
        skipList.add("tile.grass");
        skipList.add("tile.tallgrass");
        skipList.add("tile.log");
        skipList.add("tile.leaves");
        skipList.add("tile.vine");
    }

    @SubscribeEvent
    public void sendMessage(BlockEvent.BreakEvent event) {

        EntityPlayer player = event.getPlayer();
        World world = player.getEntityWorld();
        BlockPos playerPos = player.getPosition();
        int x = playerPos.getX();
        int y = playerPos.getY();
        int z = playerPos.getZ();
        Map<String, Integer> blocksCount = new HashMap<String, Integer>();

        // Figure out what direction the player is looking at
        Vec3d lookVec = player.getLookVec();
        double lookX = lookVec.xCoord;
        double lookY = lookVec.yCoord;
        double lookZ = lookVec.zCoord;
        double factor = 0.8;
        if (Math.abs(lookX) > factor) {
            //showMessage(player, "Player is facing X (" + lookX+ ")");

            if (lookX < 0.0f) {
                for (int i = 1; i <= RANGE; i++) {
                    Block block = world.getBlockState(new BlockPos(x - i, y, z)).getBlock();
                    countBlock(block, blocksCount);
                }
            } else {
                for (int i = 1; i <= RANGE; i++) {
                    Block block = world.getBlockState(new BlockPos(x + i, y, z)).getBlock();
                    countBlock(block, blocksCount);
                }
            }

        }
        else if (Math.abs(lookY) > factor) {
            //showMessage(player, "Player is facing Y (" + lookY+ ")");

            if (lookY < 0.0f) {
                for (int i = 1; i <= RANGE; i++) {
                    Block block = world.getBlockState(new BlockPos(x, y - i, z)).getBlock();
                    countBlock(block, blocksCount);
                }
            } else {
                for (int i = 1; i <= RANGE; i++) {
                    Block block = world.getBlockState(new BlockPos(x, y + i, z)).getBlock();
                    countBlock(block, blocksCount);
                }
            }

        }
        else if (Math.abs(lookZ) > factor) {
            //showMessage(player, "Player is facing Z (" + lookZ+ ")");


            if (lookZ < 0.0f) {
                for (int i = 1; i <= RANGE; i++) {
                    Block block = world.getBlockState(new BlockPos(x, y, z - i)).getBlock();
                    countBlock(block, blocksCount);
                }
            } else {
                for (int i = 1; i <= RANGE; i++) {
                    Block block = world.getBlockState(new BlockPos(x, y, z + i)).getBlock();
                    countBlock(block, blocksCount);
                }
            }
        }

        if (!blocksCount.isEmpty()){
            showMessage(player, blocksCount.toString());
        }


        event.setResult(Event.Result.ALLOW);

    }

    private void countBlock(Block block, Map<String, Integer> blocksCount) {
        String name = block.getUnlocalizedName();

        if (skipList.contains(name)) {
            // We dont care about blocks on the skip list
            return;
        }

        if (blocksCount.containsKey(name)) {
            int curVal = blocksCount.get(name);

            blocksCount.put(name, ++curVal);
        } else {
            blocksCount.put(name, 1);
        }

    }

    private void showMessage(EntityPlayer player, String message) {
        TextComponentString textComponents = new TextComponentString(message);
        player.addChatMessage(textComponents);
    }

Posted

You are aware that you dont use the IDE building right?

You need to run gradlew building in the workspace and use the mod from building folder im pretty sure... 

 

#phonekeyboard

 

Doing stuff n' things

Posted

Thanks for the reply. Im using the "jar" gradle task from IntelliJ, which outputs a JAR file in the build directory. I was thinking that was the finished "product" that I could drop into any mod folder in my minecraft installation (with forge installed ofc. But I guess its not the case?

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Make a test with another Launcher like the Curseforge Launcher, MultiMC or AT Launcher
    • can anyone help me i am opening forge and add modpacks and then it says unable to update native luancher and i redownlaod java and the luancher it self?
    • The problem occurs also in 1.20.1 Forge, but with an "Error executing task on client" instead. I have "Sinytra Connector" installed. On 1.21.5 Fabric, there is no problem. When this happens, the chat message before the death screen appears gets sent, with an extra dash added.
    • Well, as usual, it was user error. Naming mismatch in sounds.json.  Please delete this post if you find it necessary. 
    • Hello Forge community.  I'm running into an issue with a mod I'm working on.  To preface, I can call /playsound modId:name music @a and I can hear the sound I registered being played in game. Great!  However, I cannot get it to trigger via my mod code.    Registration: public static final RegistryObject<SoundEvent> A_WORLD_OF_MADNESS = SOUND_EVENTS.register("a_world_of_madness", () -> new SoundEvent(new ResourceLocation("tetheredsouls", "a_world_of_madness")));   Playback: Minecraft mc = Minecraft.getInstance(); if (!(mc.player instanceof LocalPlayer) || mc.level == null) return; LocalPlayer player = (LocalPlayer) mc.player; BlockPos pos = player.blockPosition(); SoundEvent track = ModSounds.A_WORLD_OF_MADNESS.get(); System.out.println(track); System.out.println(pos); System.out.println(player); // play exactly like the tutorial: client-only, at the player's position try { mc.level.playLocalSound( player.getX(), player.getY(), player.getZ(), track, SoundSource.MUSIC, // Or MASTER if needed 1f, 1f, false ); System.out.println("[DEBUG] playSound success: " + track.getLocation()); } catch (Exception e) { System.err.println("[ERROR] Failed to play sound: " + track.getLocation()); e.printStackTrace(); } Sounds.json:   { "theme_of_laura": { "category": "music", "sounds": [ { "name": "tetheredsouls:a_world_of_madness", "stream": true } ] } } Things I have tried: - multiple .ogg files. Short .ogg files (5 seconds, <100KB).  - default minecraft sounds imported from import net.minecraft.sounds.SoundEvents; These work given my code. No idea why these are different.  - playSound() method, as well as several others in past iterations that did not work   I would be forever grateful if somebody could point me in the right direction. I've looked at several mod github repositories and found extremely similar code to what I'm doing. I've also found several threads in this forum that did not solve my issue. I just cannot figure out what I'm doing differently, and why I'm able to queue sounds manually with playsound but the code won't play it (despite confirming the code is being run with the debug statements.)
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.