Jump to content

Recommended Posts

Posted

Manage to find a way out but isn't perfect since if i get the item from creative menu it wont came with the Attribute Modifier.

 

ItemStack swordStack = new ItemStack(TutorialItems.super_cheaty_sword);
swordStack.setStackDisplayName("Not a cheaty sword");
final UUID ATTACK_DAMAGE_MODIFIER = UUID.fromString("CB3F55D3-645C-4F38-A497-9C13A33DB5CF");
final UUID ATTACK_SPEED_MODIFIER = UUID.fromString("FA233E1C-4180-4865-B01B-BCCE9785ACA3");
swordStack.addAttributeModifier(SharedMonsterAttributes.ATTACK_DAMAGE.getAttributeUnlocalizedName(),
        new AttributeModifier(ATTACK_DAMAGE_MODIFIER, "Weapon modifier", (double)40, 0),
        EntityEquipmentSlot.MAINHAND);
swordStack.addAttributeModifier(SharedMonsterAttributes.ATTACK_SPEED.getAttributeUnlocalizedName(),
        new AttributeModifier(ATTACK_SPEED_MODIFIER, "Weapon modifier", (double)10, 0),
        EntityEquipmentSlot.MAINHAND);
String[] cheatySwordCraft = {"CCC", "CDC", "CCC"};
GameRegistry.addShapedRecipe(swordStack, cheatySwordCraft[0],
        cheatySwordCraft[1], cheatySwordCraft[2], 'C', TutorialItems.custom_item, 'D', Items.DIAMOND_SWORD);

 

Can someone help me with the creative tab issue?

 

Source:

Posted

Override

Item#getAttributeModifiers

to do the following:

  • Call the super method.
  • Check that the
    EntityEquipmentSlot

    argument is

    EntityEquipmentSlot.MAINHAND

    .

  • If it is, replace the modifiers with the IDs
    Item.ATTACK_DAMAGE_MODIFIER

    and

    Item.ATTACK_SPEED_MODIFIER

    (use the existing fields rather than calling

    UUID.fromString

    ) in the

    Multimap

    with your own modifiers.

  • Return the
    Multimap

    .

 

I have an example of this here.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Posted

Thank you, it worked here but i had to reimplemented like this since i was recieving errors from the java lambda expression not being supported.

 

private void replaceModifier(Multimap<String, AttributeModifier> modifierMultimap,
                             IAttribute attribute, UUID id, double multiplier) {
    // Get the modifiers for the specified attribute
    final Collection<AttributeModifier> modifiers = modifierMultimap.get(attribute.getAttributeUnlocalizedName());
    AttributeModifier selectedModifier = null;
    for (AttributeModifier modifier: modifiers) {
        if (modifier.getID().equals(id)) {
            selectedModifier = modifier;
            break;
        }
    }
    if (selectedModifier != null) {
        modifiers.remove(selectedModifier);
        modifiers.add(new AttributeModifier(selectedModifier.getID(), selectedModifier.getName(),
                selectedModifier.getAmount() * multiplier, selectedModifier.getOperation()));
    }
}

Previous error: “lambda expressions not supported at this language level”

Posted

Just a quick question about other AttributeModifier. I'm able to add Knockack resistance to an armor like this:

@Override
public Multimap<String, AttributeModifier> getAttributeModifiers(EntityEquipmentSlot slot, ItemStack stack) {
    final Multimap<String, AttributeModifier> modifiers = super.getAttributeModifiers(slot, stack);
    if (slot == EQUIPMENT_SLOT) {
        modifiers.put(SharedMonsterAttributes.KNOCKBACK_RESISTANCE.getAttributeUnlocalizedName(),
                new AttributeModifier(SharedMonsterAttributes.KNOCKBACK_RESISTANCE.getAttributeUnlocalizedName(), (double)20, 0));
    }
    return modifiers;
}

Is this the best way to do it? I couldn't find the UUID either know what modifiers are those at ItemArmor

private static final UUID[] ARMOR_MODIFIERS = new UUID[] {UUID.fromString("845DB27C-C624-495F-8C9F-6020A9A58B6B"), UUID.fromString("D8499B04-0E66-4726-AB29-64469D734E0D"), UUID.fromString("9F3D476D-C118-4544-8365-64846904B48E"), UUID.fromString("2AD3F246-FEE1-4E67-B886-69FD380BB150")};

Posted

You should use the existing

ItemArmor#armorType

field to get the

EntityEquipmentSlot

of an

ItemArmor

instance rather than creating your own field.

 

The

ItemArmor.ARMOR_MODIFIERS

array contains the

UUID

s used for the

SharedMonsterAttributes.ARMOR

and

SharedMonsterAttributes.ARMOR_TOUGHNESS

modifiers provided by each piece of armour (see

ItemArmor#getItemAttributeModifiers

). It uses the return of

EntityEquipmentSlot#getIndex

as the index.

 

You should create your own UUID for your modifier. Call

UUID.randomUUID

once at startup to generate a random UUID, then write it to the log. Create a

private static final

field of type

UUID

in your armour class and initialise it by calling

UUID.fromString

with the UUID that was printed to the log. Use this field as the ID of your modifier.

 

Side note: You don't need to cast from

int

to

double

, Java will automatically convert numeric types to "wider" types. You only see these casts in vanilla code because the compiler automatically generates them.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hello all. I'm currently grappling with the updateShape method in a custom class extending Block.  My code currently looks like this: The conditionals in CheckState are there to switch blockstate properties, which is working fine, as it functions correctly every time in getStateForPlacement.  The problem I'm running into is that when I update a state, the blocks seem to call CheckState with the position of the block which was changed updated last.  If I build a wall I can see the same change propagate across. My question thus is this: is updateShape sending its return to the neighbouring block?  Is each block not independently executing the updateShape method, thus inserting its own current position?  The first statement appears to be true, and the second false (each block is not independently executing the method). I have tried to fix this by saving the block's own position to a variable myPos at inception, and then feeding this in as CheckState(myPos) but this causes a worse outcome, where all blocks take the update of the first modified block, rather than just their neighbour.  This raises more questions than it answers, obviously: how is a different instance's variable propagating here?  I also tried changing it so that CheckState did not take a BlockPos, but had myPos built into the body - same problem. I have previously looked at neighbourUpdate and onNeighbourUpdate, but could not find a way to get this to work at all.  One post on here about updatePostPlacement and other methods has proven itself long superceded.  All other sources on the net seem to be out of date. Many thanks in advance for any help you might offer me, it's been several days now of trying to get this work and several weeks of generally trying to get round this roadblock.  - Sandermall
    • sorry, I might be stupid, but how do I open it? because the only options I have are too X out, copy it, which doesn't work and send crash report, which doesn't show it to me, also, sorry for taking so long.
    • Can you reproduce this with version 55.0.21? A whole lot of plant placement issues were just fixed in this PR.
    • Necro'ing that thread to ask if you found a solution ? I'm encountering the same crash on loading the world. I created the world in Creative to test my MP, went into survival to test combat, died, crashed on respawn and since then crash on loading the world. Deactivating Oculus isn't fixing it either, and I don't have Optifine (Twilight forest is incompatible)
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.