Search the Forums BEFORE making a new post.

Currently supported: All versions

[SOLVED]Help with onItemRightClick method

Posted December 10, 20168 yr

Hello i am getting an error when right clicking in game

[16:58:12] [server thread/FATAL]: Error executing task

java.util.concurrent.ExecutionException: java.lang.NullPointerException

at java.util.concurrent.FutureTask.report(FutureTask.java:122) ~[?:1.8.0_112]

at java.util.concurrent.FutureTask.get(FutureTask.java:192) ~[?:1.8.0_112]

at net.minecraft.util.Util.runTask(Util.java:26) [util.class:?]

at net.minecraft.server.MinecraftServer.updateTimeLightAndEntities(MinecraftServer.java:742) [MinecraftServer.class:?]

at net.minecraft.server.MinecraftServer.tick(MinecraftServer.java:687) [MinecraftServer.class:?]

at net.minecraft.server.integrated.IntegratedServer.tick(IntegratedServer.java:156) [integratedServer.class:?]

at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:536) [MinecraftServer.class:?]

at java.lang.Thread.run(Thread.java:745) [?:1.8.0_112]

Caused by: java.lang.NullPointerException

at com.drsteam1111.drbit.item.ItemNecklessOfDeath.onItemRightClick(ItemNecklessOfDeath.java:35) ~[itemNecklessOfDeath.class:?]

at net.minecraft.item.ItemStack.useItemRightClick(ItemStack.java:176) ~[itemStack.class:?]

at net.minecraft.server.management.PlayerInteractionManager.processRightClick(PlayerInteractionManager.java:391) ~[PlayerInteractionManager.class:?]

at net.minecraft.network.NetHandlerPlayServer.processPlayerBlockPlacement(NetHandlerPlayServer.java:740) ~[NetHandlerPlayServer.class:?]

at net.minecraft.network.play.client.CPacketPlayerTryUseItem.processPacket(CPacketPlayerTryUseItem.java:43) ~[CPacketPlayerTryUseItem.class:?]

at net.minecraft.network.play.client.CPacketPlayerTryUseItem.processPacket(CPacketPlayerTryUseItem.java:9) ~[CPacketPlayerTryUseItem.class:?]

at net.minecraft.network.PacketThreadUtil$1.run(PacketThreadUtil.java:15) ~[PacketThreadUtil$1.class:?]

at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) ~[?:1.8.0_112]

at java.util.concurrent.FutureTask.run(FutureTask.java:266) ~[?:1.8.0_112]

at net.minecraft.util.Util.runTask(Util.java:25) ~[util.class:?]

... 5 more

Heres my Code:

@Override

public ActionResult<ItemStack> onItemRightClick(ItemStack itemStack, World world, EntityPlayer player, EnumHand hand) {

if(!world.isRemote) {

if(player.getHeldItemOffhand().getItem() == itemStack.getItem() && player.getHeldItemMainhand().getItem() == itemStack.getItem()) {

} else if (player.getHeldItemOffhand().getItem() == itemStack.getItem() || player.getHeldItemMainhand().getItem() == itemStack.getItem()){

player.addPotionEffect(new PotionEffect(Potion.getPotionById(6), 1, 2, false, false));

player.addChatComponentMessage(new TextComponentString("You Drain Strength From The Dead"));

player.setHealth(player.getHealth() - 4f);

return ActionResult.newResult(EnumActionResult.SUCCESS, itemStack);

}

return super.onItemRightClick(itemStack, world, player, hand);

}

Does any one know what the problem is?

Quote

December 10, 20168 yr

What if one of the hands contains nothing? Hint: it returns

null

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

1.12 -> 1.13 primer by williewillus.

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

http://www.howoldisminecraft1710.today/

Quote

December 10, 20168 yr

Author

What if one of the hands contains nothing? Hint: it returns
null
.

changed the code to

if(player.getHeldItemOffhand().getItem() == ModItems.neckless_of_death && player.getHeldItemMainhand().getItem() == null || player.getHeldItemOffhand().getItem() == null && player.getHeldItemMainhand().getItem() == ModItems.neckless_of_death) {

player.addPotionEffect(new PotionEffect(Potion.getPotionById(6), 1, 2, false, false));

player.addChatComponentMessage(new TextComponentString("You Drain Strength From The Dead"));

player.setHealth(player.getHealth() - 4f);

return ActionResult.newResult(EnumActionResult.SUCCESS, itemStack);

}

Quote

December 10, 20168 yr

No.

getHeldItem*hand()

returns

null

, not

getItem()

. Check if

getHeldItem*hand()

is not equal to

null

, then try to get the

Item

from it.

Don't PM me with questions. They will be ignored! Make a thread on the appropriate board for support.

1.12 -> 1.13 primer by williewillus.

1.7.10 and older versions of Minecraft are no longer supported due to it's age! Update to the latest version for support.

http://www.howoldisminecraft1710.today/

Quote

December 10, 20168 yr

Author

No.
getHeldItem*hand()
returns
null
, not
getItem()
. Check if
getHeldItem*hand()
is not equal to
null
, then try to get the
Item
from it.

got it working with

if(player.getHeldItemMainhand() != null && player.getHeldItemMainhand().getItem() == itemStack.getItem() && player.getHeldItemOffhand() == null) {

player.addPotionEffect(new PotionEffect(Potion.getPotionById(5), 1200, 2, false, false));

player.addChatComponentMessage(new TextComponentString("You Drain Strength From The Dead"));

player.setHealth(player.getHealth() - 4f);

return ActionResult.newResult(EnumActionResult.SUCCESS, itemStack);

} else if (player.getHeldItemOffhand() != null && player.getHeldItemOffhand().getItem() == itemStack.getItem() && player.getHeldItemMainhand() == null) {

player.addPotionEffect(new PotionEffect(Potion.getPotionById(5), 1200, 2, false, false));

player.addChatComponentMessage(new TextComponentString("You Drain Strength From The Dead"));

player.setHealth(player.getHealth() - 4f);

return ActionResult.newResult(EnumActionResult.SUCCESS, itemStack);

Thank You!

Quote

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.

Reply to this topic...

https://forums.minecraftforge.net/topic/43659-solvedhelp-with-onitemrightclick-method/

Followers

Go to topic listing

IPS spam blocked by CleanTalk.

Announcements

How to change player renderer and transform model parts?

I have been trying for a while now to make a custom player renderer, and replace the vanilla player renderer with it. So far I've come up with a custom player renderer class that extends vanilla PlayerRenderer:
package com.FireDude123.BOTW.entity.renderer; import com.mojang.blaze3d.vertex.PoseStack; import net.minecraft.client.player.AbstractClientPlayer; import net.minecraft.client.renderer.MultiBufferSource; import net.minecraft.client.renderer.entity.player.PlayerRenderer; import net.minecraft.client.renderer.entity.EntityRendererProvider; import net.minecraftforge.client.event.RenderPlayerEvent; import net.minecraftforge.common.MinecraftForge; public class PoseablePlayerRenderer extends PlayerRenderer { public PoseablePlayerRenderer(EntityRendererProvider.Context ctx, boolean slim) { super(ctx, slim); System.out.println("here too"); } @Override public void render(AbstractClientPlayer p_117788_, float p_117789_, float p_117790_, PoseStack poseStack, MultiBufferSource p_117792_, int p_117793_) { System.out.println("didnt get here lol"); model.leftArm.xRot=(float)Math.toRadians(160); super.render(p_117788_, p_117789_, p_117790_, poseStack, p_117792_, p_117793_); } } As you can see, the intended purpose of this is to raise the player's left arm by 160 degrees. However, combined with this logic in ClientModEvents:
@Mod.EventBusSubscriber(modid = MODID, bus = Mod.EventBusSubscriber.Bus.MOD, value = Dist.CLIENT) public static class ClientModEvents { @SubscribeEvent public static void onClientSetup(FMLClientSetupEvent event) { EntityRenderers.register((EntityType<? extends AbstractClientPlayer>)(EntityType<?)EntityType.PLAYER, ctx -> new PoseablePlayerRenderer(ctx, true)); EntityRenderers.register(Entities.MAGNESIS_BLOCK.get(), com.FireDude123.BOTW.entity.renderer.BlockDisplayRenderer::new); EntityRenderers.register(Entities.REMOTE_BOMB.get(), ThrownItemRenderer::new); EntityRenderers.register(Entities.CRYONIS_ICE.get(), com.FireDude123.BOTW.entity.renderer.BlockDisplayRenderer::new); EntityRenderers.register(Entities.STASIS_BLOCK.get(), FallingBlockRenderer::new); } @SubscribeEvent public static void registerLayerDefinitions(EntityRenderersEvent.RegisterLayerDefinitions event) { event.registerLayerDefinition(new ModelLayerLocation(new ResourceLocation(BOTW.MODID, "paraglider"), "main"), ParagliderLayer::createBodyLayer); } }(I also have a paraglider layer here for something else, it's working perfectly fine, also I used the slim setting because the player is slim in 1.20.1 forge)
This logic isn't replacing the renderer, as far as I can tell. Can someone please advise as to why, and how to fix it?

By FireDude123 · Posted 20 hours ago20 hr
How to add my mob to another mod's biome in 1.20.1.

I'm on 1.20.1 and was wondering if there was a way to add a mob I am going to make to a other mod's biome (Regions Unexplored in this case). I am trying to figure this out before I start coding the mod. Could someone point me to a good guide on this? I saw some things about biome modifier's but all the resources are either to short, unhelpful or for a different version. Thanks in advance. (i am a beginner but i have java and modding knowledge so this isn't like a "i am new and don't know anything about coding" problem btw)

By ilov3gam3z · Posted Yesterday at 04:08 PM1 day
Help with file conversion

Many Forge users seek help with file conversions. Similarly, managing your health can benefit from structured tools like the https://wellness-app.com/calculator/fasting-calculator/ and a free intermittent fasting calculator. These tools help you plan and personalize your fasting and eating windows based on your lifestyle and goals. By entering your preferred fasting duration and meal times, you receive a tailored schedule that makes intermittent fasting easier to follow. Just as mastering file conversions improves modding success, using a fasting calculator brings clarity and structure to your health routine, supporting better results over time.

By Brialeblanc · Yesterday at 10:34 AM1 day
Cobblemon invalid player data

Hi everyone, I keep getting "invalid player data" when trying to log onto my friend's server. Log analysis says to remove Night Lights and ImmediatelyFast, but that doesn't work. Any insight is appreciated

Log: https://mclo.gs/uj6pMkd

By CobbleDN · Posted Yesterday at 04:14 AM1 day
Bad pathfinding for big mobs (1.21.1)

I've struggled with this for way too long now, so I have decided to ask for some assistance here because there is almost no information about this online.

I made a hostile mob and I built it like this:
public static final Supplier<EntityType<Bunyip>> BUNYIP = ENTITY_TYPES.register("bunyip" , () -> EntityType.Builder. of(Bunyip::new, MobCategory.MONSTER).sized(3f, 2.5f).eyeHeight(1.75f).build("bunyip"));

However, I have discovered that a BoundingBox of 3 is too big for the vanilla pathfinding to work well. In fact, anything bigger than a block will not work well. This is especially noticeable when having it chase a player in a negative X and/or negative Z direction. The mob starts spinning, walking backwards, walking diagonally, etc.

I am using the Goal system:
protected void registerGoals() { super.registerGoals(); this.goalSelector.addGoal(1, new MeleeAttackGoal(this, 1.25, true)); this.targetSelector.addGoal(2, new NearestAttackableTargetGoal<>(this, Player.class, true, true)); }

This does not seem to be a me issue as the ravager, one of the biggest vanilla mobs, also struggles with proper pathfinding. I am a bit familiar with how Minecraft's pathfinding works, but not enough to make a pathfinding system from scratch (or at least not in a reasonable amount of time). Is there any way to fix this with some tweaks or will I have to make a custom pathfinding system?

By VictorEvers · Posted Tuesday at 08:42 PM2 days

There are no registered users currently online

Sign In

[SOLVED]Help with onItemRightClick method

Featured Replies

Join the conversation

Posts

How to change player renderer and transform model parts?

How to add my mob to another mod's biome in 1.20.1.

Help with file conversion

Cobblemon invalid player data

Bad pathfinding for big mobs (1.21.1)

Who's Online (See full list)

Important Information

Account

Navigation

Search

Configure browser push notifications

Chrome (Android)

Chrome (Desktop)

Safari (iOS 16.4+)

Safari (macOS)

Edge (Android)

Edge (Desktop)

Firefox (Android)

Firefox (Desktop)