Jump to content

[SOLVED, I'm incredibly dumb][1.11] Portal vanishes as soon as it is created.


imacatlolol

Recommended Posts

EDIT: I must be either blind, dumb, or both. I finally realized that when I was doing the isEmptyBlock check, I was checking the vanilla portal, not my own. I was so sure that I had replaced all of the vanilla portal-related stuff will me own stuff I was completely oblivious to it. I can't believe I wasted so much time on this  :-[

 


 

I'm attempting to create a custom portal to a custom dimension. I have managed to get the portal to generate correctly under normal circumstances, but ever since I tried to get it to generate from fire (like how the nether portal works) it vanishes as soon as it generates.

 

My portal frame:

public class BlockPortalFrame extends Block {
    public BlockPortalFrame() {
        super(Material.IRON);
        setRegistryName("block_portal_frame");
        setUnlocalizedName("block_portal_frame");
        setCreativeTab(CreativeTab.Mod_TAB);
        setSoundType(SoundType.METAL);
        setResistance(10.0F);
        setHardness(5.0F);
        setLightLevel(0.9F);
        setHarvestLevel("pickaxe", 2);
    }

    @Override
    public void neighborChanged(IBlockState state, World worldIn, BlockPos pos, Block blockIn, BlockPos neighbor) {
        if (worldIn.getBlockState(neighbor).getBlock() == Blocks.FIRE) {
            ModBlocks.BLOCK_PORTAL.trySpawnPortal(worldIn, neighbor);
        }
    }
}

 

My portal block:

public class BlockModPortal extends BlockPortal {

    public BlockModPortal() {
        super();
        setRegistryName("block_portal");
        setUnlocalizedName("block_portal");
        setSoundType(SoundType.GLASS);
        setHardness(-1.0F);
        setLightLevel(0.75F);
    }

    @Override
    @SideOnly(Side.CLIENT)
    public void randomDisplayTick(IBlockState stateIn, World worldIn, BlockPos pos, Random rand) {
        if (rand.nextInt(100) == 0) {
            worldIn.playSound((double)pos.getX() + 0.5D, (double)pos.getY() + 0.5D, (double)pos.getZ() + 0.5D, SoundEvents.BLOCK_PORTAL_AMBIENT, SoundCategory.BLOCKS, 0.5F, rand.nextFloat() * 0.4F + 0.8F, false);
        }

        for (int i = 0; i < 4; ++i) {
            double d0 = (double)((float)pos.getX() + rand.nextFloat());
            double d1 = (double)((float)pos.getY() + rand.nextFloat());
            double d2 = (double)((float)pos.getZ() + rand.nextFloat());
            double d3 = ((double)rand.nextFloat() - 0.5D) * 0.5D;
            double d4 = ((double)rand.nextFloat() - 0.5D) * 0.5D;
            double d5 = ((double)rand.nextFloat() - 0.5D) * 0.5D;
            int j = rand.nextInt(2) * 2 - 1;

            if (worldIn.getBlockState(pos.west()).getBlock() != this && worldIn.getBlockState(pos.east()).getBlock() != this) {
                d0 = (double)pos.getX() + 0.5D + 0.25D * (double)j;
                d3 = (double)(rand.nextFloat() * 2.0F * (float)j);
            }
            else {
                d2 = (double)pos.getZ() + 0.5D + 0.25D * (double)j;
                d5 = (double)(rand.nextFloat() * 2.0F * (float)j);
            }

            worldIn.spawnParticle(EnumParticleTypes.PORTAL, d0, d1, d2, d3, d4, d5, new int[0]);
        }
    }

    @Override
    public boolean trySpawnPortal(World worldIn, BlockPos pos) {
        BlockModPortal.Size blockmodportal$size = new BlockModPortal.Size(worldIn, pos, EnumFacing.Axis.X);

        if (blockmodportal$size.isValid() && blockmodportal$size.portalBlockCount == 0) {
            blockmodportal$size.placePortalBlocks();
            return true;
        }
        else {
            BlockModPortal.Size blockmodportal$size1 = new BlockModPortal.Size(worldIn, pos, EnumFacing.Axis.Z);

            if (blockmodportal$size1.isValid() && blockmodportal$size1.portalBlockCount == 0) {
                blockmodportal$size1.placePortalBlocks();
                return true;
            }
            else {
                return false;
            }
        }
    }

    @Override
    public void neighborChanged(IBlockState state, World worldIn, BlockPos pos, Block blockIn, BlockPos neighbor) {
        EnumFacing.Axis enumfacing$axis = (EnumFacing.Axis)state.getValue(AXIS);

        if (enumfacing$axis == EnumFacing.Axis.X) {
            BlockModPortal.Size blockmodportal$size = new BlockModPortal.Size(worldIn, pos, EnumFacing.Axis.X);

            if (!blockmodportal$size.isValid() || blockmodportal$size.portalBlockCount < blockmodportal$size.width * blockmodportal$size.height) {
                worldIn.setBlockState(pos, Blocks.AIR.getDefaultState());
            }
        }
        else if (enumfacing$axis == EnumFacing.Axis.Z) {
            BlockModPortal.Size blockmodportal$size1 = new BlockModPortal.Size(worldIn, pos, EnumFacing.Axis.Z);

            if (!blockmodportal$size1.isValid() || blockmodportal$size1.portalBlockCount < blockmodportal$size1.width * blockmodportal$size1.height) {
                worldIn.setBlockState(pos, Blocks.AIR.getDefaultState());
            }
        }
    }

    @Override
    public BlockPattern.PatternHelper createPatternHelper(World worldIn, BlockPos blockPos) {
        EnumFacing.Axis enumfacing$axis = EnumFacing.Axis.Z;
        BlockModPortal.Size blockmodportal$size = new BlockModPortal.Size(worldIn, blockPos, EnumFacing.Axis.X);
        LoadingCache<BlockPos, BlockWorldState> loadingcache = BlockPattern.createLoadingCache(worldIn, true);

        if (!blockmodportal$size.isValid()) {
            enumfacing$axis = EnumFacing.Axis.X;
            blockmodportal$size = new BlockModPortal.Size(worldIn, blockPos, EnumFacing.Axis.Z);
        }

        if (!blockmodportal$size.isValid()) {
            return new BlockPattern.PatternHelper(blockPos, EnumFacing.NORTH, EnumFacing.UP, loadingcache, 1, 1, 1);
        }
        else {
            int[] aint = new int[EnumFacing.AxisDirection.values().length];
            EnumFacing enumfacing = blockmodportal$size.rightDir.rotateYCCW();
            BlockPos blockpos = blockmodportal$size.bottomLeft.up(blockmodportal$size.getHeight() - 1);

            for (EnumFacing.AxisDirection enumfacing$axisdirection : EnumFacing.AxisDirection.values()) {
                BlockPattern.PatternHelper blockpattern$patternhelper = new BlockPattern.PatternHelper(enumfacing.getAxisDirection() == enumfacing$axisdirection ? blockpos : blockpos.offset(blockmodportal$size.rightDir, blockmodportal$size.getWidth() - 1), EnumFacing.getFacingFromAxis(enumfacing$axisdirection, enumfacing$axis), EnumFacing.UP, loadingcache, blockmodportal$size.getWidth(), blockmodportal$size.getHeight(), 1);

                for (int i = 0; i < blockmodportal$size.getWidth(); ++i) {
                    for (int j = 0; j < blockmodportal$size.getHeight(); ++j) {
                        BlockWorldState blockworldstate = blockpattern$patternhelper.translateOffset(i, j, 1);

                        if (blockworldstate.getBlockState().getMaterial() != Material.AIR) {
                            ++aint[enumfacing$axisdirection.ordinal()];
                        }
                    }
                }
            }

            EnumFacing.AxisDirection enumfacing$axisdirection1 = EnumFacing.AxisDirection.POSITIVE;

            for (EnumFacing.AxisDirection enumfacing$axisdirection2 : EnumFacing.AxisDirection.values()) {
                if (aint[enumfacing$axisdirection2.ordinal()] < aint[enumfacing$axisdirection1.ordinal()]) {
                    enumfacing$axisdirection1 = enumfacing$axisdirection2;
                }
            }

            return new BlockPattern.PatternHelper(enumfacing.getAxisDirection() == enumfacing$axisdirection1 ? blockpos : blockpos.offset(blockmodportal$size.rightDir, blockmodportal$size.getWidth() - 1), EnumFacing.getFacingFromAxis(enumfacing$axisdirection1, enumfacing$axis), EnumFacing.UP, loadingcache, blockmodportal$size.getWidth(), blockmodportal$size.getHeight(), 1);
        }
    }

    public static class Size {
        private final World world;
        private final EnumFacing.Axis axis;
        private final EnumFacing rightDir;
        private final EnumFacing leftDir;
        private int portalBlockCount;
        private BlockPos bottomLeft;
        private int height;
        private int width;

        public Size(World worldIn, BlockPos blockPos, EnumFacing.Axis axis)
        {
            this.world = worldIn;
            this.axis = axis;

            if (axis == EnumFacing.Axis.X)
            {
                this.leftDir = EnumFacing.EAST;
                this.rightDir = EnumFacing.WEST;
            }
            else
            {
                this.leftDir = EnumFacing.NORTH;
                this.rightDir = EnumFacing.SOUTH;
            }

            for (BlockPos blockpos = blockPos; blockPos.getY() > blockpos.getY() - 21 && blockPos.getY() > 0 && this.isEmptyBlock(worldIn.getBlockState(blockPos.down()).getBlock()); blockPos = blockPos.down())
            {
                ;
            }

            int i = this.getDistanceUntilEdge(blockPos, this.leftDir) - 1;

            if (i >= 0)
            {
                this.bottomLeft = blockPos.offset(this.leftDir, i);
                this.width = this.getDistanceUntilEdge(this.bottomLeft, this.rightDir);

                if (this.width < 2 || this.width > 21)
                {
                    this.bottomLeft = null;
                    this.width = 0;
                }
            }

            if (this.bottomLeft != null)
            {
                this.height = this.calculatePortalHeight();
            }
        }

        protected int getDistanceUntilEdge(BlockPos blockPos, EnumFacing enumFacing)
        {
            int i;

            for (i = 0; i < 22; ++i)
            {
                BlockPos blockpos = blockPos.offset(enumFacing, i);

                if (!this.isEmptyBlock(this.world.getBlockState(blockpos).getBlock()) || this.world.getBlockState(blockpos.down()).getBlock() != ModBlocks.BLOCK_PORTAL_FRAME)
                {
                    break;
                }
            }

            Block block = this.world.getBlockState(blockPos.offset(enumFacing, i)).getBlock();
            return block == ModBlocks.BLOCK_PORTAL_FRAME ? i : 0;
        }

        public int getHeight() {
            return this.height;
        }

        public int getWidth() {
            return this.width;
        }

        protected int calculatePortalHeight() {
            label24:

            for (this.height = 0; this.height < 21; ++this.height) {
                for (int i = 0; i < this.width; ++i) {
                    BlockPos blockpos = this.bottomLeft.offset(this.rightDir, i).up(this.height);
                    Block block = this.world.getBlockState(blockpos).getBlock();

                    if (!this.isEmptyBlock(block)) {
                        break label24;
                    }

                    if (block == ModBlocks.BLOCK_PORTAL) {
                        ++this.portalBlockCount;
                    }

                    if (i == 0) {
                        block = this.world.getBlockState(blockpos.offset(this.leftDir)).getBlock();

                        if (block != ModBlocks.BLOCK_PORTAL_FRAME) {
                            break label24;
                        }
                    }
                    else if (i == this.width - 1) {
                        block = this.world.getBlockState(blockpos.offset(this.rightDir)).getBlock();

                        if (block != ModBlocks.BLOCK_PORTAL_FRAME) {
                            break label24;
                        }
                    }
                }
            }

            for (int j = 0; j < this.width; ++j)
            {
                if (this.world.getBlockState(this.bottomLeft.offset(this.rightDir, j).up(this.height)).getBlock() != ModBlocks.BLOCK_PORTAL_FRAME) {
                    this.height = 0;
                    break;
                }
            }

            if (this.height <= 21 && this.height >= 3) {
                return this.height;
            }
            else {
                this.bottomLeft = null;
                this.width = 0;
                this.height = 0;
                return 0;
            }
        }

        protected boolean isEmptyBlock(Block blockIn) {
            return blockIn.getMaterial(blockIn.getDefaultState()) == Material.AIR || blockIn == Blocks.FIRE || blockIn == Blocks.PORTAL;
        }

        public boolean isValid() {
            return this.bottomLeft != null && this.width >= 2 && this.width <= 21 && this.height >= 3 && this.height <= 21;
        }

        public void placePortalBlocks() {
            for (int i = 0; i < this.width; ++i) {
                BlockPos blockpos = this.bottomLeft.offset(this.rightDir, i);

                for (int j = 0; j < this.height; ++j) {
                    this.world.setBlockState(blockpos.up(j), ModBlocks.BLOCK_PORTAL.getDefaultState().withProperty(BlockModPortal.AXIS, this.axis), 2);
                }
            }
        }
    }
}

 

Through debugging, I noticed that it does, in fact, generate. It just disappears instantly, at least partly because of neighborChanged failing the isValid() check(s). For some reason, isValid() is returning false because bottomLeft is returning null and both the width and height are returning 0.

 

I've been staring at this for so long my brain is turning into jello, so I was hoping someone with a fresher (and probably better) mind could help me! :)

I'm eager to learn and am prone to mistakes. Don't hesitate to tell me how I can improve.

Link to comment
Share on other sites

Well this:

protected boolean isEmptyBlock(Block blockIn) {
    return blockIn.getMaterial(blockIn.getDefaultState()) == Material.AIR || blockIn == Blocks.FIRE || blockIn == Blocks.PORTAL;
}

is telling it that fire is technically a valid empty block, so I don't think that's it.

 

After a little more looking, I realized that the isValid() checks aren't actually failing, otherwise trySpawnPortal would return false (it's returning true)...

I'm eager to learn and am prone to mistakes. Don't hesitate to tell me how I can improve.

Link to comment
Share on other sites

Guest
This topic is now closed to further replies.


×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.