Raycoms

We uploaded a fix and got it now in 1.10, 1.11 and 1.12

Just released an update where we reworked our townhall GUI completely. Made the workers search a real bed at night and stay close to it. Reworked the build tool rendering to work with all tileEntities and entities. And the possibility to increase the warehouse storage x2 paying 1 emerald block each upgrade. (3 upgrades increase it by x2)

Okay, this had been updated to 1.10, 1.11 and 1.12. We added warehouses, deliverymen, barbarians (hostile mobs attacking your colony) a baker and much more. Check it out.

Introducing Blockout: About BlockOut BlockOut is a data-driven GUI library for Minecraft. BlockOut uses a hierarchical structure, consisting of a root Window, which contains one or more Panes and Views. Views are a type of Pane which can contain other Panes (and Views). Position coordinates in BlockOut are relative, where a Pane's x,y position is relative to the top-left of the parent View. There are various means of declaring the size and position of a Pane. Blockout offers support for quite a list of different features including: - Scrolllists - Buttons - Image button - Switch views - Item icons - Text - Input field - Images Repository and installation details: https://github.com/Minecolonies/blockout Download: https://minecraft.curseforge.com/projects/blockout Examples screenshots are in the attachments. Good examples of the XML GUI's can be found here: https://github.com/Minecolonies/minecolonies/tree/version/1.11/src/main/resources/assets/minecolonies/gui Good examples regarding the functional window classes here: https://github.com/Minecolonies/minecolonies/tree/version/1.11/src/main/java/com/minecolonies/coremod/client/gui

We developed a system based on minecrafts structureblocks to render ghost blocks into the world. Nevertheless blocks like walls don'T get rendered at all and fences get rendered without their connections. https://pastebin.com/Auj7Npsy

got it

Oh okay, I got it, sometimes I'm a bit slow. Okay I created the message, only problem is. player.openGUI() on the server side doesn't take anything I could work with, it wants a tileEntityChest or similar, but I don't have anything like that, its a crafting table gui...

But the button in the gui is only on the client side, how would I trigger the server side then? Is there a message for that?

I open the gui on button click: private void craftingClicked() { Minecraft.getMinecraft().displayGuiScreen(new WindowGuiCrafting(Minecraft.getMinecraft().thePlayer.inventory, Minecraft.getMinecraft().theWorld, building)); } /** * Create a crafting gui window. * * @param playerInv the player. * @param worldIn the world. * @param building the building it belongs to. */ public WindowGuiCrafting(InventoryPlayer playerInv, World worldIn, final AbstractBuilding.View building) { this(playerInv, worldIn, BlockPos.ORIGIN, building); } /** * Create a crafting gui window. * * @param playerInv the player. * @param worldIn the world. * @param blockPosition the position. * @param building the building. */ public WindowGuiCrafting(InventoryPlayer playerInv, World worldIn, BlockPos blockPosition, final AbstractBuilding.View building) { super(new CraftingGUIBuilding(playerInv, worldIn, blockPosition, building)); }

I'm sorry, exactly that's what I meant. I click on a slot and it chooses the content of another slot or no content at all.

When I click on a certain block or it selects another block of the inventory or it does not select any block at all.

I'm trying to make a custom 2x2 crafting grid inside a container with a done button. I created the GUI button etc. The gui opens, the button clicks, the crafting works. The only problem is that the player inventory does bug heavily. https://pastebin.com/iZ0hGNTh It doesn't let me click the block I want.

Hey, We have a few custom commands in our mod all players should be able to use but it seems like forge blocks them for non-op players. They get a "You don't have the permission" message. How can we change this? Thanks already

Oh, that was stupid, didn't even see that... Resolved it now. Now I'm only missing a fix to the inventory bug where I have different instances of the inventory in the tileEntity it seems.

I created my own custom chest which should imitate vanilla chest behavior but be faster for automatic mods to read its content (Don't have to read null slots for content etc). I have a tileEntity and an Inventory. But I have one problem Items get lost and reappear again after emptying some items or after reopening a bunch of times. When debugging it seems like the same tileEntity has two different versions of the inventory. package com.minecolonies.coremod.tileentities; import com.minecolonies.coremod.inventory.InventoryChest; import com.minecolonies.coremod.lib.Constants; import net.minecraft.item.ItemStack; import net.minecraft.nbt.NBTTagCompound; import net.minecraft.tileentity.TileEntityChest; import javax.annotation.Nullable; public class TileEntityMinecoloniesChest extends TileEntityChest { /** * Tag to store inventory to nbt. */ private static final String TAG_INVENTORY = "inventory"; /** * The inventory connected with the scarecrow. */ private InventoryChest chest; public TileEntityMinecoloniesChest() { super(); chest = new InventoryChest(); } /** * Returns the stack in the given slot. */ @Nullable @Override public ItemStack getStackInSlot(int index) { return chest.getStackInSlot(index); } @Override public void readFromNBT(final NBTTagCompound compound) { super.readFromNBT(compound); chest = InventoryChest.deserializeFromNBT(compound.getCompoundTag(Constants.MOD_ID + TAG_INVENTORY)); } @Override public NBTTagCompound writeToNBT(final NBTTagCompound compound) { final NBTTagCompound localCompound = super.writeToNBT(compound); if(chest != null) { localCompound.setTag(Constants.MOD_ID + TAG_INVENTORY, chest.serializeNBT()); } return localCompound; } public void close() { numPlayersUsing = 0; } /** * Removes up to a specified number of items from an inventory slot and returns them in a new stack. */ @Nullable @Override public ItemStack decrStackSize(int index, int count) { return chest.decrStackSize(index, count); } /** * Removes a stack from the given slot and returns it. */ @Nullable @Override public ItemStack removeStackFromSlot(int index) { return chest.removeStackFromSlot(index); } /** * Sets the given item stack to the specified slot in the inventory (can be crafting or armor sections). */ @Override public void setInventorySlotContents(int index, @Nullable ItemStack stack) { chest.setInventorySlotContents(index, stack); } /** * Clear the inventory. */ @Override public void clear() { chest.clear(); } /** * Getter for the inventory. * @return the stackHandler. */ public InventoryChest getInventory() { return this.chest; } /** * Set the inventory. * @param inventory to set. */ public void setInventory(final InventoryChest inventory) { this.chest = inventory; } } package com.minecolonies.coremod.inventory; import com.minecolonies.coremod.tileentities.TileEntityMinecoloniesChest; import com.minecolonies.coremod.util.ExtendedItemStack; import com.minecolonies.coremod.util.InventoryUtils; import net.minecraft.entity.player.EntityPlayer; import net.minecraft.entity.player.InventoryPlayer; import net.minecraft.inventory.Container; import net.minecraft.inventory.Slot; import net.minecraft.item.ItemStack; import net.minecraft.nbt.NBTTagCompound; import net.minecraft.nbt.NBTTagList; import net.minecraft.tileentity.TileEntity; import net.minecraftforge.common.util.Constants; import net.minecraftforge.items.IItemHandler; import org.jetbrains.annotations.NotNull; import org.jetbrains.annotations.Nullable; import java.util.HashMap; /** * The custom chest of the field. */ public class InventoryChest extends Container implements IItemHandler { /** * The size of a normal inventory. */ private static final int MAX_INVENTORY_INDEX = 27; /** * The size of the the inventory hotbar. */ private static final int INVENTORY_HOT_BAR_SIZE = 9; /** * Tag to store the content. */ private static final String TAG_CONTENT = "items"; /** * TileEntity of the chest. */ private final TileEntityMinecoloniesChest entity; /** * The hashmap with the content of the inventory. */ private final HashMap<ExtendedItemStack, ExtendedItemStack> content = new HashMap<>(); public InventoryChest(@NotNull final TileEntityMinecoloniesChest tileEntity, final InventoryPlayer playerInventory) { super(); tileEntity.openInventory(playerInventory.player); int i = (3 - 4) * 18; for (int j = 0; j < 3; ++j) { for (int k = 0; k < 9; ++k) { this.addSlotToContainer(new Slot(tileEntity, k + j * 9, 8 + k * 18, 18 + j * 18)); } } for (int l = 0; l < 3; ++l) { for (int j1 = 0; j1 < 9; ++j1) { this.addSlotToContainer(new Slot(playerInventory, j1 + l * 9 + 9, 8 + j1 * 18, 103 + l * 18 + i)); } } for (int i1 = 0; i1 < 9; ++i1) { this.addSlotToContainer(new Slot(playerInventory, i1, 8 + i1 * 18, 161 + i)); } this.content.putAll(tileEntity.getInventory().content); tileEntity.setInventory(this); this.entity = tileEntity; } public InventoryChest() { super(); this.entity = null; } @Override public int getSlots() { return MAX_INVENTORY_INDEX; } @Override public void onContainerClosed(final EntityPlayer playerIn) { entity.close(); } @Override public ItemStack insertItem(final int slot, final ItemStack stack, final boolean simulate) { return null; } @Override public ItemStack extractItem(final int slot, final int amount, final boolean simulate) { return null; } /** * Mark the tileEntity of this inventory dirty. */ private void markDirty() { if(this.entity != null) { entity.setInventory(this); entity.markDirty(); } } /** * Returns the stack in the given slot. */ @Nullable @Override public ItemStack getStackInSlot(int index) { int i = 0; for (final ExtendedItemStack stack : content.values()) { int totalAmount = stack.getAmount(); double divisor = Math.max(64, totalAmount) / 64.0; for (int partialStacks = 0; partialStacks < divisor; partialStacks++) { int size = Math.min(64, totalAmount); if (i + partialStacks == index) { final ItemStack returnStack = stack.getStack().copy(); returnStack.stackSize = size; return returnStack; } totalAmount -= size; } i += divisor; } return InventoryUtils.EMPTY; } public static InventoryChest deserializeFromNBT(final NBTTagCompound compound) { final InventoryChest chest = new InventoryChest(); final NBTTagList nbttaglist = compound.getTagList(TAG_CONTENT, Constants.NBT.TAG_COMPOUND); for (int i = 0; i < nbttaglist.tagCount(); ++i) { final NBTTagCompound nbttagcompound = nbttaglist.getCompoundTagAt(i); final ExtendedItemStack stack = ExtendedItemStack.readFromNBT(nbttagcompound); chest.content.put(stack, stack); } return chest; } @Nullable @Override public ItemStack transferStackInSlot(@NotNull final EntityPlayer playerIn, final int slotIndex) { if (slotIndex < this.getSlots()) { playerIn.inventory.addItemStackToInventory(this.getStackInSlot(slotIndex)); this.removeStackFromSlot(slotIndex); } else { int index = slotIndex - this.getSlots(); index = index >= MAX_INVENTORY_INDEX ? index - MAX_INVENTORY_INDEX : index + INVENTORY_HOT_BAR_SIZE; if (playerIn.inventory.getStackInSlot(index) != InventoryUtils.EMPTY) { int remain = this.addToInventory(playerIn.inventory.getStackInSlot(index)); playerIn.inventory.getStackInSlot(index).splitStack(64 - remain); if (playerIn.inventory.getStackInSlot(index).stackSize == 0) { playerIn.inventory.removeStackFromSlot(index); } } } markDirty(); return InventoryUtils.EMPTY; } private int addToInventory(final ItemStack stackInSlot) { markDirty(); int fullSlots = 0; for(ExtendedItemStack stack: content.values()) { fullSlots += Math.ceil(stack.getAmount() / 64.0); } if(fullSlots >= getSlots()) { //todo check if can fill up a stack. return stackInSlot.stackSize; } final int stackSize = stackInSlot.stackSize; stackInSlot.stackSize = 0; if (content.containsKey(new ExtendedItemStack(stackInSlot, 0))) { ExtendedItemStack ext = content.remove(new ExtendedItemStack(stackInSlot, 0)); ext.increaseAmount(stackSize); content.put(ext, ext); } else { final ExtendedItemStack ext = new ExtendedItemStack(stackInSlot, stackSize); content.put(ext, ext); } return 0; } public NBTTagCompound serializeNBT() { final NBTTagCompound compound = new NBTTagCompound(); final NBTTagList nbttaglist = new NBTTagList(); for (final ExtendedItemStack stack : content.values()) { final NBTTagCompound stackCompound = new NBTTagCompound(); stack.writeToNBT(stackCompound); nbttaglist.appendTag(stackCompound); } compound.setTag(TAG_CONTENT, nbttaglist); return compound; } /** * Removes up to a specified number of items from an inventory slot and returns them in a new stack. */ @Nullable public ItemStack decrStackSize(int index, int count) { markDirty(); int i = 0; for (final ExtendedItemStack stack : content.values()) { int totalAmount = stack.getAmount(); double divisor = Math.max(64, totalAmount) / 64.0; for (int partialStacks = 0; partialStacks < divisor; partialStacks++) { int size = Math.min(64, totalAmount); if (i + partialStacks == index) { final ItemStack returnStack = stack.getAsItemStackWithAmount(count); if (stack.getAmount() == 0) { content.remove(stack); } return returnStack; } totalAmount -= size; } i += divisor; } return InventoryUtils.EMPTY; } /** * Removes a stack from the given slot and returns it. */ @Nullable public ItemStack removeStackFromSlot(int index) { markDirty(); int i = 0; for (final ExtendedItemStack stack : content.values()) { int totalAmount = stack.getAmount(); double divisor = Math.max(64, totalAmount) / 64.0; for (int partialStacks = 0; partialStacks < divisor; partialStacks++) { int size = Math.min(64, totalAmount); if (i + partialStacks == index) { final ItemStack returnStack = stack.getAsItemStackWithAmount(size); if(stack.getAmount() <= 0) { content.remove(stack); } return returnStack; } totalAmount -= size; } i += divisor; } return InventoryUtils.EMPTY; } /** * Sets the given item stack to the specified slot in the inventory (can be crafting or armor sections). * @param index the index. * @param stack the incoming stack. */ public void setInventorySlotContents(int index, @Nullable ItemStack stack) { markDirty(); if (stack == null) { return; } int i = 0; for (final ExtendedItemStack exStack : new HashMap<>(content).values()) { int totalAmount = exStack.getAmount(); double divisor = Math.max(64, totalAmount) / 64.0; for (int partialStacks = 0; partialStacks < divisor; partialStacks++) { int size = Math.min(64, totalAmount); if (i + partialStacks == index) { exStack.setAmount(exStack.getAmount() - size); if(exStack.getAmount() <= 0) { content.remove(exStack); } break; } totalAmount -= size; } i += divisor; } final int stacksize = stack.stackSize; stack.stackSize = 0; if (content.containsKey(new ExtendedItemStack(stack, 0))) { ExtendedItemStack ext = content.remove(new ExtendedItemStack(stack, 0)); ext.increaseAmount(stacksize); content.put(ext, ext); } else { final ExtendedItemStack ext = new ExtendedItemStack(stack, stacksize); content.put(ext, ext); } } @Override public boolean canInteractWith(final EntityPlayer playerIn) { return true; } public void clear() { markDirty(); content.clear(); } }

Still searching for a fix

Still no one any idea?

I tried around more. But not one of the overridable events is being called on double clicking the stacks out of the other inventory and on filling up stacks.

Anyone, any idea?

Hmm I think to be 100% sure you'll have to use something that ticks and checks if something is trying to apply a potion effect to the player to remove it. Did you already dig in what "saves" the player of potion effects when he is in another gamemode. And make the armour apply it to him?

ThrowableImpactEvent should work for witch events as well

I know that's not that reliable. But in our mod we're catching potion throw events (right click something with splash potion). You might use that.

Ahh yeah. and if you catch the event?

You can't overwrite this from EntityLivingBase: public boolean isPotionApplicable(PotionEffect potioneffectIn) public void addPotionEffect(PotionEffect potioneffectIn) And check if the player has the suit on?

package com.minecolonies.coremod.tileentities; import com.minecolonies.coremod.util.ExtendedItemStack; import com.minecolonies.coremod.util.InventoryUtils; import net.minecraft.item.ItemStack; import net.minecraft.nbt.NBTTagCompound; import net.minecraft.nbt.NBTTagList; import net.minecraft.tileentity.TileEntityChest; import javax.annotation.Nullable; import java.util.HashMap; public class TileEntityMinecoloniesChest extends TileEntityChest { private final HashMap<ExtendedItemStack, ExtendedItemStack> content = new HashMap<>(); public TileEntityMinecoloniesChest() { super(); } /** * Returns the stack in the given slot. */ @Nullable @Override public ItemStack getStackInSlot(int index) { int i = 0; for(final ExtendedItemStack stack: content.values()) { int totalAmount = stack.getAmount(); double divisor = Math.max(64, totalAmount) / 64.0; for(int partialStacks = 0; partialStacks < divisor; partialStacks++) { int size = Math.min(64, totalAmount); if(i+partialStacks == index) { final ItemStack returnStack = stack.getStack(); returnStack.stackSize = size; return returnStack; } totalAmount-= size; } i+=divisor; } return InventoryUtils.EMPTY; } @Override public NBTTagCompound serializeNBT() { final NBTTagCompound compound = super.serializeNBT(); if (!this.checkLootAndWrite(compound)) { final NBTTagList nbttaglist = new NBTTagList(); for (final ExtendedItemStack stack : content.values()) { stack.writeToNBT(compound); } compound.setTag("Items", nbttaglist); } return compound; } @Override public void deserializeNBT(final NBTTagCompound nbt) { super.deserializeNBT(nbt); if (!this.checkLootAndRead(nbt)) { final NBTTagList nbttaglist = nbt.getTagList("Items", 10); for (int i = 0; i < nbttaglist.tagCount(); ++i) { final NBTTagCompound nbttagcompound = nbttaglist.getCompoundTagAt(i); final ExtendedItemStack stack = ExtendedItemStack.readFromNBT(nbttagcompound); content.put(stack, stack); } } } /** * Removes up to a specified number of items from an inventory slot and returns them in a new stack. */ @Nullable @Override public ItemStack decrStackSize(int index, int count) { this.markDirty(); int i = 0; for(final ExtendedItemStack stack: content.values()) { int totalAmount = stack.getAmount(); double divisor = Math.max(64, totalAmount) / 64.0; for(int partialStacks = 0; partialStacks < divisor; partialStacks++) { int size = Math.min(64, totalAmount); if(i+partialStacks == index) { final ItemStack returnStack = stack.getAsItemStackWithAmount(count); if(stack.getAmount() == 0) { content.remove(stack); } return returnStack; } totalAmount-= size; } i+=divisor; } return InventoryUtils.EMPTY; } /** * Removes a stack from the given slot and returns it. */ @Nullable @Override public ItemStack removeStackFromSlot(int index) { this.markDirty(); int i = 0; for(final ExtendedItemStack stack: content.values()) { int totalAmount = stack.getAmount(); double divisor = Math.max(64, totalAmount) / 64.0; for(int partialStacks = 0; partialStacks < divisor; partialStacks++) { int size = Math.min(64, totalAmount); if(i+partialStacks == index) { return stack.getAsItemStackWithAmount(size); } totalAmount-= size; } i+=divisor; } return InventoryUtils.EMPTY; } /** * Sets the given item stack to the specified slot in the inventory (can be crafting or armor sections). */ @Override public void setInventorySlotContents(int index, @Nullable ItemStack stack) { if(stack == null) { return; } if(content.containsKey(new ExtendedItemStack(stack, 0))) { ExtendedItemStack ext = content.remove(new ExtendedItemStack(stack, 0)); ext.increaseAmount(stack.stackSize); content.put(ext, ext); } else { final ExtendedItemStack ext = new ExtendedItemStack(stack, stack.stackSize); content.put(ext, ext); } stack.stackSize = 0; this.markDirty(); } /** * Clear the inventory. */ @Override public void clear() { content.clear(); } } I updated the code but still, filling up stacks, extracting them with double click or persisting them does not work at all.