[1.10.2] WorldSavedData and concurrency

[OreCruncher]

I have been getting sporadic concurrency exceptions from the chunk IO thread and I suspect it may be related to how I interact with my global WorldSavedData.  Currently I do not have concurrency guards in place.  I looked at the mcforge docs and I did not see anything on this particular topic.  So my question is do I need to synchronize access to my WorldSavedData?

 

EDIT: Additional info - I do have various lists inside the WorldSavedData object.

[OreCruncher]

Link to the file in my Github repository.

 

My main concern is that I have a Set<> burried in DimensionEffectData.  It is possible that the Set<> would be modified in the main server thread while the IO thread is serializing - assuming serialization takes place in the IO thread.

[OreCruncher]

This particular set  of classes had a colorful past.  They started off reading/writing Json but morphed into what you currently see.

 

* Is it that markDirty is generally pointless?

* I was planning on making it per dimension as you indicate - would simplify things.

 

Thanks for the suggestions.

[OreCruncher]

That's what I thought.  Because of how the class was implemented it was the only place that I could guarantee it would be flagged.  My new sandbox implementation does it differently.