[1.10.2][1.11.2] ItemTool.onBlockDestroyed() different between versions...

[OreCruncher]

In 1.10.2-12.18.3.2221:

    public boolean onBlockDestroyed(ItemStack stack, World worldIn, IBlockState state, BlockPos pos, EntityLivingBase entityLiving)
    {
        if ((double)state.getBlockHardness(worldIn, pos) != 0.0D)
        {
            stack.damageItem(1, entityLiving);
        }

        return true;
    }

 

In 1.11.2-13.20.0.2223:

 

    public boolean onBlockDestroyed(ItemStack stack, World worldIn, IBlockState state, BlockPos pos, EntityLivingBase entityLiving)
    {
        if (!worldIn.isRemote && (double)state.getBlockHardness(worldIn, pos) != 0.0D)
        {
            stack.damageItem(1, entityLiving);
        }

        return true;
    }

 

The 1.11.2 version has a check for isRemote.  In my sandbox I believe it is preventing the tool break sound from playing in the client.  Under this all the logic is using the "play sound" that excludes the player.  Am I missing something?

[MCenderdragon]

You have most likely found the cause why in 1.11.2 tools dont make the braking sound and sawn the particles. I think there is maybe a usefull Thought behind that change but it seems like its only causing issues. Have you opend and issue or Pullrequest on forge to fix this ?

[OreCruncher]

No, I haven't.  Reasons.

[MCenderdragon]

Well I opened an issue... https://github.com/MinecraftForge/MinecraftForge/issues/3821