Jump to content

Recommended Posts

Posted

Im attempting to use NBT Tags to save an array of block locations, matching with player names. I am trying to save this to my item. But it isn't working. I crash with this:

	public ItemStack onItemRightClick(ItemStack itemstack , World world, EntityPlayer player){
	itemstack = player.getCurrentEquippedItem();
	NBTTagCompound nbt = itemstack.getTagCompound();
	if(!world.isRemote)
	{
		if(player.isSneaking()){
			String i = nbt.getString("HELLO!");
			player.sendChatToPlayer(i);
		}else{
		nbt.setString("name", "YOLO");
		}
	}

	return itemstack;

}

(Also this is my first mod and also just a test to see if it will work). If there is a better way to save block location and player names. Please say! Also I need it to still contain this info even after restart. I am trying to make a protection mod and have everything working besides this! Please help if you can :)

Posted

You should have included some stacktrace to help us tackle your problem. But I'm guessing it's a NullPointerException you're getting, because in your code the NBTTagCompound nbt might be null, as well as String i. (They're null if they're not set on this itemStack.)

 

I think it's ok to save some data like block locations in your custom item in an NBT tag. You can set arrays, and all info should be retained on restart as well.

Posted

You should have included some stacktrace to help us tackle your problem. But I'm guessing it's a NullPointerException you're getting, because in your code the NBTTagCompound nbt might be null, as well as String i. (They're null if they're not set on this itemStack.)

 

I think it's ok to save some data like block locations in your custom item in an NBT tag. You can set arrays, and all info should be retained on restart as well.

Caused by: java.lang.NullPointerException

2013-01-16 19:15:49 [iNFO] [sTDERR] at bartboy8.needynecessities.common.ItemPortableItem.onItemRightClick(ItemPortableItem.java:35)

Line 35 is: nbt.setString("name", "YOLO");

 

Do u have any idea how I could set a variable to my itemStack?

Posted

I think it's done like this:

NBTTagCompound tag = itemStack.getTagCompound();
if (tag == null) {
tag = new NBTTagCompound();
itemStack.setTagCompound(tag);
}
tag.setString("playerName", player.getName());
tag.setInt("playerHP", player.getHP());

 

Methods getName() and getHP() are given just for example, they probably don't exist in player.

Also read this tutorial: www.minecraftforge.net/wiki/How_to_use_NBT_Tag_Compound

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • I tried do download the essential mod to my mod pack but i didnt work. I paly on 1.21 and it should work. I use neoforge for my modding. The weird things is my friend somehow added the mod to his modpack and many others that I somehow can´t. Is there anything i can do? 
    • Thanks, I've now installed a slightly newer version and the server is at least starting up now.
    • i have the same issue. Found 1 Create mod class dependency(ies) in createdeco-1.3.3-1.19.2.jar, which are missing from the current create-1.19.2-0.5.1.i.jar Found 11 Create mod class dependency(ies) in createaddition-fabric+1.19.2-20230723a.jar, which are missing from the current create-1.19.2-0.5.1.i.jar Detailed walkthrough of mods which rely on missing Create mod classes: Mod: createaddition-fabric+1.19.2-20230723a.jar Missing classes of create: com/simibubi/create/compat/jei/category/sequencedAssembly/JeiSequencedAssemblySubCategory com/simibubi/create/compat/recipeViewerCommon/SequencedAssemblySubCategoryType com/simibubi/create/compat/rei/CreateREI com/simibubi/create/compat/rei/EmptyBackground com/simibubi/create/compat/rei/ItemIcon com/simibubi/create/compat/rei/category/CreateRecipeCategory com/simibubi/create/compat/rei/category/WidgetUtil com/simibubi/create/compat/rei/category/animations/AnimatedBlazeBurner com/simibubi/create/compat/rei/category/animations/AnimatedKinetics com/simibubi/create/compat/rei/category/sequencedAssembly/ReiSequencedAssemblySubCategory com/simibubi/create/compat/rei/display/CreateDisplay Mod: createdeco-1.3.3-1.19.2.jar Missing classes of create: com/simibubi/create/content/kinetics/fan/SplashingRecipe
    • The crash points to moonlight lib - try other builds or make a test without this mod and the mods requiring it
    • Do you have shaders enabled? There is an issue with the mod simpleclouds - remove this mod or disable shaders, if enabled  
  • Topics

  • Who's Online (See full list)

    • There are no registered users currently online
×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.