On 07/04/2017 at 11:06 AM, lethinh said:

world.setBlockToAir(pos);

Ignoring the mess of the code to spawn drops, there is no reason this line shouldn't be doing what you want. Step through the code with the debugger or use print statements to see whether the code is reaching this point and acting on the block you expect it to, to find out where it goes wrong.

1 minute ago, Jay Avery said:

Ignoring the mess of the code to spawn drops, there is no reason this line shouldn't be doing what you want. Step through the code with the debugger or use print statements to see whether the code is reaching this point and acting on the block you expect it to, to find out where it goes wrong.

Do you know how to use debugger? I'm using Intellij IDEA

Edited April 8, 20178 yr by lethinh

1 hour ago, lethinh said:

Do you know how to use debugger? I'm using Intellij IDEA

https://www.jetbrains.com/help/idea/2017.1/debugging.html

12 hours ago, Jay Avery said:

https://www.jetbrains.com/help/idea/2017.1/debugging.html

 

How to wheater the code is reaching the break unbreakable block statements?

2 hours ago, lethinh said:

 

How to wheater the code is reaching the break unbreakable block statements?

https://www.jetbrains.com/help/idea/2017.1/creating-line-breakpoints.html

I noticed once, that when I used methods like world.setBlockToAir(pos); or world.setBlockState... nothing would happen.

 

It resulted that if I used if (!world.isRemote) {world.setBlockToAir(pos);} or if (!world.isRemote) {world.setBlockState...}

 

Then it would work. In the first case, when it wasn't executed on logical server side, you could see the code would run, but quickly turned back to before it's execution and changes where not effective. Even after restarting Minecraft. But that little check of sides, would make the changes persist.

 

I may be wrong, I am new to this, but maybe you could try that. Check the sides. Try to put your code inside

if (!world.isRemote) {

}

 

If I am wrong, then I welcome corrections.

On 7/4/2017 at 8:33 PM, Draco18s said:

 List<ItemStack> drop = new ArrayList<>();

Cool, I have an array object

if (drop == null)

Nope, it's not null. It's an ArrayList of size zero.

block.harvestBlock(world, player, pos, state, world.getTileEntity(pos), new ItemStack(block));
InventoryHelper.spawnItemStack(world, pos.getX(), pos.getY(), pos.getZ(), new ItemStack(block));

And now, I ignore the fuck out of my array object.

 

So do you know how to convert List<ItemStack> to ItemStack ?

51 minutes ago, ctbe said:

I noticed once, that when I used methods like world.setBlockToAir(pos); or world.setBlockState... nothing would happen.

 

It resulted that if I used if (!world.isRemote) {world.setBlockToAir(pos);} or if (!world.isRemote) {world.setBlockState...}

 

Then it would work. In the first case, when it wasn't executed on logical server side, you could see the code would run, but quickly turned back to before it's execution and changes where not effective. Even after restarting Minecraft. But that little check of sides, would make the changes persist.

 

I may be wrong, I am new to this, but maybe you could try that. Check the sides. Try to put your code inside

if (!world.isRemote) {

}

 

If I am wrong, then I welcome corrections.

 

Thanks for your idea but it doesn't work. The world.isRemote has already called in the code.

When I toggle line breakpoint. It doesn't break. But it doesn't break unbreable block

1 hour ago, lethinh said:

 

So do you know how to convert List<ItemStack> to ItemStack ?

It's a list of ItemStacks. If you want to get an ItemStack from it, you pick an index and take it from the list. This is again pretty fundamental Java stuff.

 

1 hour ago, lethinh said:

When I toggle line breakpoint. It doesn't break. But it doesn't break unbreable block

You mean it doesn't reach the breakpoint? That shows that the code isn't being run at all. Where do you register your event handler?

2 hours ago, Jay Avery said:

It's a list of ItemStacks. If you want to get an ItemStack from it, you pick an index and take it from the list. This is again pretty fundamental Java stuff.

 

You mean it doesn't reach the breakpoint? That shows that the code isn't being run at all. Where do you register your event handler?

I use @Mod.EventBusSubscriber on the beginning of the class file

Since the thread is getting lengthy I will try to explain as best as I can. I tried to achieve what you want on a custom pickaxe and got it working. I got it to break Bedrock and give me the block drop. However, the pickaxe must be enchanted with Silk Touch for the code I am about to provide you to work. The reason is that I use here the harvestBlock method and if it doesn't have Silk Touch it will not harvest anything, at least not bedrock. It may harverst custom unbreakable blocks with an unenchanted pickaxe if those custom blocks have a drop defined for harvest, but not bedrock. For bedrock it needs Silk Touch.

Without deviating much from subscribe event, the logic was this:

1.     Create an item that extends ItemPickaxe
2.     Create a method to subscribe to the Event Handler PlayerInteractEvent.LeftClickBlock inside the class of the custom pickaxe
3.     Do the logic inside that created method
   • Get the World, EntityPlayer, BlockPos, IBlockState, Block, and ItemStack into variables (get them from the event variable that gets passed to the method)
   • Check that we work on the logical server
     • Check if the block is an unbreakable block by using the IBlockState getBlockHardness method and checking if the hardness is less than 0
       • If it is an unbreakable block, harvest it with the harvestBlock method
       • Destroy the block
4.     Register the subscribed event handler in the item's constructor

 

The code for the event would be

@SubscribeEvent
public void onPlayerDig(PlayerInteractEvent.LeftClickBlock event) {
  World worldIn = event.getWorld();
  EntityPlayer player = event.getEntityPlayer();
  BlockPos pos = event.getPos();
  IBlockState state = worldIn.getBlockState(pos);
  Block block = state.getBlock();
  ItemStack stack = event.getItemStack();

  if (!worldIn.isRemote) {
    if (state.getBlockHardness(worldIn, pos) < 0) {
      //Block is unbreakable
      //Harvest it
      worldIn.getBlockState(pos).getBlock().harvestBlock(worldIn, player, pos, state, null, stack);
      //Destroy the block
      worldIn.destroyBlock(pos, false);
    }
  }
}

 

then the code to register the event would go in the item's constructor like so

public CustomPickaxe () {
  MinecraftForge.EVENT_BUS.register(this);
}

This last one you need to call. If you don't register the event, it will not work. The code will not run.

 

I hope this helps you at least to get you in the right direction. The code works.

Notes: This is a template. Your constructor could have a parameter that passes the ToolMaterial into it, etc. And more code to initialize your tool. Like I mentioned above, the tool must be enchanted with Silk Touch for the block to drop itself. I tested it and it breaks bedrock and drops it.

The reason I did not use the code tags is that something is messed up in my editor. It is placing the code on the top and not where I want. If someone from staff wants to edit it and make it look properly when using the code tags then that is okay with me.
 

Edited April 9, 20178 yr by ctbe
Fixed typography

On 10/4/2017 at 3:47 AM, ctbe said:

Since the thread is getting lengthy I will try to explain as best as I can. I tried to achieve what you want on a custom pickaxe and got it working. I got it to break Bedrock and give me the block drop. However, the pickaxe must be enchanted with Silk Touch for the code I am about to provide you to work. The reason is that I use here the harvestBlock method and if it doesn't have Silk Touch it will not harvest anything, at least not bedrock. It may harverst custom unbreakable blocks with an unenchanted pickaxe if those custom blocks have a drop defined for harvest, but not bedrock. For bedrock it needs Silk Touch.
....

 

Well, I may forget to put state.getBlockHardness in the code so that the code didn't work. I have put it in the first but seem like I have deleted it. Thanks

Happy to help. I hope you achieve what you want. Cheers.

Edited April 12, 20178 yr by ctbe
Add cheers