Best way to mod a mod?

[vemacs]

I've been trying to mod Fihgu's protection mod all morning (basically trying to change some strings), and so far, I have the deobfuscated source from BON and JD-Gui, and have modified a single class (EventHandler.java).

 

However, I'm having serious issues compiling. I've added the deobfuscated and recompiled minecraft.jar from MCP, fihgu's core mod, Forge (both src+universal), all the imports in mcp /lib to the classpath, and for the life of me, still can't get it to compile (see http://www.minecraftforge.net/forum/index.php/topic,5536.0.html).

 

Am I completely doing it wrong, and if so, how would I do it properly? I honestly don't think that reinventing the wheel is needed just to modify a single .class.

 

Thanks in advance.

 

(sorry for not providing more details, a generic answer would be preferred)

[Mazetar]

Well generally decompilling other peoples mod's / classes is kinda something people tend to look down upon, at least if the intention is to do more than just look and learn

 

If it's Fihgu's mod's you are trying to decompile and modify why don't you contact him?

As far as I can see on the MC forums he is active there and you could PM him and ask for the source you need, if you explain your reasons and ask polite and nicely maybe he will help you out by giving you the part you need to look at or help you inn some other way? Generally having the permission of the mod author to decompile and play around with his source code is more accepted and thereby you would easier get help the problems you are facing while doing so

 

what exactly are you trying to accomplish by decompiling the files?

[vemacs]

Well generally decompilling other peoples mod's / classes is kinda something people tend to look down upon, at least if the intention is to do more than just look and learn

 

If it's Fihgu's mod's you are trying to decompile and modify why don't you contact him?

As far as I can see on the MC forums he is active there and you could PM him and ask for the source you need, if you explain your reasons and ask polite and nicely maybe he will help you out by giving you the part you need to look at or help you inn some other way? Generally having the permission of the mod author to decompile and play around with his source code is more accepted and thereby you would easier get help the problems you are facing while doing so

 

what exactly are you trying to accomplish by decompiling the files?

 

Thanks, I've PMed him, but I'm just patching some exploits related to the /lock function. I'm also patching some vulnerabilities in the login mod.

I've PMed him my patches (which should fix the issues), and I'm going to ask him for the source.

 

However, assuming that I did get the source, and the source is the exact same as the decompiled version, what would I be doing wrong if it isn't compiling?

[Mazetar]

No the source would not be the same as the recompiled version, it will be the same as how he wrote it before he compiled it.

The difference being that you won't have any errors because of things lost or wrongly interpreted during the decompiling of the file(s).

You will get the source as he wrote it, which means since his mod is working it will work (with the MCP and Forge version he used at least)