[1.11.2] Custom Sound Issues

[MinecraftWero]

Hello, I wanted to add a custom sound to my mod and it registers but it sounds different than the sound I want to use, here's my code:

 

SoundHandler

package com.minecraftwero.baconmod.handlers;

import com.minecraftwero.baconmod.Reference;
import com.minecraftwero.baconmod.util.Utils;

import net.minecraft.util.ResourceLocation;
import net.minecraft.util.SoundEvent;

public class BaconSoundHandler {

	private static int size = 0;
	
	
	public static SoundEvent BACON_SHOOT;
	
	public static void init(){
		size = SoundEvent.REGISTRY.getKeys().size();
	
		BACON_SHOOT = register("item.bacon_shoot.shoot");
	}

	
	public static SoundEvent register(String name){
		ResourceLocation location = new ResourceLocation(Reference.MODID, name);
		SoundEvent e = new SoundEvent(location);
	
		SoundEvent.REGISTRY.register(size, location, e);
		size++;
		Utils.getLogger().info("Registered sound: " + name);
		return e;
	}
}


	

 

Sound .json

{
    "item.bacon_shoot.shoot": {
        "category": "item",
        "subtitle": "item.bacon_shoot.shoot",
        "sounds": [ { "name": "bmod:item/bacon_shoot/shoot", "stream": true } ]
    }
   }

 

and here's my Item class that I want the sound for (basically ItemSnowball class:

package com.minecraftwero.baconmod.items;

import com.minecraftwero.baconmod.Reference;
import com.minecraftwero.baconmod.entities.EntityBacon;
import com.minecraftwero.baconmod.handlers.BaconSoundHandler;
import com.minecraftwero.baconmod.init.ModItems;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.SoundEvents;
import net.minecraft.item.Item;
import net.minecraft.item.ItemArrow;
import net.minecraft.item.ItemStack;
import net.minecraft.stats.StatList;
import net.minecraft.util.ActionResult;
import net.minecraft.util.EnumActionResult;
import net.minecraft.util.EnumHand;
import net.minecraft.util.ResourceLocation;
import net.minecraft.util.SoundCategory;
import net.minecraft.util.text.TextComponentTranslation;
import net.minecraft.world.World;
import net.minecraftforge.items.ItemStackHandler;

public class BaconLauncher extends Item
{
	public BaconLauncher(String unlocalizedName, String registryName) {
		this.setUnlocalizedName(unlocalizedName);
		this.setRegistryName(new ResourceLocation(Reference.MODID, registryName));
		this.setMaxStackSize(1);
	}
    /**
     * Called when the equipped item is right clicked.
     */
	
	public ActionResult<ItemStack> onItemRightClick(World worldIn, EntityPlayer playerIn, EnumHand handIn)
    {
        ItemStack itemStack = playerIn.getHeldItem(handIn);
       
        for (int i = 0; i < playerIn.inventory.getSizeInventory(); ++i){
            
        	ItemStack itemstack = playerIn.inventory.getStackInSlot(i);
            
        	if (itemstack.getItem()==ModItems.rawbacon){
            
        		itemstack.shrink(1);
               
                if (!worldIn.isRemote)
                {
                    EntityBacon entitybacon = new EntityBacon(worldIn, playerIn);
                    entitybacon.setHeadingFromThrower(playerIn, playerIn.rotationPitch, playerIn.rotationYaw, 0.0F, 1.5F, 1.0F);
                    worldIn.spawnEntity(entitybacon);
                    worldIn.playSound((EntityPlayer)null, playerIn.posX, playerIn.posY, playerIn.posZ, BaconSoundHandler.BACON_SHOOT, SoundCategory.NEUTRAL, 0.5F, 0.4F / (itemRand.nextFloat() * 0.4F + 0.8F));
                }
                break;
            }
        }
        
        
        playerIn.addStat(StatList.getObjectUseStats(this));
        return new ActionResult(EnumActionResult.SUCCESS, itemStack);
    }
}

 

I would appreciate it if someone could point out what I am doing wrong, oh I and I also registered the SoundHandlers inside my Init on main class.

[DimensionsInTime]

0.4F / (itemRand.nextFloat() * 0.4F + 0.8F

 

Why is your pitch that complicated formula and not 1.0F for normal speed?

[MinecraftWero]

6 minutes ago, DimensionsInTime said:

0.4F / (itemRand.nextFloat() * 0.4F + 0.8F

 

Why is your pitch that complicated formula and not 1.0F for normal speed?

wow I feel so dumb now.. that fixed it! thank you.

 

Edit: is there anyway to make it sound as soon as I press the right click? it's working now but it has a tiny delay.

Edited June 6, 2017 by MinecraftWero

[MinecraftWero]

3 hours ago, diesieben07 said:

Probably. We can't help you though, because you have not posted your code.

what code do you need? I thought I posted everything that was needed

[MinecraftWero]

14 minutes ago, diesieben07 said:

How did you get to that conclusion? You posted where you register your sound. Great. That tells us nothing about where and how you play it.

 

I guess there was an issue with formatting in the main post..

anyways I  managed to fix it, here is my item class:

Spoiler

package com.minecraftwero.baconmod.items;

import com.minecraftwero.baconmod.Reference;
import com.minecraftwero.baconmod.entities.EntityBacon;
import com.minecraftwero.baconmod.handlers.BaconSoundHandler;
import com.minecraftwero.baconmod.init.ModItems;

import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.init.SoundEvents;
import net.minecraft.item.Item;
import net.minecraft.item.ItemArrow;
import net.minecraft.item.ItemStack;
import net.minecraft.stats.StatList;
import net.minecraft.util.ActionResult;
import net.minecraft.util.EnumActionResult;
import net.minecraft.util.EnumHand;
import net.minecraft.util.ResourceLocation;
import net.minecraft.util.SoundCategory;
import net.minecraft.util.text.TextComponentTranslation;
import net.minecraft.world.World;
import net.minecraftforge.items.ItemStackHandler;

public class BaconLauncher extends Item
{
	public BaconLauncher(String unlocalizedName, String registryName) {
		this.setUnlocalizedName(unlocalizedName);
		this.setRegistryName(new ResourceLocation(Reference.MODID, registryName));
		this.setMaxStackSize(1);
	}
    /**
     * Called when the equipped item is right clicked.
     */
	
	public ActionResult<ItemStack> onItemRightClick(World worldIn, EntityPlayer playerIn, EnumHand handIn)
    {
        ItemStack itemStack = playerIn.getHeldItem(handIn);
       
        for (int i = 0; i < playerIn.inventory.getSizeInventory(); ++i){
            
        	ItemStack itemstack = playerIn.inventory.getStackInSlot(i);
            
        	if (itemstack.getItem()==ModItems.rawbacon){
            
        		itemstack.shrink(1);
               
                if (!worldIn.isRemote)
                {
                    EntityBacon entitybacon = new EntityBacon(worldIn, playerIn);
                    entitybacon.setHeadingFromThrower(playerIn, playerIn.rotationPitch, playerIn.rotationYaw, 0.0F, 1.5F, 1.0F);
                    worldIn.spawnEntity(entitybacon);
                    worldIn.playSound((EntityPlayer)null, playerIn.posX, playerIn.posY, playerIn.posZ, BaconSoundHandler.BACON_SHOOT, SoundCategory.NEUTRAL, 1.0F, 2.0F);
                }
                    break;
            }
        }
        
        
        playerIn.addStat(StatList.getObjectUseStats(this));
        return new ActionResult(EnumActionResult.SUCCESS, itemStack);
    }
}

 

 

Edited June 6, 2017 by MinecraftWero

[DimensionsInTime]

Your play code was in there, it's how I knew you had that complicated pitch formula there. You just had a few nested spoiler tags that made it hidden. You have stream set in your json, so it should start playing right away instead of loading then playing.