[1.10.2] Lamp won't update lighting properly

[That_Martin_Guy]

Finally some progress! The block can actually get to HIGH now. Still a problem, however. The lighting values aren't correct. In a cycle of HIGH -> MEDIUM -> LOW -> EMPTY it should, with the blockLightBulb instance I created, have a lighting cycle like this (if drained):

15 -> 6 -> 3 -> 0, but it goes like this:

0 -> 9 -> 12 -> 0. I tried using Math.round on the return values in getLightValue, but it didn't change. I definitely should've mentioned this earlier since it has always been a ever since I got the lighting to actually update at all.

 

Also, the block still doesn't update lighting when charging up. The main change from the previous code is that it actually logs HIGH, unlike any previous experiment.

 

Github

[V0idWa1k3r]

https://github.com/adudewithapc/Brighten-Up/blob/master/src/main/java/thatmartinguy/brightenup/block/BlockLamp.java#L34

Block::setLightLevel accepts a range of [0 - 1] and you are passing a 3.

https://github.com/adudewithapc/Brighten-Up/blob/master/src/main/java/thatmartinguy/brightenup/block/BlockLamp.java#L93

Block.lightValue is an integer that should be in range of [0 - 15]. In your case it is 45, as you are passing a 3 in your Block::setLightLevel.

Your light cycle is actually going to be

225 -> 90 -> 45 -> 0 (due to the way NibbleArray(the thing that stores the light values) functions it gets translated to 0 -> 9 -> 12 -> 0). 

 

If the code logs HIGH that means that you are either full of energy or your LightLevel calculations are off. Debug it further to see which case it is.

Edited June 26, 2017 by V0idWa1k3r

[That_Martin_Guy]

The block correctly calculates energy (log excerpt as proof). It just doesn't update when charging AFAIK.

Edited June 27, 2017 by That_Martin_Guy
typo

[That_Martin_Guy]

I managed to fix the lighting- somewhat. I just now realised that I was using Block#lightLevel to update my lighting, instead of the actual base light level like I had intended. A new variable has been introduced and the setLightLevel parameter that I passed in has also been updated. The multipliers for the lighting are a bit too high, though, and it gets brighter than minecraft can handle. A small tweak to them will fix it though.

 

Still, though, the lighting only updates when the block is draining, not when it gets charged. Why is this?

[That_Martin_Guy]

Does anyone have an idea? It would be horrible if I can't fix this mod-breaking bug.