1.8.9 Client Command not executing

[Irrational]

Hi there! I'm sure this is a noobish question, since I am new with forge, but I want to ask it anyway.

 

I'm updating a mod that integrates the YouTube Live Stream chat into the MC chat to 1.8.9. But after I make the necessary changes, the command won't execute. Not even a usage message (however, I do get one of those in the "mock" command). I'm not seeing anything in the MC client log, nor is it spitting out errors at me in the chat. It's just that nothing happens!

 

Here is my code: https://github.com/PeregrineZ/youtube-chat-for-minecraft/

 

Can anyone kindly explain to me what I've done wrong?

 

Thanks!

[Choonster]

YouTubeCommand#processCommand checks if World#isRemote is false, i.e. if the code is being called on the logical server. Since you register it with the client command handler, it will only ever be called from the logical client and the method won't do anything.

 

Is it meant to be a client command or a server command? If it's the former, check for the logical client rather than the logical server (or don't check at all, it will only ever be called on the side you register it for). If it's the latter, you need to register it in FMLServerStartingEvent using FMLServerStartingEvent#registerServerCommand.

 

If your command has sub-commands, you can extend CommandTreeBase and register each sub-command with CommandTreeBase#addSubcommand.

[Irrational]

  On 7/8/2017 at 4:47 AM, Choonster said:

YouTubeCommand#processCommand checks if World#isRemote is false, i.e. if the code is being called on the logical server. Since you register it with the client command handler, it will only ever be called from the logical client and the method won't do anything.

 

Is it meant to be a client command or a server command? If it's the former, check for the logical client rather than the logical server (or don't check at all, it will only ever be called on the side you register it for). If it's the latter, you need to register it in FMLServerStartingEvent using FMLServerStartingEvent#registerServerCommand.

 

If your command has sub-commands, you can extend CommandTreeBase and register each sub-command with CommandTreeBase#addSubcommand.

Expand  

Ah, I didn't see that part of the source.

 

This mod was originally coded for single-player only (surprisingly), which is why it checked for a local server, and not a remote one. I was reprogramming it to work on multiplayer.

 

Anyways, I'll build again and see what happens.

[Irrational]

  On 7/8/2017 at 4:47 AM, Choonster said:

YouTubeCommand#processCommand checks if World#isRemote is false, i.e. if the code is being called on the logical server. Since you register it with the client command handler, it will only ever be called from the logical client and the method won't do anything.

 

Is it meant to be a client command or a server command? If it's the former, check for the logical client rather than the logical server (or don't check at all, it will only ever be called on the side you register it for). If it's the latter, you need to register it in FMLServerStartingEvent using FMLServerStartingEvent#registerServerCommand.

 

If your command has sub-commands, you can extend CommandTreeBase and register each sub-command with CommandTreeBase#addSubcommand.

Expand  

 

  On 7/8/2017 at 5:54 AM, Irrational said:

Ah, I didn't see that part of the source.

 

This mod was originally coded for single-player only (surprisingly), which is why it checked for a local server, and not a remote one. I was reprogramming it to work on multiplayer.

 

Anyways, I'll build again and see what happens.

Expand  

Alright, now I've got another problem. 

 

I can't seem to find a way to reference the current MP Player client-side. I can use ICommandSender sender with some methods, but I can't with others because they override. I'm sure this is very noobish, and I'm probably just overlooking a method in the javadocs, but could you quickly point me in the right direction?

 

Thanks!

[Choonster]

  On 7/8/2017 at 2:56 PM, Irrational said:

I can't seem to find a way to reference the current MP Player client-side. I can use ICommandSender sender with some methods, but I can't with others because they override. I'm sure this is very noobish, and I'm probably just overlooking a method in the javadocs, but could you quickly point me in the right direction?

Expand  

 

The ICommandSender will usually be the client player, but this isn't guaranteed. Mods can execute client commands with their own ICommandSender if they want.

 

The Minecraft#player field contains the current client player.