Jump to content

[Solved][1.12] Getting Player/Chest Within a Loot Function/Condition


TheXFactor117

Recommended Posts

Long story short, I've been using the PlayerTickEvent to set certain items up with specific NBT data - works fine, but I don't necessarily want to loop through a player's inventory every tick for everyone on a given server. My idea of a solution was to use LootTables to spawn in said items with the given NBT data applied to it whenever they drop from a monster or are spawned in a chest. The problem is in order to setup this information, I need to get the chunk coordinates for where that item was dropped/looted from a chest (reason for this is chunks will be assigned a value, and I need to retrieve this value and set this value to the specific item drops and such). To get these coordinates I'd either need the player or chest TE position. The issue is partially solved when the item is dropped from a monster since I would have access to the monster killed or the player who killed it via LootContext - however, this doesn't help me with loot generated in chests.

 

My question is, does anything store the chest that was opened/the player who opened anywhere where I could access it easily, ideally from a custom LootFunction (or LootCondition because I think that could work too)? I read somewhere that this information is stored, but I'm not sure if that's entirely true and don't know where it would even be located.

Edited by TheXFactor117

Developer of Levels and Lost Eclipse

Link to comment
Share on other sites

4 minutes ago, diesieben07 said:

Yes, you could do that. Better yet, use a subclass of LootContext that can store the inventory, then you can check for that class in your loot pools.

 

Actually, I don't understand how this could even work. There's still not away to the get a player or chest from the inventory unless I'm missing something.

Developer of Levels and Lost Eclipse

Link to comment
Share on other sites

1 hour ago, TheXFactor117 said:

Actually, I don't understand how this could even work. There's still not away to the get a player or chest from the inventory unless I'm missing something.

Generally speaking, the IInventory in question will be an instance of the Tile Entity class of the appropriate type when filling tile entity inventories. So you can just check if the passed IInventory is an instance of TileEntity, then cast it and store it somewhere.

Whatever Minecraft needs, it is most likely not yet another tool tier.

Link to comment
Share on other sites

I know, I realized that now, not sure why it didn't occur to me. I don't have access to my code now but I was getting an IllegalStateException which said I was recursively loading in my loot table which didn't make a whole lot of sense. I was casting the loot table to my new LootTable class inside LootTableLoadEvent so maybe that was an issue or it was an issue with the class itself. 

 

Either way way I'll post code later if needed. My LootTableClass is basically a copy of the old one plus the new LootContext class and I'm sure that's where my issue is. I just haven't had time to look into it yet.

Developer of Levels and Lost Eclipse

Link to comment
Share on other sites

I'll mess with this when I get a chance. Just to make sure I'm understanding this correctly, when I load my own loot table, I need to create a new instance of my own LootTable class? I didn't really understand what you meant be check for that class in your pools - I'm assuming if a loot table is loaded as an instance of my LootTable class, it'll use my own LootContext which can store the chest position. I just need to make sure I'm loading everything properly because obviously I'm doing something wrong.

Developer of Levels and Lost Eclipse

Link to comment
Share on other sites

5 hours ago, diesieben07 said:

That sounds correct, yes.

 
 

I got it working now - though one thing isn't working properly and it's the fact that the NBT data isn't actually saving properly. I have a helper method which creates the data and adds it to the stack which gets called properly from within my function. However, this data doesn't actually make it for whatever reason because the tooltip doesn't display anything and the NBT doesn't actually have any of the data.

 

The data gets saved on the server - outputs, when it's in your inventory, show no data is on it, also on the server. I looked into the SetNBT function and they essentially create a new NBTTagCompound and merge it with the existing (if it's available). Though that doesn't really help. I don't really know what's happening or how to fix it so any insight would be helpful.

 

I've fixed everything now - my helper method for loading/saving NBT compounds wasn't working properly. Thanks for all the help!

Edited by TheXFactor117

Developer of Levels and Lost Eclipse

Link to comment
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hello, I don't have much experience with forge but I have some java knowledge, I want to add a button that says "Explore New Packs" to the Pause Screen that opens when we enter a world in the game and press the "esc" button, but I couldn't understand it (or I don't know how to use it), although I did research from artificial intelligence or different places. I was told that I can do it using mixins but I have no idea how to do it, can you explain step by step
    • We need the crash report or debug.log, as explained in the FAQ
    • i have the decocraft mod and i can see all of them. i can click right click and place the items but as soon as i put it down it disappears. im so sad it doesnt work and i dont know how to fix it. i used cursed forge to launch minecraft as well.
    • Me and my friend wanted to make a custom mod pack hosted on aternos. I downloaded the same mods as the server then started the server and my minecraft and I joined the server without issues. Then I sent the mods to my friend compressed in a zip folder (i don’t know if that has anything to do with the issue). He unpacked it put it in his mod folder and started it but couldn't join the server and got this issue:   internal exception: java.lang.runtimeexception: server not initialized yet! call IMDLib.entityHandler (modid)   Also we are using curseforge launcher to manage the mods on client side. But as I said it works on my side but not with my friend, that’s why it doesn’t make sense   Mod list:   xplosives-1.2.0.jar whisperwoods-1.18.2-2.1.0-forge.jar waystones-forge-1.18.2-10.2.2.jar voicechat-forge-1.18.2-2.4.32.jar trashslot-forge-1.18.2-11.0.3.jar towns_and_towers_forge-1.10.0.1+1.18.2.jar torchmaster-18.2.1.jar ToolBelt-1.18.2-1.18.9.jar toms_storage-1.18.2-1.4.4.jar swingthroughgrass-1.18.2-1.9.1.jar strictly_origins_v5.1_1.18.2.jar starlight-1.0.2+forge.546ae87.jar SpartanWeaponry-1.18.2-3.0.4.jar SimpleQuarry-1.18.2-18.2.5.jar simpleplanes-1.18.2-5.2.2.jar secretrooms-1.18.2-1.1.5.jar right-click-harvest-3.2.0+1.18.2-forge.jar REIPluginCompatibilities-forge-8.0.89.jar RoughlyEnough|tems-8.3.681-forge.jar RegionsUnexploredForge-0.4.1_1+1.18.2.jar TerraBlender-forge-1.18.2-1.2.0.126.jar Recall_Potion_v1.0.3-1.18.2.jar Quark-3.2-358.jar PickleTweaks-1.18.2-6.1.2.jar Pehkui-3.7.11+1.18.2-forge.jar Origins-1.18.2-1.4.1.4-unified.jar naturalist-forge-1.1.1-1.18.2.jar mysticaloaktree-1.18.2-1.2.jar selene-1.18.2-1.17.14.jar MysticalAgradditions-1.18.2-5.1.4.jar MysticalAgriculture-1.18.2-5.1.5.jar MultiMine-1.18.7.jar moyai-1.18.2-1.1.4.jar ModernDynamicSurroundings-5.0.0.4.jar lootbeams-1.18.1-release-july1722.jar journeymap-1.18.2-5.9.7-forge.jar ironfurnaces-1.18.2-3.3.3.jar ironchest-1.18.2-13.2.11.jar industrial-foregoing-1.18.2-3.3.1.6-10.jar titanium-1.18.2-3.5.11-45.jar immersive_armors-1.5.6+1.18.2-forge.jar hardcorerevival-forge-1.18.2-8.0.1.jar HammerLib-1.18.2-18.2.16. jar gravestone-1.18.2-1.0.1.jar geckolib-forge-1.18-3.0.57.jar findme-3.0.6-forge.jar faithfulbackrooms3.0.0.7.jar elevatorid-1.18.2-1.8.4.jar EasyMagic-v3.3.0-1.18.2-Forge.jar PuzzlesLib-v3.5.9-1.18.2-Forge.jar easy_villagers-1.18.2-1.0.11.jar easy_mob_farm_1.18.2-7.1.0.jar DynamicTrees-1.18.2-1.0.4.jar dragonseeker-1.1.1-1.18.2.jar iceandfire-2.1.12-1.18.2.jar Cucumber-1.18.2-5.1.5 jar cloth-config-6.5.116-forge.jar citadel-1.11.3-1.18.2.jar chunkloaders-1.2.8a-forge-mc1.18.jar supermartijn642configlib-1.1.8-forge-mc1.18.jar supermartijn642corelib-1.1.17-forge-mc1.18.jar cave_dweller-1.18.2-1.6.4.jar carryon-1.18.2-1.17.1.12.jar caelus-forge-1.18.1-3.0.0.2.jar BotanyTrees-Forge-1.18.2-4.0.13.jar BotanyPots-Forge-1.18.2-8.1.29.jar Bookshelf-Forge-1.18.2-13.3.56.jar balm-3.2.6.jar AutoRegLib-1.7-53.jar ars_nouveau-1.18.2-2.9.0.jar curios-forge-1.18.2-5.0.9.2.jar Patchouli-1.18.2-71.1.jar architectury-4.12.94-forge.jar almostunified-forge-1.18.2-0.3.10.jar [1.18.2] SecurityCraft v1.9.8.jar
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.