Jump to content

Recommended Posts

Posted (edited)

Hello, I am trying to run a method using the PopulateChunkEvent.populate event but the event does not seem to be firing in the End dimension. Here is a snippet of code I am using to show it is not working.

 

@SubscribeEvent
    public void populate(PopulateChunkEvent.Populate event){
        LogHelper.info("What is this? " + event.getWorld().provider.getDimensionType());
        switch (event.getWorld().provider.getDimensionType()) {
        case OVERWORLD:
            break;
        case NETHER:
            break;
        case THE_END:
            LogHelper.info("End populate");
            break;
        default:
            break;
        }
    }

 

The class has been annotated using @Mod.EventBusSubscriber and is also being registered to the event bus using both MinecraftForge.EVENT_BUS.register and MinecraftForge.TERRAIN_GEN_BUS.register. It works in the overworld and the nether just fine, but fails to occur in the end. As you can see in the log below, the event is called many times in the overworld but when I enter the end it ceases. Going out to the outer islands of the end does not fire the event either.

 

[22:19:23] [Server thread/INFO] [Mod]: What is this? OVERWORLD
[22:19:23] [Server thread/INFO] [Mod]: What is this? OVERWORLD
[22:19:23] [Server thread/INFO] Mod]: What is this? OVERWORLD
[22:19:23] [Server thread/INFO] [Mod]: What is this? OVERWORLD
[22:19:23] [Server thread/INFO] [Mod]: What is this? OVERWORLD
[22:19:23] [Server thread/INFO] [Mod]: What is this? OVERWORLD
[22:19:23] [Server thread/INFO] [Mod]: What is this? OVERWORLD
[22:19:23] [Server thread/INFO] [Mod]: What is this? OVERWORLD
[22:19:23] [Server thread/INFO] [Mod]: What is this? OVERWORLD
[22:19:23] [Server thread/INFO] [Mod]: What is this? OVERWORLD
[22:19:24] [Server thread/INFO]: Player274 has made the advancement [The End?]
[22:19:24] [main/INFO]: [CHAT] Player274 has made the advancement [The End?]
[22:19:24] [main/INFO]: Loaded 18 advancements
[22:19:26] [Server thread/INFO]: Scanning for legacy world dragon fight...
[22:19:26] [Server thread/INFO]: Found that the dragon has not yet been killed in this world.

 

I can't figure out what is going wrong, the event appears to be fired in both ChunkGeneratorOverworld and ChunkGeneratorEnd in amost exactly the same way. Chorus plants and end cities generate normally so it should be being called.

Edited by laton95
Added version to title
Posted

It looks like Forge only fires PopulateChunkEvent.Populate in ChunkGeneratorOverworld and ChunkGeneratorHell, but it fires PopulateChunkEvent.Pre/Post in these classes as well as in ChunkGeneratorEnd and ChunkGeneratorFlat.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Posted

 

  On 7/13/2017 at 1:49 PM, Choonster said:

It looks like Forge only fires PopulateChunkEvent.Populate in ChunkGeneratorOverworld and ChunkGeneratorHell, but it fires PopulateChunkEvent.Pre/Post in these classes as well as in ChunkGeneratorEnd and ChunkGeneratorFlat.

Expand  

Oh, thats odd. I wonder what the reason for that is.

Thanks for pointing it out, I guess I'll have to try and work with either the pre and post events.

Posted
  On 7/13/2017 at 1:54 PM, laton95 said:

Oh, thats odd. I wonder what the reason for that is.

Thanks for pointing it out, I guess I'll have to try and work with either the pre and post events.

Expand  

 

PopulateChunkEvent.Populate is fired for specific features and I guess nobody ever requested the addition of The End's 1.9 features.

 

If you create an issue or PR on GitHub, the missing features may be added to the event.

Please don't PM me to ask for help. Asking your question in a public thread preserves it for people who are having the same problem in the future.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

×   Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Managed to solve the issue myself. Solved by a fresh modpack instance.
    • Hello, so straight to the problem. Today i wanted to startup Enigmatica as usual and it just wont startup. Last night everything worked fine, i didnt even turn off my pc. Crash log: https://mclo.gs/GJ6Kcy1
    • Rubidium and Embeddium are versions of the same mod, you can only have one. I believe Embeddium is the one that's actively maintained.
    • Hello, New to modding, but have a solid CS foundation. I've created multiple custom BlockEntities that all have the same issue, which is that the inventory only updates on right click (overriding the useItemOn method). I've seen multiple posts on here outlining a similar issue to mine, but I've already implemented the solution of: overriding the correct methods in the BlockEntity class and calling setChanged(). I've tried every different place for setChanged() to no success. I'm wondering if I'm missing something else or if there was some change to sending data to the client in 1.21.5? Or will I have to use a custom packet sender? Here is the code for one of my BlockEntity classes with a single inventory slot: public class MyCustomBlockEntity extends BlockEntity { public final ItemStackHandler inventory = new ItemStackHandler(1) { @Override protected int getStackLimit(int slot, @NotNull ItemStack stack) { return 1; } @Override protected void onContentsChanged(int slot) { setChanged(); if (!level.isClientSide()) { level.setBlockAndUpdate(getBlockPos(), getBlockState()); } } }; public MyCustomBlockEntity(BlockPos pPos, BlockState pBlockState) { super(ModBlockEntities.MY_CUSTOM_BE.get(), pPos, pBlockState); } public void clearContents() { inventory.setStackInSlot(0, ItemStack.EMPTY); } public void dropItem() { SimpleContainer inv = new SimpleContainer(inventory.getSlots()); inv.setItem(0, inventory.getStackInSlot(0)); Containers.dropContents(this.level, this.worldPosition, inv); } @Override public void setRemoved() { dropItem(); super.setRemoved(); } @Override protected void saveAdditional(CompoundTag pTag, HolderLookup.Provider pRegistries) { super.saveAdditional(pTag, pRegistries); pTag.put("inventory", inventory.serializeNBT(pRegistries)); } @Override protected void loadAdditional(CompoundTag pTag, HolderLookup.Provider pRegistries) { super.loadAdditional(pTag, pRegistries); inventory.deserializeNBT(pRegistries, pTag.getCompound("inventory").get()); } @Override public Packet<ClientGamePacketListener> getUpdatePacket() { return ClientboundBlockEntityDataPacket.create(this); } @Override public CompoundTag getUpdateTag(HolderLookup.Provider pRegistries) { return saveWithoutMetadata(pRegistries); } } Mostly encountering the issue when calling the clearContents() method anywhere outside of useItemOn() in the Block class. I've also tried overriding both the handleUpdateTag() and onDataPacket() methods, calling their super along with loadAdditional(), but neither changed the outcome. Thanks in advance for any replies.
    • Hi all! I’m working on a Jurassic Park-themed mod for Minecraft 1.20.1, aiming to include dinosaurs, fossils, DNA extraction, and cool machines. This is a free project, mainly passion-driven, and I’ll give full credit to everyone involved. this is the perfect opportunity for beginners of modeling and coding. This project will give you experience and a creative freedom If you love dinosaurs and Minecraft modding, hit me up! Thanks! Add Me ogfrost. <--- Discord
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.