Hi guys,

I want to know in my KeyInputEvent which is the key pressed without write a code like this:

int n = 0;
if(KeyBindings.left.isPressed()){
	//EXAMPLE CODE
	n = 1;
}else if(KeyBindings.right.isPressed()){
	//EXAMPLE CODE
	n = 2;
}else if(KeyBindings.up.isPressed()){
	//EXAMPLE CODE
	n = 3;
}else if(KeyBindings.down.isPressed()){
	//EXAMPLE CODE
	n = 4;
}else if(KeyBindings.back.isPressed()){
	//EXAMPLE CODE
	n = 5;
}

because I need to check on ALL the key bindings (even to vanilla ones).

 

Is there a method to get this information from the event argument or can I get a list of all registered KeyBinding?

 

Add:

I've tryied with 

Set<String> binds = KeyBinding.getKeybinds();
for (String bind : binds) {
  System.out.println(bind);
}

but I can only see the categories:

key.categories.misc
key.categories.creative
key.categories.gameplay
key.categories.multiplayer
key.categories.movement
key.categories.inventory

Edited July 31, 20178 yr by oznecniV97
Add

Sorry but, why this is wrong?

	@SubscribeEvent
    public void onKeyInput(InputEvent.KeyInputEvent event) {
        if(KeyBindings.left.isPressed()){
        	//do something
        }
        if(KeyBindings.right.isPressed()){
        	//do something
        }
        if(KeyBindings.up.isPressed()){
        	//do something
        }
        if(KeyBindings.down.isPressed()){
        	//do something
        }
        if(KeyBindings.rompi.isPressed()){
        	//do something
        }
    }

For me it works without any problem.

 

Which are the improvement to use the ClientTickEvent instead of this?

UPDATE:

If I do this code (*) in the KeyInputEvent I can see the key pressed in the console but if the key works on a isPressed logic it didn't do the base logic (Ex: if I press E, I see "key.inventory - E" but my inventory didn't open).

If I do this code (*) in the PlayerTickEvent/ClientTickEvent if the key works on a isPressed logic I can't see the key pressed in the console but the key works as expected (Ex: if I press E, I can see my inventory opened but nothing in the console).

 

(*)

		Field campo = KeyBinding.class.getDeclaredField("KEYBIND_ARRAY");
    	campo.setAccessible(true);
    	Map<String, KeyBinding> binds = (Map<String, KeyBinding>) campo.get(null);
    	for (String bind : binds.keySet()) {
			if(binds.get(bind).isPressed()){
				System.out.println(bind + " - " + binds.get(bind).getDisplayName());
				break;
			}
		}

 

Edited July 31, 20178 yr by oznecniV97
Missing code

Ok thanks!

Now it work (more or less) with the following code:

private static Map<String, KeyBinding> binds = null;

@SubscribeEvent (priority = EventPriority.LOWEST) //END is not present
public void onClientTick(TickEvent.ClientTickEvent event) throws Exception {
	if(binds == null){
		Field campo = KeyBinding.class.getDeclaredField("KEYBIND_ARRAY");
    	campo.setAccessible(true);
    	binds = (Map<String, KeyBinding>) campo.get(null);
	}
	for (String bind : binds.keySet()) {
		if(binds.get(bind).isKeyDown()){
			System.out.println(bind + " - " + binds.get(bind).getDisplayName());
			break;
		}
	}
}

 

The only one issue that I've found is that if I press very fast a key that have a isPressed logic (like E key) it didn't catch the pressing event and print nothing.

Set this thread as solved.

With this update (check if phase is END):

private static Field KEYBIND_ARRAY = null;

	@SubscribeEvent (priority = EventPriority.LOWEST)
	public void onClientTick(TickEvent.ClientTickEvent event) throws Exception {
		if(KEYBIND_ARRAY == null){
			KEYBIND_ARRAY = KeyBinding.class.getDeclaredField("KEYBIND_ARRAY");
			KEYBIND_ARRAY.setAccessible(true);
		}
		if(event.phase.equals(Phase.END)){
			Map<String, KeyBinding> binds = (Map<String, KeyBinding>) KEYBIND_ARRAY.get(null);
	    	for (String bind : binds.keySet()) {
				if(binds.get(bind).isKeyDown()){
					System.out.println(bind + " - " + binds.get(bind).getDisplayName());
					break;
				}
			}
		}
	}

I see no difference about the issue.

 

I have a doubt of how can I set the static Field to final because if I do that and set equals to KeyBinding.class.getDeclaredField("field") eclipse give me an error and didn't compile it because there's a throws declaration on this method.

5 minutes ago, diesieben07 said:

Are such short presses even detected by Minecraft itself?

Yes, this issue is basically related to the open phase of a GUI. If I short press E I see the inventory opened but in the console I can't see nothing (Same problem with L key Advancements). In the others cases (even the E press to close the inventory) I see it.

Oh ok, now it's clear!

Thanks @diesieben07

Vanilla methods/fields have more than one name: there's the Notch name (Mojang's obfuscated names that change each version), the SRG name (MCP's auto-generated names that remain stable between versions) and the MCP name (MCP's community-assigned deobfuscated names). Forge deobfuscates from Notch to SRG names at runtime, so you never need to worry about Notch names.

 

For normal code, ForgeGradle reobfuscates from MCP to SRG names at build time, so you don't need to worry about the names.

 

For reflection, you need to check both the SRG and the MCP names for vanilla fields and methods yourself. The easiest way to do this is by using Forge's ReflectionHelper.findMethod/findField methods. These don't throw any checked exceptions, so you can use them directly in the field initialiser of the Method/Field field.

 

You can use MCPBot to find the SRG name of a method/field.