[1.11.2] [SOLVED] SimpleImpl Issues

[jdawg3636]

Hello, I'm trying to set up some basic networking functionality for my mod. I've looked around at various online tutorials, including the forge docs, and I've gotten it set up without errors. However, for some reason, the server does not appear to be receiving the messages.

 

I am running this code on the client (NOTE: getModList() returns a String):

Main.FACINSTANCE.sendToServer( new MyMessage( this.getModList() ) );
System.out.println( "SENT LIST TO SERVER!!!" );

Here is my "MyMessage" class and its embedded handler:

import io.netty.buffer.ByteBuf;
import net.minecraftforge.fml.common.network.ByteBufUtils;
import net.minecraftforge.fml.common.network.simpleimpl.IMessage;
import net.minecraftforge.fml.common.network.simpleimpl.IMessageHandler;
import net.minecraftforge.fml.common.network.simpleimpl.MessageContext;

public class MyMessage implements IMessage {

	  public MyMessage(){}

	  private String text;
	  public MyMessage(String text) {
	    this.text = text;
	  }

	  @Override public void toBytes(ByteBuf buf) {
		  ByteBufUtils.writeUTF8String(buf, text);
	  }

	  @Override public void fromBytes(ByteBuf buf) {
		  text = ByteBufUtils.readUTF8String(buf);
	  }
	  
	  public static class MyMessageHandler implements IMessageHandler<MyMessage, IMessage> {
		  
		  @Override public IMessage onMessage( MyMessage message, MessageContext ctx ) {
			  System.out.println(String.format("Received %s from %s", message.text, ctx.getServerHandler().playerEntity.getDisplayName()));
	          return null;
		  }
	  }
}

However, on the server end, Handler's onMessage method does not appear to be getting called. Nothing is printed to its console. From my understanding, this method should be called automatically by Forge. If this is not the case, then I need to know how and when to properly call it myself.

 

Here are some smaller snippets of code from other areas just in case they're relevant:

 

Main Mod Class:

public static SimpleNetworkWrapper FACINSTANCE;

CommonProxy preInit():

Main.FACINSTANCE = NetworkRegistry.INSTANCE.newSimpleChannel( "forgeanticheat" );
Main.FACINSTANCE.registerMessage(MyMessageHandler.class, MyMessage.class, 0, Side.SERVER );

 

Please let me know if you need any more information. Thanks in advance!

Edited September 10, 2017 by jdawg3636
Changed title to [SOLVED]

[jdawg3636]

  On 8/15/2017 at 1:42 PM, diesieben07 said:

Why is this in your "CommonProxy"? The idea of a "common proxy" does not make sense, proxies are inherently "sideful" and not "common", they contain side-specific code. Common code goes in your main mod class or other organization classes.

Expand  

Yes, sorry, I should have explained this. "CommonProxy" is code run on both sides. It is essentially just a way to clean up the main mod class. I have tested and can confirm that the code there gets run at the proper time.

 

  On 8/15/2017 at 1:42 PM, diesieben07 said:

Where are you calling sendToServer? Show more code.

Expand  

I am calling it from the ClientProxy on server join. The System.out.println statement is being called at the correct time, so I assume that sendToServer is being called as well.

  On 8/15/2017 at 1:42 PM, diesieben07 said:

As a heads up: This idea of an "anti-cheat" will not work. The client will just lie to the server about which mods are installed.

Expand  

Yes, I am aware that anyone with even a scrap of knowledge of Java could easily break this system. I am designing it purely as a deterrent for obnoxious players on my modded servers. If it stops even one person, then It'll be worth it.

Edited August 15, 2017 by jdawg3636
Autocorrect being dumb

[jdawg3636]

  On 8/15/2017 at 7:49 PM, diesieben07 said:

What is "on server join", exactly?

Expand  

Server Join is FMLNetworkEvent.ClientConnectedToServerEvent

 

  On 8/15/2017 at 1:42 PM, diesieben07 said:

Show more code.

Expand  

Main Mod Class:

  Reveal hidden contents

package com.jdawg3636.forgeanticheat.init;

import com.jdawg3636.forgeanticheat.proxy.CommonProxy;

import net.minecraftforge.fml.common.Mod;
import net.minecraftforge.fml.common.Mod.EventHandler;
import net.minecraftforge.fml.common.SidedProxy;
import net.minecraftforge.fml.common.event.FMLInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPostInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPreInitializationEvent;
import net.minecraftforge.fml.common.network.simpleimpl.SimpleNetworkWrapper;



@Mod( modid = Main.MODID, version = Main.VERSION )
public class Main {
	
    // Variables
	public static final String MODID = "forgeanticheat";
    public static final String VERSION = "1.0";
    static boolean debug = true;
    
    // Getter Methods
    public static boolean getDebugMode() {
    	return debug;
    }
    
    // Network Setup
    public static SimpleNetworkWrapper FACINSTANCE;
    
    // Proxy Setup
    @SidedProxy( clientSide = "com.jdawg3636.forgeanticheat.proxy.ClientProxy", serverSide = "com.jdawg3636.forgeanticheat.proxy.ServerProxy" )
    public static CommonProxy proxy;
    
    @EventHandler
    public void preInit( FMLPreInitializationEvent event ) {
    	proxy.preInit( event );
    }
    
    @EventHandler
    public void init( FMLInitializationEvent event ) {
    	proxy.init( event );
    }
    
    @EventHandler
    public void postInit( FMLPostInitializationEvent event ) {
    	proxy.postInit( event );
    }
    
}

 

EventHandler:

  Reveal hidden contents

package com.jdawg3636.forgeanticheat.init;

import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;
import net.minecraftforge.fml.common.network.FMLNetworkEvent;

public class EventHandler {
	
	@SubscribeEvent
    public void serverJoin( FMLNetworkEvent.ClientConnectedToServerEvent event ) {
		com.jdawg3636.forgeanticheat.init.Main.proxy.serverJoin( event );
    }
	
	@SubscribeEvent
    public void clientJoin( FMLNetworkEvent.ServerConnectionFromClientEvent event ) {
		com.jdawg3636.forgeanticheat.init.Main.proxy.clientJoin( event );
    }
	
}

 

MyMessage:

  Reveal hidden contents

package com.jdawg3636.forgeanticheat.network;

import io.netty.buffer.ByteBuf;
import net.minecraftforge.fml.common.network.ByteBufUtils;
import net.minecraftforge.fml.common.network.simpleimpl.IMessage;
import net.minecraftforge.fml.common.network.simpleimpl.IMessageHandler;
import net.minecraftforge.fml.common.network.simpleimpl.MessageContext;

public class MyMessage implements IMessage {

	  public MyMessage(){}

	  private String text;
	  public MyMessage(String text) {
	    this.text = text;
	  }

	  @Override public void toBytes(ByteBuf buf) {
		  ByteBufUtils.writeUTF8String(buf, text);
	  }

	  @Override public void fromBytes(ByteBuf buf) {
		  text = ByteBufUtils.readUTF8String(buf);
	  }
	  
	  public static class MyMessageHandler implements IMessageHandler<MyMessage, IMessage> {
		  
		  @Override public IMessage onMessage( MyMessage message, MessageContext ctx ) {
			  System.out.println(String.format("Received %s from %s", message.text, ctx.getServerHandler().playerEntity.getDisplayName()));
	          return null;
		  }
	  }
}

 

CommonProxy:

  Reveal hidden contents

package com.jdawg3636.forgeanticheat.proxy;

import com.jdawg3636.forgeanticheat.init.EventHandler;
import com.jdawg3636.forgeanticheat.init.Main;
import com.jdawg3636.forgeanticheat.network.MyMessage;
import com.jdawg3636.forgeanticheat.network.MyMessage.MyMessageHandler;

import net.minecraftforge.fml.common.FMLCommonHandler;
import net.minecraftforge.fml.common.Loader;
import net.minecraftforge.fml.common.event.FMLInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPostInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPreInitializationEvent;
import net.minecraftforge.fml.common.network.FMLNetworkEvent;
import net.minecraftforge.fml.common.network.NetworkRegistry;
import net.minecraftforge.fml.relauncher.Side;



public class CommonProxy {
	public void preInit( FMLPreInitializationEvent event ) {
		System.out.println( "CommonProxy PreInit" );
		// Networking
		Main.FACINSTANCE = NetworkRegistry.INSTANCE.newSimpleChannel( "forgeanticheat" );
		Main.FACINSTANCE.registerMessage(MyMessageHandler.class, MyMessage.class, 0, Side.SERVER );
		
    }

    public void init( FMLInitializationEvent event ) {
    	
    	// Event Handling
    	FMLCommonHandler.instance().bus().register( new EventHandler() );
    }

    public void postInit( FMLPostInitializationEvent event ) {
    	
    	// Debug
    	if ( com.jdawg3636.forgeanticheat.init.Main.getDebugMode() == true ) {
    		String modlist = Loader.instance().getModList().toString();
    		System.out.println( "Mod List: " + modlist );
    		System.out.println( "Mod List Printed to Console" );
    	}
    	
    }
    
    public void serverJoin( FMLNetworkEvent.ClientConnectedToServerEvent event ) {
    	
    }
    
    public void clientJoin( FMLNetworkEvent.ServerConnectionFromClientEvent event ) {
    	
    }
    
}

 

ClientProxy:

  Reveal hidden contents

package com.jdawg3636.forgeanticheat.proxy;

import com.jdawg3636.forgeanticheat.init.Main;
import com.jdawg3636.forgeanticheat.network.MyMessage;

import net.minecraftforge.fml.common.Loader;
import net.minecraftforge.fml.common.event.FMLInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPostInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPreInitializationEvent;
import net.minecraftforge.fml.common.network.FMLNetworkEvent;



public class ClientProxy extends CommonProxy {
	
	String modlist;
	
	public String getModList() {
    	return modlist;
    }
	
	@Override
    public void preInit( FMLPreInitializationEvent event ) {
        super.preInit( event );
    }

    @Override
    public void init( FMLInitializationEvent event ) {
        super.init( event );
    }

    @Override
    public void postInit( FMLPostInitializationEvent event ) {
    	super.postInit( event );
    	modlist = Loader.instance().getModList().toString();
    }
    
    @Override
    public void serverJoin( FMLNetworkEvent.ClientConnectedToServerEvent event ) {
    	super.serverJoin( event );
    	Main.FACINSTANCE.sendToServer( new MyMessage( this.getModList() ) );
    	System.out.println( "SENT LIST TO SERVER!!!" );
    }
    
}

 

ServerProxy:

  Reveal hidden contents

package com.jdawg3636.forgeanticheat.proxy;

import net.minecraftforge.fml.common.event.FMLInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPostInitializationEvent;
import net.minecraftforge.fml.common.event.FMLPreInitializationEvent;
import net.minecraftforge.fml.common.network.FMLNetworkEvent;

public class ServerProxy extends CommonProxy {
	@Override
    public void preInit( FMLPreInitializationEvent event ) {
        super.preInit( event );
    }

    @Override
    public void init( FMLInitializationEvent event ) {
        super.init( event );
    }

    @Override
    public void postInit( FMLPostInitializationEvent event ) {
        super.postInit( event );
    }
    
    @Override
    public void clientJoin( FMLNetworkEvent.ServerConnectionFromClientEvent event ) {
    	super.clientJoin( event );
    	System.out.println( "Client Connected" );
    }
}

 

 

[jdawg3636]

  On 8/16/2017 at 8:02 AM, diesieben07 said:

This is too early to send packets.

Expand  

Okay... I'm wanting to send the message when the client joins the server. Is there another event that I can hook into?

 

[jdawg3636]

  On 8/17/2017 at 7:57 AM, diesieben07 said:

You'll just have to wait for one tick.

What is this message supposed to do?

Expand  

It is intended to send a copy of the client's mod list to the server. What would be the best method of waiting a tick?

[jdawg3636]

  On 8/22/2017 at 1:31 PM, diesieben07 said:

What are you trying to achieve?

Expand  

Make a basic anticheat mod for server modpacks

  On 8/15/2017 at 1:42 PM, diesieben07 said:

This idea of an "anti-cheat" will not work. The client will just lie to the server about which mods are installed.

Expand  

  On 8/15/2017 at 7:24 PM, jdawg3636 said:

Yes, I am aware that anyone with even a scrap of knowledge of Java could easily break this system. I am designing it purely as a deterrent for obnoxious players on my modded servers. If it stops even one person, then It'll be worth it.

Expand  

Also, I have found that the majority of cheaters don't know how Java works. Usually just some obnoxious kid with an Xray mod.

  On 8/22/2017 at 1:31 PM, diesieben07 said:

Forge already does this.

Expand  

How and when would I go about accessing this list? Also I might send other information in the future so I would still like to work this out.

  On 8/21/2017 at 11:29 PM, jdawg3636 said:

What would be the best method of waiting a tick?

Expand  

This is probably a really dumb question but I'm new to this.

[jdawg3636]

  On 8/23/2017 at 9:06 AM, diesieben07 said:

You wait a tick by subscribing to ClientTickEvent.

Expand  

Thanks! Just for future reference: I had to wait more than one tick. Five seems to do the trick; I'm not exactly sure what the minimum is.