Problem with Tileentity and Special Renderer

[Dustpuppy]

Hi,

i have a funny problem with my tile entity. It's a jar, like in one of the tutorials from MrCrayfish. It work's ok, but if i place a second one in the world, both jars running synced. If i put an item in one jar, it also spawns in the second jar. If i destroy one of the jars, i got my items back and the other jar will become empty. It's like i have a clone of it, but not a seperate one.

 

Here's my Block class

package thewizardmod.jars;

import java.util.List;

import javax.annotation.Nullable;

import net.minecraft.block.Block;
import net.minecraft.block.ITileEntityProvider;
import net.minecraft.block.material.Material;
import net.minecraft.block.state.IBlockState;
import net.minecraft.creativetab.CreativeTabs;
import net.minecraft.entity.Entity;
import net.minecraft.entity.player.EntityPlayer;
import net.minecraft.item.ItemStack;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.BlockRenderLayer;
import net.minecraft.util.EnumBlockRenderType;
import net.minecraft.util.EnumFacing;
import net.minecraft.util.EnumHand;
import net.minecraft.util.math.AxisAlignedBB;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.IBlockAccess;
import net.minecraft.world.World;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;
import thewizardmod.items.StartupCommon;

public class BlockJar extends Block implements ITileEntityProvider
{
	private static final AxisAlignedBB BOUNCING_BOX = new AxisAlignedBB(0.0625 * 3, 0, 0.0625 * 3, 0.0625 * 13, 0.0625 * 15, 0.0625 * 13);
	private static final AxisAlignedBB COLLISION_BOX = new AxisAlignedBB(0.0625 * 4, 0, 0.0625 * 4, 0.0625 * 12, 0.0625 * 14, 0.0625 * 12);
	
  public BlockJar()
  {
    super(Material.GLASS);
    this.setCreativeTab(CreativeTabs.MISC);   // the block will appear on the Blocks tab in creative
    

    setHardness(0.3F);
    
  }

  @SideOnly(Side.CLIENT)
  public BlockRenderLayer getBlockLayer()
  {
    return BlockRenderLayer.TRANSLUCENT;
  }

  @Override
  public boolean isOpaqueCube(IBlockState iBlockState) {
    return false;
  }

  @Override
  public boolean isFullCube(IBlockState iBlockState) {
    return false;
  }

  @Override
  @Deprecated
	public boolean hasTileEntity() {
	return true;
  }
  
  @Override
  public EnumBlockRenderType getRenderType(IBlockState iBlockState) {
    return EnumBlockRenderType.MODEL;
  }

  
  @Override
  @Deprecated
  public AxisAlignedBB getBoundingBox(IBlockState state, IBlockAccess source, BlockPos pos) {
	  return BOUNCING_BOX;
  }
  
  @Override
  @Deprecated
  public void addCollisionBoxToList(IBlockState state, World worldIn, BlockPos pos, AxisAlignedBB entityBox, List<AxisAlignedBB> collidingBoxes, @Nullable Entity entityIn) {
	  super.addCollisionBoxToList(pos, entityBox, collidingBoxes, COLLISION_BOX);
  }

  @Override
  public TileEntity createNewTileEntity(World worldIn, int meta) {
	return new TileEntityJar();
  }
  
  @Override
  public boolean onBlockActivated(World worldIn, BlockPos pos, IBlockState state, EntityPlayer playerIn, EnumHand hand, @Nullable ItemStack heldItem, EnumFacing side, float hitX, float hitY, float hitZ) {
	  if(!worldIn.isRemote)
	  {
		  TileEntity tileEntity = worldIn.getTileEntity(pos);
		  if(tileEntity instanceof TileEntityJar)
		  {
			  TileEntityJar jar = (TileEntityJar) tileEntity;
			  if(heldItem != null)
			  {
				  if(heldItem.getItem() == StartupCommon.magicGem);
				  {
					  if(jar.addItem())
					  {
						  heldItem.stackSize--;
						  return true;
					  }
				  }
			  }
			  jar.removeItem();
		  }
	  }
	  return true;
  }
  
  @Override
  public void breakBlock(World worldIn, BlockPos pos, IBlockState state)
  {
      if (!worldIn.isRemote)
      {
          TileEntity tileEntity = worldIn.getTileEntity(pos);
             
          if (tileEntity instanceof TileEntityJar)
          {
              TileEntityJar jar = (TileEntityJar) tileEntity;
                 
              while (jar.counter > 0)
              {
                  jar.removeItem();
              }
          }
      }
         
      super.breakBlock(worldIn, pos, state);
  }

}

 

My Tile Entity

package thewizardmod.jars;

import javax.annotation.Nullable;

import thewizardmod.items.StartupCommon;

import net.minecraft.block.state.IBlockState;
import net.minecraft.entity.item.EntityItem;
import net.minecraft.init.Items;
import net.minecraft.item.Item;
import net.minecraft.item.ItemStack;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.network.NetworkManager;
import net.minecraft.network.Packet;
import net.minecraft.network.play.server.SPacketUpdateTileEntity;
import net.minecraft.tileentity.TileEntity;

public class TileEntityJar extends TileEntity{

	public static int counter = 0;
	private int MAX = 14;
	
	public boolean addItem()
	{
		if(counter < MAX)
		{
			counter++;
			markDirty();
			IBlockState state = worldObj.getBlockState(pos);
			worldObj.notifyBlockUpdate(pos, state, state, 3);
			return true;
		}
		return false;
	}
	
	public void removeItem()
	{
			if(counter > 0)
			{
				worldObj.spawnEntityInWorld(new EntityItem(worldObj, pos.getX() + 0.5F, pos.getY() + 1, pos.getZ() + 0.5F, new ItemStack(StartupCommon.magicGem)));
				counter --;
				markDirty();
				IBlockState state = worldObj.getBlockState(pos);
				worldObj.notifyBlockUpdate(pos, state, state, 3);
			}
	}
	
	@Override
	public NBTTagCompound writeToNBT(NBTTagCompound compound) {
		super.writeToNBT(compound);
		compound.setInteger("counter", counter);
		return compound;
	}

	@Override
	public void readFromNBT(NBTTagCompound compound) {
		super.readFromNBT(compound);
		this.counter = compound.getInteger("counter");
	}
	
	@Override
	public void onDataPacket(NetworkManager net, SPacketUpdateTileEntity pkt) {
		NBTTagCompound tag = pkt.getNbtCompound();
		this.counter = tag.getInteger("counter");
	}
	
	@Override
	@Nullable
	public SPacketUpdateTileEntity getUpdatePacket() {
		NBTTagCompound tag = new NBTTagCompound();
		tag.setInteger("counter", counter);
		return new SPacketUpdateTileEntity(pos, getBlockMetadata(), tag);
	}
	
	@Override
	public NBTTagCompound getUpdateTag() {
		NBTTagCompound tag = super.getUpdateTag();
		tag.setInteger("counter", counter);
		return tag;
	}
	
}

 

My Special Renderer

package thewizardmod.jars;

import thewizardmod.items.StartupCommon;
import net.minecraft.client.Minecraft;
import net.minecraft.client.renderer.GlStateManager;
import net.minecraft.client.renderer.tileentity.TileEntitySpecialRenderer;
import net.minecraft.entity.item.EntityItem;
import net.minecraft.item.ItemStack;

public class RendererJar extends TileEntitySpecialRenderer<TileEntityJar>{

	private static final EntityItem ITEM = new EntityItem(Minecraft.getMinecraft().theWorld, 0, 0, 0, new ItemStack(StartupCommon.magicGem));
	
	@Override
	public void renderTileEntityAt(TileEntityJar te, double x, double y, double z, float partialTicks, int destroyStage) {
		super.renderTileEntityAt(te, x, y, z, partialTicks, destroyStage);
	
		// For items that hover around
		ITEM.hoverStart = 0F;
		float pt = 0F;
//		float pt = partialTicks;
		
		GlStateManager.pushMatrix();
		{
			GlStateManager.translate(x, y, z);
			GlStateManager.rotate(90F, 1, 0, 0);
			GlStateManager.translate(0.5F, 0.1F, -0.1F);
			GlStateManager.scale(0.7F, 0.7F, 0.7F);
			for(int i = 0; i < te.counter; i++)
			{
				Minecraft.getMinecraft().getRenderManager().doRenderEntity(ITEM, 0, 0, 0, 0F, pt, false);
				GlStateManager.translate(0, 0, -0.0625F);
			}
		}
		GlStateManager.popMatrix();
	}
}

 

I register the block in my common proxy

package thewizardmod.jars;

import thewizardmod.TheWizardMod;
import net.minecraft.item.ItemBlock;
import net.minecraftforge.fml.common.registry.GameRegistry;

public class StartupCommon
{
  public static BlockJar jar;
  public static ItemBlock itemJar;



  public static void preInitCommon()
  {
    jar = (BlockJar)(new BlockJar().setUnlocalizedName("twm_jar_unlocalised_name"));
    jar.setRegistryName("jar");
    GameRegistry.register(jar);

    itemJar = new ItemBlock(jar);
    itemJar.setRegistryName(jar.getRegistryName());
    GameRegistry.register(itemJar);

    GameRegistry.registerTileEntity(TileEntityJar.class, TheWizardMod.MODID + "TileEntityJar");
  
}

  public static void initCommon()
  {
  }

  public static void postInitCommon()
  {
  }

}

 

and the model and renderer in my Client proxy

package thewizardmod.jars;

import net.minecraft.client.renderer.block.model.ModelResourceLocation;
import net.minecraftforge.client.model.ModelLoader;
import net.minecraftforge.fml.client.registry.ClientRegistry;

public class StartupClientOnly
{
  public static void preInitClientOnly()
  {
	    final int DEFAULT_ITEM_SUBTYPE = 0;
    ModelResourceLocation itemModelResourceLocation = new ModelResourceLocation("thewizardmod:jar", "inventory");
    ModelLoader.setCustomModelResourceLocation(StartupCommon.itemJar, DEFAULT_ITEM_SUBTYPE, itemModelResourceLocation);

    ClientRegistry.bindTileEntitySpecialRenderer(TileEntityJar.class, new RendererJar());

}

  public static void initClientOnly()
  {
  }

  public static void postInitClientOnly()
  {
  }
}

 

I've started learning Java just 2 weeks ago. If you see crap in files, please don't blame me. Still learning.

 

Edited August 31, 2017 by Dustpuppy

[Dustpuppy]

Oh, i forgot...it's MC 1.10.2 :-)

 

[Dustpuppy]

That's how it look like. First picture, one jar placed, all ok. Second picture, another jar placed, same amount of items in. If i took out an item of one of them, both sync to the same amount.

 

[Alpvax]

Your counter variable is static, so all tileentities will have the same number of items in

[Dustpuppy]

7 minutes ago, Alpvax said:

Your counter variable is static, so all tileentities will have the same number of items in

That was the problem. Thank's for open my eyes.

[Dustpuppy]

Then i have another question on top of this. How can i make it, that i don't drop all items in the jar and destroy it, but take the full jar into my inventory?

 

[Alpvax]

Quote

Excerpt from your Block class:

@Override
public void breakBlock(World worldIn, BlockPos pos, IBlockState state)
  {
      if (!worldIn.isRemote)
      {
          TileEntity tileEntity = worldIn.getTileEntity(pos);
             
          if (tileEntity instanceof TileEntityJar)
          {
              TileEntityJar jar = (TileEntityJar) tileEntity;
                 
              while (jar.counter > 0)
              {
                  jar.removeItem();
              }
          }
      }
         
      super.breakBlock(worldIn, pos, state);
  }

This is the code that drops all the items when the block is broken. You need to change it so that it doesn't call `jar.removeItem();` but you need to save the counter value to the itemstack NBT (Try following the super call back to where items are dropped, see which method it is and override that one instead). Try looking at banners, they save their pattern etc to the NBT of the stack in an easy to follow way.

Edited August 31, 2017 by Alpvax

[Dustpuppy]

Saving the data works, but when i replace the jar, the items will be rendered at the old position. No idea, why.

 

 

[Dustpuppy]

Ups...the new code

  @Override
  public final ArrayList<ItemStack> getDrops(IBlockAccess world, BlockPos pos, IBlockState state, int fortune) {
  	int meta = state.getBlock().getMetaFromState(state);
  	ItemStack ret = new ItemStack(this, 1, meta);
  	NBTTagCompound compound = new NBTTagCompound();
  	TileEntity tileEntity = world.getTileEntity(pos);
  	NBTTagCompound tileEntityTag = new NBTTagCompound();
  	tileEntity.writeToNBT(tileEntityTag);
  	compound.setTag("TileEntityData", tileEntityTag);
  	ret.setTagCompound(compound);
  	return Lists.newArrayList(ret);
  }

  @Override
  public boolean removedByPlayer(IBlockState state, World world, BlockPos pos, EntityPlayer player,	boolean willHarvest) {
  	if (willHarvest) return true; 
  	return super.removedByPlayer(state, world, pos, player, willHarvest);
  }

  @Override
  public void harvestBlock(World world, EntityPlayer player, BlockPos pos, IBlockState state, TileEntity tileEntity, ItemStack tool) {
  	super.harvestBlock(world, player, pos, state, tileEntity, tool);
  	world.setBlockToAir(pos);
  }

  @Override
  public void onBlockPlacedBy(World worldIn, BlockPos pos, IBlockState state, EntityLivingBase placer, ItemStack stack) {
  	super.onBlockPlacedBy(worldIn, pos, state, placer, stack);
  	if (stack.hasTagCompound() && stack.getTagCompound().hasKey("TileEntityData")) {
  		NBTTagCompound tag = stack.getTagCompound().getCompoundTag("TileEntityData");
  		worldIn.getTileEntity(pos).readFromNBT(tag);
  	}
  }

 

[Dustpuppy]

Found it by my self

The saved tag need to have the key "BlockEntityTag". Then minecraft restores the data it self and i don't need onBlockPlacedBy anymore.

Haaaa!!!! ..... 2 Weeks on java and i get better every day.