Jump to content

[1.10.2] Store Item or Blocks for recipe in same variable


Recommended Posts

Posted
 
public class ModMaterial {
    private String name;
    private Item craftingMaterial;

    //tools
    private int harvestLevel;
    private int maxUses;
    private Float efficiency;
    private Float damage;
    private int enchantability;
    private Item.ToolMaterial toolMaterial;

    //constructor
    public ModMaterial(final String name, final Item craftingMaterial, final int harvestLevel, final int maxUses, final Float efficiency, final Float damage, final int enchantability) {
        this.name = name;
        this.craftingMaterial = craftingMaterial;
        this.harvestLevel = harvestLevel;
        this.maxUses = maxUses;
        this.efficiency = efficiency;
        this.damage = damage;
        this.enchantability = enchantability;
        this.toolMaterial = EnumHelper.addToolMaterial(name,harvestLevel, maxUses, efficiency, damage, enchantability);
    }
}

 

I have this class to create objects which store info about materials for my mod. Right now the crafting material is specified as an Item type, but I want it to also accept Block types as this is used in recipes and some are made from blocks and some are made from items. Any ideas?

 

 

Posted

So I added this and it works for accepting one of the two types.

 

public class ModMaterial {
    private String name;
    private Item craftingItem;
    private Block craftingBlock;

    //tools
    private int harvestLevel;
    private int maxUses;
    private Float efficiency;
    private Float damage;
    private int enchantability;
    private Item.ToolMaterial toolMaterial;

    //constructor
    public ModMaterial(final String name, final Item craftingItem, final boolean hiltOnly, final int harvestLevel, final int maxUses, final Float efficiency, final Float damage, final int enchantability) {
        this.name = name;
        this.craftingItem = craftingItem;
        this.harvestLevel = harvestLevel;
        this.maxUses = maxUses;
        this.efficiency = efficiency;
        this.damage = damage;
        this.enchantability = enchantability;
        this.toolMaterial = EnumHelper.addToolMaterial(name,harvestLevel, maxUses, efficiency, damage, enchantability);
    }

    //constructor
    public ModMaterial(final String name, final Block craftingBlock, final int harvestLevel, final int maxUses, final Float efficiency, final Float damage, final int enchantability) {
        this.name = name;
        this.craftingBlock = craftingBlock;
        this.harvestLevel = harvestLevel;
        this.maxUses = maxUses;
        this.efficiency = efficiency;
        this.damage = damage;
        this.enchantability = enchantability;
        this.toolMaterial = EnumHelper.addToolMaterial(name,harvestLevel, maxUses, efficiency, damage, enchantability);
    }

    //output
    public String name() { return this.name; }
    public String nameLower() { return this.name.toLowerCase(); }
    public Item craftingMaterial() {
        if (this.craftingItem != null) {
            return this.craftingItem;
        } else {
            return this.craftingBlock;
        }
    }
}

 

The output function (craftingMaterial()) does not work though, because it has to be declared as a type (meaning I can't do the if statement in it which I tried). I don't understand what getItemFromBlock is and can't find it in the documentation and my my ide can't resolve it.

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

  Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

  Your link has been automatically embedded.   Display as a link instead

  Your previous content has been restored.   Clear editor

  You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • The problem occurs also in 1.20.1 Forge, but with an "Error executing task on client" instead. I have "Sinytra Connector" installed. On 1.21.5 Fabric, there is no problem. When this happens, the chat message before the death screen appears gets sent, with an extra dash added.
    • Well, as usual, it was user error. Naming mismatch in sounds.json.  Please delete this post if you find it necessary. 
    • Hello Forge community.  I'm running into an issue with a mod I'm working on.  To preface, I can call /playsound modId:name music @a and I can hear the sound I registered being played in game. Great!  However, I cannot get it to trigger via my mod code.    Registration: public static final RegistryObject<SoundEvent> A_WORLD_OF_MADNESS = SOUND_EVENTS.register("a_world_of_madness", () -> new SoundEvent(new ResourceLocation("tetheredsouls", "a_world_of_madness")));   Playback: Minecraft mc = Minecraft.getInstance(); if (!(mc.player instanceof LocalPlayer) || mc.level == null) return; LocalPlayer player = (LocalPlayer) mc.player; BlockPos pos = player.blockPosition(); SoundEvent track = ModSounds.A_WORLD_OF_MADNESS.get(); System.out.println(track); System.out.println(pos); System.out.println(player); // play exactly like the tutorial: client-only, at the player's position try { mc.level.playLocalSound( player.getX(), player.getY(), player.getZ(), track, SoundSource.MUSIC, // Or MASTER if needed 1f, 1f, false ); System.out.println("[DEBUG] playSound success: " + track.getLocation()); } catch (Exception e) { System.err.println("[ERROR] Failed to play sound: " + track.getLocation()); e.printStackTrace(); } Sounds.json:   { "theme_of_laura": { "category": "music", "sounds": [ { "name": "tetheredsouls:a_world_of_madness", "stream": true } ] } } Things I have tried: - multiple .ogg files. Short .ogg files (5 seconds, <100KB).  - default minecraft sounds imported from import net.minecraft.sounds.SoundEvents; These work given my code. No idea why these are different.  - playSound() method, as well as several others in past iterations that did not work   I would be forever grateful if somebody could point me in the right direction. I've looked at several mod github repositories and found extremely similar code to what I'm doing. I've also found several threads in this forum that did not solve my issue. I just cannot figure out what I'm doing differently, and why I'm able to queue sounds manually with playsound but the code won't play it (despite confirming the code is being run with the debug statements.)
    • Delete the tensura-reincarnated/common.toml file (config folder)
  • Topics

  • Create New...

Important Information

By using this site, you agree to our Terms of Use.