Jump to content

Recommended Posts

Posted

I've made a custom dimension, but rather than using a chunk generator, my own is just a "copy" of the overworld and i want replace some blocks by other.

So i need to get a list of all block on the chunk and replacing them by the wanted block or remove them, but i don't know how to get a list of block in the chunk, maybe this way is just impossible ?

Posted

I'm doing something like this, doesn't test it yet but i think i'm on the right way :

package com.kporal.lau.events;

import java.util.Map;

import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.chunk.Chunk;
import net.minecraftforge.event.world.ChunkEvent.Load;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

public class OnChunkEvent {
	
	@SubscribeEvent
	public void EditChunk( Load e ) {
		
		Chunk c = e.getChunk();
		
		Map<BlockPos, TileEntity> map = c.getTileEntityMap();
		for( BlockPos p : map.keySet() ) {
		    
		    c.removeTileEntity( p );
		    
		}
	}
}

removeTileEntity may remove my desired block ? then i should replace a new block at the position, or i need to use setBlockState ?

Posted

Ok, my custom dimension is a mimic of the overworld, it work, i can teleport, spawn etc, but now, because i don't use a custom chunk generator i try to use the chunk Load event to replace undesired block by other, my actual code is more like :

package com.kporal.lau.events;

import java.util.Map;

import net.minecraft.init.Blocks;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.chunk.Chunk;
import net.minecraftforge.event.world.ChunkEvent.Load;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

public class OnChunkEvent {
	
	@SubscribeEvent
	public void EditChunk( Load e ) {
		
		Chunk c = e.getChunk();
		
		Map<BlockPos, TileEntity> map = c.getTileEntityMap();
		for( BlockPos p : map.keySet() ) {
		    
			if( c.getBlockState( p ).getBlock() == Blocks.DIRT ) {
				c.removeTileEntity( p );
				//c.addTileEntity( p, );
			}
		    
		}
	}
}

it's just an exemple for dirt block, but when i'm doing a better job here i'm gonna use some array, i hope to give you suffisant information ( sorry if my english is bad :/ )

Posted

my explanation isn't good, it's not a mimic, the "erzine" ( my custom one ) doens't mimic stuff from the overworld, it was just generated with the same seed, but totally separate dimension.

Posted

Actually my code is :

package com.kporal.lau.events;

import java.util.Map;

import com.kporal.lau.LAU;

import net.minecraft.block.Block;
import net.minecraft.block.BlockSand;
import net.minecraft.block.BlockStaticLiquid;
import net.minecraft.init.Blocks;
import net.minecraft.tileentity.TileEntity;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;
import net.minecraft.world.chunk.Chunk;
import net.minecraftforge.event.world.ChunkEvent.Load;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

public class OnChunkEvent {
	
	//private final Block[] toNetherrack = { Blocks.SAND };
	//private final Blocks[] toLava = { Blocks.WATER };
	
	@SubscribeEvent
	public void EditChunk( Load e ) {
		
		World w = e.getWorld();
		
		if( !w.isRemote && w.provider.getDimension() == LAU.erzineId ) {
		
			Chunk c = e.getChunk();
			Map<BlockPos, TileEntity> map = c.getTileEntityMap();
			
			for( BlockPos p : map.keySet() ) {
				
				Block b = c.getBlockState( p ).getBlock();
				
			    /*if( ArrayUtils.contains( toNetherrack, c.getBlockState( p ).getBlock() )) {
			    	c.removeTileEntity( p );
			    }*/
				
				if( b instanceof BlockSand ) {
					// Convert to soulsand
					c.removeTileEntity( p );
					c.setBlockState( p, Blocks.SOUL_SAND.getDefaultState() );
				}
				if( b instanceof BlockStaticLiquid ) {
					// Convert to lava
					c.removeTileEntity( p );
					c.setBlockState( p, Blocks.LAVA.getDefaultState() );
				}
				
			}
		}
	}
}

But it doesn't work, i mean nothing happen, i register the event on the FMLInit

@EventHandler
public void Init( FMLInitializationEvent e ) {
	MinecraftForge.EVENT_BUS.register( new OnChunkEvent() );
}

But i have no error at all, so i know i'm wrong because nothing happen, but i don't know where i'm wrong

Posted

Ok so finally i check ... nothing so this is why nothing is replace ... theire is a way to get all chunk block directly ? or i need to use a for <<4 loop ?

Posted

Yes, i've made some test and i think i've found a way to ensure the game do not load heavily by using nbttag when a chunk is converted, may work but for now my "converter" work ( and like you said it's pretty laggy but not everywhere almost at the first generation ).

 

So i need to know if i can use nbttag into chunk, maybe not but in world should be better by saving something like that : chunk_0_-1_0 as id with isConverted to avoid a second convertion.

 

But in case of needed, i'm also gonna make an admin command to re convert a chunk !

 

And my last possibility but actually ... i think it don't work :/ ... changing the height of the map ... because i don't need 256 but ... should be better with 96 height trying to do it with :

 

ErzineProvider.class

package com.kporal.lau.dimensions;

import com.kporal.lau.LAU;

import net.minecraft.init.Biomes;
import net.minecraft.util.math.BlockPos;
import net.minecraft.util.math.Vec3d;
import net.minecraft.world.DimensionType;
import net.minecraft.world.World;
import net.minecraft.world.WorldProvider;
import net.minecraft.world.biome.Biome;
import net.minecraft.world.biome.BiomeProviderSingle;
import net.minecraftforge.fml.relauncher.Side;
import net.minecraftforge.fml.relauncher.SideOnly;

public class ErzineProvider extends WorldProvider {

	public World worldObj;
	
	public void registerWorldChunkManager() {
		this.biomeProvider = new BiomeProviderSingle( Biomes.VOID );
		this.setDimension( LAU.erzineId );
		this.setAllowedSpawnTypes( false, false );
		this.hasNoSky = false;
		this.doesWaterVaporize = true;
	}

	public Biome getBiomeGenForCoords( BlockPos pos ) { return Biomes.VOID; }

	@Override
	public boolean canRespawnHere() { return false; }

	@Override
	public boolean isSurfaceWorld() { return false; }

	@Override
	public DimensionType getDimensionType() { return LAU.ERZINE_DIMENSION; }
	
	@Override
	public float calculateCelestialAngle( long worldTime, float partialTicks ) { return 0.0F; }

	@Override
	@SideOnly( Side.CLIENT )
	public float[] calcSunriseSunsetColors( float celestialAngle, float partialTicks ) { return null; }
	
	@Override
	@SideOnly( Side.CLIENT )
	public Vec3d getFogColor( float p_76562_1_, float p_76562_2_ ) {
		return new Vec3d(0.20000000298023224D, 0.029999999329447746D, 0.029999999329447746D);
	}
	
	@Override
	@SideOnly( Side.CLIENT )
	public float getCloudHeight() { return 12.0F; }
	
	@SideOnly( Side.CLIENT )
    public boolean doesXZShowFog( int x, int z ) { return true; }
	
	@Override
	public int getHeight() { return 96; }

	@Override
    public int getActualHeight() { return 96; }

}

But ... because my "Erzine" dimension is a "copy" of the overworld it's doesn't work ( i need to check something ... ).

Posted

Ok it work really fine with nbt :)

package com.kporal.lau.events;

import com.kporal.lau.LAU;

import net.minecraft.block.Block;
import net.minecraft.block.BlockDirt;
import net.minecraft.block.BlockFalling;
import net.minecraft.block.BlockLiquid;
import net.minecraft.block.BlockOre;
import net.minecraft.block.BlockSandStone;
import net.minecraft.block.BlockStone;
import net.minecraft.init.Blocks;
import net.minecraft.nbt.NBTTagCompound;
import net.minecraft.util.math.BlockPos;
import net.minecraft.world.World;
import net.minecraft.world.chunk.Chunk;
import net.minecraftforge.event.world.ChunkEvent;
import net.minecraftforge.fml.common.eventhandler.SubscribeEvent;

public class OnChunkEvent {
	
	//private final Block[] toNetherrack = { Blocks.SAND };
	//private final Block[] toEndstone = { Blocks.END_STONE };
	//private final Block[] toDestroy = { Blocks.OAK_STAIRS };
	
	@SubscribeEvent
	public void EditChunk( ChunkEvent.Load e ) {
		
		World w = e.getWorld();
		
		if( !w.isRemote && w.provider.getDimension() == LAU.ERZINEID ) {
			
			NBTTagCompound nbt = w.getWorldInfo().getDimensionData( LAU.ERZINEID );
			Chunk c = e.getChunk();
			String chunkid = "erzineChunk:" + c.xPosition + "_" + c.zPosition;
			
			if( nbt.hasKey( chunkid ) ) { return; }
			
			int cx = c.xPosition << 4;
			int cy = w.getHeight();
			int cz = c.zPosition << 4;
			
			for( int x = cx - 16; x < cx; x++ ) {
				for( int y = 0; y < cy; y++ ) {
					for( int z = cz - 16; z < cz; z++ ) {
						
						BlockPos p = new BlockPos( x, y, z );
						Block b = c.getBlockState( p ).getBlock();
						
						if( b instanceof BlockFalling && b != Blocks.SOUL_SAND ) { c.setBlockState( p, Blocks.SOUL_SAND.getDefaultState() ); }
						if( b instanceof BlockLiquid && b != Blocks.LAVA ) { c.setBlockState( p, Blocks.LAVA.getDefaultState() ); }
						if(( b instanceof BlockOre || b instanceof BlockStone || b instanceof BlockSandStone ) && b != Blocks.END_STONE ) { c.setBlockState( p, Blocks.END_STONE.getDefaultState() ); }
						if( b instanceof BlockDirt && b != Blocks.NETHERRACK ) { c.setBlockState( p, Blocks.NETHERRACK.getDefaultState() ); }
						//w.destroyBlock( p, false );
						
					}
				}
			}
			
			nbt.setBoolean( chunkid, true );
			w.getWorldInfo().setDimensionData( LAU.ERZINEID, nbt );
		}
	}
}

And now i need to clean up entity spawn, and decorate event, if i'm right tree is on the decorate event ?

I also need to clear every structure ( with event too ... to prevent them to spawn )

Posted

Now i'm here :

 

ErzineConverter.class

  Reveal hidden contents

Yes i use DecorateBiomeEvent Pre and Decorate ( i've made this for testing purpose ) but, i'm in trouble, my main event for replacing block do not clear everything, sometime some flower, grass or tree is populated on my world and i don't know how to canceled that or maybe by doing a second loop ...

 

But first, my first problem here is at the bottom, LivingSpawn, i don't understand why this not work, i've made this to prevent creature to spawn but ... i also use this on my world provider : this.setAllowedSpawnTypes( false, false ); ...

 

And why some tree / flower / water keep on the world ... i'm trying a lot of thing but nothing seem to really clear the world

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.

Guest
Unfortunately, your content contains terms that we do not allow. Please edit your content to remove the highlighted words below.
Reply to this topic...

  Pasted as rich text.   Restore formatting

  Only 75 emoji are allowed.

  Your link has been automatically embedded.   Display as a link instead

  Your previous content has been restored.   Clear editor

  You cannot paste images directly. Upload or insert images from URL.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • Hoffman Law Recovery helped me recovered my lost funds
    • Hi! I'm trying to add my custom models/textures renderer like this: public class PonyPlayerWrapperRenderer extends EntityRenderer<Player> { // wrapper class under my LivingEntityRenderer class implementation private final PonyPlayerRenderer innerRenderer; private final PonyPlayerRenderer innerSlimRenderer; public PonyPlayerWrapperRenderer(final EntityRendererProvider.Context context) { super(context); System.out.println("creating new PonyPlayerWrapperRenderer"); this.innerRenderer = new PonyPlayerRenderer(context, false); this.innerSlimRenderer = new PonyPlayerRenderer(context, true); } @Override public void render(final Player entity, final float yaw, final float partialTicks, final PoseStack poseStack, final MultiBufferSource bufferSource, final int packedLight) { System.out.println("PonyPlayerWrapperRenderer render: " + entity.toString()); if (entity instanceof AbstractClientPlayer clientPlayer) { if (clientPlayer.getModelName().contains("slim")) { innerSlimRenderer.render(clientPlayer, yaw, partialTicks, poseStack, bufferSource, packedLight); } else { innerRenderer.render(clientPlayer, yaw, partialTicks, poseStack, bufferSource, packedLight); } } } @Override public ResourceLocation getTextureLocation(final Player player) { System.out.println("PonyPlayerWrapperRenderer getTextureLocation"); if (player instanceof AbstractClientPlayer clientPlayer) { return clientPlayer.getSkinTextureLocation(); } System.out.println("player instanceof AbstractClientPlayer is false"); return getDefaultSkin(player.getUUID()); } } public class PonyPlayerRenderer extends LivingEntityRenderer<AbstractClientPlayer, PlayerModel<AbstractClientPlayer>> { private final PlayerModel<AbstractClientPlayer> earthModel; private final PlayerModel<AbstractClientPlayer> pegasusModel; private final PlayerModel<AbstractClientPlayer> unicornModel; public PonyPlayerRenderer(final EntityRendererProvider.Context context, final boolean slim) { super( context, slim ? new PonyModelSlim(context.bakeLayer(PonyModelSlim.LAYER_LOCATION)) : new PonyModel(context.bakeLayer(PonyModel.LAYER_LOCATION)), 0.5f ); System.out.println("creating new PonyPlayerRenderer"); this.earthModel = slim ? new PonyModelSlim(context.bakeLayer(PonyModelSlim.LAYER_LOCATION)) : new PonyModel(context.bakeLayer(PonyModel.LAYER_LOCATION)); this.pegasusModel = new PegasusModel(context.bakeLayer(PegasusModel.LAYER_LOCATION)); this.unicornModel = new UnicornModel(context.bakeLayer(UnicornModel.LAYER_LOCATION)); } @Override public void render(final AbstractClientPlayer player, final float entityYaw, final float partialTicks, final PoseStack poseStack, final MultiBufferSource buffer, final int packedLight) { final PonyRace race = player.getCapability(PONY_DATA) .map(data -> ofNullable(data.getRace()).orElse(PonyRace.EARTH)) .orElse(PonyRace.EARTH); this.model = switch (race) { case PEGASUS -> pegasusModel; case UNICORN -> unicornModel; case EARTH -> earthModel; }; super.render(player, entityYaw, partialTicks, poseStack, buffer, packedLight); } @Override public ResourceLocation getTextureLocation(final AbstractClientPlayer player) { final PonyRace race = player.getCapability(PONY_DATA) .map(data -> ofNullable(data.getRace()).orElse(PonyRace.EARTH)) .orElse(PonyRace.EARTH); return switch (race) { case EARTH -> fromNamespaceAndPath(MODID, "textures/entity/earth_pony.png"); case PEGASUS -> fromNamespaceAndPath(MODID, "textures/entity/pegasus.png"); case UNICORN -> fromNamespaceAndPath(MODID, "textures/entity/unicorn.png"); }; } } @Mod.EventBusSubscriber(modid = MODID, bus = MOD, value = CLIENT) public class ClientRenderers { // mod bus render registration config @SubscribeEvent public static void onRegisterLayerDefinitions(final EntityRenderersEvent.RegisterLayerDefinitions event) { event.registerLayerDefinition(PonyModel.LAYER_LOCATION, PonyModel::createBodyLayer); event.registerLayerDefinition(PonyModelSlim.LAYER_LOCATION, PonyModelSlim::createBodyLayer); event.registerLayerDefinition(PegasusModel.LAYER_LOCATION, PegasusModel::createBodyLayer); event.registerLayerDefinition(UnicornModel.LAYER_LOCATION, UnicornModel::createBodyLayer); event.registerLayerDefinition(InnerPonyArmorModel.LAYER_LOCATION, InnerPonyArmorModel::createBodyLayer); event.registerLayerDefinition(OuterPonyArmorModel.LAYER_LOCATION, OuterPonyArmorModel::createBodyLayer); } @SubscribeEvent public static void onRegisterRenderers(final EntityRenderersEvent.RegisterRenderers event) { event.registerEntityRenderer(EntityType.PLAYER, PonyPlayerWrapperRenderer::new); System.out.println("onRegisterRenderers end"); } } Method onRegisterRenderers() is called and I can see it being logged. But when I enter the world, my PonyWrapperRenderer render() method doesn't ever seem to be called. I also tried to put my renderer to EntityRenderDispatcher's playerRenderers via reflection: @Mod.EventBusSubscriber(modid = MODID, bus = MOD, value = CLIENT) public class ClientRenderers { @SubscribeEvent public static void onRegisterLayerDefinitions(final EntityRenderersEvent.RegisterLayerDefinitions event) { event.registerLayerDefinition(PonyModel.LAYER_LOCATION, PonyModel::createBodyLayer); event.registerLayerDefinition(PonyModelSlim.LAYER_LOCATION, PonyModelSlim::createBodyLayer); event.registerLayerDefinition(PegasusModel.LAYER_LOCATION, PegasusModel::createBodyLayer); event.registerLayerDefinition(UnicornModel.LAYER_LOCATION, UnicornModel::createBodyLayer); event.registerLayerDefinition(InnerPonyArmorModel.LAYER_LOCATION, InnerPonyArmorModel::createBodyLayer); event.registerLayerDefinition(OuterPonyArmorModel.LAYER_LOCATION, OuterPonyArmorModel::createBodyLayer); } @SubscribeEvent public static void onClientSetup(final FMLClientSetupEvent event) { event.enqueueWork(() -> { try { final EntityRenderDispatcher dispatcher = Minecraft.getInstance().getEntityRenderDispatcher(); final Field renderersField = getEntityRenderDispatcherField("playerRenderers"); final Field itemInHandRenderer = getEntityRenderDispatcherField("itemInHandRenderer"); @SuppressWarnings("unchecked") final Map<String, EntityRenderer<? extends Player>> playerRenderers = (Map<String, EntityRenderer<? extends Player>>)renderersField.get(dispatcher); final PonyPlayerWrapperRenderer renderer = new PonyPlayerWrapperRenderer( new EntityRendererProvider.Context( dispatcher, Minecraft.getInstance().getItemRenderer(), Minecraft.getInstance().getBlockRenderer(), (ItemInHandRenderer)itemInHandRenderer.get(dispatcher), Minecraft.getInstance().getResourceManager(), Minecraft.getInstance().getEntityModels(), Minecraft.getInstance().font ) ); playerRenderers.put("default", renderer); playerRenderers.put("slim", renderer); System.out.println("Player renderers replaced"); } catch (final Exception e) { throw new RuntimeException("Failed to replace player renderers", e); } }); } private static Field getEntityRenderDispatcherField(final String fieldName) throws NoSuchFieldException { final Field field = EntityRenderDispatcher.class.getDeclaredField(fieldName); field.setAccessible(true); return field; } } But I receive the error before Minecraft Client appears (RuntimeException: Failed to replace player renderers - from ClientRenderers onClientSetup() method - and its cause below): java.lang.IllegalArgumentException: No model for layer anotherlittlepony:earth_pony#main at net.minecraft.client.model.geom.EntityModelSet.bakeLayer(EntityModelSet.java:18) ~[forge-1.20.1-47.4.0_mapped_official_1.20.1-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A} at net.minecraft.client.renderer.entity.EntityRendererProvider$Context.bakeLayer(EntityRendererProvider.java:69) ~[forge-1.20.1-47.4.0_mapped_official_1.20.1-recomp.jar:?] {re:classloading,pl:runtimedistcleaner:A} at com.thuggeelya.anotherlittlepony.client.renderer.pony.PonyPlayerRenderer.<init>(PonyPlayerRenderer.java:32) ~[main/:?] {re:classloading} at com.thuggeelya.anotherlittlepony.client.renderer.pony.PonyPlayerWrapperRenderer.<init>(PonyPlayerWrapperRenderer.java:24) ~[main/:?] {re:classloading} at com.thuggeelya.anotherlittlepony.client.renderer.ClientRenderers.lambda$onClientSetup$0(ClientRenderers.java:79) ~[main/:?] {re:classloading} ... 33 more Problem appears when EntityRendererProvider context tries to bakeLayer with my model layer location: new PonyModel(context.bakeLayer(PonyModel.LAYER_LOCATION)); // PonyPlayerRenderer.java:32 public class PonyModel extends PlayerModel<AbstractClientPlayer> { // the model class itself public static final ModelLayerLocation LAYER_LOCATION = new ModelLayerLocation( ResourceLocation.fromNamespaceAndPath(MODID, "earth_pony"), "main" ); public PonyModel(final ModelPart root) { super(root, false); } public static LayerDefinition createBodyLayer() { // some CubeListBuilder stuff for model appearance } } Textures PNGs are placed at: resources/assets/[my mod id]/textures/entity. My forge version is 1.20.1. Would appreciate any help.
    • Well, a bit more information about what you're trying to do would be helpful. e.g. why you're trying to use "INVOKE_ASSIGN" instead of "INVOKE". "INVOKE_ASSIGN" calls your code after the "target" is called and its value is stored, if applicable. "INVOKE" calls your code before the target is called. "target" expects a fully qualified name, as per the SpongePowered docs, if that name is going to be remapped (which it will be if your injecting into Minecraft itself and not another mod). For more information on fully qualified names versus canonical names, see the Java specifications. Here's an example of a working "@At" from my own code that targets the "getClosestsVulnerablePlayerToEntity" call inside a mob's logic: @At(value = "INVOKE_ASSIGN", target = "net.minecraft.world.World.getClosestVulnerablePlayerToEntity(Lnet/minecraft/entity/Entity;D)Lnet/minecraft/entity/player/EntityPlayer;") Hope this helps!
    • Ran it one more time just to check, and there's no errors this time on the log??? Log : https://mclo.gs/LnuaAiu I tried allocating more memory to the modpack, around 8000MB and it's still the same; stopping at "LOAD_REGISTRIES". Are some of the mods clashing, maybe? I have no clue what to do LOL
    • Tried removing some biome generation mods and test ran it again, but it's still the same; still not responding as soon as it gets to "LOAD_REGISTRIES". This time with more errors though. Log : https://mclo.gs/uygZzD8 Is there too little memory allocated to the modpack maybe? Can someone help please.    (T.T)馃挃
  • Topics

  • Create New...

Important Information

By using this site, you agree to our Terms of Use.