MSpace-Dev Posted December 22, 2017 Posted December 22, 2017 (edited) Hey everyone, So, for the passed hour or so, I've been trying to make a custom particle. I feel like I am on the absolute brink of getting it to work, after 100s upon 100s of crashes later! And boy... I have no clue where to go from here. So, let me right a numbered list of what's happening, and what is calling what. "Chain of events": ModBlock calls genMagicParticle() method in Common Proxy Class Client Proxy Class overrides Common Proxy Class' - genMagicParticle() method genMagicParticle() method creates a new instance of a ParticleMagic object, which extends ParticleCloud Also adds this new ParticleMagic instance to the effectRenderer --- Minecraft.getMinecraft().effectRenderer.addEffect() ParticleMagic sets particle colours through particleRed, particleGreen, particleBlue and sets particleMaxAge TextureStitchEvent.Pre gets a texture map and registers a new sprite pointing to my mod's particle PNG sheet ParticleMagic returns 1 in getFXLayer() ParticleMagic sets the particle texture (setParticleTexture()) to the registered sprite using the TextureStitchEvent.Pre. And that's about everything. Here is the relevant code from each class: InfusedLog ("ModBlock"): public class BlockInfusedLog extends BlockWoodBase implements ITileEntityProvider { @SideOnly(Side.CLIENT) @Override public void randomDisplayTick(IBlockState stateIn, World worldIn, BlockPos pos, Random rand) { MonsterTotems.proxy.genMagicParticle(this, pos); super.randomDisplayTick(stateIn, worldIn, pos, rand); } } Common Proxy: public class CommonProxy { public void genMagicParticle(Block block, BlockPos pos) { } } Client Proxy: public class ClientProxy extends CommonProxy { @Override public void genMagicParticle(Block block, BlockPos pos) { World world = Minecraft.getMinecraft().world; double rand = world.rand.nextDouble(); double d1 = pos.getX() + rand; double d2 = pos.getY() + 1; double d3 = pos.getZ() + rand; ParticleMagic particleMagic = new ParticleMagic(world, d1, d2, d3, rand * 0.4D, 0.7D, rand * 0.4D); Minecraft.getMinecraft().effectRenderer.addEffect(particleMagic); } } RegistryEventHandler: @Mod.EventBusSubscriber public class RegistryEventHandler { public static TextureAtlasSprite textureAtlasSprite; @SubscribeEvent public static void registerParticleMap(TextureStitchEvent.Pre event) { TextureMap map = event.getMap(); textureAtlasSprite = map.registerSprite(new ResourceLocation(Reference.MODID, "particle/particles")); // Points to 'monstertotems:textures/particle/particles.png' } } ParticleMagic: public class ParticleMagic extends ParticleCloud { public ParticleMagic(World worldIn, double xCoordIn, double yCoordIn, double zCoordIn, double xSpeedIn, double ySpeedIn, double zSpeedIn) { super(worldIn, xCoordIn, yCoordIn, zCoordIn, xSpeedIn, ySpeedIn, zSpeedIn); this.particleRed = 1; this.particleGreen = 0; this.particleBlue = 1; this.particleMaxAge = 1000000; this.setParticleTexture(RegistryEventHandler.textureAtlasSprite); } @Override public int getFXLayer() { return 1; } } Phew... that should be everything. Oh, one more thing, here is the crash report. Crash Report: Spoiler [00:42:05] [Client thread/INFO]: [net.minecraft.init.Bootstrap:printToSYSOUT:600]: ---- Minecraft Crash Report ---- // You should try our sister game, Minceraft! Time: 12/23/17 12:42 AM Description: Ticking Particle java.lang.RuntimeException: Invalid call to Particle.setMiscTex at net.minecraft.client.particle.Particle.setParticleTextureIndex(Particle.java:261) at net.minecraft.client.particle.ParticleCloud.onUpdate(ParticleCloud.java:60) at net.minecraft.client.particle.ParticleManager.tickParticle(ParticleManager.java:243) at net.minecraft.client.particle.ParticleManager.tickParticleList(ParticleManager.java:229) at net.minecraft.client.particle.ParticleManager.updateEffectLayer(ParticleManager.java:213) at net.minecraft.client.particle.ParticleManager.updateEffects(ParticleManager.java:169) at net.minecraft.client.Minecraft.runTick(Minecraft.java:1934) at net.minecraft.client.Minecraft.runGameLoop(Minecraft.java:1119) at net.minecraft.client.Minecraft.run(Minecraft.java:407) at net.minecraft.client.main.Main.main(Main.java:118) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) at net.minecraft.launchwrapper.Launch.main(Launch.java:28) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at net.minecraftforge.gradle.GradleStartCommon.launch(GradleStartCommon.java:97) at GradleStart.main(GradleStart.java:26) Thanks! Edited December 23, 2017 by MSpace-Dev Solved the problem Quote
MSpace-Dev Posted December 22, 2017 Author Posted December 22, 2017 Oh, Hmm, I saw another thread where a guy extended one of the particle classes. Anways, it seems to be working perfectly now. Haha, was so close =p One more question, how do I select what UV the particle uses as the texture? I have a 128x128 image, like MC does, and I want to select the top most 8x8 pixels as this particle's texture. Couldn't find a 'setUV()' type method in Particle. Quote
JoeStrout Posted December 29, 2017 Posted December 29, 2017 Can you show us your solution? I may need something similar. Quote
Differentiation Posted December 29, 2017 Posted December 29, 2017 (edited) 9 minutes ago, JoeStrout said: Can you show us your solution? I may need something similar. The solution is simply not to extend ParticleCloud and remove the overrided method. Edited December 29, 2017 by Differentiation Quote
JoeStrout Posted December 29, 2017 Posted December 29, 2017 1 hour ago, Differentiation said: The solution is simply not to extend ParticleCloud and remove the overrided method. Really? The ParticleMagic class shown above was nothing but overriding that method; take that out, and it has no data and no methods. How does that make a custom particle? (Unless there was more code to it that wasn't considered relevant in the original post.) Instead of repeating what to not do, it'd be great if somebody could show or say what one should do. @MSpace-Dev, can you share your working solution? Quote
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.