Jump to content

Recommended Posts

Posted

public void PlayerUseItemEvent(net.minecraftforge.event.entity.player.PlayerUseItemEvent.Start event, Item itemStack)
 {
          ItemStack item = event.item;
           
          if (itemStack == Items.string)
          {
         event.item.useItemRightClick(null, null);
          }
  }

___________________________________________________________________

That's how far I got, not really far at all lol.

I want string to do nothing at all when you right click it, just like gunpowder or glowstone for instane.

Does someone have an idea what I could do?

Posted

You are comparing an ItemStack(that contains an item) to an item. You need to use ItemStack::getItem, and then compare it.

ItemStack::useItemRightClick does not do what you think it does, by the way. It is normally called when an item is rightclicked, and replaces the current ItemStack to a new one (normally the same itemstack, perhaps +-1 stack-count depending on what the item actually does).
If you want to block the player from actually using the item, call Event::setCanceled(true).

 

Also previously known as eAndPi.

"Pi, is there a station coming up where we can board your train of thought?" -Kronnn

Published Mods: Underworld

Handy links: Vic_'s Forge events Own WIP Tutorials.

Posted
9 minutes ago, Matryoshika said:

You are comparing an ItemStack(that contains an item) to an item. You need to use ItemStack::getItem, and then compare it.

ItemStack::useItemRightClick does not do what you think it does, by the way. It is normally called when an item is rightclicked, and replaces the current ItemStack to a new one (normally the same itemstack, perhaps +-1 stack-count depending on what the item actually does).
If you want to block the player from actually using the item, call Event::setCanceled(true).

 

Ok, thanks! I'm just having some problems translating that into some working code :L

_________________________________________________________________________

   public void PlayerUseItemEvent(net.minecraftforge.event.entity.player.PlayerUseItemEvent.Start event, Item itemStack)
   {
           ItemStack getItem;
           
           if (itemStack == Items.string)
           {
           event.setCanceled(true);
           }
   }

Posted

ItemStack is not an item. You are still trying to compare them, which will always return false.
You get an ItemStack from the event. You then need to get the item out of the ItemStack. You then compare the item, to string.

Also previously known as eAndPi.

"Pi, is there a station coming up where we can board your train of thought?" -Kronnn

Published Mods: Underworld

Handy links: Vic_'s Forge events Own WIP Tutorials.

Posted
14 minutes ago, Matryoshika said:

ItemStack is not an item. You are still trying to compare them, which will always return false.
You get an ItemStack from the event. You then need to get the item out of the ItemStack. You then compare the item, to string.

" ItemStack getItem; " gets the item out of the stack right? But what's the single item called?

_______________________________________________

 

public class TripWireRem {


   public void PlayerUseItemEvent(net.minecraftforge.event.entity.player.PlayerUseItemEvent.Start event, Item itemStack)
    {
           ItemStack getItem;
           
           if (Item == Items.string)
           {
           event.setCanceled(true);
           }
   }
}

 

Posted (edited)

"getItem" is a non-static method, in the ItemStack class. You need to call it on an ItemStack.

As it is right now, your code will not even compile, and your IDE should tell you as much.

Edited by Matryoshika

Also previously known as eAndPi.

"Pi, is there a station coming up where we can board your train of thought?" -Kronnn

Published Mods: Underworld

Handy links: Vic_'s Forge events Own WIP Tutorials.

Posted
3 minutes ago, Matryoshika said:

"getItem" is a non-static method, in the ItemStack class. You need to call it on an ItemStack.

As it is right now, your code will not even compile, and your IDE should tell you as much.

Ahhh D: I'm sorry, but I really don't know how to translate that into code.

Posted
2 minutes ago, Matryoshika said:

event.item returns an ItemStack.
event.item.getItem() returns an actual Item.

 

This is basic Java...

And is " event.setCanceled(true); " at the end enough to cancel the right click action, so it doesn't place the string? Or do I need to say which event has to get canceled?

Posted (edited)

"event" is given to you by the EventHandler, because your method "PlayerUseItemEvent" requires a Start Event (which here is a sub-class of the actual PlayerUseItemEvent)

(Your method shouldn't have the same name as the event, as it can get confusing).
This "event" will always be of the type PlayerUseItemEvent, specifically before the item is used. (As indicated of the sub-type Start).

As such, you do not have to worry about "which" event, because this will only work for the event that you have.

 

For the future, you should also look up what Static and Non-Static classes, methods and fields means. This is as said basic Java knowledge, which is sorely needed, but not taught here.

Edited by Matryoshika

Also previously known as eAndPi.

"Pi, is there a station coming up where we can board your train of thought?" -Kronnn

Published Mods: Underworld

Handy links: Vic_'s Forge events Own WIP Tutorials.

Posted
6 minutes ago, Matryoshika said:

"event" is given to you by the EventHandler, because your method "PlayerUseItemEvent" requires a Start Event (which here is a sub-class of the actual PlayerUseItemEvent)

(Your method shouldn't have the same name as the event, as it can get confusing).
This "event" will always be of the type PlayerUseItemEvent, specifically before the item is used. (As indicated of the sub-type Start).

As such, you do not have to worry about "which" event, because this will only work for the event that you have.

 

For the future, you should also look up what Static and Non-Static classes, methods and fields means. This is as said basic Java knowledge, which is sorely needed, but not taught here.

I'm just going to stop and hope that someone else writes a mod that does the same thing lol.

Posted
2 hours ago, Matryoshika said:

"event" is given to you by the EventHandler, because your method "PlayerUseItemEvent" requires a Start Event (which here is a sub-class of the actual PlayerUseItemEvent)

(Your method shouldn't have the same name as the event, as it can get confusing).
This "event" will always be of the type PlayerUseItemEvent, specifically before the item is used. (As indicated of the sub-type Start).

As such, you do not have to worry about "which" event, because this will only work for the event that you have.

 

For the future, you should also look up what Static and Non-Static classes, methods and fields means. This is as said basic Java knowledge, which is sorely needed, but not taught here.

Could you maybe write that short piece of code for me to copy? That would be really kind of you! :)

Posted

No.
Why won't I?
Because this forum is meant to help people with their own code.
If I write the code for you, you won't know what the heck it does, why it does it, when it does it, nor how it does it.

If you have any issues, you would have no idea how to solve them, and would need further help.

 

You were pretty close last time around, just had to actually compare an item against an item.

Also previously known as eAndPi.

"Pi, is there a station coming up where we can board your train of thought?" -Kronnn

Published Mods: Underworld

Handy links: Vic_'s Forge events Own WIP Tutorials.

Posted
6 minutes ago, Matryoshika said:

No.
Why won't I?
Because this forum is meant to help people with their own code.
If I write the code for you, you won't know what the heck it does, why it does it, when it does it, nor how it does it.

If you have any issues, you would have no idea how to solve them, and would need further help.

 

You were pretty close last time around, just had to actually compare an item against an item.

Don't make it so difficult for me :L I just wanted to know how I could get that code to work. I'm just not good with java :L

Posted

Difficult? How am I making this difficult?
I've told you how to get the item

2 hours ago, Matryoshika said:

event.item.getItem() returns an actual Item.

I have told you how to cancel the event.
Now you take one, and stick it to the other, and you're done.

Also previously known as eAndPi.

"Pi, is there a station coming up where we can board your train of thought?" -Kronnn

Published Mods: Underworld

Handy links: Vic_'s Forge events Own WIP Tutorials.

Posted
6 minutes ago, Matryoshika said:

Difficult? How am I making this difficult?
I've told you how to get the item

I have told you how to cancel the event.
Now you take one, and stick it to the other, and you're done.

Like this? :L

___________________________________________

       public void PlayerUseItemEvent(net.minecraftforge.event.entity.player.PlayerUseItemEvent.Start event, Item itemStack)
        {     
               ItemStack itemstack = event.entityPlayer.inventory.getCurrentItem();
               if (itemstack.getItem() == Items.string)
               {
               event.setCanceled(true);
               }
       }

Posted (edited)

You are comparing the items correctly now, yes.
However, you should be getting the ItemStack from the event itself, not from the player. (Go back to ItemStack stack = event.getItem())

And on another note, I am now seeing what I missed before. Your method takes in two arguments (the Event & Item).

This code will never be called because you have more than one arguments. Forge's EventHandler (which is the thing that goes "HEY, this happened, do your stuff") can only see static methods that need one argument, and that has to be some type of Event.
TL;DR remove the Item itemStack at the top, and put "static" after the "public", before the "void".

Edited by Matryoshika

Also previously known as eAndPi.

"Pi, is there a station coming up where we can board your train of thought?" -Kronnn

Published Mods: Underworld

Handy links: Vic_'s Forge events Own WIP Tutorials.

Posted
9 minutes ago, Newww said:

Like this? :L

___________________________________________

       public void PlayerUseItemEvent(net.minecraftforge.event.entity.player.PlayerUseItemEvent.Start event, Item itemStack)
        {     
               ItemStack itemstack = event.entityPlayer.inventory.getCurrentItem();
               if (itemstack.getItem() == Items.string)
               {
               event.setCanceled(true);
               }
       }

It doesn't do anything. Still places that dumb tripwire :L Is " PlayerUseItemEvent " even the correct on to use?

Posted (edited)
6 minutes ago, Newww said:

It doesn't do anything. Still places that dumb tripwire :L Is " PlayerUseItemEvent " even the correct on to use?

*******

@SubscribeEvent
public void onPlayerUseItem(PlayerUseItemEvent event)
{
 ...
}

Properly SUBSCRIBE to the event, THEN do things when it is fired.

Edited by Differentiation
Posted
3 minutes ago, Matryoshika said:

You are comparing the items correctly now, yes.
However, you should be getting the ItemStack from the event itself, not from the player. (Go back to ItemStack stack = event.getItem())

And on another note, I am now seeing what I missed before. Your method takes in two arguments (the Event & Item).

This code will never be called because you have more than one arguments. Forge's EventHandler (which is the thing that goes "HEY, this happened, do your stuff") can only see static methods that need one argument, and that has to be some type of Event.
TL;DR remove the Item itemStack at the top, and put "static" after the "public", before the "void".

_________________________________________

public class StringFix {

@SubscribeEvent       
       public static void PlayerUseItemEvent(net.minecraftforge.event.entity.player.PlayerUseItemEvent.Start event)
        {     
               ItemStack itemstack = event.entityPlayer.inventory.getCurrentItem();
               if (itemstack.getItem() == Items.string)
               {
               event.setCanceled(true);
               }
       }
}

__________________________________

Ok, that's my current code. But he still places down those tripwires :L

And about that @SubscribeEvent, I need that right?

 

And here's my main file, if there's a mistake in there lol

___________________________________________

 

package com.example.examplemod;

import cpw.mods.fml.common.Mod;
import cpw.mods.fml.common.Mod.EventHandler;
import cpw.mods.fml.common.event.FMLInitializationEvent;
import cpw.mods.fml.common.event.FMLPreInitializationEvent;
import cpw.mods.fml.common.registry.GameRegistry;
import net.minecraft.init.Blocks;
import net.minecraftforge.common.MinecraftForge;

@Mod(modid = ExampleMod.MODID, version = ExampleMod.VERSION)
public class ExampleMod
{
    public static final String MODID = "examplemod";
    public static final String VERSION = "1.0";
    
@Mod.EventHandler
public void preInit(FMLPreInitializationEvent event) {
    
MinecraftForge.EVENT_BUS.register(new StringFix());
}
}

Posted
1 minute ago, Newww said:

_________________________________________

public class StringFix {

@SubscribeEvent       
       public static void PlayerUseItemEvent(net.minecraftforge.event.entity.player.PlayerUseItemEvent.Start event)
        {     
               ItemStack itemstack = event.entityPlayer.inventory.getCurrentItem();
               if (itemstack.getItem() == Items.string)
               {
               event.setCanceled(true);
               }
       }
}

__________________________________

Ok, that's my current code. But he still places down those tripwires :L

And about that @SubscribeEvent, I need that right?

 

And here's my main file, if there's a mistake in there lol

___________________________________________

 

package com.example.examplemod;

import cpw.mods.fml.common.Mod;
import cpw.mods.fml.common.Mod.EventHandler;
import cpw.mods.fml.common.event.FMLInitializationEvent;
import cpw.mods.fml.common.event.FMLPreInitializationEvent;
import cpw.mods.fml.common.registry.GameRegistry;
import net.minecraft.init.Blocks;
import net.minecraftforge.common.MinecraftForge;

@Mod(modid = ExampleMod.MODID, version = ExampleMod.VERSION)
public class ExampleMod
{
    public static final String MODID = "examplemod";
    public static final String VERSION = "1.0";
    
@Mod.EventHandler
public void preInit(FMLPreInitializationEvent event) {
    
MinecraftForge.EVENT_BUS.register(new StringFix());
}
}

Please PROPERLY set up the mod and proxies, etc. before doing anything else...

Posted
1 minute ago, Differentiation said:

Please PROPERLY set up the mod and proxies, etc. before doing anything else...

Why do I need any Proxies? :L

Posted
1 minute ago, Differentiation said:

Don't use static, you don't have to have that modifier.

Tried that before, didn't make much of a difference lol

Guest
This topic is now closed to further replies.

Announcements



  • Recently Browsing

    • No registered users viewing this page.
  • Posts

    • So me and a couple of friends are playing with a shitpost mod pack and one of the mods in the pack is corail tombstone and for some reason there is a problem with it, where on death to fire the player will get kicked out of the server and the tombstone will not spawn basically deleting an entire inventory, it doesn't matter what type of fire it is, whether it's from vanilla fire/lava, or from modded fire like ice&fire/lycanites and it's common enough to where everyone on the server has experienced at least once or twice and it doesn't give any crash log. a solution to this would be much appreciated thank you!
    • It is 1.12.2 - I have no idea if there is a 1.12 pack
    • Okay, but does the modpack works with 1.12 or just with 1.12.2, because I need the Forge client specifically for Minecraft 1.12, not 1.12.2
    • Version 1.19 - Forge 41.0.63 I want to create a wolf entity that I can ride, so far it seems to be working, but the problem is that when I get on the wolf, I can’t control it. I then discovered that the issue is that the server doesn’t detect that I’m riding the wolf, so I’m struggling with synchronization. However, it seems to not be working properly. As I understand it, the server receives the packet but doesn’t register it correctly. I’m a bit new to Java, and I’ll try to provide all the relevant code and prints *The comments and prints are translated by chatgpt since they were originally in Spanish* Thank you very much in advance No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. No player is mounted, or the passenger is not a player. MountableWolfEntity package com.vals.valscraft.entity; import com.vals.valscraft.network.MountSyncPacket; import com.vals.valscraft.network.NetworkHandler; import net.minecraft.client.Minecraft; import net.minecraft.network.syncher.EntityDataAccessor; import net.minecraft.network.syncher.EntityDataSerializers; import net.minecraft.network.syncher.SynchedEntityData; import net.minecraft.server.MinecraftServer; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.EntityType; import net.minecraft.world.entity.Mob; import net.minecraft.world.entity.ai.attributes.AttributeSupplier; import net.minecraft.world.entity.ai.attributes.Attributes; import net.minecraft.world.entity.animal.Wolf; import net.minecraft.world.entity.player.Player; import net.minecraft.world.entity.Entity; import net.minecraft.world.InteractionHand; import net.minecraft.world.InteractionResult; import net.minecraft.world.item.ItemStack; import net.minecraft.world.item.Items; import net.minecraft.world.level.Level; import net.minecraft.world.phys.Vec3; import net.minecraftforge.event.TickEvent; import net.minecraftforge.eventbus.api.SubscribeEvent; import net.minecraftforge.network.PacketDistributor; public class MountableWolfEntity extends Wolf { private boolean hasSaddle; private static final EntityDataAccessor<Byte> DATA_ID_FLAGS = SynchedEntityData.defineId(MountableWolfEntity.class, EntityDataSerializers.BYTE); public MountableWolfEntity(EntityType<? extends Wolf> type, Level level) { super(type, level); this.hasSaddle = false; } @Override protected void defineSynchedData() { super.defineSynchedData(); this.entityData.define(DATA_ID_FLAGS, (byte)0); } public static AttributeSupplier.Builder createAttributes() { return Wolf.createAttributes() .add(Attributes.MAX_HEALTH, 20.0) .add(Attributes.MOVEMENT_SPEED, 0.3); } @Override public InteractionResult mobInteract(Player player, InteractionHand hand) { ItemStack itemstack = player.getItemInHand(hand); if (itemstack.getItem() == Items.SADDLE && !this.hasSaddle()) { if (!player.isCreative()) { itemstack.shrink(1); } this.setSaddle(true); return InteractionResult.SUCCESS; } else if (!level.isClientSide && this.hasSaddle()) { player.startRiding(this); MountSyncPacket packet = new MountSyncPacket(true); // 'true' means the player is mounted NetworkHandler.CHANNEL.sendToServer(packet); // Ensure the server handles the packet return InteractionResult.SUCCESS; } return InteractionResult.PASS; } @Override public void travel(Vec3 travelVector) { if (this.isVehicle() && this.getControllingPassenger() instanceof Player) { System.out.println("The wolf has a passenger."); System.out.println("The passenger is a player."); Player player = (Player) this.getControllingPassenger(); // Ensure the player is the controller this.setYRot(player.getYRot()); this.yRotO = this.getYRot(); this.setXRot(player.getXRot() * 0.5F); this.setRot(this.getYRot(), this.getXRot()); this.yBodyRot = this.getYRot(); this.yHeadRot = this.yBodyRot; float forward = player.zza; float strafe = player.xxa; if (forward <= 0.0F) { forward *= 0.25F; } this.flyingSpeed = this.getSpeed() * 0.1F; this.setSpeed((float) this.getAttributeValue(Attributes.MOVEMENT_SPEED) * 1.5F); this.setDeltaMovement(new Vec3(strafe, travelVector.y, forward).scale(this.getSpeed())); this.calculateEntityAnimation(this, false); } else { // The wolf does not have a passenger or the passenger is not a player System.out.println("No player is mounted, or the passenger is not a player."); super.travel(travelVector); } } public boolean hasSaddle() { return this.hasSaddle; } public void setSaddle(boolean hasSaddle) { this.hasSaddle = hasSaddle; } @Override protected void dropEquipment() { super.dropEquipment(); if (this.hasSaddle()) { this.spawnAtLocation(Items.SADDLE); this.setSaddle(false); } } @SubscribeEvent public static void onServerTick(TickEvent.ServerTickEvent event) { if (event.phase == TickEvent.Phase.START) { MinecraftServer server = net.minecraftforge.server.ServerLifecycleHooks.getCurrentServer(); if (server != null) { for (ServerPlayer player : server.getPlayerList().getPlayers()) { if (player.isPassenger() && player.getVehicle() instanceof MountableWolfEntity) { MountableWolfEntity wolf = (MountableWolfEntity) player.getVehicle(); System.out.println("Tick: " + player.getName().getString() + " is correctly mounted on " + wolf); } } } } } private boolean lastMountedState = false; @Override public void tick() { super.tick(); if (!this.level.isClientSide) { // Only on the server boolean isMounted = this.isVehicle() && this.getControllingPassenger() instanceof Player; // Only print if the state changed if (isMounted != lastMountedState) { if (isMounted) { Player player = (Player) this.getControllingPassenger(); // Verify the passenger is a player System.out.println("Server: Player " + player.getName().getString() + " is now mounted."); } else { System.out.println("Server: The wolf no longer has a passenger."); } lastMountedState = isMounted; } } } @Override public void addPassenger(Entity passenger) { super.addPassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(true)); } } } @Override public void removePassenger(Entity passenger) { super.removePassenger(passenger); if (passenger instanceof Player) { Player player = (Player) passenger; if (!this.level.isClientSide && player instanceof ServerPlayer) { // Send the packet to the server to indicate the player is no longer mounted NetworkHandler.CHANNEL.send(PacketDistributor.PLAYER.with(() -> (ServerPlayer) player), new MountSyncPacket(false)); } } } @Override public boolean isControlledByLocalInstance() { Entity entity = this.getControllingPassenger(); return entity instanceof Player; } @Override public void positionRider(Entity passenger) { if (this.hasPassenger(passenger)) { double xOffset = Math.cos(Math.toRadians(this.getYRot() + 90)) * 0.4; double zOffset = Math.sin(Math.toRadians(this.getYRot() + 90)) * 0.4; passenger.setPos(this.getX() + xOffset, this.getY() + this.getPassengersRidingOffset() + passenger.getMyRidingOffset(), this.getZ() + zOffset); } } } MountSyncPacket package com.vals.valscraft.network; import com.vals.valscraft.entity.MountableWolfEntity; import net.minecraft.network.FriendlyByteBuf; import net.minecraft.server.level.ServerLevel; import net.minecraft.server.level.ServerPlayer; import net.minecraft.world.entity.Entity; import net.minecraft.world.entity.player.Player; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class MountSyncPacket { private final boolean isMounted; public MountSyncPacket(boolean isMounted) { this.isMounted = isMounted; } public void encode(FriendlyByteBuf buffer) { buffer.writeBoolean(isMounted); } public static MountSyncPacket decode(FriendlyByteBuf buffer) { return new MountSyncPacket(buffer.readBoolean()); } public void handle(NetworkEvent.Context context) { context.enqueueWork(() -> { ServerPlayer player = context.getSender(); // Get the player from the context if (player != null) { // Verifies if the player has dismounted if (!isMounted) { Entity vehicle = player.getVehicle(); if (vehicle instanceof MountableWolfEntity wolf) { // Logic to remove the player as a passenger wolf.removePassenger(player); System.out.println("Server: Player " + player.getName().getString() + " is no longer mounted."); } } } }); context.setPacketHandled(true); // Marks the packet as handled } } networkHandler package com.vals.valscraft.network; import com.vals.valscraft.valscraft; import net.minecraft.resources.ResourceLocation; import net.minecraftforge.network.NetworkRegistry; import net.minecraftforge.network.simple.SimpleChannel; import net.minecraftforge.network.NetworkEvent; import java.util.function.Supplier; public class NetworkHandler { private static final String PROTOCOL_VERSION = "1"; public static final SimpleChannel CHANNEL = NetworkRegistry.newSimpleChannel( new ResourceLocation(valscraft.MODID, "main"), () -> PROTOCOL_VERSION, PROTOCOL_VERSION::equals, PROTOCOL_VERSION::equals ); public static void init() { int packetId = 0; // Register the mount synchronization packet CHANNEL.registerMessage( packetId++, MountSyncPacket.class, MountSyncPacket::encode, MountSyncPacket::decode, (msg, context) -> msg.handle(context.get()) // Get the context with context.get() ); } }  
  • Topics

×
×
  • Create New...

Important Information

By using this site, you agree to our Terms of Use.