Posted December 31, 20177 yr Hey, I'm creating a pull request in forge. I generated the patches with ./gradlew genPatches, but I see there are two files with a few numbers different which I didn't edit. Should I be concerned about that and remove those files from the commit, or keep them? I'll attach some screenshots of the two file diffs in sourcetree. The AdvancementManager, FunctionManager, and TemplateManager changes look like they're supposed to. Hopefully someone more familiar with making pull requests knows what to do. Tmtravlr. Pictures: Spoiler EntityList: Item: Edited December 31, 20177 yr by Tmtravlr
December 31, 20177 yr This sometimes happens, just leave them out. If they are indeed invalid, LexManos will eventually regenerate patches. But for PRs just ignore them and revert the changes
December 31, 20177 yr Author Hmm, all right. I'll just remove those two files from the pull request. Hopefully everything will work.
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.
Note: Your post will require moderator approval before it will be visible.